184112 2018-03-28 15:09:18 -0700 Drop DOMWindow::frames() / DOMWindow::window() methods 2018-03-29 09:53:23 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson berto cdumez cgarcia commit-queue dbates esprehn+autocc ews-watchlist gustavo kondapallykalyan mcatanzaro rniwa webkit-bug-importer youennf oldest_to_newest 1410070 0 cdumez 2018-03-28 15:09:18 -0700 Drop DOMWindow::frames() / DOMWindow::window() methods as they are just aliases for DOMWindow::self(). 1410072 1 336724 cdumez 2018-03-28 15:10:24 -0700 Created attachment 336724 Patch 1410192 2 336724 dbates 2018-03-28 23:17:14 -0700 Comment on attachment 336724 Patch r=me 1410193 3 336724 dbates 2018-03-28 23:21:57 -0700 Comment on attachment 336724 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336724&action=review > Source/WebCore/page/DOMWindow.h:194 > // Self-referential attributes Please remove this comment now that self() is the only self-referential attribute that we have a member function for and its name is self-descriptive. Self :) 1410194 4 dbates 2018-03-28 23:26:01 -0700 (In reply to Daniel Bates from comment #3) > Comment on attachment 336724 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336724&action=review > > > Source/WebCore/page/DOMWindow.h:194 > > // Self-referential attributes > > Please remove this comment now that self() is the only self-referential > attribute that we have a member function for and its name is > self-descriptive. Self :) Err, top() is self-referential for the main frame :/ 1410284 5 336777 cdumez 2018-03-29 09:27:08 -0700 Created attachment 336777 Patch 1410286 6 ews-watchlist 2018-03-29 09:29:08 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1410292 7 336777 commit-queue 2018-03-29 09:52:37 -0700 Comment on attachment 336777 Patch Clearing flags on attachment: 336777 Committed r230077: <https://trac.webkit.org/changeset/230077> 1410293 8 commit-queue 2018-03-29 09:52:39 -0700 All reviewed patches have been landed. Closing bug. 1410294 9 webkit-bug-importer 2018-03-29 09:53:23 -0700 <rdar://problem/39002370> 336724 2018-03-28 15:10:24 -0700 2018-03-29 09:27:07 -0700 Patch bug-184112-20180328151024.patch text/plain 2643 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODAwYzMwNGI3YzhhOTEy MDdjNWYxMDRiY2FhYWMwY2Q2Y2JkMWRlNS4uMDQxMzQ3YzhlZThkZjFhNDk2MTMyOTYxMzNmM2Ex NDBhMTUxOTg1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAzLTI4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBET01XaW5kb3c6OmZy YW1lcygpIC8gRE9NV2luZG93Ojp3aW5kb3coKSBtZXRob2RzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQxMTIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcm9wIERPTVdpbmRvdzo6ZnJhbWVzKCkgLyBE T01XaW5kb3c6OndpbmRvdygpIG1ldGhvZHMgYXMgdGhleSBhcmUganVzdCBhbGlhc2VzIGZvciBE T01XaW5kb3c6OnNlbGYoKS4KKworICAgICAgICAqIHBhZ2UvRE9NV2luZG93Lmg6CisgICAgICAg ICogcGFnZS9ET01XaW5kb3cuaWRsOgorCiAyMDE4LTAzLTI4ICBEYW5pZWwgQmF0ZXMgIDxkYWJh dGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBTdWJzdGl0dXRlICJzdHJvbmcgcGFzc3dvcmQgY29u ZmlybWF0aW9uIGF1dG8gZmlsbCIgZm9yICJzdHJvbmcgY29uZmlybWF0aW9uIHBhc3N3b3JkIGF1 dG8gZmlsbCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmggYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCmluZGV4IDY0MjJhNDg1MTdhZTNkZTVjNzFj MGE4NTIxNGViYWNhNzcxNmE0NTMuLjhmNDA5NTlmM2VlZmFjZTEzZGZmM2U2NjhmY2EwYWE1Y2Rl ZWVjMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaApAQCAtMTk0LDggKzE5NCw2IEBAIHB1Ymxp YzoKICAgICAvLyBTZWxmLXJlZmVyZW50aWFsIGF0dHJpYnV0ZXMKIAogICAgIERPTVdpbmRvdyog c2VsZigpIGNvbnN0OwotICAgIERPTVdpbmRvdyogd2luZG93KCkgY29uc3QgeyByZXR1cm4gc2Vs ZigpOyB9Ci0gICAgRE9NV2luZG93KiBmcmFtZXMoKSBjb25zdCB7IHJldHVybiBzZWxmKCk7IH0K IAogICAgIERPTVdpbmRvdyogb3BlbmVyKCkgY29uc3Q7CiAgICAgdm9pZCBkaXNvd25PcGVuZXIo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAppbmRleCA4MDFhMGZiM2JiMzMxYmE0ZDgyOWMz ZDJhMGQ5NjczZGE0MGUwYzZmLi40NmViYzE1NjFmYWViZWY3MzBjY2I5YmMzZmE1MmMwNGYwY2Rk NjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCkBAIC00OSw3ICs0OSw3IEBAIHR5cGVk ZWYgVVNWU3RyaW5nIENTU09NU3RyaW5nOwogICAgIFByaW1hcnlHbG9iYWwsCiBdIGludGVyZmFj ZSBET01XaW5kb3cgOiBFdmVudFRhcmdldCB7CiAgICAgLy8gVGhlIGN1cnJlbnQgYnJvd3Npbmcg Y29udGV4dC4KLSAgICBbRG9Ob3RDaGVja1NlY3VyaXR5LCBVbmZvcmdlYWJsZV0gcmVhZG9ubHkg YXR0cmlidXRlIERPTVdpbmRvdyB3aW5kb3c7CisgICAgW0RvTm90Q2hlY2tTZWN1cml0eSwgVW5m b3JnZWFibGUsIEltcGxlbWVudGVkQXM9c2VsZl0gcmVhZG9ubHkgYXR0cmlidXRlIERPTVdpbmRv dyB3aW5kb3c7CiAgICAgW1JlcGxhY2VhYmxlLCBEb05vdENoZWNrU2VjdXJpdHlPbkdldHRlcl0g cmVhZG9ubHkgYXR0cmlidXRlIERPTVdpbmRvdyBzZWxmOwogICAgIFtVbmZvcmdlYWJsZV0gcmVh ZG9ubHkgYXR0cmlidXRlIERvY3VtZW50IGRvY3VtZW50OwogICAgIGF0dHJpYnV0ZSBET01TdHJp bmcgbmFtZTsKQEAgLTcwLDcgKzcwLDcgQEAgdHlwZWRlZiBVU1ZTdHJpbmcgQ1NTT01TdHJpbmc7 CiAgICAgW0RvTm90Q2hlY2tTZWN1cml0eSwgRm9yd2FyZERlY2xhcmVJbkhlYWRlcl0gdm9pZCBi bHVyKCk7CiAKICAgICAvLyBPdGhlciBicm93c2luZyBjb250ZXh0cy4KLSAgICBbUmVwbGFjZWFi bGUsIERvTm90Q2hlY2tTZWN1cml0eU9uR2V0dGVyXSByZWFkb25seSBhdHRyaWJ1dGUgRE9NV2lu ZG93IGZyYW1lczsKKyAgICBbUmVwbGFjZWFibGUsIERvTm90Q2hlY2tTZWN1cml0eU9uR2V0dGVy LCBJbXBsZW1lbnRlZEFzPXNlbGZdIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01XaW5kb3cgZnJhbWVz OwogICAgIFtSZXBsYWNlYWJsZSwgRG9Ob3RDaGVja1NlY3VyaXR5T25HZXR0ZXJdIHJlYWRvbmx5 IGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25nIGxlbmd0aDsKICAgICBbRG9Ob3RDaGVja1NlY3VyaXR5 T25HZXR0ZXIsIFVuZm9yZ2VhYmxlXSByZWFkb25seSBhdHRyaWJ1dGUgRE9NV2luZG93PyB0b3A7 CiAgICAgW0RvTm90Q2hlY2tTZWN1cml0eU9uR2V0dGVyLCBDdXN0b21TZXR0ZXJdIGF0dHJpYnV0 ZSBET01XaW5kb3c/IG9wZW5lcjsK 336777 2018-03-29 09:27:08 -0700 2018-03-29 09:52:37 -0700 Patch bug-184112-20180329092708.patch text/plain 4005 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWVlMDAyN2MwNmQ0Mzkz ODI4MDA2ZmUzNjk3YjgwYjc3MDEwY2Q0OC4uMDE2MDU5Y2Q1MzBkMGExM2RmZTI0YTRjNzY0ZDQy ZWViNDY2OWFkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAzLTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBET01XaW5kb3c6OmZy YW1lcygpIC8gRE9NV2luZG93Ojp3aW5kb3coKSBtZXRob2RzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQxMTIKKworICAgICAgICBSZXZpZXdlZCBi eSBEYW5pZWwgQmF0ZXMuCisKKyAgICAgICAgRHJvcCBET01XaW5kb3c6OmZyYW1lcygpIC8gRE9N V2luZG93Ojp3aW5kb3coKSBtZXRob2RzIGFzIHRoZXkgYXJlIGp1c3QgYWxpYXNlcyBmb3IgRE9N V2luZG93OjpzZWxmKCkuCisKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5oOgorICAgICAgICAq IHBhZ2UvRE9NV2luZG93LmlkbDoKKwogMjAxOC0wMy0yOSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0 LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIz MDA2Mi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmggYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCmluZGV4IDY0MjJhNDg1MTdhZTNkZTVjNzFjMGE4 NTIxNGViYWNhNzcxNmE0NTMuLjRjNjZiNzI0ZTI5YWJiYjBhMGIyYmNiNjZkNTczMWNlODRlZDFk N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaApAQCAtMTkxLDExICsxOTEsNyBAQCBwdWJsaWM6 CiAgICAgU3RyaW5nIGRlZmF1bHRTdGF0dXMoKSBjb25zdDsKICAgICB2b2lkIHNldERlZmF1bHRT dGF0dXMoY29uc3QgU3RyaW5nJik7CiAKLSAgICAvLyBTZWxmLXJlZmVyZW50aWFsIGF0dHJpYnV0 ZXMKLQogICAgIERPTVdpbmRvdyogc2VsZigpIGNvbnN0OwotICAgIERPTVdpbmRvdyogd2luZG93 KCkgY29uc3QgeyByZXR1cm4gc2VsZigpOyB9Ci0gICAgRE9NV2luZG93KiBmcmFtZXMoKSBjb25z dCB7IHJldHVybiBzZWxmKCk7IH0KIAogICAgIERPTVdpbmRvdyogb3BlbmVyKCkgY29uc3Q7CiAg ICAgdm9pZCBkaXNvd25PcGVuZXIoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RE9NV2luZG93LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAppbmRleCA4 MDFhMGZiM2JiMzMxYmE0ZDgyOWMzZDJhMGQ5NjczZGE0MGUwYzZmLi40NmViYzE1NjFmYWViZWY3 MzBjY2I5YmMzZmE1MmMwNGYwY2RkNjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RPTVdpbmRvdy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCkBA IC00OSw3ICs0OSw3IEBAIHR5cGVkZWYgVVNWU3RyaW5nIENTU09NU3RyaW5nOwogICAgIFByaW1h cnlHbG9iYWwsCiBdIGludGVyZmFjZSBET01XaW5kb3cgOiBFdmVudFRhcmdldCB7CiAgICAgLy8g VGhlIGN1cnJlbnQgYnJvd3NpbmcgY29udGV4dC4KLSAgICBbRG9Ob3RDaGVja1NlY3VyaXR5LCBV bmZvcmdlYWJsZV0gcmVhZG9ubHkgYXR0cmlidXRlIERPTVdpbmRvdyB3aW5kb3c7CisgICAgW0Rv Tm90Q2hlY2tTZWN1cml0eSwgVW5mb3JnZWFibGUsIEltcGxlbWVudGVkQXM9c2VsZl0gcmVhZG9u bHkgYXR0cmlidXRlIERPTVdpbmRvdyB3aW5kb3c7CiAgICAgW1JlcGxhY2VhYmxlLCBEb05vdENo ZWNrU2VjdXJpdHlPbkdldHRlcl0gcmVhZG9ubHkgYXR0cmlidXRlIERPTVdpbmRvdyBzZWxmOwog ICAgIFtVbmZvcmdlYWJsZV0gcmVhZG9ubHkgYXR0cmlidXRlIERvY3VtZW50IGRvY3VtZW50Owog ICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgbmFtZTsKQEAgLTcwLDcgKzcwLDcgQEAgdHlwZWRlZiBV U1ZTdHJpbmcgQ1NTT01TdHJpbmc7CiAgICAgW0RvTm90Q2hlY2tTZWN1cml0eSwgRm9yd2FyZERl Y2xhcmVJbkhlYWRlcl0gdm9pZCBibHVyKCk7CiAKICAgICAvLyBPdGhlciBicm93c2luZyBjb250 ZXh0cy4KLSAgICBbUmVwbGFjZWFibGUsIERvTm90Q2hlY2tTZWN1cml0eU9uR2V0dGVyXSByZWFk b25seSBhdHRyaWJ1dGUgRE9NV2luZG93IGZyYW1lczsKKyAgICBbUmVwbGFjZWFibGUsIERvTm90 Q2hlY2tTZWN1cml0eU9uR2V0dGVyLCBJbXBsZW1lbnRlZEFzPXNlbGZdIHJlYWRvbmx5IGF0dHJp YnV0ZSBET01XaW5kb3cgZnJhbWVzOwogICAgIFtSZXBsYWNlYWJsZSwgRG9Ob3RDaGVja1NlY3Vy aXR5T25HZXR0ZXJdIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25nIGxlbmd0aDsKICAg ICBbRG9Ob3RDaGVja1NlY3VyaXR5T25HZXR0ZXIsIFVuZm9yZ2VhYmxlXSByZWFkb25seSBhdHRy aWJ1dGUgRE9NV2luZG93PyB0b3A7CiAgICAgW0RvTm90Q2hlY2tTZWN1cml0eU9uR2V0dGVyLCBD dXN0b21TZXR0ZXJdIGF0dHJpYnV0ZSBET01XaW5kb3c/IG9wZW5lcjsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL0RPTS9XZWJLaXRE T01ET01XaW5kb3cuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxl L0FQSS9ndGsvRE9NL1dlYktpdERPTURPTVdpbmRvdy5jcHAKaW5kZXggOWEzMmFkZjFmOTgzMGIy ZjMzZTM1OTgyNTNkN2VmNzA3ZjJmOGQ3Mi4uNWYwZjJmMDkzOTg2ZWNkZGNmMDhlNzkxMTZmYmVi MGM5YTIwMjFjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVk QnVuZGxlL0FQSS9ndGsvRE9NL1dlYktpdERPTURPTVdpbmRvdy5jcHAKKysrIGIvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsvRE9NL1dlYktpdERPTURPTVdp bmRvdy5jcHAKQEAgLTk2Miw3ICs5NjIsNyBAQCBXZWJLaXRET01ET01XaW5kb3cqIHdlYmtpdF9k b21fZG9tX3dpbmRvd19nZXRfd2luZG93KFdlYktpdERPTURPTVdpbmRvdyogc2VsZikKICAgICBX ZWJDb3JlOjpKU01haW5UaHJlYWROdWxsU3RhdGUgc3RhdGU7CiAgICAgZ19yZXR1cm5fdmFsX2lm X2ZhaWwoV0VCS0lUX0RPTV9JU19ET01fV0lORE9XKHNlbGYpLCAwKTsKICAgICBXZWJDb3JlOjpE T01XaW5kb3cqIGl0ZW0gPSBXZWJLaXQ6OmNvcmUoc2VsZik7Ci0gICAgUmVmUHRyPFdlYkNvcmU6 OkRPTVdpbmRvdz4gZ29iamVjdFJlc3VsdCA9IFdURjo6Z2V0UHRyKGl0ZW0tPndpbmRvdygpKTsK KyAgICBSZWZQdHI8V2ViQ29yZTo6RE9NV2luZG93PiBnb2JqZWN0UmVzdWx0ID0gV1RGOjpnZXRQ dHIoaXRlbS0+c2VsZigpKTsKICAgICByZXR1cm4gV2ViS2l0OjpraXQoZ29iamVjdFJlc3VsdC5n ZXQoKSk7CiB9CiAKQEAgLTk3MSw3ICs5NzEsNyBAQCBXZWJLaXRET01ET01XaW5kb3cqIHdlYmtp dF9kb21fZG9tX3dpbmRvd19nZXRfZnJhbWVzKFdlYktpdERPTURPTVdpbmRvdyogc2VsZikKICAg ICBXZWJDb3JlOjpKU01haW5UaHJlYWROdWxsU3RhdGUgc3RhdGU7CiAgICAgZ19yZXR1cm5fdmFs X2lmX2ZhaWwoV0VCS0lUX0RPTV9JU19ET01fV0lORE9XKHNlbGYpLCAwKTsKICAgICBXZWJDb3Jl OjpET01XaW5kb3cqIGl0ZW0gPSBXZWJLaXQ6OmNvcmUoc2VsZik7Ci0gICAgUmVmUHRyPFdlYkNv cmU6OkRPTVdpbmRvdz4gZ29iamVjdFJlc3VsdCA9IFdURjo6Z2V0UHRyKGl0ZW0tPmZyYW1lcygp KTsKKyAgICBSZWZQdHI8V2ViQ29yZTo6RE9NV2luZG93PiBnb2JqZWN0UmVzdWx0ID0gV1RGOjpn ZXRQdHIoaXRlbS0+c2VsZigpKTsKICAgICByZXR1cm4gV2ViS2l0OjpraXQoZ29iamVjdFJlc3Vs dC5nZXQoKSk7CiB9CiAK