184110 2018-03-28 13:17:07 -0700 [iOS] Multiple select appearance doesn't update when selecting or deselecting rows in the picker view 2018-03-28 15:03:11 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin cdumez commit-queue thorton timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1410012 0 wenson_hsieh 2018-03-28 13:17:07 -0700 <rdar://problem/38796648> 1410019 1 wenson_hsieh 2018-03-28 13:22:21 -0700 To reproduce: 1. Tap on a multiple select element 2. Pick a few rows, but don't hit Done Expected: the title of the select should reflect the current state of the options Observed: the title of the select is whatever it was prior to focusing the node Some additional notes: - As far as I know, the WK2 implementation has always been this way - When a row is selected using the picker UI, the corresponding option element is actually updated in the DOM (asking for option.selected will return the updated value) - However, the appearance of the select element itself doesn't update until the node is blurred - Alternately, programmatic changes to the selected attribute of the select's options also trigger appearance updates 1410030 2 336710 wenson_hsieh 2018-03-28 13:37:50 -0700 Created attachment 336710 Patch 1410067 3 336710 commit-queue 2018-03-28 15:03:09 -0700 Comment on attachment 336710 Patch Clearing flags on attachment: 336710 Committed r230055: <https://trac.webkit.org/changeset/230055> 1410068 4 commit-queue 2018-03-28 15:03:11 -0700 All reviewed patches have been landed. Closing bug. 336710 2018-03-28 13:37:50 -0700 2018-03-28 15:03:09 -0700 Patch bug-184110-20180328133749.patch text/plain 6483 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzJmMmEzZmY3ZmVjYzBj ZWFkNTE5NTBjYmE2OGUzM2JmYTEwODQ4Ni4uOWIxN2I2MjI0NmZmNzViNDlmYTJjMjExYTJjOTgw NjIwMjZiNGQyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTAzLTI4ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIE11bHRp cGxlIHNlbGVjdCBhcHBlYXJhbmNlIGRvZXNuJ3QgdXBkYXRlIHdoZW4gc2VsZWN0aW5nIG9yIGRl c2VsZWN0aW5nIHJvd3MgaW4gdGhlIHBpY2tlciB2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQxMTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzM4Nzk2NjQ4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEhUTUxTZWxlY3RFbGVtZW50OjpvcHRpb25TZWxlY3RlZEJ5VXNlciBpcyBpbnZva2VkIHVw b24gdXNlciBpbnRlcmFjdGlvbiB3aXRoIGEgc2VsZWN0IG1lbnUuIFRoaXMgY3VycmVudGx5Cisg ICAgICAgIHRha2VzIHR3byBzZXBhcmF0ZSBjb2RlcGF0aHMsIGRlcGVuZGluZyBvbiB3aGV0aGVy IG9yIG5vdCB0aGUgbWVudSBsaXN0IGFwcGVhcmFuY2UgaXMgYmVpbmcgdXNlZCB0byByZW5kZXIg dGhlCisgICAgICAgIHNlbGVjdC4gSWYgYSBtZW51IGxpc3QgYXBwZWFyYW5jZSBpcyB1c2VkLCB3 ZSBjYWxsIHNlbGVjdE9wdGlvbigpLCB3aGljaCB1cGRhdGVzIHZhbGlkaXR5LCB1cGRhdGVzIHRo ZSBlbGVtZW50CisgICAgICAgIHJlbmRlcmVyLCBhbmQgdGhlbiBkaXNwYXRjaGVzIGEgYGNoYW5n ZWAgZXZlbnQgaWYgbmVlZGVkLgorCisgICAgICAgIEhvd2V2ZXIsIGlmIHVwZGF0ZVNlbGVjdGVk U3RhdGUoKSBpcyB1c2VkLCB3ZSBvbmx5IHVwZGF0ZSBmb3JtIHZhbGlkaXR5IGFuZCB0aGVuIGRp c3BhdGNoIHRoZSBgY2hhbmdlYCBldmVudAorICAgICAgICB3aXRob3V0IHVwZGF0aW5nIHRoZSBy ZW5kZXJlciwgbGVhdmluZyBpdCBzdGFsZS4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL2lv cy9pcGFkL211bHRpcGxlLXNlbGVjdC11cGRhdGVzLXJlbmRlcmVyLmh0bWwKKworICAgICAgICAq IGh0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFNlbGVj dEVsZW1lbnQ6Om9wdGlvblNlbGVjdGVkQnlVc2VyKToKKworICAgICAgICBVcGRhdGUgdGhlIHJl bmRlcmVyIGFmdGVyIHVwZGF0aW5nIHRoZSBET00gdG8gcmVmbGVjdCB0aGUgc2VsZWN0ZWQgb3B0 aW9uLgorCiAyMDE4LTAzLTI4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29t PgogCiAgICAgICAgIFtFeHRyYSB6b29tIG1vZGVdIE1ha2UgYm9vc3RlZCB0ZXh0IGF1dG9zaXpp bmcgdmFsdWVzIHN3aXRjaGFibGUgYXQgcnVudGltZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxT ZWxlY3RFbGVtZW50LmNwcAppbmRleCAwYTg2MDJlZTcxYzQ5NjkwMjhkZGE2MGNmNTBiZjg0ZWZl YzY5NDgyLi42MjEzZGJkZDJiMjk2MGQ0OTVkYWRjOGIzMDY1MDAxMWMxZjgyODEyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcApAQCAtMTE3LDYgKzExNyw4IEBA IHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6Om9wdGlvblNlbGVjdGVkQnlVc2VyKGludCBvcHRpb25J bmRleCwgYm9vbCBmaXJlT25DaGFuZ2VOCiAgICAgaWYgKCF1c2VzTWVudUxpc3QoKSkgewogICAg ICAgICB1cGRhdGVTZWxlY3RlZFN0YXRlKG9wdGlvblRvTGlzdEluZGV4KG9wdGlvbkluZGV4KSwg YWxsb3dNdWx0aXBsZVNlbGVjdGlvbiwgZmFsc2UpOwogICAgICAgICB1cGRhdGVWYWxpZGl0eSgp OworICAgICAgICBpZiAoYXV0byogcmVuZGVyZXIgPSB0aGlzLT5yZW5kZXJlcigpKQorICAgICAg ICAgICAgcmVuZGVyZXItPnVwZGF0ZUZyb21FbGVtZW50KCk7CiAgICAgICAgIGlmIChmaXJlT25D aGFuZ2VOb3cpCiAgICAgICAgICAgICBsaXN0Qm94T25DaGFuZ2UoKTsKICAgICAgICAgcmV0dXJu OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IGFhODVhYTYzN2JmMGFmMzc2Yjg4ZGZmYmJkNTRjYTViOThmNjZhOGUuLmY2MjFj YzExYWFlYTRmZWE5NDUyMGVjMzViZGRiMDkwMGQ4MWZlMzAgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBA QAorMjAxOC0wMy0yOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKwor ICAgICAgICBbaU9TXSBNdWx0aXBsZSBzZWxlY3QgYXBwZWFyYW5jZSBkb2Vzbid0IHVwZGF0ZSB3 aGVuIHNlbGVjdGluZyBvciBkZXNlbGVjdGluZyByb3dzIGluIHRoZSBwaWNrZXIgdmlldworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MTEwCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8zODc5NjY0OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGRzIGEgbmV3IGxheW91dCB0ZXN0IHRvIHZlcmlmeSB0 aGF0IGFmdGVyIHRhcHBpbmcgb24gYSBtdWx0aXBsZSBzZWxlY3QgYW5kIGNob29zaW5nIGFuIG9w dGlvbiwgdGhlIHNlbGVjdCdzCisgICAgICAgIHJlbmRlcmVyIGlzIHVwZGF0ZWQgdG8gcmVmbGVj dCBpdHMgbmV3IHN0YXRlLgorCisgICAgICAgICogZmFzdC9mb3Jtcy9pb3MvaXBhZC9tdWx0aXBs ZS1zZWxlY3QtdXBkYXRlcy1yZW5kZXJlci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGZhc3QvZm9ybXMvaW9zL2lwYWQvbXVsdGlwbGUtc2VsZWN0LXVwZGF0ZXMtcmVuZGVyZXIuaHRt bDogQWRkZWQuCisgICAgICAgICogcmVzb3VyY2VzL2Jhc2ljLWdlc3R1cmVzLmpzOgorCiAyMDE4 LTAzLTI3ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBNb2Rlcm5pemUgc29tZSB1dGlsaXR5IGZ1bmN0aW9ucwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvaXBhZC9tdWx0aXBsZS1zZWxlY3QtdXBkYXRl cy1yZW5kZXJlci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9pcGFk L211bHRpcGxlLXNlbGVjdC11cGRhdGVzLXJlbmRlcmVyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li5hYTQ0ZTdjOWY5MTFiNzI5MjkxM2FhZTRlZDVhYzE3YzgwNGI5MjgzCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvaXBhZC9tdWx0aXBsZS1zZWxlY3QtdXBk YXRlcy1yZW5kZXJlci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACisKK1BBU1MKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2lwYWQvbXVsdGlwbGUtc2VsZWN0LXVw ZGF0ZXMtcmVuZGVyZXIuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2lwYWQvbXVs dGlwbGUtc2VsZWN0LXVwZGF0ZXMtcmVuZGVyZXIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iNmU3MWJmZTM4 N2I0NDkyNWM2ZDJlYWRlNmM2YWY3ZDBlYzRmOGYwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9pb3MvaXBhZC9tdWx0aXBsZS1zZWxlY3QtdXBkYXRlcy1yZW5kZXJl ci5odG1sCkBAIC0wLDAgKzEsNjEgQEAKKzwhRE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10ZXN0 LXJ1bm5lciBbIHVzZUZsZXhpYmxlVmlld3BvcnQ9dHJ1ZSBdIC0tPgorPGh0bWw+Cis8aGVhZD4K KzxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJpbml0aWFsLXNjYWxlPTEuMCwgdXNlci1z Y2FsYWJsZT1ubyI+Cis8c3R5bGU+CisgICAgYm9keSwgaHRtbCB7CisgICAgICAgIHdpZHRoOiAx MDAlOworICAgICAgICBoZWlnaHQ6IDEwMCU7CisgICAgICAgIG1hcmdpbjogMDsKKyAgICB9Cisg ICAgc2VsZWN0IHsKKyAgICAgICAgd2lkdGg6IDIwMHB4OworICAgICAgICBoZWlnaHQ6IDIwMHB4 OworICAgIH0KKzwvc3R5bGU+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vLi4vcmVzb3VyY2VzL2Jh c2ljLWdlc3R1cmVzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisgICAgYXN5bmMgZnVuY3Rpb24g cnVuKCkKKyAgICB7CisgICAgICAgIGlmICghd2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAg ICByZXR1cm47CisKKyAgICAgICAgYXdhaXQgdGFwQXRQb2ludCgxMDAsIDEwMCk7CisgICAgICAg IGF3YWl0IHNlbGVjdEZvcm1BY2Nlc3NvcnlQaWNrZXJSb3coMCk7CisgICAgICAgIGRvbmVFdmFs dWF0aW5nVUlTY3JpcHQgPSB0cnVlOworICAgICAgICBjaGVja0RvbmUoKTsKKyAgICB9CisKKyAg ICBmdW5jdGlvbiBjaGVja0RvbmUoKQorICAgIHsKKyAgICAgICAgaWYgKHdpbmRvdy5kb25lRXZh bHVhdGluZ1VJU2NyaXB0ICYmIHdpbmRvdy52YWx1ZUNoYW5nZWQgJiYgd2luZG93LnRlc3RSdW5u ZXIpCisgICAgICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICB9Cis8L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuKCkiPgorICAgIDxzZWxlY3QgbXVsdGlwbGUg aWQ9InNlbGVjdCI+PG9wdGlvbj5UaGlzIGlzIGFuIG9wdGlvbi48L29wdGlvbj48L3NlbGVjdD4K KyAgICA8cHJlIGlkPSJvdXRwdXQiPjwvcHJlPgorPC9ib2R5PgorPHNjcmlwdD4KKyAgICBzZWxl Y3QuYWRkRXZlbnRMaXN0ZW5lcigiY2hhbmdlIiwgKCkgPT4geworICAgICAgICBpZiAod2luZG93 LmludGVybmFscykgeworICAgICAgICAgICAgY29uc3QgcmVuZGVyVHJlZUFzVGV4dCA9IGludGVy bmFscy5lbGVtZW50UmVuZGVyVHJlZUFzVGV4dChkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQpOwor ICAgICAgICAgICAgY29uc3QgZXhwZWN0ZWRPcHRpb25WYWx1ZSA9ICJUaGlzIGlzIGFuIG9wdGlv bi4iOworICAgICAgICAgICAgaWYgKHJlbmRlclRyZWVBc1RleHQuaW5kZXhPZihleHBlY3RlZE9w dGlvblZhbHVlKSAhPSAtMSkKKyAgICAgICAgICAgICAgICBvdXRwdXQudGV4dENvbnRlbnQgPSAi UEFTUyI7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgb3V0cHV0LnRleHRDb250 ZW50ID0gYEZBSUw6IGV4cGVjdGVkICcke2V4cGVjdGVkT3B0aW9uVmFsdWV9JyBpbiByZW5kZXIg dHJlZSBkdW1wOlxuJHtyZW5kZXJUcmVlQXNUZXh0fWA7CisgICAgICAgIH0KKworICAgICAgICBz ZWxlY3QuYmx1cigpOworICAgICAgICB2YWx1ZUNoYW5nZWQgPSB0cnVlOworICAgICAgICBjaGVj a0RvbmUoKTsKKyAgICB9KTsKKworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAg ICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNU ZXh0KCk7CisgICAgfQorPC9zY3JpcHQ+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9yZXNvdXJjZXMvYmFzaWMtZ2VzdHVyZXMuanMgYi9MYXlvdXRUZXN0cy9yZXNvdXJjZXMvYmFz aWMtZ2VzdHVyZXMuanMKaW5kZXggYzk2NTlhNDFlOTVhMjhhNzdlMDE2N2U0NjQ4NjEyNTJjMWE2 YzJmOC4uOWQ0NmQyYzA1YzU2NzQyN2FlMWJjMDAxYmE3MmYzYWM1YWQ5NTk5OSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL2Jhc2ljLWdlc3R1cmVzLmpzCisrKyBiL0xheW91dFRl c3RzL3Jlc291cmNlcy9iYXNpYy1nZXN0dXJlcy5qcwpAQCAtMTQwLDYgKzE0MCwxMiBAQCBmdW5j dGlvbiB0b3VjaEFuZERyYWdGcm9tUG9pbnRUb1BvaW50KHN0YXJ0WCwgc3RhcnRZLCBlbmRYLCBl bmRZKQogICAgIH0pOwogfQogCitmdW5jdGlvbiBzZWxlY3RGb3JtQWNjZXNzb3J5UGlja2VyUm93 KHJvd0luZGV4KQoreworICAgIGNvbnN0IHNlbGVjdFJvd1NjcmlwdCA9IGAoKCkgPT4gdWlDb250 cm9sbGVyLnNlbGVjdEZvcm1BY2Nlc3NvcnlQaWNrZXJSb3coJHtyb3dJbmRleH0pKSgpYDsKKyAg ICByZXR1cm4gbmV3IFByb21pc2UocmVzb2x2ZSA9PiB0ZXN0UnVubmVyLnJ1blVJU2NyaXB0KHNl bGVjdFJvd1NjcmlwdCwgcmVzb2x2ZSkpOworfQorCiBmdW5jdGlvbiBob2xkQXRQb2ludCh4LCB5 KQogewogICAgIHJldHVybiBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHsK