184104 2018-03-28 11:46:42 -0700 Web Inspector: Remove dead TabBrowser/TabContentView code 2018-04-01 23:00:43 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1409955 0 mattbaker 2018-03-28 11:46:42 -0700 Summary: Remove dead TabBrowser/TabContentView code. Additionally, code that accesses the global TabBar through the TabBrowser should just access the TabBar directly. 1409956 1 336686 mattbaker 2018-03-28 11:48:26 -0700 Created attachment 336686 Patch 1410948 2 336686 hi 2018-04-01 01:40:07 -0700 Comment on attachment 336686 Patch r=me. Nice fixes :) 1411007 3 336686 commit-queue 2018-04-01 22:59:33 -0700 Comment on attachment 336686 Patch Clearing flags on attachment: 336686 Committed r230149: <https://trac.webkit.org/changeset/230149> 1411008 4 commit-queue 2018-04-01 22:59:34 -0700 All reviewed patches have been landed. Closing bug. 1411009 5 webkit-bug-importer 2018-04-01 23:00:43 -0700 <rdar://problem/39096687> 336686 2018-03-28 11:48:26 -0700 2018-04-01 22:59:33 -0700 Patch bug-184104-20180328114826.patch text/plain 6007 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBh Yjg3Y2YwMDEzZjE4ZWQ4ZWQ1MDMzYTJhMzQzMTBkMTA5MzQwMWY1Li42MzMxOThlMDU2OGM2YTM5 MzQ0ZGMxYTA4N2VkOTgzZTJlYmVmMjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxOC0wMy0yOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIGRlYWQgVGFiQnJvd3Nlci9UYWJDb250 ZW50VmlldyBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODQxMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV0kuX3RyeVRvUmVz dG9yZVBlbmRpbmdUYWJzKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05ld1RhYkNv bnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuTmV3VGFiQ29udGVudFZpZXcucHJvdG90eXBlLnNo b3duKToKKyAgICAgICAgKFdJLk5ld1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5oaWRkZW4pOgor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGFiQnJvd3Nlci5qczoKKyAgICAgICAgKFdJ LlRhYkJyb3dzZXIucHJvdG90eXBlLmFkZFRhYkZvckNvbnRlbnRWaWV3KToKKyAgICAgICAgKFdJ LlRhYkJyb3dzZXIucHJvdG90eXBlLnNob3dUYWJGb3JDb250ZW50Vmlldyk6CisgICAgICAgIChX SS5UYWJCcm93c2VyLl90YWJCYXJJdGVtUmVtb3ZlZCk6CisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9UYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLlRhYkNvbnRlbnRWaWV3LnBy b3RvdHlwZS5nZXQgcGFyZW50VGFiQnJvd3Nlcik6IERlbGV0ZWQuCisgICAgICAgIChXSS5UYWJD b250ZW50Vmlldy5wcm90b3R5cGUuc2V0IHBhcmVudFRhYkJyb3dzZXIpOiBEZWxldGVkLgorCiAy MDE4LTAzLTI3ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBNb2Rlcm5pemUgc29tZSB1dGlsaXR5IGZ1bmN0aW9ucwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDE1 ZjQzMGE0MTJhZDBjZTUxY2JjYjZiMTA4MjBjMjAzN2JjMjVkNDAuLjVlYzIxYjhiMzE5MjA2MTNm ZWJjZDFlMmIyNTMzMjEyMjYxZjRkMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTYxNCw3ICs2MTQsNyBAQCBXSS5fdHJ5VG9S ZXN0b3JlUGVuZGluZ1RhYnMgPSBmdW5jdGlvbigpCiAgICAgdGhpcy5fcGVuZGluZ09wZW5UYWJz ID0gc3RpbGxQZW5kaW5nT3BlblRhYnM7CiAKICAgICBpZiAoIVdJLnNldHRpbmdzLmV4cGVyaW1l bnRhbEVuYWJsZU5ld1RhYkJhci52YWx1ZSkKLSAgICAgICAgdGhpcy50YWJCcm93c2VyLnRhYkJh ci51cGRhdGVOZXdUYWJUYWJCYXJJdGVtU3RhdGUoKTsKKyAgICAgICAgdGhpcy50YWJCYXIudXBk YXRlTmV3VGFiVGFiQmFySXRlbVN0YXRlKCk7CiB9OwogCiBXSS5zaG93TmV3VGFiVGFiID0gZnVu Y3Rpb24ob3B0aW9ucykKQEAgLTE0MTYsOCArMTQxNiw2IEBAIFdJLl9tYWluUmVzb3VyY2VEaWRD aGFuZ2UgPSBmdW5jdGlvbihldmVudCkKICAgICBpZiAoIWV2ZW50LnRhcmdldC5pc01haW5GcmFt ZSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICB0aGlzLl9pblByb3Zpc2lvbmFsTG9hZCA9IGZh bHNlOwotCiAgICAgLy8gUnVuIGNvb2tpZSByZXN0b3JhdGlvbiBhZnRlciB3ZSBhcmUgc3VyZSBh bGwgb2YgdGhlIFRhYnMgYW5kIE5hdmlnYXRpb25TaWRlYmFyUGFuZWxzCiAgICAgLy8gaGF2ZSB1 cGRhdGVkIHdpdGggcmVzcGVjdCB0byB0aGUgbWFpbiByZXNvdXJjZSBjaGFuZ2UuCiAgICAgc2V0 VGltZW91dCh0aGlzLl9yZXN0b3JlQ29va2llRm9yT3BlblRhYnMuYmluZCh0aGlzLCBXSS5TdGF0 ZVJlc3RvcmF0aW9uVHlwZS5OYXZpZ2F0aW9uKSk7CkBAIC0xNDMzLDggKzE0MzEsNiBAQCBXSS5f cHJvdmlzaW9uYWxMb2FkU3RhcnRlZCA9IGZ1bmN0aW9uKGV2ZW50KQogICAgICAgICByZXR1cm47 CiAKICAgICB0aGlzLl9zYXZlQ29va2llRm9yT3BlblRhYnMoKTsKLQotICAgIHRoaXMuX2luUHJv dmlzaW9uYWxMb2FkID0gdHJ1ZTsKIH07CiAKIFdJLl9yZXN0b3JlQ29va2llRm9yT3BlblRhYnMg PSBmdW5jdGlvbihyZXN0b3JhdGlvblR5cGUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXdUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ld1RhYkNvbnRlbnRWaWV3LmpzCmlu ZGV4IDU2MjY2NDk2Njg1YTA5ZGFiNThjNmIwNmRmNjZlNDUxY2FiOTExZGMuLmVjNGQzNzVmZjQ5 OGEzYjQxZmI3MTNmMzFlZjVmYTg3NDEyMWFiZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ld1RhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ld1RhYkNvbnRlbnRWaWV3 LmpzCkBAIC02MiwxNSArNjIsMTUgQEAgV0kuTmV3VGFiQ29udGVudFZpZXcgPSBjbGFzcyBOZXdU YWJDb250ZW50VmlldyBleHRlbmRzIFdJLlRhYkNvbnRlbnRWaWV3CiAKICAgICBzaG93bigpCiAg ICAgewotICAgICAgICBXSS50YWJCcm93c2VyLnRhYkJhci5hZGRFdmVudExpc3RlbmVyKFdJLlRh YkJhci5FdmVudC5UYWJCYXJJdGVtQWRkZWQsIHRoaXMuX3VwZGF0ZVRhYkl0ZW1zLCB0aGlzKTsK LSAgICAgICAgV0kudGFiQnJvd3Nlci50YWJCYXIuYWRkRXZlbnRMaXN0ZW5lcihXSS5UYWJCYXIu RXZlbnQuVGFiQmFySXRlbVJlbW92ZWQsIHRoaXMuX3VwZGF0ZVRhYkl0ZW1zLCB0aGlzKTsKKyAg ICAgICAgV0kudGFiQmFyLmFkZEV2ZW50TGlzdGVuZXIoV0kuVGFiQmFyLkV2ZW50LlRhYkJhckl0 ZW1BZGRlZCwgdGhpcy5fdXBkYXRlVGFiSXRlbXMsIHRoaXMpOworICAgICAgICBXSS50YWJCYXIu YWRkRXZlbnRMaXN0ZW5lcihXSS5UYWJCYXIuRXZlbnQuVGFiQmFySXRlbVJlbW92ZWQsIHRoaXMu X3VwZGF0ZVRhYkl0ZW1zLCB0aGlzKTsKIAogICAgICAgICB0aGlzLl91cGRhdGVUYWJJdGVtcygp OwogICAgIH0KIAogICAgIGhpZGRlbigpCiAgICAgewotICAgICAgICBXSS50YWJCcm93c2VyLnRh YkJhci5yZW1vdmVFdmVudExpc3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOworICAgICAgICBXSS50 YWJCYXIucmVtb3ZlRXZlbnRMaXN0ZW5lcihudWxsLCBudWxsLCB0aGlzKTsKICAgICB9CiAKICAg ICBnZXQgc3VwcG9ydHNTcGxpdENvbnRlbnRCcm93c2VyKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJyb3dzZXIuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJCcm93c2VyLmpzCmluZGV4IGE1 NjAyMGMwMWFiZWY3NjdiNGFlZDM0ZDgzNDk2M2NiNzFiZDE4OGUuLjUzN2I5M2ZiZTMzOWQ1NGIz M2Q5N2I2NmI2ZDIyZjNlYmM5YjFkN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJyb3dzZXIuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQnJvd3Nlci5qcwpAQCAtMTU3LDggKzE1Nyw2 IEBAIFdJLlRhYkJyb3dzZXIgPSBjbGFzcyBUYWJCcm93c2VyIGV4dGVuZHMgV0kuVmlldwogICAg ICAgICBpZiAodGFiQmFySXRlbS5yZXByZXNlbnRlZE9iamVjdCAhPT0gdGFiQ29udGVudFZpZXcp CiAgICAgICAgICAgICB0YWJCYXJJdGVtLnJlcHJlc2VudGVkT2JqZWN0ID0gdGFiQ29udGVudFZp ZXc7CiAKLSAgICAgICAgdGFiQ29udGVudFZpZXcucGFyZW50VGFiQnJvd3NlciA9IHRoaXM7Ci0K ICAgICAgICAgaWYgKHRhYkJhckl0ZW0ucGFyZW50VGFiQmFyID09PSB0aGlzLl90YWJCYXIpCiAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKIApAQCAtMTg1LDggKzE4Myw3IEBAIFdJLlRhYkJyb3dz ZXIgPSBjbGFzcyBUYWJCcm93c2VyIGV4dGVuZHMgV0kuVmlldwogICAgICAgICBpZiAoIXRoaXMu YWRkVGFiRm9yQ29udGVudFZpZXcodGFiQ29udGVudFZpZXcsIG9wdGlvbnMpKQogICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgIGlmICghb3B0aW9ucy5zdXBwcmVzc1NlbGVjdGlv bikKLSAgICAgICAgICAgIHRoaXMuX3RhYkJhci5zZWxlY3RlZFRhYkJhckl0ZW0gPSB0YWJDb250 ZW50Vmlldy50YWJCYXJJdGVtOworICAgICAgICB0aGlzLl90YWJCYXIuc2VsZWN0ZWRUYWJCYXJJ dGVtID0gdGFiQ29udGVudFZpZXcudGFiQmFySXRlbTsKIAogICAgICAgICAvLyBGSVhNRTogdGhp cyBpcyBhIHdvcmthcm91bmQgZm9yIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNTE4NzY+LgogICAg ICAgICAvLyBXaXRob3V0IHRoaXMgZXh0cmEgY2FsbCwgd2UgbWlnaHQgbmV2ZXIgbGF5IG91dCB0 aGUgY2hpbGQgdGFiCkBAIC0yOTIsOCArMjg5LDYgQEAgV0kuVGFiQnJvd3NlciA9IGNsYXNzIFRh YkJyb3dzZXIgZXh0ZW5kcyBXSS5WaWV3CiAKICAgICAgICAgdGhpcy5fY29udGVudFZpZXdDb250 YWluZXIuY2xvc2VDb250ZW50Vmlldyh0YWJDb250ZW50Vmlldyk7CiAKLSAgICAgICAgdGFiQ29u dGVudFZpZXcucGFyZW50VGFiQnJvd3NlciA9IG51bGw7Ci0KICAgICAgICAgY29uc29sZS5hc3Nl cnQodGhpcy5fcmVjZW50VGFiQ29udGVudFZpZXdzLmxlbmd0aCA9PT0gdGhpcy5fdGFiQmFyLnNh dmVhYmxlVGFiQ291bnQpOwogICAgICAgICBjb25zb2xlLmFzc2VydCghdGhpcy5zZWxlY3RlZFRh YkNvbnRlbnRWaWV3IHx8IHRoaXMuc2VsZWN0ZWRUYWJDb250ZW50VmlldyA9PT0gdGhpcy5fcmVj ZW50VGFiQ29udGVudFZpZXdzWzBdKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkNvbnRlbnRWaWV3LmpzCmluZGV4 IGM4ZTE5M2UxYzEzNGJjYjhjMjY4MjVjNDE4NzZhNjNiZTk5MmFlYWMuLjkzNzc0NTBlZTJjODdk ZGJlNDM2OWMyMjY3YzBhMDljNWVkMGZiYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkNvbnRlbnRWaWV3LmpzCkBAIC03 OSwxNiArNzksNiBAQCBXSS5UYWJDb250ZW50VmlldyA9IGNsYXNzIFRhYkNvbnRlbnRWaWV3IGV4 dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICAgICAgcmV0dXJuIG51bGw7CiAgICAgfQogCi0gICAg Z2V0IHBhcmVudFRhYkJyb3dzZXIoKQotICAgIHsKLSAgICAgICAgcmV0dXJuIHRoaXMuX3BhcmVu dFRhYkJyb3dzZXI7Ci0gICAgfQotCi0gICAgc2V0IHBhcmVudFRhYkJyb3dzZXIodGFiQnJvd3Nl cikKLSAgICB7Ci0gICAgICAgIHRoaXMuX3BhcmVudFRhYkJyb3dzZXIgPSB0YWJCcm93c2VyIHx8 IG51bGw7Ci0gICAgfQotCiAgICAgZ2V0IGlkZW50aWZpZXIoKQogICAgIHsKICAgICAgICAgcmV0 dXJuIHRoaXMuX2lkZW50aWZpZXI7Cg==