184093 2018-03-28 09:58:07 -0700 Rename UNUSED to BUNUSED 2018-04-09 18:43:20 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro ap commit-queue fpizlo ggaren mcatanzaro saam webkit-bug-importer ysuzuki oldest_to_newest 1409889 0 mcatanzaro 2018-03-28 09:58:07 -0700 Should we rename UNUSED to BUNUSED? This would make it less likely to be misused outside of bmalloc, as I did in bug #184081. 1409890 1 336669 mcatanzaro 2018-03-28 09:58:55 -0700 Created attachment 336669 Patch 1410135 2 336738 mcatanzaro 2018-03-28 17:32:01 -0700 Created attachment 336738 Patch 1413087 3 mcatanzaro 2018-04-09 17:28:19 -0700 Pinging bmalloc reviewers! 1413096 4 336738 ysuzuki 2018-04-09 17:32:19 -0700 Comment on attachment 336738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336738&action=review r=me > Source/bmalloc/bmalloc/BAssert.h:103 > +#define BUNUSED(x) ((void)x) renaming this to `BUNUSED_PARAM` would be good. But either is OK to me. 1413115 5 336738 mcatanzaro 2018-04-09 18:12:44 -0700 Comment on attachment 336738 Patch I kinda prefer BUNUSED, it's short and sweet, but no strong preference here either. Whatever the bmalloc crew prefers. 1413132 6 336738 commit-queue 2018-04-09 18:42:50 -0700 Comment on attachment 336738 Patch Clearing flags on attachment: 336738 Committed r230463: <https://trac.webkit.org/changeset/230463> 1413133 7 commit-queue 2018-04-09 18:42:52 -0700 All reviewed patches have been landed. Closing bug. 1413134 8 webkit-bug-importer 2018-04-09 18:43:20 -0700 <rdar://problem/39301964> 336669 2018-03-28 09:58:55 -0700 2018-03-28 17:31:59 -0700 Patch bug-184093-20180328115854.patch text/plain 2278 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggN2U4MTlmZjNlM2ZjMDEw ZTE3YmRjMTE3YjkyOWE3NTg0ODAxNGIzYS4uM2U1NTEwYjliMzk5YjNmMjY3ODYyOTIxMzFlODJj MThhMGE2ZjY0YiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAzLTI4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBSZW5hbWUg VU5VU0VEIHRvIEJVTlVTRUQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NDA5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogYm1hbGxvYy9CQXNzZXJ0Lmg6CisgICAgICAgICogYm1hbGxvYy9WTUFsbG9j YXRlLmg6CisgICAgICAgIChibWFsbG9jOjp2bVZhbGlkYXRlKToKKyAgICAgICAgKGJtYWxsb2M6 OnZtVmFsaWRhdGVQaHlzaWNhbCk6CisKIDIwMTgtMDMtMjcgIFNhYW0gQmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgbWVtb3J5U3RhdHVzKCkgaXMgd3JvbmcgaW4gY2VydGFp biB0ZXN0aW5nIHNjZW5hcmlvcyBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvQkFzc2VydC5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CQXNzZXJ0LmgKaW5kZXgg YzA5NzUxNDgxYzIwNDUxZWM5ODZmYWNhMTBlYWRlNTI4NDExYTc4NS4uNTcyZDRiNWQ2MTRjNTI5 ZTgzZDBmOWFiNjIwM2RiOTMwMGU1NzFmYiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1h bGxvYy9CQXNzZXJ0LmgKKysrIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CQXNzZXJ0LmgKQEAg LTEwMCw3ICsxMDAsNyBAQAogfSB3aGlsZSAoMCkKICNlbmRpZgogCi0jZGVmaW5lIFVOVVNFRCh4 KSAoKHZvaWQpeCkKKyNkZWZpbmUgQlVOVVNFRCh4KSAoKHZvaWQpeCkKIAogLy8gPT09PT0gUmVs ZWFzZSBidWlsZCA9PT09PQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1ZN QWxsb2NhdGUuaCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvVk1BbGxvY2F0ZS5oCmluZGV4IDcx M2U5YzlmYmI2ZDY4OWQ3YjFkMzg4YjRhNGQ1NjE0N2Y1MjNlZmYuLjMzYzBhMTNhYmExNzJhMDA4 MmM1MzM4MWFmMGQyYzU4NmFlODBlYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxs b2MvVk1BbGxvY2F0ZS5oCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvVk1BbGxvY2F0ZS5o CkBAIC03Niw3ICs3Niw3IEBAIGlubGluZSBzaXplX3Qgdm1TaXplKHNpemVfdCBzaXplKQogCiBp bmxpbmUgdm9pZCB2bVZhbGlkYXRlKHNpemVfdCB2bVNpemUpCiB7Ci0gICAgVU5VU0VEKHZtU2l6 ZSk7CisgICAgQlVOVVNFRCh2bVNpemUpOwogICAgIEJBU1NFUlQodm1TaXplKTsKICAgICBCQVNT RVJUKHZtU2l6ZSA9PSByb3VuZFVwVG9NdWx0aXBsZU9mKHZtUGFnZVNpemUoKSwgdm1TaXplKSk7 CiB9CkBAIC04NSw3ICs4NSw3IEBAIGlubGluZSB2b2lkIHZtVmFsaWRhdGUodm9pZCogcCwgc2l6 ZV90IHZtU2l6ZSkKIHsKICAgICB2bVZhbGlkYXRlKHZtU2l6ZSk7CiAgICAgCi0gICAgVU5VU0VE KHApOworICAgIEJVTlVTRUQocCk7CiAgICAgQkFTU0VSVChwKTsKICAgICBCQVNTRVJUKHAgPT0g bWFzayhwLCB+KHZtUGFnZVNpemUoKSAtIDEpKSk7CiB9CkBAIC0xMDQsNyArMTA0LDcgQEAgaW5s aW5lIHNpemVfdCB2bVBhZ2VTaXplUGh5c2ljYWwoKQogCiBpbmxpbmUgdm9pZCB2bVZhbGlkYXRl UGh5c2ljYWwoc2l6ZV90IHZtU2l6ZSkKIHsKLSAgICBVTlVTRUQodm1TaXplKTsKKyAgICBCVU5V U0VEKHZtU2l6ZSk7CiAgICAgQkFTU0VSVCh2bVNpemUpOwogICAgIEJBU1NFUlQodm1TaXplID09 IHJvdW5kVXBUb011bHRpcGxlT2Yodm1QYWdlU2l6ZVBoeXNpY2FsKCksIHZtU2l6ZSkpOwogfQpA QCAtMTEzLDcgKzExMyw3IEBAIGlubGluZSB2b2lkIHZtVmFsaWRhdGVQaHlzaWNhbCh2b2lkKiBw LCBzaXplX3Qgdm1TaXplKQogewogICAgIHZtVmFsaWRhdGVQaHlzaWNhbCh2bVNpemUpOwogICAg IAotICAgIFVOVVNFRChwKTsKKyAgICBCVU5VU0VEKHApOwogICAgIEJBU1NFUlQocCk7CiAgICAg QkFTU0VSVChwID09IG1hc2socCwgfih2bVBhZ2VTaXplUGh5c2ljYWwoKSAtIDEpKSk7CiB9Cg== 336738 2018-03-28 17:32:01 -0700 2018-04-09 18:42:50 -0700 Patch bug-184093-20180328193200.patch text/plain 3738 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRkODNkY2FmOTRjNzliYWRi N2Y1OWViZWVkOTNjODQxMWExZTkwYWQuLjNhMzUzMzAxNzUyNGQ4NmZiZThjZTE4MWI5NWIzYTk3 MTAwYjE1MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDMtMjggIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJlbmFtZSBVTlVT RUQgdG8gQlVOVVNFRAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg0MDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tX ZWJWaWV3IF9nZXRBcHBsaWNhdGlvbk1hbmlmZXN0V2l0aENvbXBsZXRpb25IYW5kbGVyOl0pOgor CiAyMDE4LTAzLTI4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAg TWFrZSBpdCBwb3NzaWJsZSB0byBvdmVycmlkZSB0aGUgc2NyZWVuIHNpemUKZGlmZiAtLWdpdCBh L1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZyBiL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwppbmRl eCAzZmI4MDVlYTBjNWU1MzhjMzA2ZmM4ZjM0NDY3ZjQzZjE3ZmVkYjZmLi45ZjJkMmM0MWNiOGU0 ZGJkZTIyMGM1MmUwZTQ1YmFhMmZkMjRkYmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cKKysrIGIvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTgtMDMtMjggIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgor CisgICAgICAgIFJlbmFtZSBVTlVTRUQgdG8gQlVOVVNFRAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBibWFsbG9jL0JBc3NlcnQuaDoKKyAgICAgICAg KiBibWFsbG9jL1ZNQWxsb2NhdGUuaDoKKyAgICAgICAgKGJtYWxsb2M6OnZtVmFsaWRhdGUpOgor ICAgICAgICAoYm1hbGxvYzo6dm1WYWxpZGF0ZVBoeXNpY2FsKToKKwogMjAxOC0wMy0yOCAgQ29t bWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjIzMDAwNS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IDBkMThlMTViM2EzNzBlNjNlOWQ1ZTkxMjg3M2IwMDc1 NjkwYTAwMjAuLjExMTY0OTllMmVlZmQ0YWQwZmM3NzZjNGQ2ZjU5MTE2Mjk0ZTM4ZDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAtNDQ1 Niw3ICs0NDU2LDcgQEAgLSAodm9pZClfZ2V0QXBwbGljYXRpb25NYW5pZmVzdFdpdGhDb21wbGV0 aW9uSGFuZGxlcjoodm9pZCAoXikoX1dLQXBwbGljYXRpb25NYW4KIHsKICNpZiBFTkFCTEUoQVBQ TElDQVRJT05fTUFOSUZFU1QpCiAgICAgX3BhZ2UtPmdldEFwcGxpY2F0aW9uTWFuaWZlc3QoW2Nv bXBsZXRpb25IYW5kbGVyID0gbWFrZUJsb2NrUHRyKGNvbXBsZXRpb25IYW5kbGVyKV0oY29uc3Qg c3RkOjpvcHRpb25hbDxXZWJDb3JlOjpBcHBsaWNhdGlvbk1hbmlmZXN0PiYgbWFuaWZlc3QsIFdl YktpdDo6Q2FsbGJhY2tCYXNlOjpFcnJvciBlcnJvcikgewotICAgICAgICBVTlVTRUQoZXJyb3Ip OworICAgICAgICBVTlVTRURfUEFSQU0oZXJyb3IpOwogICAgICAgICBpZiAoY29tcGxldGlvbkhh bmRsZXIpIHsKICAgICAgICAgICAgIGlmIChtYW5pZmVzdCkgewogICAgICAgICAgICAgICAgIGF1 dG8gYXBpTWFuaWZlc3QgPSBBUEk6OkFwcGxpY2F0aW9uTWFuaWZlc3Q6OmNyZWF0ZSgqbWFuaWZl c3QpOwpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CQXNzZXJ0LmggYi9Tb3Vy Y2UvYm1hbGxvYy9ibWFsbG9jL0JBc3NlcnQuaAppbmRleCBjMDk3NTE0ODFjMjA0NTFlYzk4NmZh Y2ExMGVhZGU1Mjg0MTFhNzg1Li41NzJkNGI1ZDYxNGM1MjllODNkMGY5YWI2MjAzZGI5MzAwZTU3 MWZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JBc3NlcnQuaAorKysgYi9T b3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JBc3NlcnQuaApAQCAtMTAwLDcgKzEwMCw3IEBACiB9IHdo aWxlICgwKQogI2VuZGlmCiAKLSNkZWZpbmUgVU5VU0VEKHgpICgodm9pZCl4KQorI2RlZmluZSBC VU5VU0VEKHgpICgodm9pZCl4KQogCiAvLyA9PT09PSBSZWxlYXNlIGJ1aWxkID09PT09CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvVk1BbGxvY2F0ZS5oIGIvU291cmNlL2Jt YWxsb2MvYm1hbGxvYy9WTUFsbG9jYXRlLmgKaW5kZXggNzEzZTljOWZiYjZkNjg5ZDdiMWQzODhi NGE0ZDU2MTQ3ZjUyM2VmZi4uMzNjMGExM2FiYTE3MmEwMDgyYzUzMzgxYWYwZDJjNTg2YWU4MGVh NyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9WTUFsbG9jYXRlLmgKKysrIGIv U291cmNlL2JtYWxsb2MvYm1hbGxvYy9WTUFsbG9jYXRlLmgKQEAgLTc2LDcgKzc2LDcgQEAgaW5s aW5lIHNpemVfdCB2bVNpemUoc2l6ZV90IHNpemUpCiAKIGlubGluZSB2b2lkIHZtVmFsaWRhdGUo c2l6ZV90IHZtU2l6ZSkKIHsKLSAgICBVTlVTRUQodm1TaXplKTsKKyAgICBCVU5VU0VEKHZtU2l6 ZSk7CiAgICAgQkFTU0VSVCh2bVNpemUpOwogICAgIEJBU1NFUlQodm1TaXplID09IHJvdW5kVXBU b011bHRpcGxlT2Yodm1QYWdlU2l6ZSgpLCB2bVNpemUpKTsKIH0KQEAgLTg1LDcgKzg1LDcgQEAg aW5saW5lIHZvaWQgdm1WYWxpZGF0ZSh2b2lkKiBwLCBzaXplX3Qgdm1TaXplKQogewogICAgIHZt VmFsaWRhdGUodm1TaXplKTsKICAgICAKLSAgICBVTlVTRUQocCk7CisgICAgQlVOVVNFRChwKTsK ICAgICBCQVNTRVJUKHApOwogICAgIEJBU1NFUlQocCA9PSBtYXNrKHAsIH4odm1QYWdlU2l6ZSgp IC0gMSkpKTsKIH0KQEAgLTEwNCw3ICsxMDQsNyBAQCBpbmxpbmUgc2l6ZV90IHZtUGFnZVNpemVQ aHlzaWNhbCgpCiAKIGlubGluZSB2b2lkIHZtVmFsaWRhdGVQaHlzaWNhbChzaXplX3Qgdm1TaXpl KQogewotICAgIFVOVVNFRCh2bVNpemUpOworICAgIEJVTlVTRUQodm1TaXplKTsKICAgICBCQVNT RVJUKHZtU2l6ZSk7CiAgICAgQkFTU0VSVCh2bVNpemUgPT0gcm91bmRVcFRvTXVsdGlwbGVPZih2 bVBhZ2VTaXplUGh5c2ljYWwoKSwgdm1TaXplKSk7CiB9CkBAIC0xMTMsNyArMTEzLDcgQEAgaW5s aW5lIHZvaWQgdm1WYWxpZGF0ZVBoeXNpY2FsKHZvaWQqIHAsIHNpemVfdCB2bVNpemUpCiB7CiAg ICAgdm1WYWxpZGF0ZVBoeXNpY2FsKHZtU2l6ZSk7CiAgICAgCi0gICAgVU5VU0VEKHApOworICAg IEJVTlVTRUQocCk7CiAgICAgQkFTU0VSVChwKTsKICAgICBCQVNTRVJUKHAgPT0gbWFzayhwLCB+ KHZtUGFnZVNpemVQaHlzaWNhbCgpIC0gMSkpKTsKIH0K