184069 2018-03-27 19:36:46 -0700 Enhance ARM64 probe to support pointer profiling. 2018-03-28 13:06:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo jfbastien keith_miller msaboff rmorisset saam webkit-bug-importer oldest_to_newest 1409761 0 mark.lam 2018-03-27 19:36:46 -0700 Patch coming. 1409763 1 webkit-bug-importer 2018-03-27 19:38:51 -0700 <rdar://problem/38939879> 1409764 2 336639 mark.lam 2018-03-27 19:42:53 -0700 Created attachment 336639 proposed patch. 1409778 3 336639 jfbastien 2018-03-27 21:37:28 -0700 Comment on attachment 336639 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=336639&action=review r=me > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2146 > + } Assert that the registers aren't the same? 1409999 4 mark.lam 2018-03-28 13:04:10 -0700 (In reply to JF Bastien from comment #3) > > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2146 > > + } > > Assert that the registers aren't the same? We talked offline, and concluded that this assertion is not always true. The client is allowed to push the same register twice if desired. So, we'll not add the assert. 1410002 5 mark.lam 2018-03-28 13:06:21 -0700 Thanks for the review. Landed in r230040: <http://trac.webkit.org/r230040>. 336639 2018-03-27 19:42:53 -0700 2018-03-27 21:37:28 -0700 proposed patch. bug-184069.patch text/plain 7045 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMwMDE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE4LTAzLTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBF bmhhbmNlIEFSTTY0IHByb2JlIHRvIHN1cHBvcnQgcG9pbnRlciBwcm9maWxpbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQwNjkKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzM4OTM5ODc5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuY3BwOgor ICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlcjo6cHJvYmUpOgorICAgICAgICAqIGFzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxl clg4NkNvbW1vbjo6cG9wUGFpcik6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29t bW9uOjpwdXNoUGFpcik6CisgICAgICAgICogYXNzZW1ibGVyL3Rlc3RtYXNtLmNwcDoKKyAgICAg ICAgKEpTQzo6dGVzdFByb2JlUmVhZHNBcmd1bWVudFJlZ2lzdGVycyk6CisgICAgICAgIChKU0M6 OnRlc3RQcm9iZVdyaXRlc0FyZ3VtZW50UmVnaXN0ZXJzKToKKyAgICAgICAgKiBydW50aW1lL1B0 clRhZy5oOgorICAgICAgICAoSlNDOjp0YWdGb3JQdHIpOgorCiAyMDE4LTAzLTI3ICBZdXN1a2Ug U3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIEFkZCBMb2FkMTZaIGZv ciBCMyBhbmQgdXNlIGl0IGluIFdlYkFzc2VtYmx5CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5jcHAJKHJldmlz aW9uIDIzMDAxNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJBUk02NC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29w eXJpZ2h0IChDKSAyMDEzLTIwMTcgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICog Q29weXJpZ2h0IChDKSAyMDEzLTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgog ICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMs IHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVk IHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0zNzEsNyArMzcxLDcgQEAgYXNtICgK ICAgICAvLyBOb3RlOiB3ZSBoYXZlbid0IGNoYW5nZWQgdGhlIHZhbHVlIG9mIGZwLiBIZW5jZSwg aXQgaXMgc3RpbGwgcG9pbnRpbmcgdG8gdGhlIGZyYW1lIG9mCiAgICAgLy8gdGhlIGNhbGxlciBv ZiB0aGUgcHJvYmUgKHdoaWNoIGlzIHdoYXQgd2Ugd2FudCBpbiBvcmRlciB0byBwbGF5IG5pY2Ug d2l0aCBkZWJ1Z2dlcnMgZS5nLiBsbGRiKS4KICAgICAibW92ICAgICAgIHgwLCBzcCIgIlxuIiAv LyBTZXQgdGhlIFByb2JlOjpTdGF0ZSogYXJnLgotICAgICJibHIgICAgICAgeDI4IiAiXG4iIC8v IENhbGwgdGhlIHByb2JlIGhhbmRsZXIuCisgICAgQ0FMTF9XSVRIX1BUUlRBRygiYmxyIiwgIngy OCIsIENGdW5jdGlvblB0clRhZykgLy8gQ2FsbCB0aGUgcHJvYmUgaGFuZGxlci4KIAogICAgIC8v IE1ha2Ugc3VyZSB0aGUgUHJvYmU6OlN0YXRlIGlzIGVudGlyZWx5IGJlbG93IHRoZSByZXN1bHQg c3RhY2sgcG9pbnRlciBzbwogICAgIC8vIHRoYXQgcmVnaXN0ZXIgdmFsdWVzIGFyZSBzdGlsbCBw cmVzZXJ2ZWQgd2hlbiB3ZSBjYWxsIHRoZSBpbml0aWFsaXplU3RhY2sKQEAgLTQwNyw3ICs0MDcs NyBAQCBhc20gKAogICAgICJjYnogICAgICAgeDIsICIgTE9DQUxfTEFCRUxfU1RSSU5HKGN0aU1h c21Qcm9iZVRyYW1wb2xpbmVSZXN0b3JlUmVnaXN0ZXJzKSAiXG4iCiAKICAgICAibW92ICAgICAg IHgwLCB4MjciICJcbiIgLy8gU2V0IHRoZSBQcm9iZTo6U3RhdGUqIGFyZy4KLSAgICAiYmxyICAg ICAgIHgyIiAiXG4iIC8vIENhbGwgdGhlIGluaXRpYWxpemVTdGFja0Z1bmN0aW9uIChsb2FkZWQg aW50byB4MiBhYm92ZSkuCisgICAgQ0FMTF9XSVRIX1BUUlRBRygiYmxyIiwgIngyIiwgQ0Z1bmN0 aW9uUHRyVGFnKSAvLyBDYWxsIHRoZSBpbml0aWFsaXplU3RhY2tGdW5jdGlvbiAobG9hZGVkIGlu dG8geDIgYWJvdmUpLgogCiAgICAgTE9DQUxfTEFCRUxfU1RSSU5HKGN0aU1hc21Qcm9iZVRyYW1w b2xpbmVSZXN0b3JlUmVnaXN0ZXJzKSAiOiIgIlxuIgogCkBAIC01MTcsNyArNTE3LDcgQEAgdm9p ZCBNYWNyb0Fzc2VtYmxlcjo6cHJvYmUoUHJvYmU6OkZ1bmN0aQogICAgIG1vdmUoVHJ1c3RlZElt bVB0cihyZWludGVycHJldF9jYXN0PHZvaWQqPihQcm9iZTo6ZXhlY3V0ZVByb2JlKSksIHgyOCk7 CiAgICAgbW92ZShUcnVzdGVkSW1tUHRyKHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KGZ1bmN0aW9u KSksIHgyNCk7CiAgICAgbW92ZShUcnVzdGVkSW1tUHRyKGFyZyksIHgyNSk7Ci0gICAgbV9hc3Nl bWJsZXIuYmxyKHgyNik7CisgICAgY2FsbCh4MjYsIENGdW5jdGlvblB0clRhZyk7CiAKICAgICAv LyBjdGlNYXNtUHJvYmVUcmFtcG9saW5lIHNob3VsZCBoYXZlIHJlc3RvcmVkIGV2ZXJ5IHJlZ2lz dGVyIGV4Y2VwdCBmb3IgbHIgYW5kIHRoZSBzcC4KICAgICBsb2FkNjQoQWRkcmVzcyhzcCwgb2Zm c2V0b2YoTFJSZXN0b3JhdGlvblJlY29yZCwgbHIpKSwgbHIpOwpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21t b24uaAkocmV2aXNpb24gMjMwMDE3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMTMzLDYgKzIx MzMsMTcgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxlci5wdXNoX2kzMihpbW0ubV92YWx1 ZSk7CiAgICAgfQogCisgICAgdm9pZCBwb3BQYWlyKFJlZ2lzdGVySUQgZGVzdDEsIFJlZ2lzdGVy SUQgZGVzdDIpCisgICAgeworICAgICAgICBwb3AoZGVzdDIpOworICAgICAgICBwb3AoZGVzdDEp OworICAgIH0KKworICAgIHZvaWQgcHVzaFBhaXIoUmVnaXN0ZXJJRCBzcmMxLCBSZWdpc3RlcklE IHNyYzIpCisgICAgeworICAgICAgICBwdXNoKHNyYzEpOworICAgICAgICBwdXNoKHNyYzIpOwor ICAgIH0KIAogICAgIC8vIFJlZ2lzdGVyIG1vdmUgb3BlcmF0aW9uczoKICAgICAvLwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci90ZXN0bWFzbS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci90ZXN0bWFzbS5jcHAJKHJldmlzaW9u IDIzMDAxNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvdGVzdG1hc20uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yMzQsMTAgKzIzNCw4IEBAIHZvaWQgdGVzdFByb2JlUmVhZHNB cmd1bWVudFJlZ2lzdGVycygpCiAgICAgY29tcGlsZUFuZFJ1bjx2b2lkPihbJl0gKENDYWxsSGVs cGVycyYgaml0KSB7CiAgICAgICAgIGppdC5lbWl0RnVuY3Rpb25Qcm9sb2d1ZSgpOwogCi0gICAg ICAgIGppdC5wdXNoKEdQUkluZm86OmFyZ3VtZW50R1BSMCk7Ci0gICAgICAgIGppdC5wdXNoKEdQ UkluZm86OmFyZ3VtZW50R1BSMSk7Ci0gICAgICAgIGppdC5wdXNoKEdQUkluZm86OmFyZ3VtZW50 R1BSMik7Ci0gICAgICAgIGppdC5wdXNoKEdQUkluZm86OmFyZ3VtZW50R1BSMyk7CisgICAgICAg IGppdC5wdXNoUGFpcihHUFJJbmZvOjphcmd1bWVudEdQUjAsIEdQUkluZm86OmFyZ3VtZW50R1BS MSk7CisgICAgICAgIGppdC5wdXNoUGFpcihHUFJJbmZvOjphcmd1bWVudEdQUjIsIEdQUkluZm86 OmFyZ3VtZW50R1BSMyk7CiAKICAgICAgICAgaml0Lm1vdmUoQ0NhbGxIZWxwZXJzOjpUcnVzdGVk SW1tMzIodGVzdFdvcmQzMigwKSksIEdQUkluZm86OmFyZ3VtZW50R1BSMCk7CiAgICAgICAgIGpp dC5jb252ZXJ0SW50MzJUb0RvdWJsZShHUFJJbmZvOjphcmd1bWVudEdQUjAsIEZQUkluZm86OmZw UmVnVDApOwpAQCAtMjY3LDEwICsyNjUsOCBAQCB2b2lkIHRlc3RQcm9iZVJlYWRzQXJndW1lbnRS ZWdpc3RlcnMoKQogICAgICAgICAgICAgQ0hFQ0tfRVEoY3B1LmZwcihGUFJJbmZvOjpmcFJlZ1Qx KSwgdGVzdFdvcmQzMigxKSk7CiAgICAgICAgIH0pOwogCi0gICAgICAgIGppdC5wb3AoR1BSSW5m bzo6YXJndW1lbnRHUFIzKTsKLSAgICAgICAgaml0LnBvcChHUFJJbmZvOjphcmd1bWVudEdQUjIp OwotICAgICAgICBqaXQucG9wKEdQUkluZm86OmFyZ3VtZW50R1BSMSk7Ci0gICAgICAgIGppdC5w b3AoR1BSSW5mbzo6YXJndW1lbnRHUFIwKTsKKyAgICAgICAgaml0LnBvcFBhaXIoR1BSSW5mbzo6 YXJndW1lbnRHUFIyLCBHUFJJbmZvOjphcmd1bWVudEdQUjMpOworICAgICAgICBqaXQucG9wUGFp cihHUFJJbmZvOjphcmd1bWVudEdQUjAsIEdQUkluZm86OmFyZ3VtZW50R1BSMSk7CiAKICAgICAg ICAgaml0LmVtaXRGdW5jdGlvbkVwaWxvZ3VlKCk7CiAgICAgICAgIGppdC5yZXQoKTsKQEAgLTI4 NywxMCArMjgzLDggQEAgdm9pZCB0ZXN0UHJvYmVXcml0ZXNBcmd1bWVudFJlZ2lzdGVycygpCiAg ICAgY29tcGlsZUFuZFJ1bjx2b2lkPihbJl0gKENDYWxsSGVscGVycyYgaml0KSB7CiAgICAgICAg IGppdC5lbWl0RnVuY3Rpb25Qcm9sb2d1ZSgpOwogCi0gICAgICAgIGppdC5wdXNoKEdQUkluZm86 OmFyZ3VtZW50R1BSMCk7Ci0gICAgICAgIGppdC5wdXNoKEdQUkluZm86OmFyZ3VtZW50R1BSMSk7 Ci0gICAgICAgIGppdC5wdXNoKEdQUkluZm86OmFyZ3VtZW50R1BSMik7Ci0gICAgICAgIGppdC5w dXNoKEdQUkluZm86OmFyZ3VtZW50R1BSMyk7CisgICAgICAgIGppdC5wdXNoUGFpcihHUFJJbmZv Ojphcmd1bWVudEdQUjAsIEdQUkluZm86OmFyZ3VtZW50R1BSMSk7CisgICAgICAgIGppdC5wdXNo UGFpcihHUFJJbmZvOjphcmd1bWVudEdQUjIsIEdQUkluZm86OmFyZ3VtZW50R1BSMyk7CiAKICAg ICAgICAgLy8gUHJlLWluaXRpYWxpemUgd2l0aCBub24tZXhwZWN0ZWQgdmFsdWVzLgogI2lmIFVT RShKU1ZBTFVFNjQpCkBAIC0zMzMsMTAgKzMyNyw4IEBAIHZvaWQgdGVzdFByb2JlV3JpdGVzQXJn dW1lbnRSZWdpc3RlcnMoKQogICAgICAgICAgICAgQ0hFQ0tfRVEoY3B1LmZwcjx1aW50NjRfdD4o RlBSSW5mbzo6ZnBSZWdUMSksIHRlc3RXb3JkNjQoMSkpOwogICAgICAgICB9KTsKIAotICAgICAg ICBqaXQucG9wKEdQUkluZm86OmFyZ3VtZW50R1BSMyk7Ci0gICAgICAgIGppdC5wb3AoR1BSSW5m bzo6YXJndW1lbnRHUFIyKTsKLSAgICAgICAgaml0LnBvcChHUFJJbmZvOjphcmd1bWVudEdQUjEp OwotICAgICAgICBqaXQucG9wKEdQUkluZm86OmFyZ3VtZW50R1BSMCk7CisgICAgICAgIGppdC5w b3BQYWlyKEdQUkluZm86OmFyZ3VtZW50R1BSMiwgR1BSSW5mbzo6YXJndW1lbnRHUFIzKTsKKyAg ICAgICAgaml0LnBvcFBhaXIoR1BSSW5mbzo6YXJndW1lbnRHUFIwLCBHUFJJbmZvOjphcmd1bWVu dEdQUjEpOwogCiAgICAgICAgIGppdC5lbWl0RnVuY3Rpb25FcGlsb2d1ZSgpOwogICAgICAgICBq aXQucmV0KCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9QdHJUYWcuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9QdHJUYWcuaAkocmV2 aXNpb24gMjMwMDE3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHRyVGFnLmgJ KHdvcmtpbmcgY29weSkKQEAgLTcwLDYgKzcwLDggQEAgdWludHB0cl90IG5leHRQdHJUYWdJRCgp OwogI2lmICFVU0UoUE9JTlRFUl9QUk9GSUxJTkcpCiBpbmxpbmUgdWludHB0cl90IG5leHRQdHJU YWdJRCgpIHsgcmV0dXJuIDA7IH0KIAoraW5saW5lIGNvbnN0IGNoYXIqIHRhZ0ZvclB0cihjb25z dCB2b2lkKikgeyByZXR1cm4gIjxubyB0YWc+IjsgfQorCiB0ZW1wbGF0ZTx0eXBlbmFtZS4uLiBB cmd1bWVudHM+CiBpbmxpbmUgY29uc3RleHByIFB0clRhZyBwdHJUYWcoQXJndW1lbnRzJiYuLi4p IHsgcmV0dXJuIE5vUHRyVGFnOyB9CiAKQEAgLTExOSw2ICsxMjEsOSBAQCB0ZW1wbGF0ZTx0eXBl bmFtZSBQdHJUeXBlPiB2b2lkIGFzc2VydElzCiB0ZW1wbGF0ZTx0eXBlbmFtZSBQdHJUeXBlPiB2 b2lkIGFzc2VydElzVGFnZ2VkV2l0aChQdHJUeXBlLCBQdHJUYWcpIHsgfQogdGVtcGxhdGU8dHlw ZW5hbWUgUHRyVHlwZT4gdm9pZCBhc3NlcnRJc051bGxPclRhZ2dlZFdpdGgoUHRyVHlwZSwgUHRy VGFnKSB7IH0KIAorI2RlZmluZSBDQUxMX1dJVEhfUFRSVEFHKGNhbGxJbnN0cnVjdGlvblN0cmlu ZywgdGFyZ2V0UmVnaXN0ZXJTdHJpbmcsIHRhZykgXAorICAgIGNhbGxJbnN0cnVjdGlvblN0cmlu ZyAiICIgdGFyZ2V0UmVnaXN0ZXJTdHJpbmcgIlxuIgorCiAjZW5kaWYgLy8gIVVTRShQT0lOVEVS X1BST0ZJTElORykKIAogfSAvLyBuYW1lc3BhY2UgSlNDCg==