184058 2018-03-27 16:25:04 -0700 REGRESSION (r229831?): LayoutTest storage/indexeddb/dont-wedge-private.html is a flaky failure 2018-05-16 17:33:41 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad beidson aestes alecflett beidson cdumez commit-queue ews-watchlist jsbell webkit-bug-importer oldest_to_newest 1409717 0 ryanhaddad 2018-03-27 16:25:04 -0700 The following layout test is flaky on iOS and macOS storage/indexeddb/dont-wedge-private.html Probable cause: Unknown, this test became flaky within the last 7 days. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fdont-wedge-private.html --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/storage/indexeddb/dont-wedge-private-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/storage/indexeddb/dont-wedge-private-actual.txt @@ -10,7 +10,6 @@ deleteDatabase1(): indexedDB.deleteDatabase(dbname1) -In a multi process implementation this deleteDatabase may be blocked temporarily, so we don't check for either the presence or absence of a blocked event. deleteDatabase2(): indexedDB.deleteDatabase(dbname2) @@ -24,8 +23,9 @@ store1.put(0, 0) openOnSuccess1(): -PASS isAfterReload() is true +FAIL isAfterReload() should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1409721 1 ryanhaddad 2018-03-27 16:33:58 -0700 Based on when this started, this could be more fallout from https://trac.webkit.org/changeset/229831/webkit 1410088 2 webkit-bug-importer 2018-03-28 15:41:13 -0700 <rdar://problem/38975304> 1424474 3 beidson 2018-05-16 13:56:20 -0700 This test is pretty straight forward, as far as IDB tests go. It's somewhat surprising that it has this failure mode. It is interesting that dont-wedge-private has the problem but not dont-wedge This suggests to me it's an aspect of the in-process, in-memory private store. Perhaps this store is synchronous enough to actually allow the open request to finish before the reload takes place. Though that would be some what surprising... I suppose I can try to verify* * - That will be hard because I have been wholly unable to reproduce locally. 1424522 4 beidson 2018-05-16 15:49:53 -0700 (In reply to Brady Eidson from comment #3) > This test is pretty straight forward, as far as IDB tests go. > > It's somewhat surprising that it has this failure mode. > > It is interesting that dont-wedge-private has the problem but not dont-wedge > > This suggests to me it's an aspect of the in-process, in-memory private > store. > > Perhaps this store is synchronous enough to actually allow the open request > to finish before the reload takes place. > > Though that would be some what surprising... I suppose I can try to verify* > > * - That will be hard because I have been wholly unable to reproduce locally. I'm going to land a speculative fix to the test that makes the asynchronous database activity take MANY MANY more spins of the runloop, reliably so. That should give the location change a chance to always take place first. 1424523 5 340534 beidson 2018-05-16 15:55:31 -0700 Created attachment 340534 Patch 1424557 6 340534 commit-queue 2018-05-16 17:33:39 -0700 Comment on attachment 340534 Patch Clearing flags on attachment: 340534 Committed r231880: <https://trac.webkit.org/changeset/231880> 1424558 7 commit-queue 2018-05-16 17:33:41 -0700 All reviewed patches have been landed. Closing bug. 340534 2018-05-16 15:55:31 -0700 2018-05-16 17:33:39 -0700 Patch bug-184058-20180516155530.patch text/plain 4044 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxODE4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjBmZTQyYzM1YjcxYTA3MjcyNTUx OTVjOTIyY2FmZTAxMmYzY2ZhNy4uMDI3ZDg2OTdkNzVkMDc0NGJmZmFmZjY2OTVhNTVmMmU0Nzk2 MzYzNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA1LTE2ICBCcmFkeSBFaWRzb24gIDxi ZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBMYXlvdXRUZXN0IHN0b3JhZ2UvaW5kZXhlZGRi L2RvbnQtd2VkZ2UtcHJpdmF0ZS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzg5NzUzMDQ+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg0MDU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTWFrZSB0aGUgYXN5bmNocm9ub3VzIElEQiBwYXJ0IG9mIHRoaXMgdGVzdCB0YWtl IHdheSwgd2F5IGxvbmdlciB0byBhbHdheXMgZ2l2ZSB0aGUgbG9jYXRpb24gY2hhbmdlIGEgY2hh bmNlIHRvIGhhcHBlbi4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICog c3RvcmFnZS9pbmRleGVkZGIvZG9udC13ZWRnZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogc3Rv cmFnZS9pbmRleGVkZGIvZG9udC13ZWRnZS1wcml2YXRlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAg KiBzdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvZG9udC13ZWRnZS5qczoKKyAgICAgICAgKG9w ZW5EYXRhYmFzZTEucmVxdWVzdC5vbnVwZ3JhZGVuZWVkZWQub3Blbk9uVXBncmFkZU5lZWRlZDEu cHV0dGVyKToKKyAgICAgICAgKG9wZW5EYXRhYmFzZTEucmVxdWVzdC5vbnVwZ3JhZGVuZWVkZWQp OgorCiAyMDE4LTA1LTE1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIE1lZGlhIGNvbnRpbnVlcyBsb2FkaW5nIGFmdGVyIHJlbmRlcmVkIGludmlzaWJsZSAocmVt b3ZlZCBmcm9tIERPTTsgc2Nyb2xsZWQgb2ZmIHNjcmVlbikKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4 IGQ4YWQ3YTE2ODM1MmM5ODM4ZTg1YTNmZWE4ZjkwNzU4OWI1ZDQ5NGYuLmU2NTQ1ZjE1NGYxZmFi YzQwMGM0MzlkNGVjNWRiNTA0ZjczZGRhMWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RF eHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTg5Niw4 ICsxODk2LDYgQEAgd2Via2l0Lm9yZy9iLzExNjYyMSBmYXN0L3JlcGxhY2VkL3ByZWZlcnJlZC13 aWR0aHMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xODQxOTggaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2Jyb3dzZXJzL29mZmxpbmUvYXBwY2FjaGUv d29ya2Vycy9hcHBjYWNoZS13b3JrZXIuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKLXdlYmtpdC5v cmcvYi8xODQwNTggc3RvcmFnZS9pbmRleGVkZGIvZG9udC13ZWRnZS1wcml2YXRlLmh0bWwgWyBQ YXNzIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMTg0MDYxIGh0dHAvdGVzdHMvYXBwY2FjaGUv aW50ZXJydXB0ZWQtdXBkYXRlLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2Iv MTg0NDUzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd29ya2Vycy9uYW1lLXByb3Bl cnR5Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFn ZS9pbmRleGVkZGIvZG9udC13ZWRnZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdG9yYWdl L2luZGV4ZWRkYi9kb250LXdlZGdlLWV4cGVjdGVkLnR4dAppbmRleCBiNTY2NDg4NGQ2MDkwODAx MzAxODkwZTZhMzBmOTVhYzY4ZmRjOWI0Li4yNDk4YWM3ZjAzNTVjYTA1YjkwNTM5YWU1NjVjNDM4 MDc1YzBkOTNiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9kb250 LXdlZGdlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9k b250LXdlZGdlLWV4cGVjdGVkLnR4dApAQCAtMTksOSArMTksNiBAQCBvcGVuRGF0YWJhc2UxKCk6 CiBpbmRleGVkREIub3BlbihkYm5hbWUxLCAxKQogCiBvcGVuT25VcGdyYWRlTmVlZGVkMSgpOgot ZGIxID0gZXZlbnQudGFyZ2V0LnJlc3VsdAotc3RvcmUxID0gZGIxLmNyZWF0ZU9iamVjdFN0b3Jl KCdzdG9yZScpCi1zdG9yZTEucHV0KDAsIDApCiAKIG9wZW5PblN1Y2Nlc3MxKCk6CiBQQVNTIGlz QWZ0ZXJSZWxvYWQoKSBpcyB0cnVlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2lu ZGV4ZWRkYi9kb250LXdlZGdlLXByaXZhdGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3Rv cmFnZS9pbmRleGVkZGIvZG9udC13ZWRnZS1wcml2YXRlLWV4cGVjdGVkLnR4dAppbmRleCBiNTY2 NDg4NGQ2MDkwODAxMzAxODkwZTZhMzBmOTVhYzY4ZmRjOWI0Li4yNDk4YWM3ZjAzNTVjYTA1Yjkw NTM5YWU1NjVjNDM4MDc1YzBkOTNiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2lu ZGV4ZWRkYi9kb250LXdlZGdlLXByaXZhdGUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L3N0b3JhZ2UvaW5kZXhlZGRiL2RvbnQtd2VkZ2UtcHJpdmF0ZS1leHBlY3RlZC50eHQKQEAgLTE5 LDkgKzE5LDYgQEAgb3BlbkRhdGFiYXNlMSgpOgogaW5kZXhlZERCLm9wZW4oZGJuYW1lMSwgMSkK IAogb3Blbk9uVXBncmFkZU5lZWRlZDEoKToKLWRiMSA9IGV2ZW50LnRhcmdldC5yZXN1bHQKLXN0 b3JlMSA9IGRiMS5jcmVhdGVPYmplY3RTdG9yZSgnc3RvcmUnKQotc3RvcmUxLnB1dCgwLCAwKQog CiBvcGVuT25TdWNjZXNzMSgpOgogUEFTUyBpc0FmdGVyUmVsb2FkKCkgaXMgdHJ1ZQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL2RvbnQtd2VkZ2Uu anMgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvZG9udC13ZWRnZS5q cwppbmRleCA2OTBjYTVmM2I1YThlYmNlODg0OTMzOTViODE4ZTZkMmFlZGNkY2UyLi4yZjgxNDFj MzI2NzczYmUzMjMxODMzODE1YmJlMWU4YjgzM2I2MmMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvZG9udC13ZWRnZS5qcworKysgYi9MYXlvdXRU ZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvZG9udC13ZWRnZS5qcwpAQCAtNTQsOSAr NTQsMTYgQEAgZnVuY3Rpb24gb3BlbkRhdGFiYXNlMSgpCiAgICAgcmVxdWVzdC5vbmJsb2NrZWQg PSB1bmV4cGVjdGVkQmxvY2tlZENhbGxiYWNrOwogICAgIHJlcXVlc3Qub251cGdyYWRlbmVlZGVk ID0gZnVuY3Rpb24gb3Blbk9uVXBncmFkZU5lZWRlZDEoZXZ0KSB7CiAgICAgICAgIHByZWFtYmxl KGV2dCk7Ci0gICAgICAgIGV2YWxBbmRMb2coImRiMSA9IGV2ZW50LnRhcmdldC5yZXN1bHQiKTsK LSAgICAgICAgZXZhbEFuZExvZygic3RvcmUxID0gZGIxLmNyZWF0ZU9iamVjdFN0b3JlKCdzdG9y ZScpIik7Ci0gICAgICAgIGV2YWxBbmRMb2coInN0b3JlMS5wdXQoMCwgMCkiKTsKKyAgICAgICAg ZGIxID0gZXZlbnQudGFyZ2V0LnJlc3VsdDsKKwkJc3RvcmUxID0gZGIxLmNyZWF0ZU9iamVjdFN0 b3JlKCdzdG9yZScpOworICAgICAgICB2YXIgY291bnQgPSAwOworICAgICAgICBmdW5jdGlvbiBw dXR0ZXIoKSB7CisJCQkrK2NvdW50OworCQkJaWYgKGNvdW50ID09IDUwKQorCQkJCXJldHVybjsK KyAgICAgICAgICAgIHN0b3JlMS5wdXQoMCwgMCkub25zdWNjZXNzID0gcHV0dGVyOworICAgICAg ICB9CisgICAgICAgIHB1dHRlcigpOwogICAgIH07CiAgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBm dW5jdGlvbiBvcGVuT25TdWNjZXNzMShldnQpIHsKICAgICAgICAgcHJlYW1ibGUoZXZ0KTsK