18405 2008-04-10 08:34:34 -0700 [GTK] Property setters do not call g_object_notify() 2008-06-15 07:42:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 marco.barisione webkit-unassigned christian oldest_to_newest 77158 0 marco.barisione 2008-04-10 08:34:34 -0700 If a property is set using the _set_foobar() method then the notify::foobar method is not emitted. We should add a call to g_object_notify to every setter, if possible emitting the signal only if the new value is different from the old one. 83369 1 21711 christian 2008-06-15 07:13:08 -0700 Created attachment 21711 Add missing g_object_notify in WebKitWebView There are in fact three cases in WebKitWebView where g_object_notify is missing, this patch fixes them. 83371 2 21711 christian 2008-06-15 07:42:19 -0700 Comment on attachment 21711 Add missing g_object_notify in WebKitWebView Committed in revision 34571. 21711 2008-06-15 07:13:08 -0700 2008-06-15 07:42:19 -0700 Add missing g_object_notify in WebKitWebView foo text/plain 1177 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggMmU3OTBjOS4uN2U4ZTNhMCAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTE0NTgsNiArMTQ1OCw3IEBAIHZvaWQg d2Via2l0X3dlYl92aWV3X3NldF9zZXR0aW5ncyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJL aXRXZWJTZXR0aW5ncyogd2ViCiAgICAgcHJpdi0+d2ViU2V0dGluZ3MgPSB3ZWJTZXR0aW5nczsK ICAgICB3ZWJraXRfd2ViX3ZpZXdfdXBkYXRlX3NldHRpbmdzKHdlYlZpZXcpOwogICAgIGdfc2ln bmFsX2Nvbm5lY3Qod2ViU2V0dGluZ3MsICJub3RpZnkiLCBHX0NBTExCQUNLKHdlYmtpdF93ZWJf dmlld19zZXR0aW5nc19ub3RpZnkpLCB3ZWJWaWV3KTsKKyAgICBnX29iamVjdF9ub3RpZnkoR19P QkpFQ1Qod2ViVmlldyksICJzZXR0aW5ncyIpOwogfQogCiBXZWJLaXRXZWJTZXR0aW5ncyogd2Vi a2l0X3dlYl92aWV3X2dldF9zZXR0aW5ncyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQpAQCAtMTk4 Niw2ICsxOTg3LDcgQEAgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfc2V0X2VkaXRhYmxlKFdlYktpdFdl YlZpZXcqIHdlYlZpZXcsIGdib29sZWFuIGZsYWcpCiAgICAgICAgIC8vICAgIG1haW5GcmFtZS0+ c2V0U2VsZWN0aW9uRnJvbU5vbmUoKTsKICAgICB9IGVsc2UKICAgICAgICAgZnJhbWUtPnJlbW92 ZUVkaXRpbmdTdHlsZUZyb21Cb2R5RWxlbWVudCgpOworICAgIGdfb2JqZWN0X25vdGlmeShHX09C SkVDVCh3ZWJWaWV3KSwgImVkaXRhYmxlIik7CiB9CiAKIC8qKgpAQCAtMjA2Niw2ICsyMDY4LDcg QEAgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfc2V0X3RyYW5zcGFyZW50KFdlYktpdFdlYlZpZXcqIHdl YlZpZXcsIGdib29sZWFuIGZsYWcpCiAgICAgRnJhbWUqIGZyYW1lID0gY29yZSh3ZWJWaWV3KS0+ bWFpbkZyYW1lKCk7CiAgICAgZ19yZXR1cm5faWZfZmFpbChmcmFtZSk7CiAgICAgZnJhbWUtPnZp ZXcoKS0+c2V0VHJhbnNwYXJlbnQoZmxhZyk7CisgICAgZ19vYmplY3Rfbm90aWZ5KEdfT0JKRUNU KHdlYlZpZXcpLCAidHJhbnNwYXJlbnQiKTsKIH0KIAogLyoqCg==