184043 2018-03-27 09:34:09 -0700 [Extra zoom mode] Add support for new focused form control overlay behaviors 2018-03-27 13:49:12 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin commit-queue thorton timothy webkit-bug-importer oldest_to_newest 1409563 0 wenson_hsieh 2018-03-27 09:34:09 -0700 <rdar://problem/38758727> 1409568 1 336591 wenson_hsieh 2018-03-27 09:43:04 -0700 Created attachment 336591 Patch 1409658 2 336591 commit-queue 2018-03-27 13:49:11 -0700 Comment on attachment 336591 Patch Clearing flags on attachment: 336591 Committed r230003: <https://trac.webkit.org/changeset/230003> 1409659 3 commit-queue 2018-03-27 13:49:12 -0700 All reviewed patches have been landed. Closing bug. 336591 2018-03-27 09:43:04 -0700 2018-03-27 13:49:11 -0700 Patch bug-184043-20180327094304.patch text/plain 5315 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5OTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk3MDZkMjQwYzE3NzQyZTU1 NzYxNDI1ZTc3OTUyYzYxMTE1YTQ1N2UuLjk5NGRkM2Q2NGFjYzA2NTk4OTQ2ZTE4M2ZmZGU1NjI2 NjM4ZWVhOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzQgQEAKKzIwMTgtMDMtMjcgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW0V4dHJhIHpvb20gbW9k ZV0gQWRkIHN1cHBvcnQgZm9yIG5ldyBmb2N1c2VkIGZvcm0gY29udHJvbCBvdmVybGF5IGJlaGF2 aW9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0 MDQzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zODc1ODcyNz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZWUgYmVsb3cgZm9yIG1vcmUgZGV0YWls cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t OgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF93aWxsU3RhcnRTY3JvbGxpbmdPclpvb21pbmdd KToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfZGlkRW5kU2Nyb2xsaW5nT3Jab29taW5nXSk6 CisKKyAgICAgICAgU3VwcHJlc3MgZm9jdXNlZCBmb3JtIGNvbnRyb2wgbmF2aWdhdGlvbiB3aGls ZSB0aGUgc2Nyb2xsIHZpZXcgaXMgdW5kZXJnb2luZyBhIHNjcm9sbCBvciB6b29tIGFuaW1hdGlv biAoZS5nLiwKKyAgICAgICAgd2hlbiBtb3ZpbmcgZnJvbSBvbmUgZm9jdXNlZCBmb3JtIGNvbnRy b2wgdG8gYW5vdGhlcikuCisKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyB0ZXh0SW5wdXRDb250 cm9sbGVyOmRpZENvbW1pdFRleHQ6d2l0aFN1Z2dlc3Rpb246XSk6CisKKyAgICAgICAgV2hlbiBk aXNtaXNzaW5nIGFuIGlucHV0IHZpZXcgY29udHJvbGxlciwgYWxsb3cgZm9jdXNlZCBmb3JtIGNv bnRyb2wgbmF2aWdhdGlvbiBvbmx5IGFmdGVyIHVwZGF0aW5nIGFzc2lzdGVkCisgICAgICAgIG5v ZGUgaW5mb3JtYXRpb24gdG8gZW5zdXJlIHRoYXQgZm9jdXMgcmVjdHMgYXJlbid0IHN0YWxlIGFz IHRoZSB1c2VyIGJlZ2lucyB0byBuYXZpZ2F0ZSBiZXR3ZWVuIGZvcm1zLgorCisgICAgICAgICgt W1dLQ29udGVudFZpZXcgcmVjdEZvckZvY3VzZWRGb3JtQ29udHJvbENvbnRyb2xsZXI6aW5Db29y ZGluYXRlU3BhY2U6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgbmV4dFJlY3RGb3JGb2N1 c2VkRm9ybUNvbnRyb2xDb250cm9sbGVyOmluQ29vcmRpbmF0ZVNwYWNlOl0pOgorICAgICAgICAo LVtXS0NvbnRlbnRWaWV3IHByZXZpb3VzUmVjdEZvckZvY3VzZWRGb3JtQ29udHJvbENvbnRyb2xs ZXI6aW5Db29yZGluYXRlU3BhY2U6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgc2Nyb2xs Vmlld0ZvckZvY3VzZWRGb3JtQ29udHJvbENvbnRyb2xsZXI6XSk6CisgICAgICAgICgtW1dLQ29u dGVudFZpZXcgaGlnaGxpZ2h0ZWRSZWN0Rm9yRm9jdXNlZEZvcm1Db250cm9sQ29udHJvbGxlcjpp bkNvb3JkaW5hdGVTcGFjZTpdKTogRGVsZXRlZC4KKworICAgICAgICBJbXBsZW1lbnQgc29tZSBu ZXcgZm9jdXNlZCBmb3JtIG92ZXJsYXkgZGVsZWdhdGUgaG9va3MgdG8gdmVuZCB0aGUgc2Nyb2xs IHZpZXcsIGFzIHdlbGwgYXMgdGhlIHJlY3RzIG9mIG5leHQgYW5kCisgICAgICAgIHByZXZpb3Vz IGZvY3VzYWJsZSBmb3JtIGNvbnRyb2xzLgorCiAyMDE4LTAzLTI2ICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtFeHRyYSB6b29tIG1vZGVdIFJlZmFj dG9yIGlucHV0IHZpZXcgY29udHJvbGxlciBwcmVzZW50YXRpb24gYW5kIGRpc21pc3NhbCBoZWxw ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbQppbmRleCA1MDRkNmNlMzRhMzEwMWIxYzg1ZjRlZDUwNjE5ZWVlNTdm MDhiNDhjLi45Njk5OWE3ZTAxNDY4YjMwZTk2ZDUzNGE5NjEzNDJmYjM2YWVlZjI3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0KQEAgLTE5NTMsNiArMTk1MywxMCBAQCAtICh2b2lkKV93aWxsU3RhcnRTY3JvbGxp bmdPclpvb21pbmcKICAgICBbX3dlYlNlbGVjdGlvbkFzc2lzdGFudCB3aWxsU3RhcnRTY3JvbGxp bmdPclpvb21pbmdQYWdlXTsKICAgICBbX3RleHRTZWxlY3Rpb25Bc3Npc3RhbnQgd2lsbFN0YXJ0 U2Nyb2xsaW5nT3ZlcmZsb3ddOwogICAgIF9wYWdlLT5zZXRJc1Njcm9sbGluZ09yWm9vbWluZyh0 cnVlKTsKKworI2lmIEVOQUJMRShFWFRSQV9aT09NX01PREUpCisgICAgW19mb2N1c2VkRm9ybUNv bnRyb2xWaWV3Q29udHJvbGxlciBkaXNlbmdhZ2VGb2N1c2VkRm9ybUNvbnRyb2xOYXZpZ2F0aW9u XTsKKyNlbmRpZgogfQogCiAtICh2b2lkKXNjcm9sbFZpZXdXaWxsU3RhcnRQYW5PclBpbmNoR2Vz dHVyZQpAQCAtMTk2OSw2ICsxOTczLDEwIEBAIC0gKHZvaWQpX2RpZEVuZFNjcm9sbGluZ09yWm9v bWluZwogICAgICAgICBbX3RleHRTZWxlY3Rpb25Bc3Npc3RhbnQgZGlkRW5kU2Nyb2xsaW5nT3Zl cmZsb3ddOwogICAgIH0KICAgICBfcGFnZS0+c2V0SXNTY3JvbGxpbmdPclpvb21pbmcoZmFsc2Up OworCisjaWYgRU5BQkxFKEVYVFJBX1pPT01fTU9ERSkKKyAgICBbX2ZvY3VzZWRGb3JtQ29udHJv bFZpZXdDb250cm9sbGVyIGVuZ2FnZUZvY3VzZWRGb3JtQ29udHJvbE5hdmlnYXRpb25dOworI2Vu ZGlmCiB9CiAKIC0gKEJPT0wpcmVxdWlyZXNBY2Nlc3NvcnlWaWV3CkBAIC00MzAxLDggKzQzMDks MTEgQEAgLSAodm9pZCl0ZXh0SW5wdXRDb250cm9sbGVyOihXS1RleHRGb3JtQ29udHJvbFZpZXdD b250cm9sbGVyICopY29udHJvbGxlciBkaWRDb20KICAgICBbX2ZvY3VzZWRGb3JtQ29udHJvbFZp ZXdDb250cm9sbGVyIHNob3c6Tk9dOwogICAgIFtzZWxmIGRpc21pc3NBbGxJbnB1dFZpZXdDb250 cm9sbGVyc107CiAgICAgW3NlbGYgdXBkYXRlQ3VycmVudEFzc2lzdGVkTm9kZUluZm9ybWF0aW9u Olt3ZWFrU2VsZiA9IFdlYWtPYmpDUHRyPFdLQ29udGVudFZpZXc+KHNlbGYpXSAoYm9vbCBkaWRV cGRhdGUpIHsKLSAgICAgICAgaWYgKGRpZFVwZGF0ZSkKLSAgICAgICAgICAgIFt3ZWFrU2VsZi5n ZXQoKS0+X2ZvY3VzZWRGb3JtQ29udHJvbFZpZXdDb250cm9sbGVyIHJlbG9hZERhdGE6WUVTXTsK KyAgICAgICAgaWYgKGRpZFVwZGF0ZSkgeworICAgICAgICAgICAgYXV0byBmb2N1c2VkRm9ybUNv bnRyb2xsZXIgPSB3ZWFrU2VsZi5nZXQoKS0+X2ZvY3VzZWRGb3JtQ29udHJvbFZpZXdDb250cm9s bGVyOworICAgICAgICAgICAgW2ZvY3VzZWRGb3JtQ29udHJvbGxlciByZWxvYWREYXRhOllFU107 CisgICAgICAgICAgICBbZm9jdXNlZEZvcm1Db250cm9sbGVyIGVuZ2FnZUZvY3VzZWRGb3JtQ29u dHJvbE5hdmlnYXRpb25dOworICAgICAgICB9CiAgICAgfV07CiB9CiAKQEAgLTQzMzAsMTEgKzQz NDEsMzIgQEAgLSAodm9pZClmb2N1c2VkRm9ybUNvbnRyb2xDb250cm9sbGVyRGlkQmVnaW5FZGl0 aW5nOihXS0ZvY3VzZWRGb3JtQ29udHJvbFZpZXdDb24KICAgICB9XTsKIH0KIAotLSAoQ0dSZWN0 KWhpZ2hsaWdodGVkUmVjdEZvckZvY3VzZWRGb3JtQ29udHJvbENvbnRyb2xsZXI6KFdLRm9jdXNl ZEZvcm1Db250cm9sVmlld0NvbnRyb2xsZXIgKiljb250cm9sbGVyIGluQ29vcmRpbmF0ZVNwYWNl OihpZCA8VUlDb29yZGluYXRlU3BhY2U+KWNvb3JkaW5hdGVTcGFjZQorLSAoQ0dSZWN0KXJlY3RG b3JGb2N1c2VkRm9ybUNvbnRyb2xDb250cm9sbGVyOihXS0ZvY3VzZWRGb3JtQ29udHJvbFZpZXdD b250cm9sbGVyICopY29udHJvbGxlciBpbkNvb3JkaW5hdGVTcGFjZTooaWQgPFVJQ29vcmRpbmF0 ZVNwYWNlPiljb29yZGluYXRlU3BhY2UKIHsKICAgICByZXR1cm4gW3NlbGYgY29udmVydFJlY3Q6 X2Fzc2lzdGVkTm9kZUluZm9ybWF0aW9uLmVsZW1lbnRSZWN0IHRvQ29vcmRpbmF0ZVNwYWNlOmNv b3JkaW5hdGVTcGFjZV07CiB9CiAKKy0gKENHUmVjdCluZXh0UmVjdEZvckZvY3VzZWRGb3JtQ29u dHJvbENvbnRyb2xsZXI6KFdLRm9jdXNlZEZvcm1Db250cm9sVmlld0NvbnRyb2xsZXIgKiljb250 cm9sbGVyIGluQ29vcmRpbmF0ZVNwYWNlOihpZCA8VUlDb29yZGluYXRlU3BhY2U+KWNvb3JkaW5h dGVTcGFjZQoreworICAgIGlmICghX2Fzc2lzdGVkTm9kZUluZm9ybWF0aW9uLmhhc05leHROb2Rl KQorICAgICAgICByZXR1cm4gQ0dSZWN0TnVsbDsKKworICAgIHJldHVybiBbc2VsZiBjb252ZXJ0 UmVjdDpfYXNzaXN0ZWROb2RlSW5mb3JtYXRpb24ubmV4dE5vZGVSZWN0IHRvQ29vcmRpbmF0ZVNw YWNlOmNvb3JkaW5hdGVTcGFjZV07Cit9CisKKy0gKENHUmVjdClwcmV2aW91c1JlY3RGb3JGb2N1 c2VkRm9ybUNvbnRyb2xDb250cm9sbGVyOihXS0ZvY3VzZWRGb3JtQ29udHJvbFZpZXdDb250cm9s bGVyICopY29udHJvbGxlciBpbkNvb3JkaW5hdGVTcGFjZTooaWQgPFVJQ29vcmRpbmF0ZVNwYWNl Piljb29yZGluYXRlU3BhY2UKK3sKKyAgICBpZiAoIV9hc3Npc3RlZE5vZGVJbmZvcm1hdGlvbi5o YXNQcmV2aW91c05vZGUpCisgICAgICAgIHJldHVybiBDR1JlY3ROdWxsOworCisgICAgcmV0dXJu IFtzZWxmIGNvbnZlcnRSZWN0Ol9hc3Npc3RlZE5vZGVJbmZvcm1hdGlvbi5wcmV2aW91c05vZGVS ZWN0IHRvQ29vcmRpbmF0ZVNwYWNlOmNvb3JkaW5hdGVTcGFjZV07Cit9CisKKy0gKFVJU2Nyb2xs VmlldyAqKXNjcm9sbFZpZXdGb3JGb2N1c2VkRm9ybUNvbnRyb2xDb250cm9sbGVyOihXS0ZvY3Vz ZWRGb3JtQ29udHJvbFZpZXdDb250cm9sbGVyICopY29udHJvbGxlcgoreworICAgIHJldHVybiBz ZWxmLl9zY3JvbGxlcjsKK30KKwogLSAoTlNTdHJpbmcgKilhY3Rpb25OYW1lRm9yRm9jdXNlZEZv cm1Db250cm9sQ29udHJvbGxlcjooV0tGb2N1c2VkRm9ybUNvbnRyb2xWaWV3Q29udHJvbGxlciAq KWNvbnRyb2xsZXIKIHsKICAgICBpZiAoX2Fzc2lzdGVkTm9kZUluZm9ybWF0aW9uLmZvcm1BY3Rp b24uaXNFbXB0eSgpKQo=