<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>184037</bug_id>
          
          <creation_ts>2018-03-27 06:42:10 -0700</creation_ts>
          <short_desc>[WPE] Floating point exception in WebEventFactory::createWebWheelEvent</short_desc>
          <delta_ts>2018-03-29 08:38:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Bentzen">cadubentzen</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1409522</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Bentzen">cadubentzen</who>
    <bug_when>2018-03-27 06:42:10 -0700</bug_when>
    <thetext>Environment:
- WebKit trunk r229973
- Gnome Wayland
- Arch Linux
- MacBook Pro Retina mid 2015

Steps to reproduce:
- Run dyz and scroll using MacBook&apos;s touchpad (with usb mouse it doesn&apos;t crash)

Backtrace:
Program terminated with signal SIGFPE, Arithmetic exception.
#0  WebKit::WebEventFactory::createWebWheelEvent (event=0x7ffc2a854f40, deviceScaleFactor=1) at ../../Source/WebKit/Shared/wpe/WebEventFactory.cpp:156
156             wheelTicks = WebCore::FloatSize(event-&gt;value / std::abs(event-&gt;value), 0);
[Current thread is 1 (Thread 0x7f854eedee80 (LWP 21448))]
(gdb) bt
#0  WebKit::WebEventFactory::createWebWheelEvent (event=0x7ffc2a854f40, deviceScaleFactor=1) at ../../Source/WebKit/Shared/wpe/WebEventFactory.cpp:156
#1  0x00007f8544aaeb06 in WebKit::NativeWebWheelEvent::NativeWebWheelEvent (this=0x7ffc2a854e60, event=0x7ffc2a854f40, deviceScaleFactor=1)
    at ../../Source/WebKit/Shared/wpe/NativeWebWheelEventWPE.cpp:36
#2  0x00007f8544b7197e in WKWPE::View::&lt;lambda(void*, wpe_input_axis_event*)&gt;::operator()(void *, wpe_input_axis_event *) const (__closure=0x0, data=0x7f852e5dd000, event=0x7ffc2a854f40)
    at ../../Source/WebKit/UIProcess/API/wpe/WPEView.cpp:119
#3  0x00007f8544b719cd in WKWPE::View::&lt;lambda(void*, wpe_input_axis_event*)&gt;::_FUN(void *, wpe_input_axis_event *) () at ../../Source/WebKit/UIProcess/API/wpe/WPEView.cpp:116
#4  0x00007f853a724c0c in wpe_view_backend_dispatch_axis_event () from /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend.so.0
#5  0x00007f852cedae8b in Wayland::{lambda(void*, wl_pointer*, unsigned int, unsigned int, int)#12}::operator()(void*, wl_pointer*, unsigned int, unsigned int, int) const ()
   from /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-default.so
#6  0x00007f852cedaee0 in Wayland::{lambda(void*, wl_pointer*, unsigned int, unsigned int, int)#12}::_FUN(void*, wl_pointer*, unsigned int, unsigned int, int) ()
   from /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-default.so
#7  0x00007f854d35827a in ffi_call_unix64 () from /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Root/lib/libffi.so.5
#8  0x00007f854d3571d6 in ffi_call (cif=&lt;optimized out&gt;, fn=&lt;optimized out&gt;, rvalue=&lt;optimized out&gt;, avalue=&lt;optimized out&gt;)
    at /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Source/libffi-3.0.10/src/x86/ffi64.c:486
#9  0x00007f8530c0cbad in ?? () from /usr/lib/libwayland-client.so.0
#10 0x00007f8530c09679 in ?? () from /usr/lib/libwayland-client.so.0
#11 0x00007f8530c0a9b4 in wl_display_dispatch_queue_pending () from /usr/lib/libwayland-client.so.0
#12 0x00007f852ceda396 in Wayland::EventSource::{lambda(_GSource*, int (*)(void*), void*)#3}::operator()(_GSource*, int (*)(void*), void*) const ()
   from /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-default.so
#13 0x00007f852ceda3ed in Wayland::EventSource::{lambda(_GSource*, int (*)(void*), void*)#3}::_FUN(_GSource*, int (*)(void*), void*) ()
   from /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-default.so
#14 0x00007f854da36b27 in g_main_dispatch (context=0x55d483567f90) at /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Source/glib-2.54.3/glib/gmain.c:3142
#15 g_main_context_dispatch (context=context@entry=0x55d483567f90) at /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Source/glib-2.54.3/glib/gmain.c:3795
#16 0x00007f854da36d60 in g_main_context_iterate (context=0x55d483567f90, block=block@entry=1, dispatch=dispatch@entry=1, self=&lt;optimized out&gt;)
    at /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Source/glib-2.54.3/glib/gmain.c:3868
#17 0x00007f854da37072 in g_main_loop_run (loop=0x55d483569190) at /home/cadubentzen/git/github/webkit/WebKitBuild/DependenciesWPE/Source/glib-2.54.3/glib/gmain.c:4064
#18 0x00007f854ea7e49b in ?? () from /usr/lib/libluajit-5.1.so.2
#19 0x00007f854eab5db7 in ?? () from /usr/lib/libluajit-5.1.so.2
#20 0x00007f854eab64b0 in ?? () from /usr/lib/libluajit-5.1.so.2
#21 0x00007f854ea7c316 in ?? () from /usr/lib/libluajit-5.1.so.2
#22 0x00007f854eac1e7c in ?? () from /usr/lib/libluajit-5.1.so.2
#23 0x00007f854ea7c316 in ?? () from /usr/lib/libluajit-5.1.so.2
#24 0x00007f854eac1e7c in ?? () from /usr/lib/libluajit-5.1.so.2
#25 0x00007f854ea7c316 in ?? () from /usr/lib/libluajit-5.1.so.2
#26 0x00007f854eac1fe0 in lua_pcall () from /usr/lib/libluajit-5.1.so.2
#27 0x000055d482c60b14 in main ()

It turns out event-&gt;value is 0 sometimes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1409532</commentid>
    <comment_count>1</comment_count>
      <attachid>336583</attachid>
    <who name="Carlos Bentzen">cadubentzen</who>
    <bug_when>2018-03-27 07:00:08 -0700</bug_when>
    <thetext>Created attachment 336583
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1409533</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Bentzen">cadubentzen</who>
    <bug_when>2018-03-27 07:02:07 -0700</bug_when>
    <thetext>The patch is only a double-check to prevent crashing but I believe it should be investigated further to prevent sending events with value = 0.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1409750</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-03-27 18:44:16 -0700</bug_when>
    <thetext>Hi!

I don&apos;t know if this is right or not. I&apos;m sure Zan will review it soon; he knows this code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1410128</commentid>
    <comment_count>4</comment_count>
      <attachid>336583</attachid>
    <who name="Carlos Bentzen">cadubentzen</who>
    <bug_when>2018-03-28 17:09:57 -0700</bug_when>
    <thetext>Comment on attachment 336583
Patch

&gt;Subversion Revision: 229973
&gt;diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
&gt;index 6b224d55338fbfcc0f7299a83aa63d06a640291a..b5539ff8f658ba0f5344d4b619ddd953f9f28280 100644
&gt;--- a/Source/WebKit/ChangeLog
&gt;+++ b/Source/WebKit/ChangeLog
&gt;@@ -1,3 +1,13 @@
&gt;+2018-03-27  Carlos Eduardo Ramalho  &lt;cadubentzen@gmail.com&gt;
&gt;+
&gt;+        [WPE] Floating point exception in WebEventFactory::createWebWheelEvent
&gt;+        https://bugs.webkit.org/show_bug.cgi?id=184037
&gt;+
&gt;+        Reviewed by NOBODY (OOPS!).
&gt;+
&gt;+        * Shared/wpe/WebEventFactory.cpp:
&gt;+        (WebKit::WebEventFactory::createWebWheelEvent):
&gt;+
&gt; 2018-03-25  Carlos Garcia Campos  &lt;cgarcia@igalia.com&gt;
&gt; 
&gt;         [GTK][WPE] Add API to convert between DOM and JSCValue
&gt;diff --git a/Source/WebKit/Shared/wpe/WebEventFactory.cpp b/Source/WebKit/Shared/wpe/WebEventFactory.cpp
&gt;index 6bedf6a465552951a4b63a4f0c41a6c25011e6dc..626829f6ac158e3f6dca941c4f1d2f73053a5b00 100644
&gt;--- a/Source/WebKit/Shared/wpe/WebEventFactory.cpp
&gt;+++ b/Source/WebKit/Shared/wpe/WebEventFactory.cpp
&gt;@@ -134,6 +134,9 @@ WebMouseEvent WebEventFactory::createWebMouseEvent(struct wpe_input_pointer_even
&gt; 
&gt; WebWheelEvent WebEventFactory::createWebWheelEvent(struct wpe_input_axis_event* event, float deviceScaleFactor)
&gt; {
&gt;+    if (!event-&gt;value)
&gt;+        return { };
&gt;+
&gt;     // FIXME: We shouldn&apos;t hard-code this.
&gt;     enum Axis {
&gt;         Vertical,</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1410133</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Bentzen">cadubentzen</who>
    <bug_when>2018-03-28 17:14:07 -0700</bug_when>
    <thetext>Opss.. Edited the patch as comment by mistake. I&apos;ll send another just fixing Changelog format. Newcomer being newcomer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1410134</commentid>
    <comment_count>6</comment_count>
      <attachid>336737</attachid>
    <who name="Carlos Bentzen">cadubentzen</who>
    <bug_when>2018-03-28 17:23:26 -0700</bug_when>
    <thetext>Created attachment 336737
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1410236</commentid>
    <comment_count>7</comment_count>
      <attachid>336737</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2018-03-29 04:47:19 -0700</bug_when>
    <thetext>Comment on attachment 336737
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336737&amp;action=review

Let&apos;s just avoid any division by using something like `(event-&gt;value &gt;= 0 ? 1.0 : -1.0) * std::abs(event-&gt;value)`. Or better yet, use std::copysign().

&gt; Source/WebKit/ChangeLog:9
&gt; +        * Shared/wpe/WebEventFactory.cpp:
&gt; +        (WebKit::WebEventFactory::createWebWheelEvent):

Please describe the changes that are done here. See other ChangeLog entries for examples.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1410249</commentid>
    <comment_count>8</comment_count>
      <attachid>336769</attachid>
    <who name="Carlos Bentzen">cadubentzen</who>
    <bug_when>2018-03-29 07:44:30 -0700</bug_when>
    <thetext>Created attachment 336769
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1410273</commentid>
    <comment_count>9</comment_count>
      <attachid>336769</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-03-29 08:38:33 -0700</bug_when>
    <thetext>Comment on attachment 336769
Patch

Clearing flags on attachment: 336769

Committed r230074: &lt;https://trac.webkit.org/changeset/230074&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1410274</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-03-29 08:38:34 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>336583</attachid>
            <date>2018-03-27 07:00:08 -0700</date>
            <delta_ts>2018-03-28 17:23:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-184037-20180327110021.patch</filename>
            <type>text/plain</type>
            <size>1372</size>
            <attacher name="Carlos Bentzen">cadubentzen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5OTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZiMjI0ZDU1MzM4ZmJmY2Mw
ZjcyOTlhODNhYTYzZDA2YTY0MDI5MWEuLmI1NTM5ZmY4ZjY1OGJhMGY1MzQ0ZDRiNjE5ZGRkOTUz
ZjlmMjgyODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDMtMjcgIENhcmxvcyBS
YW1hbGhvICA8Y2FkdWJlbnR6ZW5AZ21haWwuY29tPgorCisgICAgICAgIFtXUEVdIENoZWNrIGZv
ciBldmVudC0+dmFsdWUgPT0gMCBpbiBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYldoZWVsRXZl
bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDAz
NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hh
cmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJFdmVudEZh
Y3Rvcnk6OmNyZWF0ZVdlYldoZWVsRXZlbnQpOgorCiAyMDE4LTAzLTI1ICBDYXJsb3MgR2FyY2lh
IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIEFkZCBB
UEkgdG8gY29udmVydCBiZXR3ZWVuIERPTSBhbmQgSlNDVmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwIGIvU291cmNlL1dlYktpdC9T
aGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9yeS5jcHAKaW5kZXggNmJlZGY2YTQ2NTU1Mjk1MWE0YjYz
YTRmMGM0MWE2YzI1MDExZTZkYy4uNjI2ODI5ZjZhYzE1OGUzZjZkY2E5NDFjNGYxZDJmNzMwNTNh
NWIwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9y
eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9yeS5jcHAK
QEAgLTEzNCw2ICsxMzQsOSBAQCBXZWJNb3VzZUV2ZW50IFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRl
V2ViTW91c2VFdmVudChzdHJ1Y3Qgd3BlX2lucHV0X3BvaW50ZXJfZXZlbgogCiBXZWJXaGVlbEV2
ZW50IFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViV2hlZWxFdmVudChzdHJ1Y3Qgd3BlX2lucHV0
X2F4aXNfZXZlbnQqIGV2ZW50LCBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvcikKIHsKKyAgICBpZiAo
IWV2ZW50LT52YWx1ZSkKKyAgICAgICAgcmV0dXJuIHsgfTsKKwogICAgIC8vIEZJWE1FOiBXZSBz
aG91bGRuJ3QgaGFyZC1jb2RlIHRoaXMuCiAgICAgZW51bSBBeGlzIHsKICAgICAgICAgVmVydGlj
YWwsCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>336737</attachid>
            <date>2018-03-28 17:23:26 -0700</date>
            <delta_ts>2018-03-29 07:44:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-184037-20180328212341.patch</filename>
            <type>text/plain</type>
            <size>1356</size>
            <attacher name="Carlos Bentzen">cadubentzen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRkODNkY2FmOTRjNzliYWRi
N2Y1OWViZWVkOTNjODQxMWExZTkwYWQuLjBkM2Q0YjY2NzUxZTJmZjA1OGY5MTIzMDBjMTY4NGM4
NTY3N2ZhOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDMtMjcgIENhcmxvcyBF
ZHVhcmRvIFJhbWFsaG8gIDxjYWR1YmVudHplbkBnbWFpbC5jb20+CisKKyAgICAgICAgW1dQRV0g
RmxvYXRpbmcgcG9pbnQgZXhjZXB0aW9uIGluIFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViV2hl
ZWxFdmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTg0MDM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBTaGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9yeS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkV2
ZW50RmFjdG9yeTo6Y3JlYXRlV2ViV2hlZWxFdmVudCk6CisKIDIwMTgtMDMtMjggIFphbGFuIEJ1
anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIGl0IHBvc3NpYmxlIHRvIG92
ZXJyaWRlIHRoZSBzY3JlZW4gc2l6ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQv
d3BlL1dlYkV2ZW50RmFjdG9yeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC93cGUvV2ViRXZl
bnRGYWN0b3J5LmNwcAppbmRleCA2YmVkZjZhNDY1NTUyOTUxYTRiNjNhNGYwYzQxYTZjMjUwMTFl
NmRjLi42MjY4MjlmNmFjMTU4ZTNmNmRjYTk0MWM0ZjFkMmY3MzA1M2E1YjAwIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC93cGUvV2ViRXZlbnRGYWN0b3J5LmNwcAorKysgYi9Tb3Vy
Y2UvV2ViS2l0L1NoYXJlZC93cGUvV2ViRXZlbnRGYWN0b3J5LmNwcApAQCAtMTM0LDYgKzEzNCw5
IEBAIFdlYk1vdXNlRXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJNb3VzZUV2ZW50KHN0
cnVjdCB3cGVfaW5wdXRfcG9pbnRlcl9ldmVuCiAKIFdlYldoZWVsRXZlbnQgV2ViRXZlbnRGYWN0
b3J5OjpjcmVhdGVXZWJXaGVlbEV2ZW50KHN0cnVjdCB3cGVfaW5wdXRfYXhpc19ldmVudCogZXZl
bnQsIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yKQogeworICAgIGlmICghZXZlbnQtPnZhbHVlKQor
ICAgICAgICByZXR1cm4geyB9OworCiAgICAgLy8gRklYTUU6IFdlIHNob3VsZG4ndCBoYXJkLWNv
ZGUgdGhpcy4KICAgICBlbnVtIEF4aXMgewogICAgICAgICBWZXJ0aWNhbCwK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>336769</attachid>
            <date>2018-03-29 07:44:30 -0700</date>
            <delta_ts>2018-03-29 08:38:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-184037-20180329114447.patch</filename>
            <type>text/plain</type>
            <size>1975</size>
            <attacher name="Carlos Bentzen">cadubentzen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRkODNkY2FmOTRjNzliYWRi
N2Y1OWViZWVkOTNjODQxMWExZTkwYWQuLmIwZGUwOTBjOGMwYjMxMzQwYTFjZWQ1MGUxOWVkYjNj
ZjBlNTlhYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDMtMjcgIENhcmxvcyBF
ZHVhcmRvIFJhbWFsaG8gIDxjYWR1YmVudHplbkBnbWFpbC5jb20+CisKKyAgICAgICAgW1dQRV0g
RmxvYXRpbmcgcG9pbnQgZXhjZXB0aW9uIGluIFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViV2hl
ZWxFdmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTg0MDM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBTaGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9yeS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkV2
ZW50RmFjdG9yeTo6Y3JlYXRlV2ViV2hlZWxFdmVudCk6IFVzZSBzdGQ6OmNvcHlzaWduKCkgdG8g
YXZvaWQgZGl2aXNpb24gYnkgMC4KKwogMjAxOC0wMy0yOCAgWmFsYW4gQnVqdGFzICA8emFsYW5A
YXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgaXQgcG9zc2libGUgdG8gb3ZlcnJpZGUgdGhlIHNj
cmVlbiBzaXplCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC93cGUvV2ViRXZlbnRG
YWN0b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3Bw
CmluZGV4IDZiZWRmNmE0NjU1NTI5NTFhNGI2M2E0ZjBjNDFhNmMyNTAxMWU2ZGMuLjE5MzU4OTk0
MDU4ODI2ZDI4ZGJmODk5NTA3OTNmNzY5NDIyNjAyMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hh
cmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwCkBAIC0yNyw3ICsyNyw3IEBACiAjaW5jbHVkZSAi
V2ViRXZlbnRGYWN0b3J5LmgiCiAKICNpbmNsdWRlIDxXZWJDb3JlL1Njcm9sbGJhci5oPgotI2lu
Y2x1ZGUgPGNzdGRsaWI+CisjaW5jbHVkZSA8Y21hdGg+CiAjaW5jbHVkZSA8d3BlL2lucHV0Lmg+
CiAjaW5jbHVkZSA8d3RmL2dsaWIvR1VuaXF1ZVB0ci5oPgogCkBAIC0xNDUsMTIgKzE0NSwxMiBA
QCBXZWJXaGVlbEV2ZW50IFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViV2hlZWxFdmVudChzdHJ1
Y3Qgd3BlX2lucHV0X2F4aXNfZXZlbnQqCiAgICAgV2ViQ29yZTo6RmxvYXRTaXplIGRlbHRhOwog
ICAgIHN3aXRjaCAoZXZlbnQtPmF4aXMpIHsKICAgICBjYXNlIFZlcnRpY2FsOgotICAgICAgICB3
aGVlbFRpY2tzID0gV2ViQ29yZTo6RmxvYXRTaXplKDAsIGV2ZW50LT52YWx1ZSAvIHN0ZDo6YWJz
KGV2ZW50LT52YWx1ZSkpOworICAgICAgICB3aGVlbFRpY2tzID0gV2ViQ29yZTo6RmxvYXRTaXpl
KDAsIHN0ZDo6Y29weXNpZ24oMSwgZXZlbnQtPnZhbHVlKSk7CiAgICAgICAgIGRlbHRhID0gd2hl
ZWxUaWNrczsKICAgICAgICAgZGVsdGEuc2NhbGUoV2ViQ29yZTo6U2Nyb2xsYmFyOjpwaXhlbHNQ
ZXJMaW5lU3RlcCgpKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBIb3Jpem9udGFsOgotICAg
ICAgICB3aGVlbFRpY2tzID0gV2ViQ29yZTo6RmxvYXRTaXplKGV2ZW50LT52YWx1ZSAvIHN0ZDo6
YWJzKGV2ZW50LT52YWx1ZSksIDApOworICAgICAgICB3aGVlbFRpY2tzID0gV2ViQ29yZTo6Rmxv
YXRTaXplKHN0ZDo6Y29weXNpZ24oMSwgZXZlbnQtPnZhbHVlKSwgMCk7CiAgICAgICAgIGRlbHRh
ID0gd2hlZWxUaWNrczsKICAgICAgICAgZGVsdGEuc2NhbGUoV2ViQ29yZTo6U2Nyb2xsYmFyOjpw
aXhlbHNQZXJMaW5lU3RlcCgpKTsKICAgICAgICAgYnJlYWs7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>