184030 2018-03-26 20:08:00 -0700 Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit 2018-03-26 21:07:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue mitz webkit-bug-importer wenson_hsieh oldest_to_newest 1409463 0 thorton 2018-03-26 20:08:00 -0700 Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit 1409464 1 webkit-bug-importer 2018-03-26 20:08:25 -0700 <rdar://problem/38895281> 1409465 2 336562 thorton 2018-03-26 20:11:10 -0700 Created attachment 336562 Patch 1409466 3 336562 mitz 2018-03-26 20:12:50 -0700 Comment on attachment 336562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336562&action=review > Source/WebKitLegacy/mac/Configurations/Base.xcconfig:129 > +WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR)); > +WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/; :| 1409468 4 336562 thorton 2018-03-26 20:24:04 -0700 Comment on attachment 336562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336562&action=review >> Source/WebKitLegacy/mac/Configurations/Base.xcconfig:129 >> +WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/; > > :| Every patch needs to touch at least one thing one level below. Thank you! 1409475 5 336562 commit-queue 2018-03-26 21:07:45 -0700 Comment on attachment 336562 Patch Clearing flags on attachment: 336562 Committed r229991: <https://trac.webkit.org/changeset/229991> 1409476 6 commit-queue 2018-03-26 21:07:46 -0700 All reviewed patches have been landed. Closing bug. 336562 2018-03-26 20:11:10 -0700 2018-03-26 21:07:45 -0700 Patch bug-184030-20180326201110.patch text/plain 6569 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRlYzY3YTQ0OWQ2OWU2NGFm ZmY3MzcwOGZkM2VkNjZiNjBhZTE4NjAuLmZlMWJmNzEwNjc5MTI3MWY5OGQ5NzY1MWI2MjFjYmUw ZDFlYzE0MTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDMtMjYgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRvcHQgV0tfQUxURVJO QVRFX0ZSQU1FV09SS1NfRElSIGluIFdlYktpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MDMwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zODg5 NTI4MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IENvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWc6CisgICAgICAgICogQ29uZmlndXJhdGlvbnMv QmFzZVRhcmdldC54Y2NvbmZpZzoKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9XZWJLaXQueGNj b25maWc6CisKIDIwMTgtMDMtMjYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5j b20+CiAKICAgICAgICAgQWRkIGFuZCBhZG9wdCBIQVZFKENPUkVfQU5JTUFUSU9OX1JFTkRFUl9T RVJWRVIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5kZXggOWYyYzVjOWM4NGJjZmQyNzRm MzNmMjBjOWVlMGQ4MzM5NWQ3ZGRjNi4uYTk0OWM5NWYwN2RmMjk0ZDNiZTYxN2U0NDA1NDUxOWFi ZWI4ZmVmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisy MDE4LTAzLTI2ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAg ICAgIEFkb3B0IFdLX0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUiBpbiBXZWJLaXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDAzMAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMzg4OTUyODE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOgorCiAyMDE4 LTAzLTI2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIFNl Y3VyaXR5T3JpZ2luRGF0YSBtb3JlIGNvbnNpc3RlbnRseSBpbiBTZXJ2aWNlIFdvcmtlciBjb2Rl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcg Yi9Tb3VyY2UvV2ViS2l0L0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKaW5kZXggZjAxOWJm YzBiN2Q5ZTUyMGVmNTkxYjUyOGM1OWIyNjY0MTYyMmY2MS4uNTlhYzFkNWRlYWNjNzJiNjRjNTQy ZmUwNTM2NzE2NDU5YzE1NTBkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9Db25maWd1cmF0 aW9ucy9CYXNlLnhjY29uZmlnCisrKyBiL1NvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvQmFz ZS54Y2NvbmZpZwpAQCAtMTM3LDYgKzEzNyw5IEBAIFdLX05PVF9ZRVMgPSBOTzsKIAogV0tfVVNF X0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUiA9ICQoV0tfTk9UXyQoV0tfRU1QVFlfJChXS19BTFRF Uk5BVEVfRlJBTUVXT1JLU19ESVIpKSk7CiAKK1dLX0FMVEVSTkFURV9XRUJLSVRfU0RLX1BBVEgg PSAkKFdLX0FMVEVSTkFURV9XRUJLSVRfU0RLX1BBVEhfJChXS19VU0VfQUxURVJOQVRFX0ZSQU1F V09SS1NfRElSKSk7CitXS19BTFRFUk5BVEVfV0VCS0lUX1NES19QQVRIX1lFUyA9ICQoV0tfQUxU RVJOQVRFX0ZSQU1FV09SS1NfRElSKS87CisKIFdLX1BMQVRGT1JNX05BTUUgPSAkKFdLX1BMQVRG T1JNX05BTUVfVVNFX0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUl8kKFdLX1VTRV9BTFRFUk5BVEVf RlJBTUVXT1JLU19ESVIpKTsKIFdLX1BMQVRGT1JNX05BTUVfVVNFX0FMVEVSTkFURV9GUkFNRVdP UktTX0RJUl9ZRVMgPSBpcGhvbmVtaW5pbWFsc2ltdWxhdG9yOwogV0tfUExBVEZPUk1fTkFNRV9V U0VfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSX05PID0gJChQTEFURk9STV9OQU1FKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvQmFzZVRhcmdldC54Y2NvbmZpZyBi L1NvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvQmFzZVRhcmdldC54Y2NvbmZpZwppbmRleCAy M2NhOGZiODFiMzYyOTM5OTg3MzkzZjE0MzViNmI1MTgyMDMyMGFhLi4wMTE1M2I5MmJjMDVhYWYy MmQ3MzZiZDMzNTg1ZDFmZjc0MDE0YjdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NvbmZp Z3VyYXRpb25zL0Jhc2VUYXJnZXQueGNjb25maWcKKysrIGIvU291cmNlL1dlYktpdC9Db25maWd1 cmF0aW9ucy9CYXNlVGFyZ2V0LnhjY29uZmlnCkBAIC00MCw3ICs0MCw3IEBAIEdDQ19QUkVQUk9D RVNTT1JfREVGSU5JVElPTlMgPSAkKERFQlVHX0RFRklORVMpICQoRkVBVFVSRV9ERUZJTkVTKSAk KFdLX01BTlVBTF9TCiBXRUJLSVRBRERJVElPTlNfSEVBREVSX1NFQVJDSF9QQVRIUyA9ICQoQlVJ TFRfUFJPRFVDVFNfRElSKS91c3IvbG9jYWwvaW5jbHVkZS9XZWJLaXRBZGRpdGlvbnMgJChTREtS T09UKS91c3IvbG9jYWwvaW5jbHVkZS9XZWJLaXRBZGRpdGlvbnM7CiBMSUJXRUJSVENfSEVBREVS X1NFQVJDSF9QQVRIUyA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS91c3IvbG9jYWwvaW5jbHVkZS93 ZWJydGMgJChTREtST09UKS91c3IvbG9jYWwvaW5jbHVkZS93ZWJydGM7CiAKLUhFQURFUl9TRUFS Q0hfUEFUSFMgPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvdXNyL2xvY2FsL2luY2x1ZGUgIiQoV0VC Q09SRV9QUklWQVRFX0hFQURFUlNfRElSKS9Gb3J3YXJkaW5nSGVhZGVycyIgJChCVUlMVF9QUk9E VUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdDIgJChXRUJLSVRBRERJVElPTlNfSEVBREVS X1NFQVJDSF9QQVRIUykgJChMSUJXRUJSVENfSEVBREVSX1NFQVJDSF9QQVRIUykgJChIRUFERVJf U0VBUkNIX1BBVEhTKTsKK0hFQURFUl9TRUFSQ0hfUEFUSFMgPSAkKEJVSUxUX1BST0RVQ1RTX0RJ UikkKFdLX0FMVEVSTkFURV9XRUJLSVRfU0RLX1BBVEgpL3Vzci9sb2NhbC9pbmNsdWRlICIkKFdF QkNPUkVfUFJJVkFURV9IRUFERVJTX0RJUikvRm9yd2FyZGluZ0hlYWRlcnMiICQoQlVJTFRfUFJP RFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJLaXQyICQoV0VCS0lUQURESVRJT05TX0hFQURF Ul9TRUFSQ0hfUEFUSFMpICQoTElCV0VCUlRDX0hFQURFUl9TRUFSQ0hfUEFUSFMpICQoSEVBREVS X1NFQVJDSF9QQVRIUyk7CiAKIE9USEVSX0NGTEFHUyA9ICQoaW5oZXJpdGVkKSAtaWZyYW1ld29y ayAkKFNES1JPT1QpJChTWVNURU1fTElCUkFSWV9ESVIpL0ZyYW1ld29ya3MvQXBwbGljYXRpb25T ZXJ2aWNlcy5mcmFtZXdvcmsvRnJhbWV3b3JrcyAtaWZyYW1ld29yayAkKFNES1JPT1QpJChTWVNU RU1fTElCUkFSWV9ESVIpL0ZyYW1ld29ya3MvQ2FyYm9uLmZyYW1ld29yay9GcmFtZXdvcmtzIC1p ZnJhbWV3b3JrICQoU0RLUk9PVCkkKFNZU1RFTV9MSUJSQVJZX0RJUikvRnJhbWV3b3Jrcy9RdWFy dHouZnJhbWV3b3JrL0ZyYW1ld29ya3MgLWlmcmFtZXdvcmsgJChTREtST09UKSQoU1lTVEVNX0xJ QlJBUllfRElSKS9GcmFtZXdvcmtzL0NvcmVTZXJ2aWNlcy5mcmFtZXdvcmsvRnJhbWV3b3JrcyAt aWZyYW1ld29yayAkKFNES1JPT1QpJChTWVNURU1fTElCUkFSWV9ESVIpL1ByaXZhdGVGcmFtZXdv cmtzOwogT1RIRVJfQ1BMVVNQTFVTRkxBR1MgPSAkKE9USEVSX0NGTEFHUykgLWlzeXN0ZW0gJChT REtST09UKS9TeXN0ZW0vTGlicmFyeS9GcmFtZXdvcmtzL1N5c3RlbS5mcmFtZXdvcmsvUHJpdmF0 ZUhlYWRlcnM7CkBAIC0xMDAsNyArMTAwLDEwIEBAIFdLX05PVF9ZRVMgPSBOTzsKIFdLX1VTRV9P VkVSUklERV9GUkFNRVdPUktTX0RJUiA9ICQoV0tfTk9UXyQoV0tfRU1QVFlfJChXS19PVkVSUklE RV9GUkFNRVdPUktTX0RJUikpKTsKIAogV0tfT1ZFUlJJREVfRlJBTUVXT1JLU19ESVIgPSAkKFdL X09WRVJSSURFX0ZSQU1FV09SS1NfRElSX1VTRV9TVEFHSU5HX0lOU1RBTExfUEFUSF8kKFVTRV9T VEFHSU5HX0lOU1RBTExfUEFUSCkpOworV0tfT1ZFUlJJREVfRlJBTUVXT1JLU19ESVJfVVNFX1NU QUdJTkdfSU5TVEFMTF9QQVRIXyA9ICQoV0tfT1ZFUlJJREVfRlJBTUVXT1JLU19ESVJfVVNFX1NU QUdJTkdfSU5TVEFMTF9QQVRIX05PKTsKK1dLX09WRVJSSURFX0ZSQU1FV09SS1NfRElSX1VTRV9T VEFHSU5HX0lOU1RBTExfUEFUSF9OTyA9ICQoV0tfT1ZFUlJJREVfRlJBTUVXT1JLU19ESVJfVVNF X0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUl8kKFdLX1VTRV9BTFRFUk5BVEVfRlJBTUVXT1JLU19E SVIpKTsKIFdLX09WRVJSSURFX0ZSQU1FV09SS1NfRElSX1VTRV9TVEFHSU5HX0lOU1RBTExfUEFU SF9ZRVMgPSAkKFNZU1RFTV9MSUJSQVJZX0RJUikvU3RhZ2VkRnJhbWV3b3Jrcy9TYWZhcmk7CitX S19PVkVSUklERV9GUkFNRVdPUktTX0RJUl9VU0VfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSX1lF UyA9ICQoV0tfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSKS9TeXN0ZW0vTGlicmFyeS9GcmFtZXdv cmtzOwogCiBXS19IQVZFX0NPUkVfUFJFRElDVElPTiA9IFlFUzsKIFdLX0hBVkVfQ09SRV9QUkVE SUNUSU9OW3Nkaz1tYWNvc3gqXVthcmNoPWkzODZdID0gTk87CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L0NvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZyBiL1NvdXJjZS9XZWJLaXQvQ29u ZmlndXJhdGlvbnMvV2ViS2l0LnhjY29uZmlnCmluZGV4IDRhMDA2ZGJkNmIxZDU4NzM3MGIyZWUx YzFkZDZkZDFiMzIzZmFlMTIuLmRhZGMzM2EyNzUzNTRkYWFhMjAzMDhhMTVjYjU0OGUzOTk0MmEx ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvV2ViS2l0LnhjY29u ZmlnCisrKyBiL1NvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvV2ViS2l0LnhjY29uZmlnCkBA IC0zMyw3ICszMyw5IEBAIE1PRFVMRU1BUF9GSUxFX2NvY29hdG91Y2ggPSBNb2R1bGVzL2lPUy5t b2R1bGVtYXA7CiBNT0RVTEVNQVBfRklMRV8gPSBNb2R1bGVzL09TWC5tb2R1bGVtYXA7CiAKIElO U1RBTExfUEFUSCA9ICQoV0VCS0lUX0ZSQU1FV09SS1NfRElSKTsKLURZTElCX0lOU1RBTExfTkFN RV9CQVNFID0gJChOT1JNQUxfV0VCS0lUX0ZSQU1FV09SS1NfRElSKTsKK0RZTElCX0lOU1RBTExf TkFNRV9CQVNFID0gJChEWUxJQl9JTlNUQUxMX05BTUVfQkFTRV8kKFdLX1VTRV9BTFRFUk5BVEVf RlJBTUVXT1JLU19ESVIpKTsKK0RZTElCX0lOU1RBTExfTkFNRV9CQVNFX05PID0gJChOT1JNQUxf V0VCS0lUX0ZSQU1FV09SS1NfRElSKTsKK0RZTElCX0lOU1RBTExfTkFNRV9CQVNFX1lFUyA9ICQo RFlMSUJfSU5TVEFMTF9OQU1FX0JBU0UpOwogCiBMSUJSQVJZX1NFQVJDSF9QQVRIUyA9ICQoaW5o ZXJpdGVkKSAiJChMSUJXRUJSVENfTElCUkFSWV9ESVIpIjsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdExlZ2FjeS9tYWMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZyBiL1NvdXJjZS9X ZWJLaXRMZWdhY3kvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKaW5kZXggMmViMmVm ZDc1YjliMTY0NDEyMGMzYjhhMzhiNDQ0YjZkYWU1NjlkZC4uMzEyNDk5ZDNlNjViMmI3ZmVmNjFm YTc0NzNjMjg5ZjU3ZGFhOWMzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMv Q29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZworKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21h Yy9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCkBAIC0xMjUsNiArMTI1LDkgQEAgV0tfTk9U X1lFUyA9IE5POwogCiBXS19VU0VfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSID0gJChXS19OT1Rf JChXS19FTVBUWV8kKFdLX0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUikpKTsKIAorV0tfQUxURVJO QVRFX1dFQktJVF9TREtfUEFUSCA9ICQoV0tfQUxURVJOQVRFX1dFQktJVF9TREtfUEFUSF8kKFdL X1VTRV9BTFRFUk5BVEVfRlJBTUVXT1JLU19ESVIpKTsKK1dLX0FMVEVSTkFURV9XRUJLSVRfU0RL X1BBVEhfWUVTID0gJChXS19BTFRFUk5BVEVfRlJBTUVXT1JLU19ESVIpLzsKKwogV0tfUExBVEZP Uk1fTkFNRSA9ICQoV0tfUExBVEZPUk1fTkFNRV9VU0VfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElS XyQoV0tfVVNFX0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUikpOwogV0tfUExBVEZPUk1fTkFNRV9V U0VfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSX1lFUyA9IGlwaG9uZW1pbmltYWxzaW11bGF0b3I7 CiBXS19QTEFURk9STV9OQU1FX1VTRV9BTFRFUk5BVEVfRlJBTUVXT1JLU19ESVJfTk8gPSAkKFBM QVRGT1JNX05BTUUpOwo=