184022 2018-03-26 14:05:48 -0700 webrtc/video-update-often.html is flakily crashing on iOS simulator Debug in PlaybackSessionManager::removeClientForContext 2018-04-04 19:41:19 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson ews-watchlist jeremyj-wk jer.noble jlewis3 ryanhaddad webkit-bug-importer youennf oldest_to_newest 1409403 0 youennf 2018-03-26 14:05:48 -0700 Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 JavaScriptCore 0x00000001142f6334 WTFCrash + 36 1 com.apple.WebKit 0x000000010c70b048 WebKit::PlaybackSessionManager::removeClientForContext(unsigned long long) + 88 2 com.apple.WebKit 0x000000010c70b29c WebKit::PlaybackSessionManager::setUpPlaybackControlsManager(WebCore::HTMLMediaElement&) + 316 3 com.apple.WebKit 0x000000010c9e7649 WebKit::WebChromeClient::setUpPlaybackControlsManager(WebCore::HTMLMediaElement&) + 41 4 com.apple.WebCore 0x0000000119da9953 WebCore::HTMLMediaElement::updatePlaybackControlsManager() + 115 5 com.apple.WebCore 0x0000000119da8ab3 WebCore::HTMLMediaElement::~HTMLMediaElement() + 1699 6 com.apple.WebCore 0x0000000119e6b876 WebCore::HTMLVideoElement::~HTMLVideoElement() + 534 7 com.apple.WebCore 0x0000000119e69035 WebCore::HTMLVideoElement::~HTMLVideoElement() + 21 8 com.apple.WebCore 0x0000000119e69059 WebCore::HTMLVideoElement::~HTMLVideoElement() + 25 9 com.apple.WebCore 0x0000000119aee0bb WebCore::Node::removedLastRef() + 91 10 com.apple.WebKit 0x000000010c46ba73 WebCore::Node::deref() + 371 11 com.apple.WebKit 0x000000010c71b621 void WTF::derefIfNotNull<WebCore::HTMLMediaElement>(WebCore::HTMLMediaElement*) + 49 12 com.apple.WebKit 0x000000010c71b5e9 WTF::RefPtr<WebCore::HTMLMediaElement, WTF::DumbPtrTraits<WebCore::HTMLMediaElement> >::~RefPtr() + 41 13 com.apple.WebKit 0x000000010c70aee5 WTF::RefPtr<WebCore::HTMLMediaElement, WTF::DumbPtrTraits<WebCore::HTMLMediaElement> >::~RefPtr() + 21 14 com.apple.WebKit 0x000000010c70ac94 WebKit::PlaybackSessionManager::removeContext(unsigned long long) + 1108 15 com.apple.WebKit 0x000000010c70b07b WebKit::PlaybackSessionManager::removeClientForContext(unsigned long long) + 139 16 com.apple.WebKit 0x000000010c70b344 WebKit::PlaybackSessionManager::setUpPlaybackControlsManager(WebCore::HTMLMediaElement&) + 484 17 com.apple.WebKit 0x000000010c9e7649 WebKit::WebChromeClient::setUpPlaybackControlsManager(WebCore::HTMLMediaElement&) + 41 18 com.apple.WebCore 0x0000000119da9953 WebCore::HTMLMediaElement::updatePlaybackControlsManager() + 115 19 com.apple.WebCore 0x0000000119de96d7 WTF::Function<void ()>::CallableWrapper<std::__1::__bind<void (WebCore::HTMLMediaElement::*)(), WebCore::HTMLMediaElement*> >::call() + 247 20 com.apple.WebCore 0x0000000117cda5eb WTF::Function<void ()>::operator()() const + 139 21 com.apple.WebCore 0x0000000117ea96f9 WebCore::GenericTaskQueue<WebCore::Timer>::enqueueTask(WTF::Function<void ()>&&)::'lambda'()::operator()() const + 137 22 com.apple.WebCore 0x0000000117ea94d9 WTF::Function<void ()>::CallableWrapper<WebCore::GenericTaskQueue<WebCore::Timer>::enqueueTask(WTF::Function<void ()>&&)::'lambda'()>::call() + 25 23 com.apple.WebCore 0x0000000117cda5eb WTF::Function<void ()>::operator()() const + 139 24 com.apple.WebCore 0x000000011a4a8b17 WebCore::TaskDispatcher<WebCore::Timer>::dispatchOneTask() + 119 25 com.apple.WebCore 0x000000011a4a88cf WebCore::TaskDispatcher<WebCore::Timer>::sharedTimerFired() + 255 26 com.apple.WebCore 0x000000011a4ac621 WebCore::TaskDispatcher<WebCore::Timer>::sharedTimer()::$_1::operator()() const + 17 27 com.apple.WebCore 0x000000011a4ac5e9 WTF::Function<void ()>::CallableWrapper<WebCore::TaskDispatcher<WebCore::Timer>::sharedTimer()::$_1>::call() + 25 28 com.apple.WebCore 0x0000000117cda5eb WTF::Function<void ()>::operator()() const + 139 29 com.apple.WebCore 0x0000000117d5d689 WebCore::Timer::fired() + 25 30 com.apple.WebCore 0x000000011a4df5c4 WebCore::ThreadTimers::sharedTimerFiredInternal() + 452 31 com.apple.WebCore 0x000000011a4f5911 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const + 33 32 com.apple.WebCore 0x000000011a4f58c9 WTF::Function<void ()>::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0>::call() + 25 33 com.apple.WebCore 0x0000000117cda5eb WTF::Function<void ()>::operator()() const + 139 34 com.apple.WebCore 0x000000011a4b7b55 WebCore::MainThreadSharedTimer::fired() + 101 35 com.apple.WebCore 0x000000011a5545a9 WebCore::timerFired(__CFRunLoopTimer*, void*) + 41 1409404 1 336541 youennf 2018-03-26 14:07:00 -0700 Created attachment 336541 WIP 1409407 2 ews-watchlist 2018-03-26 14:08:44 -0700 Attachment 336541 did not pass style-queue: ERROR: Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm:264: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1411793 3 337191 youennf 2018-04-04 10:50:48 -0700 Created attachment 337191 Patch 1411794 4 ews-watchlist 2018-04-04 10:52:13 -0700 Attachment 337191 did not pass style-queue: ERROR: Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm:264: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1411981 5 337191 commit-queue 2018-04-04 19:05:07 -0700 Comment on attachment 337191 Patch Rejecting attachment 337191 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 337191, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing rebase: :040000 040000 0eb32cc993e8b85218d7fb643ac6f302495ed911 74eca5052fc797f88153da7bc22c7d2b38fff0f7 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/7211098 1411990 6 337191 commit-queue 2018-04-04 19:40:54 -0700 Comment on attachment 337191 Patch Clearing flags on attachment: 337191 Committed r230292: <https://trac.webkit.org/changeset/230292> 1411991 7 commit-queue 2018-04-04 19:40:55 -0700 All reviewed patches have been landed. Closing bug. 1411992 8 webkit-bug-importer 2018-04-04 19:41:19 -0700 <rdar://problem/39197603> 336541 2018-03-26 14:07:00 -0700 2018-04-04 10:50:47 -0700 WIP bug-184022-20180326140659.patch text/plain 2304 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ2YjlkODg3ZWQ2MGJhNWNm ZjBkN2ZlOTE4ZjgzZmY3MWM4NTFmNjQuLjNlYzQ0OWU0YTgzODU4MDAyZWQ5MmU3MWRhNmUxYWMw ZThkNDM0ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDMtMjYgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIHdlYnJ0Yy92aWRlby11cGRhdGUt b2Z0ZW4uaHRtbCBpcyBmbGFraWx5IGNyYXNoaW5nIG9uIGlPUyBzaW11bGF0b3IgRGVidWcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDAyMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGZpeC0xODQwMjIK KworICAgICAgICAqIFdlYlByb2Nlc3MvY29jb2EvUGxheWJhY2tTZXNzaW9uTWFuYWdlci5tbToK KyAgICAgICAgKFdlYktpdDo6UGxheWJhY2tTZXNzaW9uTWFuYWdlcjo6c2V0VXBQbGF5YmFja0Nv bnRyb2xzTWFuYWdlcik6CisKIDIwMTgtMDMtMjMgIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJk bmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCB1c2UgdGhlIHByZXNlbmNlIG9mIGEgdGV4 dFNlbGVjdGlvbkFzc2lzdGFudCBhcyBhIHByb3h5IGZvciBpZiB3ZSBhcmUgaW4gY29udGVudCBl ZGl0YWJsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9QbGF5 YmFja1Nlc3Npb25NYW5hZ2VyLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1Bs YXliYWNrU2Vzc2lvbk1hbmFnZXIubW0KaW5kZXggMDU2M2Y5YTBlM2QwYjBhZmMyNWExYzU4ZWZm MmFjYWU4NDRkZjVmZS4uYWNmNTJmNjAwZGU2YzMxNTU4MTYzNjNjN2Q3MDQwZjhlNjYyMWQzMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1BsYXliYWNrU2Vzc2lv bk1hbmFnZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1BsYXliYWNr U2Vzc2lvbk1hbmFnZXIubW0KQEAgLTI1NiwxNSArMjU2LDE4IEBAIHZvaWQgUGxheWJhY2tTZXNz aW9uTWFuYWdlcjo6c2V0VXBQbGF5YmFja0NvbnRyb2xzTWFuYWdlcihXZWJDb3JlOjpIVE1MTWVk aWFFbGVtCiAgICAgICAgIGlmIChtX2NvbnRyb2xzTWFuYWdlckNvbnRleHRJZCA9PSBjb250ZXh0 SWQpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYgKG1fY29udHJvbHNNYW5hZ2Vy Q29udGV4dElkKQotICAgICAgICAgICAgcmVtb3ZlQ2xpZW50Rm9yQ29udGV4dChtX2NvbnRyb2xz TWFuYWdlckNvbnRleHRJZCk7CisgICAgICAgIGF1dG8gcHJldmlvdXNDb250ZXh0SWQgPSBtX2Nv bnRyb2xzTWFuYWdlckNvbnRleHRJZDsKICAgICAgICAgbV9jb250cm9sc01hbmFnZXJDb250ZXh0 SWQgPSBjb250ZXh0SWQ7CisgICAgICAgIGlmIChwcmV2aW91c0NvbnRleHRJZCkKKyAgICAgICAg ICAgIHJlbW92ZUNsaWVudEZvckNvbnRleHQocHJldmlvdXNDb250ZXh0SWQpOwogICAgIH0gZWxz ZSB7Ci0gICAgICAgIGF1dG8gYWRkUmVzdWx0ID0gbV9tZWRpYUVsZW1lbnRzLmVuc3VyZSgmbWVk aWFFbGVtZW50LCBbJl0geyByZXR1cm4gbmV4dENvbnRleHRJZCgpOyB9KTsKLSAgICAgICAgYXV0 byBjb250ZXh0SWQgPSBhZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVlOwotICAgICAgICBpZiAobV9j b250cm9sc01hbmFnZXJDb250ZXh0SWQpCi0gICAgICAgICAgICByZW1vdmVDbGllbnRGb3JDb250 ZXh0KG1fY29udHJvbHNNYW5hZ2VyQ29udGV4dElkKTsKKyAgICAgICAgYXV0byBjb250ZXh0SWQg PSBtX21lZGlhRWxlbWVudHMuZW5zdXJlKCZtZWRpYUVsZW1lbnQsIFsmXSB7IHJldHVybiBuZXh0 Q29udGV4dElkKCk7IH0pLml0ZXJhdG9yLT52YWx1ZTsKKworICAgICAgICBhdXRvIHByZXZpb3Vz Q29udGV4dElkID0gbV9jb250cm9sc01hbmFnZXJDb250ZXh0SWQ7CiAgICAgICAgIG1fY29udHJv bHNNYW5hZ2VyQ29udGV4dElkID0gY29udGV4dElkOworICAgICAgICBpZiAocHJldmlvdXNDb250 ZXh0SWQpCisgICAgICAgICAgICByZW1vdmVDbGllbnRGb3JDb250ZXh0KHByZXZpb3VzQ29udGV4 dElkKTsKKwogICAgICAgICBlbnN1cmVNb2RlbChjb250ZXh0SWQpLnNldE1lZGlhRWxlbWVudCgm bWVkaWFFbGVtZW50KTsKICAgICB9CiAK 337191 2018-04-04 10:50:48 -0700 2018-04-04 19:40:54 -0700 Patch bug-184022-20180404105047.patch text/plain 2422 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFhMTc5ODMzZjkwYjM5Yjg5 ZDI2YTc0ODY1YTQ4NGE5ZTA0ZmNlZDkuLjRiODQxZjYwMDA0NDM2NjUxNThhMzFjZjZhMzBiNWQz MTJkZmRlYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDQtMDQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIHdlYnJ0Yy92aWRlby11cGRhdGUt b2Z0ZW4uaHRtbCBpcyBmbGFraWx5IGNyYXNoaW5nIG9uIGlPUyBzaW11bGF0b3IgRGVidWcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDAyMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBjbGll bnQgY29udGV4dCBvbmNlIHRoZSBuZXcgY29udGV4dCBpZGVudGlmaWVyIGlzIHNldC4KKyAgICAg ICAgQ292ZXJlZCBieSB0ZXN0IG5vIGxvbmdlciBjcmFzaGluZyBsb2NhbGx5LgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9jb2NvYS9QbGF5YmFja1Nlc3Npb25NYW5hZ2VyLm1tOgorICAgICAgICAo V2ViS2l0OjpQbGF5YmFja1Nlc3Npb25NYW5hZ2VyOjpzZXRVcFBsYXliYWNrQ29udHJvbHNNYW5h Z2VyKToKKwogMjAxOC0wNC0wNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTiAocjIzMDIyMyk6IExheW91dFRlc3QgaHR0cC90ZXN0cy9jb250 ZW50ZXh0ZW5zaW9ucy9jc3MtZGlzcGxheS1ub25lLW92ZXJmbG93cy1ydWxlLWRhdGEtMS5odG1s IGlzIGNyYXNoaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2Ev UGxheWJhY2tTZXNzaW9uTWFuYWdlci5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2Nv YS9QbGF5YmFja1Nlc3Npb25NYW5hZ2VyLm1tCmluZGV4IDA1NjNmOWEwZTNkMGIwYWZjMjVhMWM1 OGVmZjJhY2FlODQ0ZGY1ZmUuLmFjZjUyZjYwMGRlNmMzMTU1ODE2MzYzYzdkNzA0MGY4ZTY2MjFk MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9QbGF5YmFja1Nl c3Npb25NYW5hZ2VyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9QbGF5 YmFja1Nlc3Npb25NYW5hZ2VyLm1tCkBAIC0yNTYsMTUgKzI1NiwxOCBAQCB2b2lkIFBsYXliYWNr U2Vzc2lvbk1hbmFnZXI6OnNldFVwUGxheWJhY2tDb250cm9sc01hbmFnZXIoV2ViQ29yZTo6SFRN TE1lZGlhRWxlbQogICAgICAgICBpZiAobV9jb250cm9sc01hbmFnZXJDb250ZXh0SWQgPT0gY29u dGV4dElkKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGlmIChtX2NvbnRyb2xzTWFu YWdlckNvbnRleHRJZCkKLSAgICAgICAgICAgIHJlbW92ZUNsaWVudEZvckNvbnRleHQobV9jb250 cm9sc01hbmFnZXJDb250ZXh0SWQpOworICAgICAgICBhdXRvIHByZXZpb3VzQ29udGV4dElkID0g bV9jb250cm9sc01hbmFnZXJDb250ZXh0SWQ7CiAgICAgICAgIG1fY29udHJvbHNNYW5hZ2VyQ29u dGV4dElkID0gY29udGV4dElkOworICAgICAgICBpZiAocHJldmlvdXNDb250ZXh0SWQpCisgICAg ICAgICAgICByZW1vdmVDbGllbnRGb3JDb250ZXh0KHByZXZpb3VzQ29udGV4dElkKTsKICAgICB9 IGVsc2UgewotICAgICAgICBhdXRvIGFkZFJlc3VsdCA9IG1fbWVkaWFFbGVtZW50cy5lbnN1cmUo Jm1lZGlhRWxlbWVudCwgWyZdIHsgcmV0dXJuIG5leHRDb250ZXh0SWQoKTsgfSk7Ci0gICAgICAg IGF1dG8gY29udGV4dElkID0gYWRkUmVzdWx0Lml0ZXJhdG9yLT52YWx1ZTsKLSAgICAgICAgaWYg KG1fY29udHJvbHNNYW5hZ2VyQ29udGV4dElkKQotICAgICAgICAgICAgcmVtb3ZlQ2xpZW50Rm9y Q29udGV4dChtX2NvbnRyb2xzTWFuYWdlckNvbnRleHRJZCk7CisgICAgICAgIGF1dG8gY29udGV4 dElkID0gbV9tZWRpYUVsZW1lbnRzLmVuc3VyZSgmbWVkaWFFbGVtZW50LCBbJl0geyByZXR1cm4g bmV4dENvbnRleHRJZCgpOyB9KS5pdGVyYXRvci0+dmFsdWU7CisKKyAgICAgICAgYXV0byBwcmV2 aW91c0NvbnRleHRJZCA9IG1fY29udHJvbHNNYW5hZ2VyQ29udGV4dElkOwogICAgICAgICBtX2Nv bnRyb2xzTWFuYWdlckNvbnRleHRJZCA9IGNvbnRleHRJZDsKKyAgICAgICAgaWYgKHByZXZpb3Vz Q29udGV4dElkKQorICAgICAgICAgICAgcmVtb3ZlQ2xpZW50Rm9yQ29udGV4dChwcmV2aW91c0Nv bnRleHRJZCk7CisKICAgICAgICAgZW5zdXJlTW9kZWwoY29udGV4dElkKS5zZXRNZWRpYUVsZW1l bnQoJm1lZGlhRWxlbWVudCk7CiAgICAgfQogCg==