184017 2018-03-26 11:28:51 -0700 [ASan] Allow Ref<> to be swapped 2018-03-26 13:16:55 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts benjamin cdumez cmarcelo dbates ews-watchlist jfbastien koivisto webkit-bug-importer oldest_to_newest 1409343 0 graouts 2018-03-26 11:28:51 -0700 [ASan] Allow Ref<> to be swapped 1409346 1 336529 graouts 2018-03-26 11:32:09 -0700 Created attachment 336529 Patch 1409347 2 graouts 2018-03-26 11:33:26 -0700 <rdar://problem/36336787> 1409348 3 336529 jfbastien 2018-03-26 11:34:58 -0700 Comment on attachment 336529 Patch I think you also need to un poison assignToHashTableEmptyValue and replace. 1409349 4 336529 koivisto 2018-03-26 11:35:23 -0700 Comment on attachment 336529 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336529&action=review > Source/WTF/wtf/Ref.h:173 > +#if ASAN_ENABLED > + if (__asan_address_is_poisoned(this)) > + __asan_unpoison_memory_region(this, sizeof(*this)); > +#endif > Ref movedReference = WTFMove(reference); Too much indentation. > Source/WTF/wtf/Ref.h:185 > +#if ASAN_ENABLED > + if (__asan_address_is_poisoned(this)) > + __asan_unpoison_memory_region(this, sizeof(*this)); > +#endif Here too. 1409362 5 336531 graouts 2018-03-26 12:01:52 -0700 Created attachment 336531 Patch 1409383 6 336531 jfbastien 2018-03-26 12:40:32 -0700 Comment on attachment 336531 Patch r=me 1409388 7 graouts 2018-03-26 13:16:55 -0700 Committed r229985: <https://trac.webkit.org/changeset/229985> 336529 2018-03-26 11:32:09 -0700 2018-03-26 12:01:49 -0700 Patch bug-184017-20180326203208.patch text/plain 1659 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5ODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE1MGZjNDgwZmM3MWI3OWY3MDQ5MTk1 ZjRmZTIwODY0ZThjNGRkNjkuLjA2MGVjODY0M2I5ZjBlMGQxN2ViNjFlZDhjOGJhMTZjNDk1OTky NjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDMtMjYgIEFudG9pbmUgUXVpbnQgIDxncmFv dXRzQGFwcGxlLmNvbT4KKworICAgICAgICBbQVNhbl0gQWxsb3cgUmVmPD4gdG8gYmUgc3dhcHBl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MDE3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYv UmVmLmg6CisgICAgICAgIChXVEY6Oj0pOiBVbnBvaXNvbiBhIFJlZiBqdXN0IGxpa2UgaW4gflJl ZiBzbyB0aGF0IHNvcnRpbmcgYSBWZWN0b3I8UmVmPD4+IHdvcmtzIHdpdGggQVNhbiBvbi4KKwog MjAxOC0wMy0yMiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAg ICAgICBBZG9wdCBVU0UoT1BFTkdMW19FU10pIGluIG1vcmUgcGxhY2VzCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9SZWYuaCBiL1NvdXJjZS9XVEYvd3RmL1JlZi5oCmluZGV4IDJlZDRkMjg2 OGY4OTk5NWMxOTY1MzUzM2Q2OTM5NDk2MGVjYzRmNDkuLmIwYTU4MjI1NDRjZDg1ZmJhOTNkNDhj NjY3MmViOTU1YTgwYmI0OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1JlZi5oCisrKyBi L1NvdXJjZS9XVEYvd3RmL1JlZi5oCkBAIC0xNjYsNiArMTY2LDEwIEBAIGlubGluZSBSZWY8VCwg VT4mIFJlZjxULCBVPjo6b3BlcmF0b3I9KFQmIHJlZmVyZW5jZSkKIHRlbXBsYXRlPHR5cGVuYW1l IFQsIHR5cGVuYW1lIFU+CiBpbmxpbmUgUmVmPFQsIFU+JiBSZWY8VCwgVT46Om9wZXJhdG9yPShS ZWYmJiByZWZlcmVuY2UpCiB7CisjaWYgQVNBTl9FTkFCTEVECisgICAgICAgIGlmIChfX2FzYW5f YWRkcmVzc19pc19wb2lzb25lZCh0aGlzKSkKKyAgICAgICAgICAgIF9fYXNhbl91bnBvaXNvbl9t ZW1vcnlfcmVnaW9uKHRoaXMsIHNpemVvZigqdGhpcykpOworI2VuZGlmCiAgICAgUmVmIG1vdmVk UmVmZXJlbmNlID0gV1RGTW92ZShyZWZlcmVuY2UpOwogICAgIHN3YXAobW92ZWRSZWZlcmVuY2Up OwogICAgIHJldHVybiAqdGhpczsKQEAgLTE3NSw2ICsxNzksMTAgQEAgdGVtcGxhdGU8dHlwZW5h bWUgVCwgdHlwZW5hbWUgVT4KIHRlbXBsYXRlPHR5cGVuYW1lIFgsIHR5cGVuYW1lIFk+CiBpbmxp bmUgUmVmPFQsIFU+JiBSZWY8VCwgVT46Om9wZXJhdG9yPShSZWY8WCwgWT4mJiByZWZlcmVuY2Up CiB7CisjaWYgQVNBTl9FTkFCTEVECisgICAgICAgIGlmIChfX2FzYW5fYWRkcmVzc19pc19wb2lz b25lZCh0aGlzKSkKKyAgICAgICAgICAgIF9fYXNhbl91bnBvaXNvbl9tZW1vcnlfcmVnaW9uKHRo aXMsIHNpemVvZigqdGhpcykpOworI2VuZGlmCiAgICAgUmVmIG1vdmVkUmVmZXJlbmNlID0gV1RG TW92ZShyZWZlcmVuY2UpOwogICAgIHN3YXAobW92ZWRSZWZlcmVuY2UpOwogICAgIHJldHVybiAq dGhpczsK 336531 2018-03-26 12:01:52 -0700 2018-03-26 12:40:32 -0700 Patch bug-184017-20180326210150.patch text/plain 2513 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5ODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE1MGZjNDgwZmM3MWI3OWY3MDQ5MTk1 ZjRmZTIwODY0ZThjNGRkNjkuLjhkYmU3N2ViNzQwZjRlZmM0MmNiMjc2NzU0MjMwZDFkNmRkNGJl MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDMtMjYgIEFudG9pbmUgUXVpbnQgIDxncmFv dXRzQGFwcGxlLmNvbT4KKworICAgICAgICBbQVNhbl0gQWxsb3cgUmVmPD4gdG8gYmUgc3dhcHBl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0MDE3 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNjMzNjc4Nz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnBvaXNvbiBhIFJlZiBpbiB2YXJpb3VzIGNh bGxzIGp1c3QgbGlrZSBpbiB+UmVmIHNvIHRoYXQgc29ydGluZyBhIFZlY3RvcjxSZWY8Pj4gd29y a3Mgd2l0aCBBU2FuIG9uLgorCisgICAgICAgICogd3RmL1JlZi5oOgorICAgICAgICAoV1RGOjpS ZWY6OmFzc2lnblRvSGFzaFRhYmxlRW1wdHlWYWx1ZSk6CisgICAgICAgIChXVEY6Oj0pOgorICAg ICAgICAoV1RGOjpVPjo6cmVwbGFjZSk6CisKIDIwMTgtMDMtMjIgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRvcHQgVVNFKE9QRU5HTFtfRVNdKSBp biBtb3JlIHBsYWNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUmVmLmggYi9Tb3VyY2Uv V1RGL3d0Zi9SZWYuaAppbmRleCAyZWQ0ZDI4NjhmODk5OTVjMTk2NTM1MzNkNjkzOTQ5NjBlY2M0 ZjQ5Li4xYWFkNzZmNjQwYjFlODY2OTFmNjU2OGJjNjc3MTI3MTc4OGRkNTA2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9SZWYuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9SZWYuaApAQCAtMTA4 LDYgKzEwOCwxMCBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGFzc2lnblRvSGFzaFRhYmxlRW1wdHlW YWx1ZShSZWYmJiByZWZlcmVuY2UpCiAgICAgeworI2lmIEFTQU5fRU5BQkxFRAorICAgICAgICBp ZiAoX19hc2FuX2FkZHJlc3NfaXNfcG9pc29uZWQodGhpcykpCisgICAgICAgICAgICBfX2FzYW5f dW5wb2lzb25fbWVtb3J5X3JlZ2lvbih0aGlzLCBzaXplb2YoKnRoaXMpKTsKKyNlbmRpZgogICAg ICAgICBBU1NFUlQobV9wdHIgPT0gaGFzaFRhYmxlRW1wdHlWYWx1ZSgpKTsKICAgICAgICAgbV9w dHIgPSAmcmVmZXJlbmNlLmxlYWtSZWYoKTsKICAgICAgICAgQVNTRVJUKG1fcHRyKTsKQEAgLTE2 Niw2ICsxNzAsMTAgQEAgaW5saW5lIFJlZjxULCBVPiYgUmVmPFQsIFU+OjpvcGVyYXRvcj0oVCYg cmVmZXJlbmNlKQogdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgVT4KIGlubGluZSBSZWY8 VCwgVT4mIFJlZjxULCBVPjo6b3BlcmF0b3I9KFJlZiYmIHJlZmVyZW5jZSkKIHsKKyNpZiBBU0FO X0VOQUJMRUQKKyAgICBpZiAoX19hc2FuX2FkZHJlc3NfaXNfcG9pc29uZWQodGhpcykpCisgICAg ICAgIF9fYXNhbl91bnBvaXNvbl9tZW1vcnlfcmVnaW9uKHRoaXMsIHNpemVvZigqdGhpcykpOwor I2VuZGlmCiAgICAgUmVmIG1vdmVkUmVmZXJlbmNlID0gV1RGTW92ZShyZWZlcmVuY2UpOwogICAg IHN3YXAobW92ZWRSZWZlcmVuY2UpOwogICAgIHJldHVybiAqdGhpczsKQEAgLTE3NSw2ICsxODMs MTAgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgVT4KIHRlbXBsYXRlPHR5cGVuYW1l IFgsIHR5cGVuYW1lIFk+CiBpbmxpbmUgUmVmPFQsIFU+JiBSZWY8VCwgVT46Om9wZXJhdG9yPShS ZWY8WCwgWT4mJiByZWZlcmVuY2UpCiB7CisjaWYgQVNBTl9FTkFCTEVECisgICAgaWYgKF9fYXNh bl9hZGRyZXNzX2lzX3BvaXNvbmVkKHRoaXMpKQorICAgICAgICBfX2FzYW5fdW5wb2lzb25fbWVt b3J5X3JlZ2lvbih0aGlzLCBzaXplb2YoKnRoaXMpKTsKKyNlbmRpZgogICAgIFJlZiBtb3ZlZFJl ZmVyZW5jZSA9IFdURk1vdmUocmVmZXJlbmNlKTsKICAgICBzd2FwKG1vdmVkUmVmZXJlbmNlKTsK ICAgICByZXR1cm4gKnRoaXM7CkBAIC0xOTcsNiArMjA5LDEwIEBAIHRlbXBsYXRlPHR5cGVuYW1l IFQsIHR5cGVuYW1lIFU+CiB0ZW1wbGF0ZTx0eXBlbmFtZSBYLCB0eXBlbmFtZSBZPgogaW5saW5l IFJlZjxULCBVPiBSZWY8VCwgVT46OnJlcGxhY2UoUmVmPFgsIFk+JiYgcmVmZXJlbmNlKQogewor I2lmIEFTQU5fRU5BQkxFRAorICAgIGlmIChfX2FzYW5fYWRkcmVzc19pc19wb2lzb25lZCh0aGlz KSkKKyAgICAgICAgX19hc2FuX3VucG9pc29uX21lbW9yeV9yZWdpb24odGhpcywgc2l6ZW9mKCp0 aGlzKSk7CisjZW5kaWYKICAgICBhdXRvIG9sZFJlZmVyZW5jZSA9IGFkb3B0UmVmKCptX3B0cik7 CiAgICAgbV9wdHIgPSAmcmVmZXJlbmNlLmxlYWtSZWYoKTsKICAgICByZXR1cm4gb2xkUmVmZXJl bmNlOwo=