184016 2018-03-26 11:15:36 -0700 [Extra zoom mode] Add plumbing for next and previous focusable element rects 2018-03-26 12:09:39 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin commit-queue thorton timothy webkit-bug-importer oldest_to_newest 1409341 0 wenson_hsieh 2018-03-26 11:15:36 -0700 Work towards <rdar://problem/38758727> 1409342 1 336528 wenson_hsieh 2018-03-26 11:24:12 -0700 Created attachment 336528 Patch 1409345 2 336528 thorton 2018-03-26 11:32:07 -0700 Comment on attachment 336528 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336528&action=review > Source/WebKit/Shared/AssistedNodeInformation.h:97 > + WebCore::IntRect nextNodeRect; I guess we’ll get subpixel sparkle if we try to use these without any padding? But that’s OK. 1409353 3 wenson_hsieh 2018-03-26 11:38:09 -0700 (In reply to Tim Horton from comment #2) > Comment on attachment 336528 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336528&action=review > > > Source/WebKit/Shared/AssistedNodeInformation.h:97 > > + WebCore::IntRect nextNodeRect; > > I guess we’ll get subpixel sparkle if we try to use these without any > padding? But that’s OK. I see! Perhaps we should be inflating to device pixel boundaries here? FWIW, the rect of the assisted node currently doesn't adjust for this, but perhaps we could look into it as a followup. 1409356 4 thorton 2018-03-26 11:46:28 -0700 Someday! Not important. 1409364 5 336528 commit-queue 2018-03-26 12:09:37 -0700 Comment on attachment 336528 Patch Clearing flags on attachment: 336528 Committed r229982: <https://trac.webkit.org/changeset/229982> 1409365 6 commit-queue 2018-03-26 12:09:39 -0700 All reviewed patches have been landed. Closing bug. 336528 2018-03-26 11:24:12 -0700 2018-03-26 12:09:37 -0700 Patch bug-184016-20180326112412.patch text/plain 6989 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5OTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ5ZmQzMTM3N2NkNThkNDhh YWVhMmE1NzQ5MmJiMjJiNjdiNTk3MjAuLmE4MjBjYTM0NjgyZGVhMjM0MmViN2MwZmI5NmE0NmFk MWUwMjcxNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMgQEAKKzIwMTgtMDMtMjYgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW0V4dHJhIHpvb20gbW9k ZV0gQWRkIHBsdW1iaW5nIGZvciBuZXh0IGFuZCBwcmV2aW91cyBmb2N1c2FibGUgZWxlbWVudCBy ZWN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0 MDE2CisgICAgICAgIFdvcmsgdG93YXJkcyA8cmRhcjovL3Byb2JsZW0vMzg3NTg3Mjc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBidWlsZGlu ZyB1cCBBc3Npc3RlZE5vZGVJbmZvcm1hdGlvbiwgd2UgY3VycmVudGx5IGNvbXB1dGUgdGhlIGVs ZW1lbnQgcmVjdCBvZiB0aGUgY3VycmVudCBmb2N1c2VkIGVsZW1lbnQsCisgICAgICAgIGFzIHdl bGwgYXMgZmxhZ3MgaW5kaWNhdGluZyB3aGV0aGVyIG9yIG5vdCB0aGVyZSBhcmUgbmV4dCBvciBw cmV2aW91cyBmb2N1c2FibGUgZWxlbWVudHMuIEZvcgorICAgICAgICA8cmRhcjovL3Byb2JsZW0v Mzg3NTg3Mjc+LCB3ZSBhZGRpdGlvbmFsbHkgc2VuZCB0aGUgcmVjdHMgb2YgdGhlIG5leHQgb3Ig cHJldmlvdXMgZm9jdXNhYmxlIGVsZW1lbnRzIGFzIHdlbGwuCisKKyAgICAgICAgKiBTaGFyZWQv QXNzaXN0ZWROb2RlSW5mb3JtYXRpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpBc3Npc3RlZE5v ZGVJbmZvcm1hdGlvbjo6ZW5jb2RlIGNvbnN0KToKKyAgICAgICAgKFdlYktpdDo6QXNzaXN0ZWRO b2RlSW5mb3JtYXRpb246OmRlY29kZSk6CisKKyAgICAgICAgSVBDIHN1cHBvcnQgZm9yIG5leHRO b2RlUmVjdCBhbmQgcHJldmlvdXNOb2RlUmVjdC4KKworICAgICAgICAqIFNoYXJlZC9Bc3Npc3Rl ZE5vZGVJbmZvcm1hdGlvbi5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi UGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6ZWxlbWVudFJlY3RJblJvb3RWaWV3Q29vcmRp bmF0ZXMpOgorCisgICAgICAgIEFkZCBhIGhlbHBlciB0byBjb21wdXRlIGFuIGVsZW1lbnQncyBy ZWN0IGluIHJvb3QgdmlldyBjb29yZGluYXRlcy4gV2UgdXNlIHRoaXMgdG8gY29tcHV0ZSB0aGUg cmVjdHMgb2YgdGhlCisgICAgICAgIGN1cnJlbnQgZm9jdXNlZCBlbGVtZW50IGFzIHdlbGwgYXMg dGhvc2Ugb2YgdGhlIG5leHQgYW5kIHByZXZpb3VzIGVsZW1lbnRzLCBpZiBhbnkuCisKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZTo6Z2V0QXNzaXN0ZWROb2RlSW5mb3JtYXRpb24pOgorICAgICAg ICAoV2ViS2l0OjpoYXNBc3Npc3RhYmxlRWxlbWVudCk6IERlbGV0ZWQuCisKKyAgICAgICAgU2lu Y2Ugd2UgbmVlZCB0aGUgbmV4dCBvciBwcmV2aW91cyBmb2N1c2FibGUgZWxlbWVudCB0byBnZXQg aXRzIHJlY3QsIHdlIGRvbid0IG5lZWQgdGhpcyBoZWxwZXIgYW55bW9yZS4KKwogMjAxOC0wMy0y MyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXgg dGhlIGJ1aWxkIHdpdGggbm8gcGFzdGVib2FyZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9T aGFyZWQvQXNzaXN0ZWROb2RlSW5mb3JtYXRpb24uY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQv QXNzaXN0ZWROb2RlSW5mb3JtYXRpb24uY3BwCmluZGV4IGE3ODg0YTk3NGI3Y2Q1OWMwOWM4MDA2 MjMzM2RiMWJiZDZmOGRlZWMuLmM3Y2IzMWFmM2U0MmI5NmE2NGNlMmE0ZGE3MzVmNjdmYTZjYTgx ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Fzc2lzdGVkTm9kZUluZm9ybWF0 aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Bc3Npc3RlZE5vZGVJbmZvcm1hdGlv bi5jcHAKQEAgLTcwLDcgKzcwLDkgQEAgdm9pZCBBc3Npc3RlZE5vZGVJbmZvcm1hdGlvbjo6ZW5j b2RlKElQQzo6RW5jb2RlciYgZW5jb2RlcikgY29uc3QKICAgICBlbmNvZGVyIDw8IG1heGltdW1T Y2FsZUZhY3Rvcklnbm9yaW5nQWx3YXlzU2NhbGFibGU7CiAgICAgZW5jb2RlciA8PCBub2RlRm9u dFNpemU7CiAgICAgZW5jb2RlciA8PCBoYXNOZXh0Tm9kZTsKKyAgICBlbmNvZGVyIDw8IG5leHRO b2RlUmVjdDsKICAgICBlbmNvZGVyIDw8IGhhc1ByZXZpb3VzTm9kZTsKKyAgICBlbmNvZGVyIDw8 IHByZXZpb3VzTm9kZVJlY3Q7CiAgICAgZW5jb2RlciA8PCBpc0F1dG9jb3JyZWN0OwogICAgIGVu Y29kZXIgPDwgaXNSVEw7CiAgICAgZW5jb2Rlci5lbmNvZGVFbnVtKGF1dG9jYXBpdGFsaXplVHlw ZSk7CkBAIC0xMTcsOSArMTE5LDE1IEBAIGJvb2wgQXNzaXN0ZWROb2RlSW5mb3JtYXRpb246OmRl Y29kZShJUEM6OkRlY29kZXImIGRlY29kZXIsIEFzc2lzdGVkTm9kZUluZm9ybWF0CiAgICAgaWYg KCFkZWNvZGVyLmRlY29kZShyZXN1bHQuaGFzTmV4dE5vZGUpKQogICAgICAgICByZXR1cm4gZmFs c2U7CiAKKyAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlc3VsdC5uZXh0Tm9kZVJlY3QpKQorICAg ICAgICByZXR1cm4gZmFsc2U7CisKICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlc3VsdC5oYXNQ cmV2aW91c05vZGUpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBpZiAoIWRlY29kZXIu ZGVjb2RlKHJlc3VsdC5wcmV2aW91c05vZGVSZWN0KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwor CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShyZXN1bHQuaXNBdXRvY29ycmVjdCkpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvQXNzaXN0 ZWROb2RlSW5mb3JtYXRpb24uaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Fzc2lzdGVkTm9kZUlu Zm9ybWF0aW9uLmgKaW5kZXggNmJjZjMzNzk1MWQ1Yjc1YzE4MmRkYjVlNjZmZTE0ZWVjM2EyZjJj Zi4uYTYxMjRmZDAwZjE2MzczZWFhY2RjNjgwZjIxMWU1OWQ1NjY0OGRmYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9TaGFyZWQvQXNzaXN0ZWROb2RlSW5mb3JtYXRpb24uaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9Bc3Npc3RlZE5vZGVJbmZvcm1hdGlvbi5oCkBAIC05NCw3ICs5NCw5 IEBAIHN0cnVjdCBBc3Npc3RlZE5vZGVJbmZvcm1hdGlvbiB7CiAgICAgZG91YmxlIG1heGltdW1T Y2FsZUZhY3Rvcklnbm9yaW5nQWx3YXlzU2NhbGFibGUgeyBJTkZJTklUWSB9OwogICAgIGRvdWJs ZSBub2RlRm9udFNpemUgeyAwIH07CiAgICAgYm9vbCBoYXNOZXh0Tm9kZSB7IGZhbHNlIH07Cisg ICAgV2ViQ29yZTo6SW50UmVjdCBuZXh0Tm9kZVJlY3Q7CiAgICAgYm9vbCBoYXNQcmV2aW91c05v ZGUgeyBmYWxzZSB9OworICAgIFdlYkNvcmU6OkludFJlY3QgcHJldmlvdXNOb2RlUmVjdDsKICAg ICBib29sIGlzQXV0b2NvcnJlY3QgeyBmYWxzZSB9OwogICAgIGJvb2wgaXNSVEwgeyBmYWxzZSB9 OwogICAgIGJvb2wgaXNNdWx0aVNlbGVjdCB7IGZhbHNlIH07CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCmluZGV4IDJhOTQ3ZmRmMWY0 OGQwZTQ3MGVkMjY5NGY3MzI1OWI0NWUzY2I1ZmUuLmRmOGQyMmE0YTQ3YmZmZTljZGYxY2M4NDFh ZTQwMmYyNWEwMDVkYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ YWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ YWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0yNjkxLDExICsyNjkxLDYgQEAgc3RhdGljIGlubGlu ZSBFbGVtZW50KiBuZXh0QXNzaXN0YWJsZUVsZW1lbnQoTm9kZSogc3RhcnROb2RlLCBQYWdlJiBw YWdlLCBib29sIGkKICAgICByZXR1cm4gbmV4dEVsZW1lbnQ7CiB9CiAKLXN0YXRpYyBpbmxpbmUg Ym9vbCBoYXNBc3Npc3RhYmxlRWxlbWVudChOb2RlKiBzdGFydE5vZGUsIFBhZ2UmIHBhZ2UsIGJv b2wgaXNGb3J3YXJkKQotewotICAgIHJldHVybiBuZXh0QXNzaXN0YWJsZUVsZW1lbnQoc3RhcnRO b2RlLCBwYWdlLCBpc0ZvcndhcmQpOwotfQotCiB2b2lkIFdlYlBhZ2U6OmZvY3VzTmV4dEFzc2lz dGVkTm9kZShib29sIGlzRm9yd2FyZCwgQ2FsbGJhY2tJRCBjYWxsYmFja0lEKQogewogICAgIEVs ZW1lbnQqIG5leHRFbGVtZW50ID0gbmV4dEFzc2lzdGFibGVFbGVtZW50KG1fYXNzaXN0ZWROb2Rl LmdldCgpLCAqbV9wYWdlLCBpc0ZvcndhcmQpOwpAQCAtMjcwNiw2ICsyNzAxLDE5IEBAIHZvaWQg V2ViUGFnZTo6Zm9jdXNOZXh0QXNzaXN0ZWROb2RlKGJvb2wgaXNGb3J3YXJkLCBDYWxsYmFja0lE IGNhbGxiYWNrSUQpCiAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpWb2lkQ2FsbGJh Y2soY2FsbGJhY2tJRCkpOwogfQogCitzdGF0aWMgSW50UmVjdCBlbGVtZW50UmVjdEluUm9vdFZp ZXdDb29yZGluYXRlcyhjb25zdCBOb2RlJiBub2RlLCBjb25zdCBGcmFtZSYgZnJhbWUpCit7Cisg ICAgYXV0byogdmlldyA9IGZyYW1lLnZpZXcoKTsKKyAgICBpZiAoIXZpZXcpCisgICAgICAgIHJl dHVybiB7IH07CisKKyAgICBhdXRvKiByZW5kZXJlciA9IG5vZGUucmVuZGVyZXIoKTsKKyAgICBp ZiAoIXJlbmRlcmVyKQorICAgICAgICByZXR1cm4geyB9OworCisgICAgcmV0dXJuIHZpZXctPmNv bnRlbnRzVG9Sb290VmlldyhyZW5kZXJlci0+YWJzb2x1dGVCb3VuZGluZ0JveFJlY3QoKSk7Cit9 CisKIHZvaWQgV2ViUGFnZTo6Z2V0QXNzaXN0ZWROb2RlSW5mb3JtYXRpb24oQXNzaXN0ZWROb2Rl SW5mb3JtYXRpb24mIGluZm9ybWF0aW9uKQogewogICAgIGxheW91dElmTmVlZGVkKCk7CkBAIC0y NzE2LDcgKzI3MjQsNyBAQCB2b2lkIFdlYlBhZ2U6OmdldEFzc2lzdGVkTm9kZUluZm9ybWF0aW9u KEFzc2lzdGVkTm9kZUluZm9ybWF0aW9uJiBpbmZvcm1hdGlvbikKIAogICAgIGlmIChSZW5kZXJP YmplY3QqIHJlbmRlcmVyID0gbV9hc3Npc3RlZE5vZGUtPnJlbmRlcmVyKCkpIHsKICAgICAgICAg RnJhbWUmIGVsZW1lbnRGcmFtZSA9IG1fcGFnZS0+Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNlZE9y TWFpbkZyYW1lKCk7Ci0gICAgICAgIGluZm9ybWF0aW9uLmVsZW1lbnRSZWN0ID0gZWxlbWVudEZy YW1lLnZpZXcoKS0+Y29udGVudHNUb1Jvb3RWaWV3KHJlbmRlcmVyLT5hYnNvbHV0ZUJvdW5kaW5n Qm94UmVjdCgpKTsKKyAgICAgICAgaW5mb3JtYXRpb24uZWxlbWVudFJlY3QgPSBlbGVtZW50UmVj dEluUm9vdFZpZXdDb29yZGluYXRlcygqbV9hc3Npc3RlZE5vZGUsIGVsZW1lbnRGcmFtZSk7CiAg ICAgICAgIGluZm9ybWF0aW9uLm5vZGVGb250U2l6ZSA9IHJlbmRlcmVyLT5zdHlsZSgpLmZvbnRE ZXNjcmlwdGlvbigpLmNvbXB1dGVkU2l6ZSgpOwogCiAgICAgICAgIGJvb2wgaW5GaXhlZCA9IGZh bHNlOwpAQCAtMjc0Niw4ICsyNzU0LDE2IEBAIHZvaWQgV2ViUGFnZTo6Z2V0QXNzaXN0ZWROb2Rl SW5mb3JtYXRpb24oQXNzaXN0ZWROb2RlSW5mb3JtYXRpb24mIGluZm9ybWF0aW9uKQogICAgIGlu Zm9ybWF0aW9uLm1heGltdW1TY2FsZUZhY3Rvcklnbm9yaW5nQWx3YXlzU2NhbGFibGUgPSBtYXhp bXVtUGFnZVNjYWxlRmFjdG9ySWdub3JpbmdBbHdheXNTY2FsYWJsZSgpOwogICAgIGluZm9ybWF0 aW9uLmFsbG93c1VzZXJTY2FsaW5nID0gbV92aWV3cG9ydENvbmZpZ3VyYXRpb24uYWxsb3dzVXNl clNjYWxpbmcoKTsKICAgICBpbmZvcm1hdGlvbi5hbGxvd3NVc2VyU2NhbGluZ0lnbm9yaW5nQWx3 YXlzU2NhbGFibGUgPSBtX3ZpZXdwb3J0Q29uZmlndXJhdGlvbi5hbGxvd3NVc2VyU2NhbGluZ0ln bm9yaW5nQWx3YXlzU2NhbGFibGUoKTsKLSAgICBpbmZvcm1hdGlvbi5oYXNOZXh0Tm9kZSA9IGhh c0Fzc2lzdGFibGVFbGVtZW50KG1fYXNzaXN0ZWROb2RlLmdldCgpLCAqbV9wYWdlLCB0cnVlKTsK LSAgICBpbmZvcm1hdGlvbi5oYXNQcmV2aW91c05vZGUgPSBoYXNBc3Npc3RhYmxlRWxlbWVudCht X2Fzc2lzdGVkTm9kZS5nZXQoKSwgKm1fcGFnZSwgZmFsc2UpOworICAgIGlmIChhdXRvKiBuZXh0 RWxlbWVudCA9IG5leHRBc3Npc3RhYmxlRWxlbWVudChtX2Fzc2lzdGVkTm9kZS5nZXQoKSwgKm1f cGFnZSwgdHJ1ZSkpIHsKKyAgICAgICAgaWYgKGF1dG8qIGZyYW1lID0gbmV4dEVsZW1lbnQtPmRv Y3VtZW50KCkuZnJhbWUoKSkKKyAgICAgICAgICAgIGluZm9ybWF0aW9uLm5leHROb2RlUmVjdCA9 IGVsZW1lbnRSZWN0SW5Sb290Vmlld0Nvb3JkaW5hdGVzKCpuZXh0RWxlbWVudCwgKmZyYW1lKTsK KyAgICAgICAgaW5mb3JtYXRpb24uaGFzTmV4dE5vZGUgPSB0cnVlOworICAgIH0KKyAgICBpZiAo YXV0byogcHJldmlvdXNFbGVtZW50ID0gbmV4dEFzc2lzdGFibGVFbGVtZW50KG1fYXNzaXN0ZWRO b2RlLmdldCgpLCAqbV9wYWdlLCBmYWxzZSkpIHsKKyAgICAgICAgaWYgKGF1dG8qIGZyYW1lID0g cHJldmlvdXNFbGVtZW50LT5kb2N1bWVudCgpLmZyYW1lKCkpCisgICAgICAgICAgICBpbmZvcm1h dGlvbi5wcmV2aW91c05vZGVSZWN0ID0gZWxlbWVudFJlY3RJblJvb3RWaWV3Q29vcmRpbmF0ZXMo KnByZXZpb3VzRWxlbWVudCwgKmZyYW1lKTsKKyAgICAgICAgaW5mb3JtYXRpb24uaGFzUHJldmlv dXNOb2RlID0gdHJ1ZTsKKyAgICB9CiAgICAgaW5mb3JtYXRpb24uYXNzaXN0ZWROb2RlSWRlbnRp ZmllciA9IG1fY3VycmVudEFzc2lzdGVkTm9kZUlkZW50aWZpZXI7CiAKICAgICBpZiAoaXM8TGFi ZWxhYmxlRWxlbWVudD4oKm1fYXNzaXN0ZWROb2RlKSkgewo=