183997 2018-03-25 12:26:14 -0700 WebProcess memory monitor: use %zu format specifier for size_t 2018-03-25 17:55:23 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183773 InRadar P2 Normal --- 1 clopez clopez achristensen benjamin cdumez clopez cmarcelo darin dbates eric.carlson ews-watchlist jer.noble mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1409197 0 clopez 2018-03-25 12:26:14 -0700 %zu is the correct format specifier for size_t 1409199 1 336497 clopez 2018-03-25 12:32:15 -0700 Created attachment 336497 Patch 1409210 2 336497 mcatanzaro 2018-03-25 13:32:03 -0700 Comment on attachment 336497 Patch Thanks for fixing this. We need to be really careful when printing integer types, since the types really do often differ in practice. 1409213 3 336497 clopez 2018-03-25 17:54:27 -0700 Comment on attachment 336497 Patch Clearing flags on attachment: 336497 Committed r229965: <https://trac.webkit.org/changeset/229965> 1409214 4 clopez 2018-03-25 17:54:31 -0700 All reviewed patches have been landed. Closing bug. 1409215 5 webkit-bug-importer 2018-03-25 17:55:23 -0700 <rdar://problem/38848827> 336497 2018-03-25 12:32:15 -0700 2018-03-25 17:54:27 -0700 Patch bug-183997-20180325213213.patch text/plain 2478 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5OTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGIwYjk3YmY4YTA5YTdjZDdiOTdlZDcy OGIzMDFjMjkyNjU1MjUxYjcuLjAwODJjNzg1NTA2MDkxMDE0MDU0MGZkNTFkZjllZWVmODhjYjFl ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDMtMjUgIENhcmxvcyBBbGJlcnRvIExvcGV6 IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgV2ViUHJvY2VzcyBtZW1vcnkg bW9uaXRvcjogdXNlICV6dSBmb3JtYXQgc3BlY2lmaWVyIGZvciBzaXplX3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mzk5NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHVzc2UgJXp1IGZvcm1hdCBzcGVj aWZpZXIgZm9yIHNpemVfdCBpbnN0ZWFkIG9mICVsdS4KKworICAgICAgICAqIHd0Zi9NZW1vcnlQ cmVzc3VyZUhhbmRsZXIuY3BwOgorICAgICAgICAoV1RGOjpNZW1vcnlQcmVzc3VyZUhhbmRsZXI6 OnNocmlua09yRGllKToKKyAgICAgICAgKFdURjo6TWVtb3J5UHJlc3N1cmVIYW5kbGVyOjptZWFz dXJlbWVudFRpbWVyRmlyZWQpOgorCiAyMDE4LTAzLTI1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9o b3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbmQgYWRvcHQgRU5BQkxFKEFJUlBMQVlf UElDS0VSKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWVtb3J5UHJlc3N1cmVIYW5kbGVy LmNwcCBiL1NvdXJjZS9XVEYvd3RmL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHAKaW5kZXggMDNl Y2JkMTYyYWRlZTNkNzFhYzQwNWUxZGQzNGRiZWJiNjlhNDY3Yy4uODMyODg1MzU4YzdiNDk4YTA3 MmJiNzc4Zjg0YWQ4Nzg1OTU0NGIxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWVtb3J5 UHJlc3N1cmVIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9NZW1vcnlQcmVzc3VyZUhh bmRsZXIuY3BwCkBAIC0xNDEsNyArMTQxLDcgQEAgdm9pZCBNZW1vcnlQcmVzc3VyZUhhbmRsZXI6 OnNocmlua09yRGllKCkKIAogICAgIGF1dG8gZm9vdHByaW50ID0gbWVtb3J5Rm9vdHByaW50KCk7 CiAgICAgUkVMRUFTRV9BU1NFUlQoZm9vdHByaW50KTsKLSAgICBSRUxFQVNFX0xPRyhNZW1vcnlQ cmVzc3VyZSwgIk5ldyBtZW1vcnkgZm9vdHByaW50OiAlbHUgTUIiLCBmb290cHJpbnQudmFsdWUo KSAvIE1CKTsKKyAgICBSRUxFQVNFX0xPRyhNZW1vcnlQcmVzc3VyZSwgIk5ldyBtZW1vcnkgZm9v dHByaW50OiAlenUgTUIiLCBmb290cHJpbnQudmFsdWUoKSAvIE1CKTsKIAogICAgIGlmIChmb290 cHJpbnQudmFsdWUoKSA8IHRocmVzaG9sZEZvck1lbW9yeUtpbGwoKSkgewogICAgICAgICBSRUxF QVNFX0xPRyhNZW1vcnlQcmVzc3VyZSwgIlNocmFuayBiZWxvdyBtZW1vcnkga2lsbCB0aHJlc2hv bGQuIFByb2Nlc3MgZ2V0cyB0byBsaXZlLiIpOwpAQCAtMTQ5LDcgKzE0OSw3IEBAIHZvaWQgTWVt b3J5UHJlc3N1cmVIYW5kbGVyOjpzaHJpbmtPckRpZSgpCiAgICAgICAgIHJldHVybjsKICAgICB9 CiAKLSAgICBXVEZMb2dBbHdheXMoIlVuYWJsZSB0byBzaHJpbmsgbWVtb3J5IGZvb3RwcmludCBv ZiBwcm9jZXNzICglbHUgTUIpIGJlbG93IHRoZSBraWxsIHRocmVzb2xkICglbHUgTUIpLiBLaWxs ZWRcbiIsIGZvb3RwcmludC52YWx1ZSgpIC8gTUIsIHRocmVzaG9sZEZvck1lbW9yeUtpbGwoKSAv IE1CKTsKKyAgICBXVEZMb2dBbHdheXMoIlVuYWJsZSB0byBzaHJpbmsgbWVtb3J5IGZvb3Rwcmlu dCBvZiBwcm9jZXNzICglenUgTUIpIGJlbG93IHRoZSBraWxsIHRocmVzb2xkICglenUgTUIpLiBL aWxsZWRcbiIsIGZvb3RwcmludC52YWx1ZSgpIC8gTUIsIHRocmVzaG9sZEZvck1lbW9yeUtpbGwo KSAvIE1CKTsKICAgICBSRUxFQVNFX0FTU0VSVChtX21lbW9yeUtpbGxDYWxsYmFjayk7CiAgICAg bV9tZW1vcnlLaWxsQ2FsbGJhY2soKTsKIH0KQEAgLTE3MSw3ICsxNzEsNyBAQCB2b2lkIE1lbW9y eVByZXNzdXJlSGFuZGxlcjo6bWVhc3VyZW1lbnRUaW1lckZpcmVkKCkKICAgICBpZiAoIWZvb3Rw cmludCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgUkVMRUFTRV9MT0coTWVtb3J5UHJlc3N1cmUs ICJDdXJyZW50IG1lbW9yeSBmb290cHJpbnQ6ICVsdSBNQiIsIGZvb3RwcmludC52YWx1ZSgpIC8g TUIpOworICAgIFJFTEVBU0VfTE9HKE1lbW9yeVByZXNzdXJlLCAiQ3VycmVudCBtZW1vcnkgZm9v dHByaW50OiAlenUgTUIiLCBmb290cHJpbnQudmFsdWUoKSAvIE1CKTsKICAgICBpZiAoZm9vdHBy aW50LnZhbHVlKCkgPj0gdGhyZXNob2xkRm9yTWVtb3J5S2lsbCgpKSB7CiAgICAgICAgIHNocmlu a09yRGllKCk7CiAgICAgICAgIHJldHVybjsK