183977 2018-03-24 01:36:18 -0700 Fix the !ENABLE(MEDIA_STREAM) build 2018-03-24 02:56:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue mitz simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1409062 0 thorton 2018-03-24 01:36:18 -0700 Fix the !ENABLE(MEDIA_STREAM) build 1409063 1 336466 thorton 2018-03-24 01:39:05 -0700 Created attachment 336466 Patch 1409064 2 336466 wenson_hsieh 2018-03-24 01:44:06 -0700 Comment on attachment 336466 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336466&action=review r=me > Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:895 > #endif Could be worth adding some UNUSED_PARAM()s as needed for debug builds. 1409076 3 336466 thorton 2018-03-24 02:29:39 -0700 Comment on attachment 336466 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336466&action=review >> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:895 >> #endif > > Could be worth adding some UNUSED_PARAM()s as needed for debug builds. Don’t think we need them in WK2. 1409080 4 336466 commit-queue 2018-03-24 02:55:40 -0700 Comment on attachment 336466 Patch Clearing flags on attachment: 336466 Committed r229950: <https://trac.webkit.org/changeset/229950> 1409081 5 commit-queue 2018-03-24 02:55:41 -0700 All reviewed patches have been landed. Closing bug. 1409082 6 webkit-bug-importer 2018-03-24 02:56:16 -0700 <rdar://problem/38823362> 336466 2018-03-24 01:39:05 -0700 2018-03-24 02:55:40 -0700 Patch bug-183977-20180324013904.patch text/plain 5641 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5OTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYyN2E4MzY5OGQ2MTFmZDQ5 MDRkYzdmM2JlZWFjNTExNWRkOTM5Y2UuLjgxNjhiNDY5Yjc3NzNjMDQyN2YzMWVmZmY0ZjA2MzMy YjdmMjUzMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDMtMjQgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRoZSAhRU5BQkxF KE1FRElBX1NUUkVBTSkgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4Mzk3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUubW06CisgICAgICAgIChX ZWJLaXQ6OlVJRGVsZWdhdGU6OlVJQ2xpZW50OjpkZWNpZGVQb2xpY3lGb3JVc2VyTWVkaWFQZXJt aXNzaW9uUmVxdWVzdCk6CisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1VzZXJNZWRpYUNhcHR1 cmVNYW5hZ2VyUHJveHkubWVzc2FnZXMuaW46CisgICAgICAgICogVUlQcm9jZXNzL1VzZXJNZWRp YVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5LmNwcDoKKyAgICAgICAgKiBXZWJQcm9jZXNz L2NvY29hL1VzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyLm1lc3NhZ2VzLmluOgorCiAyMDE4LTAzLTI0 ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUg V0tBbmltYXRpb25EZWxlZ2F0ZSB0byBpdHMgb3duIGhlYWRlcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVUlEZWxlZ2F0ZS5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0NvY29hL1VJRGVsZWdhdGUubW0KaW5kZXggMDJjNjY2ZmYyNjUwYmE0ZWZlNWU0MTNk N2UyYTQ4N2M5YWZiMWRiMC4uNGM4NjUyZjI5MDM5YWU3NjdkYjlmNmNjNzk4OWYyZjhlMjdkODdm OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVUlEZWxlZ2F0ZS5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRlLm1tCkBAIC03 ODYsNiArNzg2LDcgQEAgYm9vbCBVSURlbGVnYXRlOjpVSUNsaWVudDo6cnVuT3BlblBhbmVsKFdl YlBhZ2VQcm94eSosIFdlYkZyYW1lUHJveHkqIHdlYkZyYW1lUHIKIH0KICNlbmRpZgogCisjaWYg RU5BQkxFKE1FRElBX1NUUkVBTSkKIHN0YXRpYyB2b2lkIHJlcXVlc3RVc2VyTWVkaWFBdXRob3Jp emF0aW9uRm9yRGV2aWNlcyhjb25zdCBXZWJGcmFtZVByb3h5JiBmcmFtZSwgVXNlck1lZGlhUGVy bWlzc2lvblJlcXVlc3RQcm94eSYgcmVxdWVzdCwgaWQgPFdLVUlEZWxlZ2F0ZVByaXZhdGU+IGRl bGVnYXRlLCBXS1dlYlZpZXcmIHdlYlZpZXcpCiB7CiAgICAgYXV0byBkZWNpc2lvbkhhbmRsZXIg PSBCbG9ja1B0cjx2b2lkKEJPT0wpPjo6ZnJvbUNhbGxhYmxlKFtwcm90ZWN0ZWRSZXF1ZXN0ID0g bWFrZVJlZihyZXF1ZXN0KV0oQk9PTCBhdXRob3JpemVkKSB7CkBAIC04MTUsOSArODE2LDExIEBA IHN0YXRpYyB2b2lkIHJlcXVlc3RVc2VyTWVkaWFBdXRob3JpemF0aW9uRm9yRGV2aWNlcyhjb25z dCBXZWJGcmFtZVByb3h5JiBmcmFtZSwKICAgICBhdXRvIHByb3RlY3RlZFdlYlZpZXcgPSBSZXRh aW5QdHI8V0tXZWJWaWV3Pigmd2ViVmlldyk7CiAgICAgW2RlbGVnYXRlIF93ZWJWaWV3OnByb3Rl Y3RlZFdlYlZpZXcuZ2V0KCkgcmVxdWVzdFVzZXJNZWRpYUF1dGhvcml6YXRpb25Gb3JEZXZpY2Vz OmRldmljZXMgdXJsOnJlcXVlc3RGcmFtZVVSTCBtYWluRnJhbWVVUkw6bWFpbkZyYW1lVVJMIGRl Y2lzaW9uSGFuZGxlcjpkZWNpc2lvbkhhbmRsZXIuZ2V0KCldOwogfQorI2VuZGlmCiAKIGJvb2wg VUlEZWxlZ2F0ZTo6VUlDbGllbnQ6OmRlY2lkZVBvbGljeUZvclVzZXJNZWRpYVBlcm1pc3Npb25S ZXF1ZXN0KFdlYlBhZ2VQcm94eSYgcGFnZSwgV2ViRnJhbWVQcm94eSYgZnJhbWUsIEFQSTo6U2Vj dXJpdHlPcmlnaW4mIHVzZXJNZWRpYU9yaWdpbiwgQVBJOjpTZWN1cml0eU9yaWdpbiYgdG9wTGV2 ZWxPcmlnaW4sIFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHkmIHJlcXVlc3QpCiB7Cisj aWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKICAgICBhdXRvIGRlbGVnYXRlID0gbV91aURlbGVnYXRl Lm1fZGVsZWdhdGUuZ2V0KCk7CiAgICAgaWYgKCFkZWxlZ2F0ZSB8fCAhbV91aURlbGVnYXRlLm1f ZGVsZWdhdGVNZXRob2RzLndlYlZpZXdSZXF1ZXN0VXNlck1lZGlhQXV0aG9yaXphdGlvbkZvckRl dmljZXNVUkxNYWluRnJhbWVVUkxEZWNpc2lvbkhhbmRsZXIpIHsKICAgICAgICAgcmVxdWVzdC5k ZW55KFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHk6OlVzZXJNZWRpYUFjY2Vzc0Rlbmlh bFJlYXNvbjo6VXNlck1lZGlhRGlzYWJsZWQpOwpAQCAtODg4LDYgKzg5MSw3IEBAIGJvb2wgVUlE ZWxlZ2F0ZTo6VUlDbGllbnQ6OmRlY2lkZVBvbGljeUZvclVzZXJNZWRpYVBlcm1pc3Npb25SZXF1 ZXN0KFdlYlBhZ2VQcm94CiAgICAgICAgIHJlcXVlc3RDYW1lcmFBdXRob3JpemF0aW9uKCk7CiAj ZWxzZQogICAgIHJlcXVlc3RVc2VyTWVkaWFBdXRob3JpemF0aW9uRm9yRGV2aWNlcyhmcmFtZSwg cmVxdWVzdCwgKGlkIDxXS1VJRGVsZWdhdGVQcml2YXRlPiltX3VpRGVsZWdhdGUubV9kZWxlZ2F0 ZS5nZXQoKSwgKm1fdWlEZWxlZ2F0ZS5tX3dlYlZpZXcpOworI2VuZGlmCiAjZW5kaWYKIAogICAg IHJldHVybiB0cnVlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev VXNlck1lZGlhQ2FwdHVyZU1hbmFnZXJQcm94eS5tZXNzYWdlcy5pbiBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0NvY29hL1VzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyUHJveHkubWVzc2FnZXMuaW4K aW5kZXggZWU1NmQzM2RmYzNlNTA0ZjUxOWIzOWIwZDI4YmIyM2YwZTU4NWE4Yi4uMjQ4YzQwZmYw MDcxY2EwODc3N2NhZjczZjA4NmQ5YzY3MmUwMmRiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQ29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXJQcm94eS5tZXNzYWdlcy5p bgorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9Vc2VyTWVkaWFDYXB0dXJlTWFu YWdlclByb3h5Lm1lc3NhZ2VzLmluCkBAIC0yMSw2ICsyMSw4IEBACiAjIEFSSVNJTkcgSU4gQU5Z IFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YK ICMgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCisjaWYgRU5BQkxFKE1FRElBX1NU UkVBTSkKKwogbWVzc2FnZXMgLT4gVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXJQcm94eSB7CiAgICAg Q3JlYXRlTWVkaWFTb3VyY2VGb3JDYXB0dXJlRGV2aWNlV2l0aENvbnN0cmFpbnRzKHVpbnQ2NF90 IGlkLCBXZWJDb3JlOjpDYXB0dXJlRGV2aWNlIGRldmljZSwgV2ViQ29yZTo6UmVhbHRpbWVNZWRp YVNvdXJjZTo6VHlwZSB0eXBlLCBzdHJ1Y3QgV2ViQ29yZTo6TWVkaWFDb25zdHJhaW50cyBjb25z dHJhaW50cykgLT4gKGJvb2wgc3VjY2VzcywgU3RyaW5nIGludmFsaWRDb25zdHJhaW50cywgV2Vi Q29yZTo6UmVhbHRpbWVNZWRpYVNvdXJjZVNldHRpbmdzIHNldHRpbmdzKQogICAgIFN0YXJ0UHJv ZHVjaW5nRGF0YSh1aW50NjRfdCBpZCkKQEAgLTI5LDMgKzMxLDUgQEAgbWVzc2FnZXMgLT4gVXNl ck1lZGlhQ2FwdHVyZU1hbmFnZXJQcm94eSB7CiAgICAgU2V0TXV0ZWQodWludDY0X3QgaWQsIGJv b2wgbXV0ZWQpCiAgICAgQXBwbHlDb25zdHJhaW50cyh1aW50NjRfdCBpZCwgc3RydWN0IFdlYkNv cmU6Ok1lZGlhQ29uc3RyYWludHMgY29uc3RyYWludHMpCiB9CisKKyNlbmRpZgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5h Z2VyUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVXNlck1lZGlhUGVybWlzc2lv blJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwCmluZGV4IDA0MWQ3YjgxYTFiZmFiY2E1NGYwMDUxYzY3 NTcyNzMzNDg2OGU1ZTMuLjI2Yjg2NjFiZDYxZmQzY2IxNzdkMzEzNGJjYzE5YTU0Mzg2NDJiN2Ig MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1VzZXJNZWRpYVBlcm1pc3Npb25S ZXF1ZXN0TWFuYWdlclByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Vc2Vy TWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eS5jcHAKQEAgLTM4LDcgKzM4LDkgQEAg dXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCisjaWYgRU5B QkxFKE1FRElBX1NUUkVBTSkKIHN0YXRpYyBjb25zdCBNZWRpYVByb2R1Y2VyOjpNZWRpYVN0YXRl RmxhZ3MgYWN0aXZlQ2FwdHVyZU1hc2sgPSBNZWRpYVByb2R1Y2VyOjpIYXNBY3RpdmVBdWRpb0Nh cHR1cmVEZXZpY2UgfCBNZWRpYVByb2R1Y2VyOjpIYXNBY3RpdmVWaWRlb0NhcHR1cmVEZXZpY2U7 CisjZW5kaWYKIAogVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHk6OlVzZXJN ZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5KFdlYlBhZ2VQcm94eSYgcGFnZSkKICAg ICA6IG1fcGFnZShwYWdlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2Nv Y29hL1VzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyLm1lc3NhZ2VzLmluIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyLm1lc3NhZ2VzLmluCmluZGV4 IDI4MGM0MTUzNzdhZmEzZmFlNWVlMzE4YzVlMzhhN2ZjZjM4ZjRlNjcuLmViNTc0MDU2MTczNTJl ODgxMzNiYjg1MGYxNTdmMzRjM2JmMjNlZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9jb2NvYS9Vc2VyTWVkaWFDYXB0dXJlTWFuYWdlci5tZXNzYWdlcy5pbgorKysgYi9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIubWVz c2FnZXMuaW4KQEAgLTIxLDYgKzIxLDggQEAKICMgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBU SEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRgogIyBUSEUgUE9TU0lC SUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKKyNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQorCiBtZXNz YWdlcyAtPiBVc2VyTWVkaWFDYXB0dXJlTWFuYWdlciB7CiAgICAgQ2FwdHVyZUZhaWxlZCh1aW50 NjRfdCBpZCkKICAgICBTb3VyY2VTdG9wcGVkKHVpbnQ2NF90IGlkKQpAQCAtMzEsMyArMzMsNSBA QCBtZXNzYWdlcyAtPiBVc2VyTWVkaWFDYXB0dXJlTWFuYWdlciB7CiAgICAgQXBwbHlDb25zdHJh aW50c1N1Y2NlZWRlZCh1aW50NjRfdCBpZCwgV2ViQ29yZTo6UmVhbHRpbWVNZWRpYVNvdXJjZVNl dHRpbmdzIHNldHRpbmdzKQogICAgIEFwcGx5Q29uc3RyYWludHNGYWlsZWQodWludDY0X3QgaWQs IFN0cmluZyBmYWlsZWRDb25zdHJhaW50LCBTdHJpbmcgbWVzc2FnZSkKIH0KKworI2VuZGlmCg==