183959 2018-03-23 16:00:25 -0700 Adopt WEBPROCESS_WINDOWSERVER_BLOCKING compiler guard in WebProcess 2018-03-28 14:17:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1408938 0 pvollan 2018-03-23 16:00:25 -0700 I suggest we add the compile guard ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING. 1409958 1 pvollan 2018-03-28 11:52:47 -0700 I would like to add a compile guard, guarding the call to CGSSetDenyWindowServerConnections. 1409959 2 webkit-bug-importer 2018-03-28 11:53:41 -0700 <rdar://problem/38965719> 1409963 3 336689 pvollan 2018-03-28 11:56:10 -0700 Created attachment 336689 Patch 1409983 4 336689 bfulgham 2018-03-28 12:47:05 -0700 Comment on attachment 336689 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336689&action=review This seems reasonable. Please add a log statement before landing. > Source/WebKit/ChangeLog:3 > + Add compile guard for blocking of the WindowServer in the WebProcess. When I read this, I though you were reading a new compile macro -- but you are just using it. I think I'd title this, "Adopt WEBPROCESS_WINDOWSERVER_BLOCKING compiler guard in WebProcess", or something. > Source/WebKit/WebProcess/WebProcess.cpp:234 > + ASSERT_UNUSED(error, error == kCGErrorSuccess); I think you should log an error here if we are unsuccessful in calling DenyWindowServerConnections. 1409991 5 pvollan 2018-03-28 12:54:40 -0700 (In reply to Brent Fulgham from comment #4) > Comment on attachment 336689 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336689&action=review > > This seems reasonable. Please add a log statement before landing. > > > Source/WebKit/ChangeLog:3 > > + Add compile guard for blocking of the WindowServer in the WebProcess. > > When I read this, I though you were reading a new compile macro -- but you > are just using it. I think I'd title this, "Adopt > WEBPROCESS_WINDOWSERVER_BLOCKING compiler guard in WebProcess", or something. > > > Source/WebKit/WebProcess/WebProcess.cpp:234 > > + ASSERT_UNUSED(error, error == kCGErrorSuccess); > > I think you should log an error here if we are unsuccessful in calling > DenyWindowServerConnections. Thanks for reviewing! I'll update the patch before landing. 1410004 6 336706 pvollan 2018-03-28 13:07:57 -0700 Created attachment 336706 Patch 1410015 7 336706 bfulgham 2018-03-28 13:17:33 -0700 Comment on attachment 336706 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336706&action=review > Source/WebKit/WebProcess/WebProcess.cpp:236 > + WTFLogAlways("Failed to deny WindowServer connections."); Is CGError ever something interesting? Would printing its value in the log message be helpful? 1410021 8 336708 pvollan 2018-03-28 13:27:29 -0700 Created attachment 336708 Patch 1410022 9 pvollan 2018-03-28 13:27:53 -0700 (In reply to Brent Fulgham from comment #7) > Comment on attachment 336706 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336706&action=review > > > Source/WebKit/WebProcess/WebProcess.cpp:236 > > + WTFLogAlways("Failed to deny WindowServer connections."); > > Is CGError ever something interesting? Would printing its value in the log > message be helpful? Done! 1410055 10 336708 commit-queue 2018-03-28 14:17:19 -0700 Comment on attachment 336708 Patch Clearing flags on attachment: 336708 Committed r230050: <https://trac.webkit.org/changeset/230050> 336689 2018-03-28 11:56:10 -0700 2018-03-28 12:47:05 -0700 Patch bug-183959-20180328115610.patch text/plain 1996 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzAwMzgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAzLTI4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgY29tcGlsZSBndWFyZCBm b3IgYmxvY2tpbmcgb2YgdGhlIFdpbmRvd1NlcnZlciBpbiB0aGUgV2ViUHJvY2Vzcy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mzk1OQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzg5NjU3MTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXNlIHRoZSBjb21waWxlIGd1YXJkIHRvIGd1YXJkIHRoZSBj YWxsIHRvIENHU1NldERlbnlXaW5kb3dTZXJ2ZXJDb25uZWN0aW9ucy4KKworICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6Omlu aXRpYWxpemVQcm9jZXNzKToKKwogMjAxOC0wMy0yOCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFt QGFwcGxlLmNvbT4KIAogICAgICAgICBBdm9pZCB1bmluaXRpYWxpemVkIG1hY2ggcG9ydHMKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHJldmlzaW9uIDIzMDAz MCkKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjI0LDExICsyMjQsMjEgQEAgdm9pZCBXZWJQcm9jZXNzOjppbml0aWFsaXplUHJv Y2Vzcyhjb25zdAogCiAgICAgTWVzc2FnZVBvcnRDaGFubmVsUHJvdmlkZXI6OnNldFNoYXJlZFBy b3ZpZGVyKFdlYk1lc3NhZ2VQb3J0Q2hhbm5lbFByb3ZpZGVyOjpzaW5nbGV0b24oKSk7CiAgICAg Ci0jaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDEwMTQwMAorI2lmIFBMQVRGT1JNKE1BQykKKyNpZiBFTkFCTEUoV0VCUFJPQ0VTU19XSU5ET1dT RVJWRVJfQkxPQ0tJTkcpCisgICAgLy8gRGVueSB0aGUgV2ViQ29udGVudCBwcm9jZXNzIGFjY2Vz cyB0byB0aGUgV2luZG93U2VydmVyLgorICAgIC8vIFdlIGNhbm5vdCBjYWxsIHNldEFwcGxpY2F0 aW9uSXNEYWVtb24gaGVyZSwgc2luY2UgQWN0aXZpdHkgTW9uaXRvciB3aWxsIG5vdCBzaG93IHRo ZQorICAgIC8vIHVybCBvZiB0aGUgV2ViQ29udGVudCBwcm9jZXNzLCB0aGVuLgorICAgIC8vIFRo aXMgY2FsbCB3aWxsIG5vdCBzdWNjZWVkIGlmIHRoZXJlIGFyZSBvcGVuIFdpbmRvd1NlcnZlciBj b25uZWN0aW9ucyBhdCB0aGlzIHBvaW50LgorICAgIENHRXJyb3IgZXJyb3IgPSBDR1NTZXREZW55 V2luZG93U2VydmVyQ29ubmVjdGlvbnModHJ1ZSk7CisgICAgQVNTRVJUX1VOVVNFRChlcnJvciwg ZXJyb3IgPT0ga0NHRXJyb3JTdWNjZXNzKTsKKyNlbmRpZgorI2lmIF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gMTAxNDAwCiAgICAgLy8gVGhpcyBjYWxsIGlzIG5lZWRlZCB3aGVu IHRoZSBXZWJQcm9jZXNzIGlzIG5vdCBydW5uaW5nIHRoZSBOU0FwcGxpY2F0aW9uIGV2ZW50IGxv b3AuCiAgICAgLy8gT3RoZXJ3aXNlLCBjYWxsaW5nIGVuYWJsZVNhbmRib3hTdHlsZUZpbGVRdWFy YW50aW5lKCkgd2lsbCBmYWlsLgogICAgIGxhdW5jaFNlcnZpY2VzQ2hlY2tJbigpOwogI2VuZGlm CisjZW5kaWYKICAgICBwbGF0Zm9ybUluaXRpYWxpemVQcm9jZXNzKHBhcmFtZXRlcnMpOwogfQog Cg== 336706 2018-03-28 13:07:57 -0700 2018-03-28 13:28:15 -0700 Patch bug-183959-20180328130756.patch text/plain 2082 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzAwMzgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAzLTI4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBZG9wdCBXRUJQUk9DRVNTX1dJ TkRPV1NFUlZFUl9CTE9DS0lORyBjb21waWxlciBndWFyZCBpbiBXZWJQcm9jZXNzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzOTU5CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8zODk2NTcxOT4KKworICAgICAgICBSZXZpZXdlZCBieSBCcmVudCBG dWxnaGFtLgorCisgICAgICAgIFVzZSB0aGUgY29tcGlsZSBndWFyZCB0byBndWFyZCB0aGUgY2Fs bCB0byBDR1NTZXREZW55V2luZG93U2VydmVyQ29ubmVjdGlvbnMuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjppbml0 aWFsaXplUHJvY2Vzcyk6CisKIDIwMTgtMDMtMjggIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBh cHBsZS5jb20+CiAKICAgICAgICAgQXZvaWQgdW5pbml0aWFsaXplZCBtYWNoIHBvcnRzCkluZGV4 OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCShyZXZpc2lvbiAyMzAwMzAp CisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIyNCwxMSArMjI0LDIzIEBAIHZvaWQgV2ViUHJvY2Vzczo6aW5pdGlhbGl6ZVByb2Nl c3MoY29uc3QKIAogICAgIE1lc3NhZ2VQb3J0Q2hhbm5lbFByb3ZpZGVyOjpzZXRTaGFyZWRQcm92 aWRlcihXZWJNZXNzYWdlUG9ydENoYW5uZWxQcm92aWRlcjo6c2luZ2xldG9uKCkpOwogICAgIAot I2lmIFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAx MDE0MDAKKyNpZiBQTEFURk9STShNQUMpCisjaWYgRU5BQkxFKFdFQlBST0NFU1NfV0lORE9XU0VS VkVSX0JMT0NLSU5HKQorICAgIC8vIERlbnkgdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBhY2Nlc3Mg dG8gdGhlIFdpbmRvd1NlcnZlci4KKyAgICAvLyBXZSBjYW5ub3QgY2FsbCBzZXRBcHBsaWNhdGlv bklzRGFlbW9uIGhlcmUsIHNpbmNlIEFjdGl2aXR5IE1vbml0b3Igd2lsbCBub3Qgc2hvdyB0aGUK KyAgICAvLyB1cmwgb2YgdGhlIFdlYkNvbnRlbnQgcHJvY2VzcywgdGhlbi4KKyAgICAvLyBUaGlz IGNhbGwgd2lsbCBub3Qgc3VjY2VlZCBpZiB0aGVyZSBhcmUgb3BlbiBXaW5kb3dTZXJ2ZXIgY29u bmVjdGlvbnMgYXQgdGhpcyBwb2ludC4KKyAgICBDR0Vycm9yIGVycm9yID0gQ0dTU2V0RGVueVdp bmRvd1NlcnZlckNvbm5lY3Rpb25zKHRydWUpOworICAgIEFTU0VSVChlcnJvciA9PSBrQ0dFcnJv clN1Y2Nlc3MpOworICAgIGlmIChlcnJvciAhPSBrQ0dFcnJvclN1Y2Nlc3MpCisgICAgICAgIFdU RkxvZ0Fsd2F5cygiRmFpbGVkIHRvIGRlbnkgV2luZG93U2VydmVyIGNvbm5lY3Rpb25zLiIpOwor I2VuZGlmCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDAKICAg ICAvLyBUaGlzIGNhbGwgaXMgbmVlZGVkIHdoZW4gdGhlIFdlYlByb2Nlc3MgaXMgbm90IHJ1bm5p bmcgdGhlIE5TQXBwbGljYXRpb24gZXZlbnQgbG9vcC4KICAgICAvLyBPdGhlcndpc2UsIGNhbGxp bmcgZW5hYmxlU2FuZGJveFN0eWxlRmlsZVF1YXJhbnRpbmUoKSB3aWxsIGZhaWwuCiAgICAgbGF1 bmNoU2VydmljZXNDaGVja0luKCk7CiAjZW5kaWYKKyNlbmRpZgogICAgIHBsYXRmb3JtSW5pdGlh bGl6ZVByb2Nlc3MocGFyYW1ldGVycyk7CiB9CiAK 336708 2018-03-28 13:27:29 -0700 2018-03-28 14:17:19 -0700 Patch bug-183959-20180328132728.patch text/plain 2100 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzAwMzgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAzLTI4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBZG9wdCBXRUJQUk9DRVNTX1dJ TkRPV1NFUlZFUl9CTE9DS0lORyBjb21waWxlciBndWFyZCBpbiBXZWJQcm9jZXNzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzOTU5CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8zODk2NTcxOT4KKworICAgICAgICBSZXZpZXdlZCBieSBCcmVudCBG dWxnaGFtLgorCisgICAgICAgIFVzZSB0aGUgY29tcGlsZSBndWFyZCB0byBndWFyZCB0aGUgY2Fs bCB0byBDR1NTZXREZW55V2luZG93U2VydmVyQ29ubmVjdGlvbnMuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjppbml0 aWFsaXplUHJvY2Vzcyk6CisKIDIwMTgtMDMtMjggIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBh cHBsZS5jb20+CiAKICAgICAgICAgQXZvaWQgdW5pbml0aWFsaXplZCBtYWNoIHBvcnRzCkluZGV4 OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCShyZXZpc2lvbiAyMzAwMzAp CisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIyNCwxMSArMjI0LDIzIEBAIHZvaWQgV2ViUHJvY2Vzczo6aW5pdGlhbGl6ZVByb2Nl c3MoY29uc3QKIAogICAgIE1lc3NhZ2VQb3J0Q2hhbm5lbFByb3ZpZGVyOjpzZXRTaGFyZWRQcm92 aWRlcihXZWJNZXNzYWdlUG9ydENoYW5uZWxQcm92aWRlcjo6c2luZ2xldG9uKCkpOwogICAgIAot I2lmIFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAx MDE0MDAKKyNpZiBQTEFURk9STShNQUMpCisjaWYgRU5BQkxFKFdFQlBST0NFU1NfV0lORE9XU0VS VkVSX0JMT0NLSU5HKQorICAgIC8vIERlbnkgdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBhY2Nlc3Mg dG8gdGhlIFdpbmRvd1NlcnZlci4KKyAgICAvLyBXZSBjYW5ub3QgY2FsbCBzZXRBcHBsaWNhdGlv bklzRGFlbW9uIGhlcmUsIHNpbmNlIEFjdGl2aXR5IE1vbml0b3Igd2lsbCBub3Qgc2hvdyB0aGUK KyAgICAvLyB1cmwgb2YgdGhlIFdlYkNvbnRlbnQgcHJvY2VzcywgdGhlbi4KKyAgICAvLyBUaGlz IGNhbGwgd2lsbCBub3Qgc3VjY2VlZCBpZiB0aGVyZSBhcmUgb3BlbiBXaW5kb3dTZXJ2ZXIgY29u bmVjdGlvbnMgYXQgdGhpcyBwb2ludC4KKyAgICBDR0Vycm9yIGVycm9yID0gQ0dTU2V0RGVueVdp bmRvd1NlcnZlckNvbm5lY3Rpb25zKHRydWUpOworICAgIEFTU0VSVChlcnJvciA9PSBrQ0dFcnJv clN1Y2Nlc3MpOworICAgIGlmIChlcnJvciAhPSBrQ0dFcnJvclN1Y2Nlc3MpCisgICAgICAgIFdU RkxvZ0Fsd2F5cygiRmFpbGVkIHRvIGRlbnkgV2luZG93U2VydmVyIGNvbm5lY3Rpb25zLCBlcnJv ciA9ICVkIiwgZXJyb3IpOworI2VuZGlmCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCA+PSAxMDE0MDAKICAgICAvLyBUaGlzIGNhbGwgaXMgbmVlZGVkIHdoZW4gdGhlIFdlYlBy b2Nlc3MgaXMgbm90IHJ1bm5pbmcgdGhlIE5TQXBwbGljYXRpb24gZXZlbnQgbG9vcC4KICAgICAv LyBPdGhlcndpc2UsIGNhbGxpbmcgZW5hYmxlU2FuZGJveFN0eWxlRmlsZVF1YXJhbnRpbmUoKSB3 aWxsIGZhaWwuCiAgICAgbGF1bmNoU2VydmljZXNDaGVja0luKCk7CiAjZW5kaWYKKyNlbmRpZgog ICAgIHBsYXRmb3JtSW5pdGlhbGl6ZVByb2Nlc3MocGFyYW1ldGVycyk7CiB9CiAK