183946 2018-03-23 12:15:25 -0700 HTMLElement factory doesn't need to call MediaPlayer::isAvailable 2018-03-23 13:11:58 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer youennf oldest_to_newest 1408815 0 eric.carlson 2018-03-23 12:15:25 -0700 The HTMLVideoElement, HTMLAudioElement, and HTMLTrackElement constructors check both document.settings().mediaEnabled() and MediaPlayer::isAvailable to see if media is disabled. Ports should disable the setting if they don't want media elements, so the later is redundant. 1408816 1 webkit-bug-importer 2018-03-23 12:15:53 -0700 <rdar://problem/38802687> 1408822 2 336403 eric.carlson 2018-03-23 12:21:03 -0700 Created attachment 336403 Patch 1408851 3 336403 commit-queue 2018-03-23 13:11:57 -0700 Comment on attachment 336403 Patch Clearing flags on attachment: 336403 Committed r229915: <https://trac.webkit.org/changeset/229915> 1408852 4 commit-queue 2018-03-23 13:11:58 -0700 All reviewed patches have been landed. Closing bug. 336403 2018-03-23 12:21:03 -0700 2018-03-23 13:11:57 -0700 Patch bug-183946-20180323122103.patch text/plain 5701 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5OTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY5NzM0ODE3MDhmZTU4 YjM0MTc2NjY4OWIzN2ZmYmY5MTI2ZDU5My4uZDdjNmI3NjI5ZmU0OTYwYzc0ZTk0NmEwYTcxN2I0 MjZjZmQ0ZTQxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAzLTIzICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIEhUTUxFbGVtZW50 IGZhY3RvcnkgZG9lc24ndCBuZWVkIHRvIGNhbGwgTWVkaWFQbGF5ZXI6OmlzQXZhaWxhYmxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM5NDYKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4ODAyNjg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL21lZGlhLWRpc2FibGVkLmh0bWwK KworICAgICAgICAqIGRvbS9tYWtlX25hbWVzLnBsOgorICAgICAgICAocHJpbnRDb25zdHJ1Y3Rv ckludGVyaW9yKToKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLnlhbWw6CisgICAgICAgICogcGFn ZS9TZXR0aW5nc0RlZmF1bHRWYWx1ZXMuaDoKKwogMjAxOC0wMy0yMyAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIGxpYndlYnJ0YyBPYmplY3RpdmVDIEgy NjQgZW5jb2RlciBhbmQgZGVjb2RlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL21h a2VfbmFtZXMucGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbAppbmRleCAxYjMw MDAyZWE3OTVhM2YxM2VhNzIzZGViZWUwMDJhMjc0MTQ1MzM3Li5iMWU3NmNmZGExZmE4N2ZlOTk5 ZWZkZTYyNDRiNmQzN2I4MDBjMjBhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vbWFr ZV9uYW1lcy5wbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbApAQCAtNDEy LDcgKzQxMiw3IEBAIHN1YiBwcmludENvbnN0cnVjdG9ySW50ZXJpb3IKICAgICAjIGluc3RlYWQg b2YgaGF2aW5nIGFsbCB0aGUgc3VwcG9ydCBmb3IgdGhpcyBoZXJlIGluIHRoaXMgc2NyaXB0Pwog ICAgIGlmICgkZW5hYmxlZFRhZ3N7JHRhZ05hbWV9e3dyYXBwZXJPbmx5SWZNZWRpYUlzQXZhaWxh YmxlfSkgewogICAgICAgICBwcmludCBGIDw8RU5ECi0gICAgaWYgKCFNZWRpYVBsYXllcjo6aXNB dmFpbGFibGUoKSB8fCAhZG9jdW1lbnQuc2V0dGluZ3MoKS5tZWRpYUVuYWJsZWQoKSkKKyAgICBp ZiAoIWRvY3VtZW50LnNldHRpbmdzKCkubWVkaWFFbmFibGVkKCkpCiAgICAgICAgIHJldHVybiAk cGFyYW1ldGVyc3tmYWxsYmFja0ludGVyZmFjZU5hbWV9OjpjcmVhdGUoJGNvbnN0cnVjdG9yVGFn TmFtZSwgZG9jdW1lbnQpOwogICAgIAogRU5ECmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL1NldHRpbmdzLnlhbWwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLnlhbWwKaW5k ZXggNTM4MWU1M2VkMmNmODYwYWQzN2ZkYjU5YjA0OWJlNjZjNjNhYThkNS4uM2ZhMTAzNDcxNWJm ZDEyMDJhM2E3YTAxOTkxZDFkZjNlNWVjM2M2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9TZXR0aW5ncy55YW1sCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MueWFt bApAQCAtMzI4LDcgKzMyOCw3IEBAIHJlcXVlc3RBbmltYXRpb25GcmFtZUVuYWJsZWQ6CiBjb29r aWVFbmFibGVkOgogICBpbml0aWFsOiB0cnVlCiBtZWRpYUVuYWJsZWQ6Ci0gIGluaXRpYWw6IHRy dWUKKyAgaW5pdGlhbDogZGVmYXVsdE1lZGlhRW5hYmxlZAogRE9NUGFzdGVBbGxvd2VkOgogICBp bml0aWFsOiBmYWxzZQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdz RGVmYXVsdFZhbHVlcy5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5nc0RlZmF1bHRWYWx1 ZXMuaAppbmRleCAzZWE4MTEwY2UzMWMzYzNmMTVkODJjZTBhMDBhOTZiZjRjNzdmYTRhLi4wZjAy MWU5YzY5ZWQ0MTVhNWJlOGQ4OGE2ZWM3ZTUxMTMxZDgzYjRkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1NldHRpbmdzRGVmYXVsdFZhbHVlcy5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvU2V0dGluZ3NEZWZhdWx0VmFsdWVzLmgKQEAgLTk4LDQgKzk4LDEwIEBAIHN0YXRpYyBj b25zdCBib29sIGRlZmF1bHRVbmlmaWVkVGV4dENoZWNrZXJFbmFibGVkID0gZmFsc2U7CiBzdGF0 aWMgY29uc3QgYm9vbCBkZWZhdWx0U21hcnRJbnNlcnREZWxldGVFbmFibGVkID0gdHJ1ZTsKIHN0 YXRpYyBjb25zdCBib29sIGRlZmF1bHRTZWxlY3RUcmFpbGluZ1doaXRlc3BhY2VFbmFibGVkID0g ZmFsc2U7CiAKKyNpZiBFTkFCTEUoVklERU8pICYmIChVU0UoQVZGT1VOREFUSU9OKSB8fCBVU0Uo R1NUUkVBTUVSKSkKK3N0YXRpYyBjb25zdCBib29sIGRlZmF1bHRNZWRpYUVuYWJsZWQgPSB0cnVl OworI2Vsc2UKK3N0YXRpYyBjb25zdCBib29sIGRlZmF1bHRNZWRpYUVuYWJsZWQgPSBmYWxzZTsK KyNlbmRpZgorCiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzMwMGVhOGNlMjc1MGU2Yjk2NzM2ZjNjMjQ4ODFlOWI5OTky NDM1Yy4uZWUwMTZjM2VjOWQ4NDQ1NTU4NWFmMDkxNGMzOGU0ZjdlMGM1ZTdlNyAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDE4LTAzLTIzICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBw bGUuY29tPgorCisgICAgICAgIEhUTUxFbGVtZW50IGZhY3RvcnkgZG9lc24ndCBuZWVkIHRvIGNh bGwgTWVkaWFQbGF5ZXI6OmlzQXZhaWxhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODM5NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4ODAy Njg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog bWVkaWEvbWVkaWEtZGlzYWJsZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRp YS9tZWRpYS1kaXNhYmxlZC5odG1sOiBBZGRlZC4KKwogMjAxOC0wMy0yMyAgUnlhbiBIYWRkYWQg IDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBPbmx5IGVuYWJsZSBMYXlvdXRUZXN0 IGZhc3QvY3NzL2FwcGxlLXN5c3RlbS1jb250cm9sLWNvbG9ycy5odG1sIG9uIG1hY09TLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtZGlzYWJsZWQtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtZGlzYWJsZWQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjU4ZGM2NGQzY2ViYjBjZTU0NWNkN2FiNjA2ZGY1NGRlM2QxZjYwNmMKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1kaXNhYmxlZC1leHBlY3RlZC50eHQKQEAgLTAs MCArMSwxNSBAQAorUlVOKGludGVybmFscy5zZXR0aW5ncy5zZXRNZWRpYUVuYWJsZWQoZmFsc2Up KQorUlVOKHZpZGVvID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidmlkZW8iKSkKK0VYUEVDVEVE ICh2aWRlbyBpbnN0YW5jZW9mIEhUTUxWaWRlb0VsZW1lbnQgPT0gJ2ZhbHNlJykgT0sKK0VYUEVD VEVEICh2aWRlbyBpbnN0YW5jZW9mIEhUTUxVbmtub3duRWxlbWVudCA9PSAndHJ1ZScpIE9LCitS VU4oYXVkaW8gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJhdWRpbyIpKQorRVhQRUNURUQgKGF1 ZGlvIGluc3RhbmNlb2YgSFRNTEF1ZGlvRWxlbWVudCA9PSAnZmFsc2UnKSBPSworRVhQRUNURUQg KGF1ZGlvIGluc3RhbmNlb2YgSFRNTFVua25vd25FbGVtZW50ID09ICd0cnVlJykgT0sKKworUlVO KGludGVybmFscy5zZXR0aW5ncy5zZXRNZWRpYUVuYWJsZWQodHJ1ZSkpCitSVU4odmlkZW8gPSBk b2N1bWVudC5jcmVhdGVFbGVtZW50KCJ2aWRlbyIpKQorRVhQRUNURUQgKHZpZGVvIGluc3RhbmNl b2YgSFRNTFZpZGVvRWxlbWVudCA9PSAndHJ1ZScpIE9LCitSVU4oYXVkaW8gPSBkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJhdWRpbyIpKQorRVhQRUNURUQgKGF1ZGlvIGluc3RhbmNlb2YgSFRNTEF1 ZGlvRWxlbWVudCA9PSAndHJ1ZScpIE9LCitFTkQgT0YgVEVTVAorCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9tZWRpYS9tZWRpYS1kaXNhYmxlZC5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVk aWEtZGlzYWJsZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jMDFiODA5Zjk5NzQ0MGE1OWFiZDUwZDMzMGYw ZmQyYTEwZTRhYTFhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEt ZGlzYWJsZWQuaHRtbApAQCAtMCwwICsxLDM0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGhlYWQ+CisgICAgPHRpdGxlPm1lZGlhLWRpc2FibGVkPC90aXRsZT4KKyAgICA8c2NyaXB0IHNy Yz12aWRlby10ZXN0LmpzPjwvc2NyaXB0PgorICAgIDxzY3JpcHQ+CisgICAgICAgIAorICAgICAg ICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGV2ZW50ID0+IHsKKyAgICAgICAgICAg IHJ1bigiaW50ZXJuYWxzLnNldHRpbmdzLnNldE1lZGlhRW5hYmxlZChmYWxzZSkiKTsKKyAgICAg ICAgICAgIHJ1bigndmlkZW8gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ2aWRlbyIpJyk7Cisg ICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoJ3ZpZGVvIGluc3RhbmNlb2YgSFRNTFZpZGVvRWxlbWVu dCcsIGZhbHNlKTsKKyAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgndmlkZW8gaW5zdGFuY2VvZiBI VE1MVW5rbm93bkVsZW1lbnQnLCB0cnVlKTsKKworICAgICAgICAgICAgcnVuKCdhdWRpbyA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImF1ZGlvIiknKTsKKyAgICAgICAgICAgIHRlc3RFeHBlY3Rl ZCgnYXVkaW8gaW5zdGFuY2VvZiBIVE1MQXVkaW9FbGVtZW50JywgZmFsc2UpOworICAgICAgICAg ICAgdGVzdEV4cGVjdGVkKCdhdWRpbyBpbnN0YW5jZW9mIEhUTUxVbmtub3duRWxlbWVudCcsIHRy dWUpOworCisgICAgICAgICAgICBjb25zb2xlV3JpdGUoIiIpOworICAgICAgICAgICAgcnVuKCJp bnRlcm5hbHMuc2V0dGluZ3Muc2V0TWVkaWFFbmFibGVkKHRydWUpIik7CisgICAgICAgICAgICBy dW4oJ3ZpZGVvID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidmlkZW8iKScpOworICAgICAgICAg ICAgdGVzdEV4cGVjdGVkKCd2aWRlbyBpbnN0YW5jZW9mIEhUTUxWaWRlb0VsZW1lbnQnLCB0cnVl KTsKKworICAgICAgICAgICAgcnVuKCdhdWRpbyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImF1 ZGlvIiknKTsKKyAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgnYXVkaW8gaW5zdGFuY2VvZiBIVE1M QXVkaW9FbGVtZW50JywgdHJ1ZSk7CisKKyAgICAgICAgICAgIGVuZFRlc3QoKTsKKyAgICAgICAg fSk7CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzwvYm9keT4KKzwvaHRtbD4KKwor Cg==