183943 2018-03-23 10:50:18 -0700 Add more support for pointer profiling. 2018-03-23 11:45:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo jfbastien keith_miller msaboff rmorisset saam webkit-bug-importer oldest_to_newest 1408762 0 mark.lam 2018-03-23 10:50:18 -0700 Patch coming. 1408763 1 webkit-bug-importer 2018-03-23 10:51:03 -0700 <rdar://problem/38799068> 1408775 2 336392 mark.lam 2018-03-23 11:14:48 -0700 Created attachment 336392 proposed patch. 1408784 3 336392 jfbastien 2018-03-23 11:25:20 -0700 Comment on attachment 336392 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=336392&action=review r=me > Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:898 > + assertIsTaggedWith(destination.executableAddress(), NearCallPtrTag); This won't be called when doing linking right? I'd expect the pointer to be zero at that point. 1408796 4 336392 mark.lam 2018-03-23 11:43:12 -0700 Comment on attachment 336392 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=336392&action=review >> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:898 >> + assertIsTaggedWith(destination.executableAddress(), NearCallPtrTag); > > This won't be called when doing linking right? I'd expect the pointer to be zero at that point. This is a repatch function. Hence, the destination that we're patching to should never be null. 1408799 5 mark.lam 2018-03-23 11:45:04 -0700 Thanks for the review. Landed in r229911: <http://trac.webkit.org/r229911>. 336392 2018-03-23 11:14:48 -0700 2018-03-23 11:25:20 -0700 proposed patch. bug-183943.patch text/plain 2833 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI5OTA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE4LTAzLTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgbW9yZSBzdXBwb3J0IGZvciBwb2ludGVyIHByb2ZpbGluZy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mzk0MworICAgICAgICA8cmRhcjovL3By b2JsZW0vMzg3OTkwNjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBhc3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaDoKKyAgICAgICAgKEpTQzo6QVJN NjRBc3NlbWJsZXI6OmxpbmtKdW1wT3JDYWxsKToKKyAgICAgICAgKiBhc3NlbWJsZXIvQWJzdHJh Y3RNYWNyb0Fzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpBYnN0cmFjdE1hY3JvQXNzZW1ibGVy OjpyZXBhdGNoTmVhckNhbGwpOgorICAgICAgICAoSlNDOjpBYnN0cmFjdE1hY3JvQXNzZW1ibGVy Ojp0YWdSZXR1cm5BZGRyZXNzKToKKyAgICAgICAgKEpTQzo6QWJzdHJhY3RNYWNyb0Fzc2VtYmxl cjo6dW50YWdSZXR1cm5BZGRyZXNzKToKKwogMjAxOC0wMy0yMyAgWXVzdWtlIFN1enVraSAgPHV0 YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbV1RGXSBBZGQgc3RhbmRhcmQgY29udGFp bmVycyB3aXRoIEZhc3RBbGxvY2F0b3Igc3BlY2lhbGl6YXRpb24KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTTY0QXNzZW1ibGVyLmgJKHJldmlzaW9uIDIy OTkwMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIu aAkod29ya2luZyBjb3B5KQpAQCAtMzAzNCw3ICszMDM0LDkgQEAgcHJvdGVjdGVkOgogICAgICAg ICBBU1NFUlRfVU5VU0VEKGlzQ2FsbCwgKGxpbmsgPT0gaXNDYWxsKSB8fCBkaXNhc3NlbWJsZU5v cChmcm9tKSk7CiAgICAgICAgIEFTU0VSVCghKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KGZy b20pICYgMykpOwogICAgICAgICBBU1NFUlQoIShyZWludGVycHJldF9jYXN0PGludHB0cl90Pih0 bykgJiAzKSk7Ci0gICAgICAgIGludHB0cl90IG9mZnNldCA9IChyZW1vdmVDb2RlUHRyVGFnPGlu dHB0cl90Pih0bykgLSByZW1vdmVDb2RlUHRyVGFnPGludHB0cl90Pihmcm9tSW5zdHJ1Y3Rpb24p KSA+PiAyOworICAgICAgICBhc3NlcnRJc05vdFRhZ2dlZCh0byk7CisgICAgICAgIGFzc2VydElz Tm90VGFnZ2VkKGZyb21JbnN0cnVjdGlvbik7CisgICAgICAgIGludHB0cl90IG9mZnNldCA9IChy ZWludGVycHJldF9jYXN0PGludHB0cl90Pih0bykgLSByZWludGVycHJldF9jYXN0PGludHB0cl90 Pihmcm9tSW5zdHJ1Y3Rpb24pKSA+PiAyOwogICAgICAgICBBU1NFUlQoc3RhdGljX2Nhc3Q8aW50 PihvZmZzZXQpID09IG9mZnNldCk7CiAKICAgICAgICAgaW50IGluc24gPSB1bmNvbmRpdGlvbmFs QnJhbmNoSW1tZWRpYXRlKGlzQ2FsbCwgc3RhdGljX2Nhc3Q8aW50PihvZmZzZXQpKTsKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQWJzdHJhY3RN YWNyb0Fzc2VtYmxlci5oCShyZXZpc2lvbiAyMjk5MDIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL0Fic3RyYWN0TWFjcm9Bc3NlbWJsZXIuaAkod29ya2luZyBjb3B5KQpAQCAt ODk1LDYgKzg5NSw3IEBAIHB1YmxpYzoKIAogICAgIHN0YXRpYyB2b2lkIHJlcGF0Y2hOZWFyQ2Fs bChDb2RlTG9jYXRpb25OZWFyQ2FsbCBuZWFyQ2FsbCwgQ29kZUxvY2F0aW9uTGFiZWwgZGVzdGlu YXRpb24pCiAgICAgeworICAgICAgICBhc3NlcnRJc1RhZ2dlZFdpdGgoZGVzdGluYXRpb24uZXhl Y3V0YWJsZUFkZHJlc3MoKSwgTmVhckNhbGxQdHJUYWcpOwogICAgICAgICBzd2l0Y2ggKG5lYXJD YWxsLmNhbGxNb2RlKCkpIHsKICAgICAgICAgY2FzZSBOZWFyQ2FsbE1vZGU6OlRhaWw6CiAgICAg ICAgICAgICBBc3NlbWJsZXJUeXBlOjpyZWxpbmtKdW1wKG5lYXJDYWxsLmRhdGFMb2NhdGlvbigp LCBkZXN0aW5hdGlvbi5kYXRhTG9jYXRpb24oKSk7CkBAIC05NTMsNiArOTU0LDkgQEAgcHVibGlj OgogICAgICAgICBidWZmZXIuc2V0Q29kZVNpemUodGFyZ2V0Q29kZVNpemUpOwogICAgIH0KIAor ICAgIEFMV0FZU19JTkxJTkUgdm9pZCB0YWdSZXR1cm5BZGRyZXNzKCkgeyB9CisgICAgQUxXQVlT X0lOTElORSB2b2lkIHVudGFnUmV0dXJuQWRkcmVzcygpIHsgfQorCiAgICAgQUxXQVlTX0lOTElO RSB2b2lkIHRhZ1B0cihSZWdpc3RlcklELCBQdHJUYWcpIHsgfQogICAgIEFMV0FZU19JTkxJTkUg dm9pZCB0YWdQdHIoUmVnaXN0ZXJJRCwgUmVnaXN0ZXJJRCkgeyB9CiAgICAgQUxXQVlTX0lOTElO RSB2b2lkIHVudGFnUHRyKFJlZ2lzdGVySUQsIFB0clRhZykgeyB9Cg==