183939 2018-03-23 09:24:58 -0700 dump-class-layout is just wrong 2018-03-26 13:19:41 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 183311 1 jfbastien jfbastien commit-queue dbates jfbastien joepeck lforschler simon.fraser webkit-bug-importer ysuzuki oldest_to_newest 1408719 0 jfbastien 2018-03-23 09:24:58 -0700 Looks like r229291 contained a half-renamed variable in it, so it just doesn't work. 1408720 1 336379 jfbastien 2018-03-23 09:26:34 -0700 Created attachment 336379 patch 1408723 2 336379 ysuzuki 2018-03-23 09:41:24 -0700 Comment on attachment 336379 patch r=me 1408740 3 336379 commit-queue 2018-03-23 10:07:51 -0700 Comment on attachment 336379 patch Clearing flags on attachment: 336379 Committed r229900: <https://trac.webkit.org/changeset/229900> 1408741 4 commit-queue 2018-03-23 10:07:53 -0700 All reviewed patches have been landed. Closing bug. 1408742 5 webkit-bug-importer 2018-03-23 10:08:16 -0700 <rdar://problem/38797356> 1408814 6 simon.fraser 2018-03-23 12:09:16 -0700 Dan was looking at adding tests for this script. 1409389 7 joepeck 2018-03-26 13:19:41 -0700 The title of this bug is misleading. It seems to indicate that the script is wrong, but in reality it just saying that there was a runtime error. 336379 2018-03-23 09:26:34 -0700 2018-03-23 10:07:51 -0700 patch 0001-dump-class-layout-is-just-wrong.patch text/plain 2851 jfbastien RnJvbSBmMmU3NTQyMWMxYzliNTM2YzhkMTQ4NjFmN2I4ZjQ3MjRkZjUwNWJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBGcmksIDIzIE1hciAyMDE4IDA5OjI2OjA4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gZHVtcC1j bGFzcy1sYXlvdXQgaXMganVzdCB3cm9uZwoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgIHwgMTQgKysrKysrKysrKysrKysKIFRvb2xzL1NjcmlwdHMvZHVtcC1jbGFzcy1sYXlv dXQgfCAgOCArKysrLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA0IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxv ZwppbmRleCBlNGRmNDBmLi5mMzhkODE3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysr IGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDMtMjMgIEpGIEJhc3Rp ZW4gIDxqZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIGR1bXAtY2xhc3MtbGF5b3V0IGlz IGp1c3Qgd3JvbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4MzkzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIExvb2tzIGxpa2UgcjIyOTI5MSBjb250YWluZWQgYSBoYWxmLXJlbmFtZWQgdmFyaWFibGUg aW4gaXQsIHNvIGl0CisgICAgICAgIGp1c3QgZG9lc24ndCB3b3JrLgorCisgICAgICAgICogU2Ny aXB0cy9kdW1wLWNsYXNzLWxheW91dDoKKyAgICAgICAgKHZlcmlmeV90eXBlKToKKyAgICAgICAg KHZlcmlmeV90eXBlX3JlY3Vyc2l2ZSk6CisKIDIwMTgtMDMtMjMgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJ1biBKU0Mg R0xpYiBBUEkgdGVzdHMgaW4gR1RLKyBhbmQgV1BFIGJvdHMuCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL2R1bXAtY2xhc3MtbGF5b3V0IGIvVG9vbHMvU2NyaXB0cy9kdW1wLWNsYXNzLWxheW91 dAppbmRleCAwMzc0NDdlLi5kNDE4NjQ0IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2R1bXAt Y2xhc3MtbGF5b3V0CisrKyBiL1Rvb2xzL1NjcmlwdHMvZHVtcC1jbGFzcy1sYXlvdXQKQEAgLTU4 LDggKzU4LDggQEAgZGVmIGltcG9ydF9sbGRiKCk6CiAKIGRlZiB2ZXJpZnlfdHlwZSh0YXJnZXQs IHR5cGUpOgogICAgIHR5cGVuYW1lID0gdHlwZS5HZXROYW1lKCkKLSAgICBzZWVuQmVmb3JlID0g U2V0KCkKLSAgICAoZW5kX29mZnNldCwgcGFkZGluZykgPSB2ZXJpZnlfdHlwZV9yZWN1cnNpdmUo dGFyZ2V0LCB0eXBlLCBOb25lLCAwLCAwLCAwLCBzZWVuQmVmb3JlKQorICAgIHNlZW5PZmZzZXQg PSBTZXQoKQorICAgIChlbmRfb2Zmc2V0LCBwYWRkaW5nKSA9IHZlcmlmeV90eXBlX3JlY3Vyc2l2 ZSh0YXJnZXQsIHR5cGUsIE5vbmUsIDAsIDAsIDAsIHNlZW5PZmZzZXQpCiAgICAgYnl0ZV9zaXpl ID0gdHlwZS5HZXRCeXRlU2l6ZSgpCiAgICAgcHJpbnQgJ1RvdGFsIGJ5dGUgc2l6ZTogJXUnICUg KGJ5dGVfc2l6ZSkKICAgICBwcmludCAnVG90YWwgcGFkIGJ5dGVzOiAldScgJSAocGFkZGluZykK QEAgLTY3LDcgKzY3LDcgQEAgZGVmIHZlcmlmeV90eXBlKHRhcmdldCwgdHlwZSk6CiAgICAgICAg IHByaW50ICdQYWRkaW5nIHBlcmNlbnRhZ2U6ICUyLjJmICUlJyAlICgoZmxvYXQocGFkZGluZykg LyBmbG9hdChieXRlX3NpemUpKSAqIDEwMC4wKQogICAgIHByaW50CiAKLWRlZiB2ZXJpZnlfdHlw ZV9yZWN1cnNpdmUodGFyZ2V0LCB0eXBlLCBtZW1iZXJfbmFtZSwgZGVwdGgsIGJhc2Vfb2Zmc2V0 LCBwYWRkaW5nLCBzZWVuQmVmb3JlKToKK2RlZiB2ZXJpZnlfdHlwZV9yZWN1cnNpdmUodGFyZ2V0 LCB0eXBlLCBtZW1iZXJfbmFtZSwgZGVwdGgsIGJhc2Vfb2Zmc2V0LCBwYWRkaW5nLCBzZWVuT2Zm c2V0KToKICAgICBwcmV2X2VuZF9vZmZzZXQgPSBiYXNlX29mZnNldAogICAgIHR5cGVuYW1lID0g dHlwZS5HZXROYW1lKCkKICAgICBieXRlX3NpemUgPSB0eXBlLkdldEJ5dGVTaXplKCkKQEAgLTEw NSw3ICsxMDUsNyBAQCBkZWYgdmVyaWZ5X3R5cGVfcmVjdXJzaXZlKHRhcmdldCwgdHlwZSwgbWVt YmVyX25hbWUsIGRlcHRoLCBiYXNlX29mZnNldCwgcGFkZGluZwogICAgICAgICAgICAgICAgICAg ICBwcmludCAnJSs0dSA8JTN1PiAlczxQQURESU5HPicgJSAocHJldl9lbmRfb2Zmc2V0LCBtZW1i ZXJfcGFkZGluZywgJyAgICAnICogKGRlcHRoICsgMSkpCiAKICAgICAgICAgICAgIGlmIG1lbWJl cl9pc19jbGFzc19vcl9zdHJ1Y3Q6Ci0gICAgICAgICAgICAgICAgKHByZXZfZW5kX29mZnNldCwg cGFkZGluZykgPSB2ZXJpZnlfdHlwZV9yZWN1cnNpdmUodGFyZ2V0LCBtZW1iZXJfY2Fub25pY2Fs X3R5cGUsIG1lbWJlcl9uYW1lLCBkZXB0aCArIDEsIG1lbWJlcl90b3RhbF9vZmZzZXQsIHBhZGRp bmcsIHNlZW5CZWZvcmUpCisgICAgICAgICAgICAgICAgKHByZXZfZW5kX29mZnNldCwgcGFkZGlu ZykgPSB2ZXJpZnlfdHlwZV9yZWN1cnNpdmUodGFyZ2V0LCBtZW1iZXJfY2Fub25pY2FsX3R5cGUs IG1lbWJlcl9uYW1lLCBkZXB0aCArIDEsIG1lbWJlcl90b3RhbF9vZmZzZXQsIHBhZGRpbmcsIHNl ZW5PZmZzZXQpCiAgICAgICAgICAgICBlbHNlOgogICAgICAgICAgICAgICAgIHByZXZfZW5kX29m ZnNldCA9IG1lbWJlcl90b3RhbF9vZmZzZXQgKyBtZW1iZXJfYnl0ZV9zaXplCiAgICAgICAgICAg ICAgICAgbWVtYmVyX3R5cGVuYW1lID0gbWVtYmVyX3R5cGUuR2V0TmFtZSgpCi0tIAoyLjEwLjEK Cg==