18393 2008-04-09 12:11:06 -0700 Move POST cache policy from platform dependent file 2010-06-10 15:38:37 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All ASSIGNED P2 Normal --- 1 dacarson dacarson oldest_to_newest 77092 0 dacarson 2008-04-09 12:11:06 -0700 The cache policy for POST is set in the file ResourceHandleMac.mm This means that every port of WebKit needs to set the policy in their implementation. 77093 1 20439 dacarson 2008-04-09 12:18:25 -0700 Created attachment 20439 Patch to move cache setting 77377 2 20439 darin 2008-04-12 23:24:21 -0700 Comment on attachment 20439 Patch to move cache setting + Move setting cache policy out of platform dependant implementation. Misspelling of dependent here. // FIXME: Where's the code that implements what the comment above says? + // ANSWER: The cache policy is set in loadItem() This is a bit silly. Lets remove the "FIXME" if there's nothing that needs fixing. if (ResourceHandle::willLoadFromCache(request)) + request.setCachePolicy(ReturnCacheDataDontLoad); action = NavigationAction(itemURL, loadType, false); else { This won't compile unless you add braces. review- because it won't compile. 78806 3 20799 dacarson 2008-04-24 14:28:33 -0700 Created attachment 20799 new patch I was waaay to hasty with the last patch. Attached is a new patch that will compile and corrects the items pointed out in the review. 82637 4 20799 darin 2008-06-08 12:38:33 -0700 Comment on attachment 20799 new patch This patch, as is, breaks the Mac platform. That's because the request sent into sendSynchronousRequest won't have the cache policy set to ReturnCacheDataDontLoad. The rearranged code sets the policy after the call, whereas the old code set it before! I think that the old behavior where the cache policy was set to ReturnCacheDataDontLoad for the navigation itself was actually a bug -- I think the intent was to set it only for the "willLoadFromCache" check itself. review- because we don't want to break the Mac. I won't try to rework this myself, but it should be relatively straightforward. 20439 2008-04-09 12:18:25 -0700 2008-04-24 14:28:33 -0700 Patch to move cache setting patch.txt text/plain 2285 dacarson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMTc1NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDgtMDQtMDkgIERhdmlkIENhcnNvbiAgZGFjYXJzb25AZ21haWwu Y29tCisKKyAgICAgICAgTW92ZSBzZXR0aW5nIGNhY2hlIHBvbGljeSBvdXQgb2YgcGxhdGZvcm0g ZGVwZW5kYW50IGltcGxlbWVudGF0aW9uLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MzkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVMb2FkZXI6OnBvc3QpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6 OmxvYWRJdGVtKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRs ZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjp3aWxsTG9hZEZyb21D YWNoZSk6CisKIDIwMDgtMDQtMDkgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1pdHouCkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShy ZXZpc2lvbiAzMDQwNCkKKysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzIzNiw2ICszMjM2LDcgQEAgdm9pZCBGcmFtZUxvYWRlcjo6cG9zdChjb25z dCBLVVJMJiB1cmwsIAogICAgIC8vIGFzIGFuIGFjdGlvbiB0byBiZSByZXR1cm5lZCBmcm9tIHRo ZSBjYWNoZSB3aXRob3V0IHN1Ym1pdHRpbmcuCiAKICAgICAvLyBGSVhNRTogV2hlcmUncyB0aGUg Y29kZSB0aGF0IGltcGxlbWVudHMgd2hhdCB0aGUgY29tbWVudCBhYm92ZSBzYXlzPworICAgIC8v IEFOU1dFUjogVGhlIGNhY2hlIHBvbGljeSBpcyBzZXQgaW4gbG9hZEl0ZW0oKQogCiAgICAgUmVz b3VyY2VSZXF1ZXN0IHJlcXVlc3QodXJsKTsKICAgICBhZGRFeHRyYUZpZWxkc1RvUmVxdWVzdChy ZXF1ZXN0LCB0cnVlLCB0cnVlKTsKQEAgLTQwNzEsNiArNDA3Miw3IEBAIHZvaWQgRnJhbWVMb2Fk ZXI6OmxvYWRJdGVtKEhpc3RvcnlJdGVtKiAKICAgICAgICAgICAgICAgICAvLyBleHRyZW1lbHkg cmFyZSwgYnV0IGluIHRoYXQgY2FzZSB0aGUgdXNlciB3aWxsIGdldCBhbiBlcnJvciBvbiB0aGUg bmF2aWdhdGlvbi4KICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBpZiAoUmVzb3Vy Y2VIYW5kbGU6OndpbGxMb2FkRnJvbUNhY2hlKHJlcXVlc3QpKQorICAgICAgICAgICAgICAgICAg ICByZXF1ZXN0LnNldENhY2hlUG9saWN5KFJldHVybkNhY2hlRGF0YURvbnRMb2FkKTsKICAgICAg ICAgICAgICAgICAgICAgYWN0aW9uID0gTmF2aWdhdGlvbkFjdGlvbihpdGVtVVJMLCBsb2FkVHlw ZSwgZmFsc2UpOwogICAgICAgICAgICAgICAgIGVsc2UgewogICAgICAgICAgICAgICAgICAgICBy ZXF1ZXN0LnNldENhY2hlUG9saWN5KFJlbG9hZElnbm9yaW5nQ2FjaGVEYXRhKTsKSW5kZXg6IFdl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5tbQko cmV2aXNpb24gMzE3NTUpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNl SGFuZGxlTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yOTAsNyArMjkwLDYgQEAgYm9vbCBSZXNv dXJjZUhhbmRsZTo6bG9hZHNCbG9ja2VkKCkKIAogYm9vbCBSZXNvdXJjZUhhbmRsZTo6d2lsbExv YWRGcm9tQ2FjaGUoUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0KQogewotICAgIHJlcXVlc3Quc2V0 Q2FjaGVQb2xpY3koUmV0dXJuQ2FjaGVEYXRhRG9udExvYWQpOwogICAgIE5TVVJMUmVzcG9uc2Ug Km5zVVJMUmVzcG9uc2UgPSBuaWw7CiAgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOwog ICAgIAo= 20799 2008-04-24 14:28:33 -0700 2010-06-10 15:38:37 -0700 new patch patch.txt text/plain 2780 dacarson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMjUxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDgtMDQtMjQgIERhdmlkIENhcnNvbiAgZGFjYXJzb25AZ21haWwu Y29tCisKKyAgICAgICAgTW92ZSBzZXR0aW5nIGNhY2hlIHBvbGljeSBvdXQgb2YgcGxhdGZvcm0g ZGVwZW5kZW50IGltcGxlbWVudGF0aW9uLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MzkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVMb2FkZXI6OnBvc3QpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6 OmxvYWRJdGVtKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRs ZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjp3aWxsTG9hZEZyb21D YWNoZSk6CisKIDIwMDgtMDQtMjQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNv bT4KIAogICAgICAgICBEb24ndCBjcmFzaCB3aGVuIHRoZSBzdHJpbmcgaXMgZW1wdHkuCkluZGV4 OiBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZpc2lvbiAzMjUxNikKKysrIFdlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzM0OSw4ICszMzQ5LDcgQEAgdm9p ZCBGcmFtZUxvYWRlcjo6cG9zdChjb25zdCBLVVJMJiB1cmwsIAogICAgIC8vIFdoZW4gcG9zdGlu ZywgdXNlIHRoZSBOU1VSTFJlcXVlc3RSZWxvYWRJZ25vcmluZ0NhY2hlRGF0YSBsb2FkIGZsYWcu CiAgICAgLy8gVGhpcyBwcmV2ZW50cyBhIHBvdGVudGlhbCBidWcgd2hpY2ggbWF5IGNhdXNlIGEg cGFnZSB3aXRoIGEgZm9ybSB0aGF0IHVzZXMgaXRzZWxmCiAgICAgLy8gYXMgYW4gYWN0aW9uIHRv IGJlIHJldHVybmVkIGZyb20gdGhlIGNhY2hlIHdpdGhvdXQgc3VibWl0dGluZy4KLQotICAgIC8v IEZJWE1FOiBXaGVyZSdzIHRoZSBjb2RlIHRoYXQgaW1wbGVtZW50cyB3aGF0IHRoZSBjb21tZW50 IGFib3ZlIHNheXM/CisgICAgLy8gU2V0dGluZyB0aGlzIGxvYWQgZmxhZyBpcyBwZXJmb3JtZWQg aW4gbG9hZEl0ZW0oKQogCiAgICAgUmVzb3VyY2VSZXF1ZXN0IHJlcXVlc3QodXJsKTsKICAgICBh ZGRFeHRyYUZpZWxkc1RvUmVxdWVzdChyZXF1ZXN0LCB0cnVlLCB0cnVlKTsKQEAgLTQxOTksOSAr NDE5OCwxMCBAQCB2b2lkIEZyYW1lTG9hZGVyOjpsb2FkSXRlbShIaXN0b3J5SXRlbSogCiAgICAg ICAgICAgICAgICAgLy8gaGF2ZSB0aGUgaXRlbSB2YW5pc2ggd2hlbiB3ZSB0cnkgdG8gdXNlIGl0 IGluIHRoZSBlbnN1aW5nIG5hdi4gIFRoaXMgc2hvdWxkIGJlCiAgICAgICAgICAgICAgICAgLy8g ZXh0cmVtZWx5IHJhcmUsIGJ1dCBpbiB0aGF0IGNhc2UgdGhlIHVzZXIgd2lsbCBnZXQgYW4gZXJy b3Igb24gdGhlIG5hdmlnYXRpb24uCiAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAg aWYgKFJlc291cmNlSGFuZGxlOjp3aWxsTG9hZEZyb21DYWNoZShyZXF1ZXN0KSkKKyAgICAgICAg ICAgICAgICBpZiAoUmVzb3VyY2VIYW5kbGU6OndpbGxMb2FkRnJvbUNhY2hlKHJlcXVlc3QpKSB7 CisgICAgICAgICAgICAgICAgICAgIHJlcXVlc3Quc2V0Q2FjaGVQb2xpY3koUmV0dXJuQ2FjaGVE YXRhRG9udExvYWQpOwogICAgICAgICAgICAgICAgICAgICBhY3Rpb24gPSBOYXZpZ2F0aW9uQWN0 aW9uKGl0ZW1VUkwsIGxvYWRUeXBlLCBmYWxzZSk7Ci0gICAgICAgICAgICAgICAgZWxzZSB7Cisg ICAgICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICAgICAgcmVxdWVzdC5zZXRD YWNoZVBvbGljeShSZWxvYWRJZ25vcmluZ0NhY2hlRGF0YSk7CiAgICAgICAgICAgICAgICAgICAg IGFjdGlvbiA9IE5hdmlnYXRpb25BY3Rpb24oaXRlbVVSTCwgTmF2aWdhdGlvblR5cGVGb3JtUmVz dWJtaXR0ZWQpOwogICAgICAgICAgICAgICAgIH0KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5tbQkocmV2aXNpb24gMzI1MTYpCisr KyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC0yOTAsNyArMjkwLDYgQEAgYm9vbCBSZXNvdXJjZUhhbmRsZTo6bG9hZHNC bG9ja2VkKCkKIAogYm9vbCBSZXNvdXJjZUhhbmRsZTo6d2lsbExvYWRGcm9tQ2FjaGUoUmVzb3Vy Y2VSZXF1ZXN0JiByZXF1ZXN0KQogewotICAgIHJlcXVlc3Quc2V0Q2FjaGVQb2xpY3koUmV0dXJu Q2FjaGVEYXRhRG9udExvYWQpOwogICAgIE5TVVJMUmVzcG9uc2UgKm5zVVJMUmVzcG9uc2UgPSBu aWw7CiAgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOwogICAgIAo=