<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>183926</bug_id>
          
          <creation_ts>2018-03-22 18:05:14 -0700</creation_ts>
          <short_desc>[GTK] Unresolved type warnings when generating gir</short_desc>
          <delta_ts>2018-03-25 23:49:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>berto</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gustavo</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1408573</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-03-22 18:05:14 -0700</bug_when>
    <thetext>[1279/1387] Generating ../../WebKit2-4.0.gir
Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:89: Warning: WebKit2: webkit_javascript_result_get_global_context: return value: Unresolved type: u&apos;JSGlobalContextRef&apos;
Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:106: Warning: WebKit2: webkit_javascript_result_get_value: return value: Unresolved type: u&apos;JSValueRef&apos;
Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:3258: Warning: WebKit2: webkit_web_view_get_javascript_global_context: return value: Unresolved type: u&apos;JSGlobalContextRef&apos;
[1298/1387] Generating ../../WebKit2WebExtension-4.0.gir
Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp:102: Warning: WebKit2WebExtension: webkit_frame_get_javascript_global_context: return value: Unresolved type: u&apos;JSGlobalContextRef&apos;
Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp:122: Warning: WebKit2WebExtension: webkit_frame_get_javascript_context_for_script_world: return value: Unresolved type: u&apos;JSGlobalContextRef&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1408634</commentid>
    <comment_count>1</comment_count>
      <attachid>336358</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-03-23 01:23:16 -0700</bug_when>
    <thetext>Created attachment 336358
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1408635</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2018-03-23 01:24:47 -0700</bug_when>
    <thetext>Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1409257</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-03-25 23:49:03 -0700</bug_when>
    <thetext>Committed r229970: &lt;https://trac.webkit.org/changeset/229970&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>336358</attachid>
            <date>2018-03-23 01:23:16 -0700</date>
            <delta_ts>2018-03-23 09:49:56 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk2-gi-warnings.diff</filename>
            <type>text/plain</type>
            <size>3290</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu
Z2VMb2cKaW5kZXggOTk1ZGI3OTExNzIuLmFjODAyZmZiMDYwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx
LDE2IEBACisyMDE4LTAzLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh
LmNvbT4KKworICAgICAgICBbR1RLXSBVbnJlc29sdmVkIHR5cGUgd2FybmluZ3Mgd2hlbiBnZW5l
cmF0aW5nIGdpcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTgzOTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgU2tpcCBkZXByZWNhdGVkIGZ1bmN0aW9ucyB1c2luZyBKU0MgQyBBUEkgZnJvbSBpbnRyb3Nw
ZWN0aW9uLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdEphdmFzY3JpcHRS
ZXN1bHQuY3BwOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNw
cDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9nbGliL1dlYktpdEZy
YW1lLmNwcDoKKwogMjAxOC0wMy0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln
YWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBBZGQgQVBJIHRvIGNvbnZlcnQgYmV0d2Vl
biBET00gYW5kIEpTQ1ZhbHVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B
UEkvZ2xpYi9XZWJLaXRKYXZhc2NyaXB0UmVzdWx0LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL0FQSS9nbGliL1dlYktpdEphdmFzY3JpcHRSZXN1bHQuY3BwCmluZGV4IDEwYmIxMTJiMWJh
Li4xNGY3ZDYzY2E1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2ds
aWIvV2ViS2l0SmF2YXNjcmlwdFJlc3VsdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl
c3MvQVBJL2dsaWIvV2ViS2l0SmF2YXNjcmlwdFJlc3VsdC5jcHAKQEAgLTgwLDcgKzgwLDcgQEAg
dm9pZCB3ZWJraXRfamF2YXNjcmlwdF9yZXN1bHRfdW5yZWYoV2ViS2l0SmF2YXNjcmlwdFJlc3Vs
dCogamF2YXNjcmlwdFJlc3VsdCkKIAogI2lmIFBMQVRGT1JNKEdUSykKIC8qKgotICogd2Via2l0
X2phdmFzY3JpcHRfcmVzdWx0X2dldF9nbG9iYWxfY29udGV4dDoKKyAqIHdlYmtpdF9qYXZhc2Ny
aXB0X3Jlc3VsdF9nZXRfZ2xvYmFsX2NvbnRleHQ6IChza2lwKQogICogQGpzX3Jlc3VsdDogYSAj
V2ViS2l0SmF2YXNjcmlwdFJlc3VsdAogICoKICAqIEdldCB0aGUgZ2xvYmFsIEphdmFzY3JpcHQg
Y29udGV4dCB0aGF0IHNob3VsZCBiZSB1c2VkIHdpdGggdGhlCkBAIC05Nyw3ICs5Nyw3IEBAIEpT
R2xvYmFsQ29udGV4dFJlZiB3ZWJraXRfamF2YXNjcmlwdF9yZXN1bHRfZ2V0X2dsb2JhbF9jb250
ZXh0KFdlYktpdEphdmFzY3JpcHRSCiB9CiAKIC8qKgotICogd2Via2l0X2phdmFzY3JpcHRfcmVz
dWx0X2dldF92YWx1ZToKKyAqIHdlYmtpdF9qYXZhc2NyaXB0X3Jlc3VsdF9nZXRfdmFsdWU6IChz
a2lwKQogICogQGpzX3Jlc3VsdDogYSAjV2ViS2l0SmF2YXNjcmlwdFJlc3VsdAogICoKICAqIEdl
dCB0aGUgdmFsdWUgb2YgQGpzX3Jlc3VsdC4gWW91IHNob3VsZCB1c2UgdGhlIDxmdW5jdGlvbj5K
U0dsb2JhbENvbnRleHRSZWY8L2Z1bmN0aW9uPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V
SVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNwcAppbmRleCBhMjdmOWVjMzE5Mi4uNTc1YTBm
NzJlYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktp
dFdlYlZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktp
dFdlYlZpZXcuY3BwCkBAIC0zMjQ5LDcgKzMyNDksNyBAQCBXZWJLaXRGaW5kQ29udHJvbGxlciog
d2Via2l0X3dlYl92aWV3X2dldF9maW5kX2NvbnRyb2xsZXIoV2ViS2l0V2ViVmlldyogd2ViVmll
dwogCiAjaWYgUExBVEZPUk0oR1RLKQogLyoqCi0gKiB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2phdmFz
Y3JpcHRfZ2xvYmFsX2NvbnRleHQ6CisgKiB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2phdmFzY3JpcHRf
Z2xvYmFsX2NvbnRleHQ6IChza2lwKQogICogQHdlYl92aWV3OiBhICNXZWJLaXRXZWJWaWV3CiAg
KgogICogR2V0IHRoZSBnbG9iYWwgSmF2YVNjcmlwdCBjb250ZXh0IHVzZWQgYnkgQHdlYl92aWV3
IHRvIGRlc2VyaWFsaXplIHRoZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz
L0luamVjdGVkQnVuZGxlL0FQSS9nbGliL1dlYktpdEZyYW1lLmNwcCBiL1NvdXJjZS9XZWJLaXQv
V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ2xpYi9XZWJLaXRGcmFtZS5jcHAKaW5kZXgg
M2EyODJhZWQ4YWUuLjIxYTNmNjM2ZTJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlBy
b2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2dsaWIvV2ViS2l0RnJhbWUuY3BwCisrKyBiL1NvdXJj
ZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ2xpYi9XZWJLaXRGcmFtZS5j
cHAKQEAgLTk4LDcgKzk4LDcgQEAgY29uc3QgZ2NoYXIqIHdlYmtpdF9mcmFtZV9nZXRfdXJpKFdl
YktpdEZyYW1lKiBmcmFtZSkKIAogI2lmIFBMQVRGT1JNKEdUSykKIC8qKgotICogd2Via2l0X2Zy
YW1lX2dldF9qYXZhc2NyaXB0X2dsb2JhbF9jb250ZXh0OgorICogd2Via2l0X2ZyYW1lX2dldF9q
YXZhc2NyaXB0X2dsb2JhbF9jb250ZXh0OiAoc2tpcCkKICAqIEBmcmFtZTogYSAjV2ViS2l0RnJh
bWUKICAqCiAgKiBHZXRzIHRoZSBnbG9iYWwgSmF2YVNjcmlwdCBleGVjdXRpb24gY29udGV4dC4g
VXNlIHRoaXMgZnVuY3Rpb24gdG8gYnJpZGdlCkBAIC0xMTgsNyArMTE4LDcgQEAgSlNHbG9iYWxD
b250ZXh0UmVmIHdlYmtpdF9mcmFtZV9nZXRfamF2YXNjcmlwdF9nbG9iYWxfY29udGV4dChXZWJL
aXRGcmFtZSogZnJhbWUKIH0KIAogLyoqCi0gKiB3ZWJraXRfZnJhbWVfZ2V0X2phdmFzY3JpcHRf
Y29udGV4dF9mb3Jfc2NyaXB0X3dvcmxkOgorICogd2Via2l0X2ZyYW1lX2dldF9qYXZhc2NyaXB0
X2NvbnRleHRfZm9yX3NjcmlwdF93b3JsZDogKHNraXApCiAgKiBAZnJhbWU6IGEgI1dlYktpdEZy
YW1lCiAgKiBAd29ybGQ6IGEgI1dlYktpdFNjcmlwdFdvcmxkCiAgKgo=
</data>
<flag name="review"
          id="354876"
          type_id="1"
          status="+"
          setter="mcatanzaro"
    />
          </attachment>
      

    </bug>

</bugzilla>