183921 2018-03-22 15:52:19 -0700 Use the same SWServer for all ephemeral sessions 2018-06-01 16:15:47 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186205 1 cdumez cdumez beidson commit-queue rniwa webkit-bug-importer youennf oldest_to_newest 1408518 0 cdumez 2018-03-22 15:52:19 -0700 Use the same SWServer for all ephemeral sessions. SWServers never go away and we create one per sessionID. When browsing doing private browsing in Safari (and other fetching favorite icons), the sessionID is ephemeral and keeps changing. This means that we kept constructing new SWServers that would never go away. Each SWServer has a thread so we would eventually hit the thread limit for the storage process. 1408519 1 cdumez 2018-03-22 15:52:37 -0700 <rdar://problem/36873075> 1408520 2 336319 cdumez 2018-03-22 15:53:58 -0700 Created attachment 336319 Patch 1408535 3 336319 beidson 2018-03-22 16:31:30 -0700 Comment on attachment 336319 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336319&action=review Not going to r-, but I do have one nit > Source/WebKit/StorageProcess/StorageProcess.cpp:438 > + // Use the same SWServer for all ephemeral sessions. > + if (sessionID.isEphemeral()) > + sessionID = PAL::SessionID::legacyPrivateSessionID(); We eventually want legacyPrivateSessionID() to go away. So it would be nicer if we had some sort of shared "global ephemeral SWServer session ID" But we can also do that later when we get rid of the legacy one. 1408560 4 336319 commit-queue 2018-03-22 17:01:00 -0700 Comment on attachment 336319 Patch Clearing flags on attachment: 336319 Committed r229872: <https://trac.webkit.org/changeset/229872> 1408561 5 commit-queue 2018-03-22 17:01:01 -0700 All reviewed patches have been landed. Closing bug. 336319 2018-03-22 15:53:58 -0700 2018-03-22 17:01:00 -0700 Patch bug-183921-20180322155358.patch text/plain 1997 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5ODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ0NzJlNjIxMWZlYTVlNTJm MDhkNzczZGZmMWE5Yjk3NGZjMzc2YTYuLjhlZjRjOWEwNTNlZDY1NTQ2YTU1Y2NiYmRkYmIxZWJm NzhiMzZiNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDMtMjIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgdGhlIHNhbWUgU1dTZXJ2ZXIg Zm9yIGFsbCBlcGhlbWVyYWwgc2Vzc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4MzkyMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzY4NzMw NzU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IHRoZSBzYW1lIFNXU2VydmVyIGZvciBhbGwgZXBoZW1lcmFsIHNlc3Npb25zLiBTV1NlcnZlcnMg bmV2ZXIgZ28gYXdheSBhbmQgd2UgY3JlYXRlCisgICAgICAgIG9uZSBwZXIgc2Vzc2lvbklELiBX aGVuIGJyb3dzaW5nIGRvaW5nIHByaXZhdGUgYnJvd3NpbmcgaW4gU2FmYXJpIChhbmQgb3RoZXIg ZmV0Y2hpbmcKKyAgICAgICAgZmF2b3JpdGUgaWNvbnMpLCB0aGUgc2Vzc2lvbklEIGlzIGVwaGVt ZXJhbCBhbmQga2VlcHMgY2hhbmdpbmcuIFRoaXMgbWVhbnMgdGhhdCB3ZSBrZXB0CisgICAgICAg IGNvbnN0cnVjdGluZyBuZXcgU1dTZXJ2ZXJzIHRoYXQgd291bGQgbmV2ZXIgZ28gYXdheS4gRWFj aCBTV1NlcnZlciBoYXMgYSB0aHJlYWQgc28gd2UKKyAgICAgICAgd291bGQgZXZlbnR1YWxseSBo aXQgdGhlIHRocmVhZCBsaW1pdCBmb3IgdGhlIHN0b3JhZ2UgcHJvY2Vzcy4KKworICAgICAgICAq IFN0b3JhZ2VQcm9jZXNzL1N0b3JhZ2VQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6U3Rv cmFnZVByb2Nlc3M6OnN3U2VydmVyRm9yU2Vzc2lvbik6CisKIDIwMTgtMDMtMjIgIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtUZXhNYXBdIE1ha2UgVGV4 dHVyZU1hcHBlckNvbnRleHRBdHRyaWJ1dGVzIHRocmVhZC1zcGVjaWZpYwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9TdG9yYWdlUHJvY2Vzcy9TdG9yYWdlUHJvY2Vzcy5jcHAgYi9Tb3VyY2Uv V2ViS2l0L1N0b3JhZ2VQcm9jZXNzL1N0b3JhZ2VQcm9jZXNzLmNwcAppbmRleCBlMDFiYmI0M2U5 YzdiZGFmZmJkYWM4YjExZjE1MzM5NmE4NWJjYzhkLi5iZDFhZDUwYTgxZjRhNTNlOTIxZGUxYWMz ZGQ4OTBlZGIxNWY4ODI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1N0b3JhZ2VQcm9jZXNz L1N0b3JhZ2VQcm9jZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1N0b3JhZ2VQcm9jZXNzL1N0 b3JhZ2VQcm9jZXNzLmNwcApAQCAtNDMyLDYgKzQzMiwxMSBAQCB2b2lkIFN0b3JhZ2VQcm9jZXNz OjpkaWRHZXRTYW5kYm94RXh0ZW5zaW9uc0ZvckJsb2JGaWxlcyh1aW50NjRfdCByZXF1ZXN0SUQs IFNhbgogU1dTZXJ2ZXImIFN0b3JhZ2VQcm9jZXNzOjpzd1NlcnZlckZvclNlc3Npb24oUEFMOjpT ZXNzaW9uSUQgc2Vzc2lvbklEKQogewogICAgIEFTU0VSVChzZXNzaW9uSUQuaXNWYWxpZCgpKTsK KworICAgIC8vIFVzZSB0aGUgc2FtZSBTV1NlcnZlciBmb3IgYWxsIGVwaGVtZXJhbCBzZXNzaW9u cy4KKyAgICBpZiAoc2Vzc2lvbklELmlzRXBoZW1lcmFsKCkpCisgICAgICAgIHNlc3Npb25JRCA9 IFBBTDo6U2Vzc2lvbklEOjpsZWdhY3lQcml2YXRlU2Vzc2lvbklEKCk7CisKICAgICBhdXRvIHJl c3VsdCA9IG1fc3dTZXJ2ZXJzLmFkZChzZXNzaW9uSUQsIG51bGxwdHIpOwogICAgIGlmICghcmVz dWx0LmlzTmV3RW50cnkpIHsKICAgICAgICAgQVNTRVJUKHJlc3VsdC5pdGVyYXRvci0+dmFsdWUp Owo=