183896 2018-03-22 05:30:44 -0700 [WPE][GTK] Build failure when ENABLE_VIDEO, ENABLE_WEB_AUDIO and ENABLE_XSLT are disabled 2018-03-22 06:48:40 -0700 1 1 1 Unclassified WebKit WPE WebKit Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez bugs-noreply clopez commit-queue dino graouts mcatanzaro ysuzuki zan oldest_to_newest 1408336 0 aperez 2018-03-22 05:30:44 -0700 This can be reproduced with the following commands: % cd path/to/WebKit % mkdir build && cd $_ % cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DDEVELOPER_MODE=ON \ -DCMAKE_INSTALL_PREFIX=$JHENV -DENABLE_VIDEO=OFF \ -DENABLE_WEB_AUDIO=OFF -DENABLE_XSLT=OFF -DPORT=WPE \ -G Ninja .. % ninja The build error is as follows, I think that DEVELOPER_MODE is not really the culprit: In file included from /usr/include/c++/7.3.1/bits/move.h:54:0, from /usr/include/c++/7.3.1/bits/nested_exception.h:40, from /usr/include/c++/7.3.1/exception:143, from /usr/include/c++/7.3.1/new:40, from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:24, from ../Source/WebCore/config.h:55, from ../Source/WebCore/bindings/js/JSTextTrackListCustom.cpp:26, from DerivedSources/WebCore/unified-sources/UnifiedSource169.cpp:1: /usr/include/c++/7.3.1/type_traits: In instantiation of ‘struct std::is_base_of<WebCore::ScriptExecutionContext, WebCore::Document>’: DerivedSources/ForwardingHeaders/wtf/TypeCasts.h:82:80: required from ‘typename WTF::match_constness<Source, Target>::type& WTF::downcast(Source&) [with Target = WebCore::Document; Source = WebCore::ScriptExecutionContext; typename WTF::match_constness<Source, Target>::type = WebCore::Document]’ ../Source/WebCore/bindings/js/JSWebAnimationCustom.cpp:63:49: required from here /usr/include/c++/7.3.1/type_traits:1512:12: error: invalid use of incomplete type ‘class WebCore::Document’ struct is_base_of ^~~~~~~~~~ In file included from ../Source/WebCore/dom/Node.h:33:0, from ../Source/WebCore/bindings/js/JSTreeWalkerCustom.cpp:23, from DerivedSources/WebCore/unified-sources/UnifiedSource169.cpp:3: ../Source/WebCore/dom/TreeScope.h:38:7: note: forward declaration of ‘class WebCore::Document’ class Document; ^~~~~~~~ In file included from DerivedSources/ForwardingHeaders/wtf/Ref.h:34:0, from DerivedSources/ForwardingHeaders/wtf/VectorTraits.h:24, from DerivedSources/ForwardingHeaders/wtf/Vector.h:38, from DerivedSources/ForwardingHeaders/wtf/text/StringImpl.h:32, from DerivedSources/ForwardingHeaders/wtf/text/UniquedStringImpl.h:29, from DerivedSources/ForwardingHeaders/wtf/text/SymbolImpl.h:28, from DerivedSources/ForwardingHeaders/JavaScriptCore/PrivateName.h:28, from DerivedSources/ForwardingHeaders/JavaScriptCore/Identifier.h:23, from DerivedSources/WebCore/JSDOMBindingInternalsBuiltins.h:34, from DerivedSources/WebCore/WebCoreJSBuiltinInternals.h:39, from ../Source/WebCore/bindings/js/JSDOMGlobalObject.h:29, from ../Source/WebCore/bindings/js/JSDOMWrapper.h:24, from DerivedSources/WebCore/JSTreeWalker.h:23, from ../Source/WebCore/bindings/js/JSTreeWalkerCustom.cpp:21, from DerivedSources/WebCore/unified-sources/UnifiedSource169.cpp:3: DerivedSources/ForwardingHeaders/wtf/TypeCasts.h: In instantiation of ‘typename WTF::match_constness<Source, Target>::type& WTF::downcast(Source&) [with Target = WebCore::Document; Source = WebCore::ScriptExecutionContext; typename WTF::match_constness<Source, Target>::type = WebCore::Document]’: ../Source/WebCore/bindings/js/JSWebAnimationCustom.cpp:63:49: required from here DerivedSources/ForwardingHeaders/wtf/TypeCasts.h:82:80: error: ‘value’ is not a member of ‘std::is_base_of<WebCore::ScriptExecutionContext, WebCore::Document>’ return static_cast<typename match_constness<Source, Target>::type&>(source); ^ DerivedSources/ForwardingHeaders/wtf/TypeCasts.h:82:12: error: invalid static_cast from type ‘WebCore::ScriptExecutionContext’ to type ‘WTF::match_constness<WebCore::ScriptExecutionContext, WebCore::Document>::type& {aka WebCore::Document&}’ return static_cast<typename match_constness<Source, Target>::type&>(source); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1408337 1 336276 aperez 2018-03-22 05:33:58 -0700 Created attachment 336276 Patch 1408339 2 336276 ysuzuki 2018-03-22 06:23:42 -0700 Comment on attachment 336276 Patch r=me 1408340 3 336276 commit-queue 2018-03-22 06:48:38 -0700 Comment on attachment 336276 Patch Clearing flags on attachment: 336276 Committed r229848: <https://trac.webkit.org/changeset/229848> 1408341 4 commit-queue 2018-03-22 06:48:40 -0700 All reviewed patches have been landed. Closing bug. 336276 2018-03-22 05:33:58 -0700 2018-03-22 06:48:38 -0700 Patch bug-183896-20180322123357.patch text/plain 1309 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY0ZmZlNDk5YTgwMzY0 N2VjMmQxNGNkOGVlNjg4YTU1NGNhMmNkZi4uNTY0MDkzYzhhMDViYWQ3MGViNjU5ZWI1Nzc5ZmRm MTg0ODExYzE0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTAzLTIyICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV1b R1RLXSBCdWlsZCBmYWlsdXJlIHdoZW4gRU5BQkxFX1ZJREVPLCBFTkFCTEVfV0VCX0FVRElPIGFu ZCBFTkFCTEVfWFNMVCBhcmUgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4Mzg5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBiaW5k aW5ncy9qcy9KU1dlYkFuaW1hdGlvbkN1c3RvbS5jcHA6IEFkZCBtaXNzaW5nICNpbmNsdWRlIG9m IERvY3VtZW50LmgKKwogMjAxOC0wMy0yMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjIyOTgyOCk6IFdlYktpdC5Ob0hpc3RvcnlJdGVtU2Ny b2xsVG9GcmFnbWVudCBBUEkgdGVzdCBpcyBmYWlsaW5nIG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXZWJBbmltYXRpb25DdXN0b20uY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNXZWJBbmltYXRpb25DdXN0b20uY3BwCmluZGV4IGFlOTUz MTJhZThlNTcxYWZmMzBhMDMwY2YzZWM2ZDljMzlmMzk0MTMuLjQ1MWZhNDE2MWU2YTU5Y2MyYjMx NDQwYjMwMWE5OTcwMzQ4NWU4Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTV2ViQW5pbWF0aW9uQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU1dlYkFuaW1hdGlvbkN1c3RvbS5jcHAKQEAgLTI2LDYgKzI2LDcgQEAKICNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJKU1dlYkFuaW1hdGlvbi5oIgogCisjaW5jbHVkZSAiRG9j dW1lbnQuaCIKICNpbmNsdWRlICJKU0FuaW1hdGlvbkVmZmVjdFJlYWRPbmx5LmgiCiAjaW5jbHVk ZSAiSlNBbmltYXRpb25UaW1lbGluZS5oIgogI2luY2x1ZGUgIkpTQ1NTQW5pbWF0aW9uLmgiCg==