18383 2008-04-09 06:53:06 -0700 [GTK] The "hovering-over-link" signal arguments aren't documented. 2008-05-30 07:17:53 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Trivial --- 1 carlos webkit-unassigned jmalonzo oldest_to_newest 76718 0 carlos 2008-04-09 06:53:06 -0700 As the title says, the arguments passed to the "hovering-over-link" signal callback aren't documented and you have to grep the source to figure out the order. This patch documents it. I can't see any option to attach the patch, so I'm posting it inline. I hope it doesn't get scrambled. Index: WebKit/gtk/webkit/webkitwebview.cpp =================================================================== --- WebKit/gtk/webkit/webkitwebview.cpp (revision 31670) +++ WebKit/gtk/webkit/webkitwebview.cpp (working copy) @@ -781,6 +781,14 @@ WEBKIT_TYPE_WEB_FRAME, G_TYPE_STRING); + /** + * WebKitWebView::hovering-over-link: + * @web_view: the object on which the signal is emitted + * @title: the link's title + * @uri: the URI the link points to + * + * When the cursor is over a link, this signal is emitted. + */ webkit_web_view_signals[HOVERING_OVER_LINK] = g_signal_new("hovering-over-link", G_TYPE_FROM_CLASS(webViewClass), (GSignalFlags)(G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION), 76719 1 20429 carlos 2008-04-09 06:55:19 -0700 Created attachment 20429 Document the "hoving-over-link" signal arguments. Here is the upload. I think the inline one is damaged. 81525 2 jmalonzo 2008-05-26 05:35:51 -0700 Hi Carlos Thanks for the patch. Can you please set the "Attachment Flags" to "r?", setting it for review so reviewers can review it? Thanks. 81527 3 carlos 2008-05-26 08:15:17 -0700 Done. Thanks for telling me, I didn't know I had to do that. 81929 4 jmalonzo 2008-05-30 07:17:53 -0700 Landed in r34263 20429 2008-04-09 06:55:19 -0700 2008-05-29 09:20:59 -0700 Document the "hoving-over-link" signal arguments. webkit-hover-link.patch text/plain 777 carlos SW5kZXg6IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCShyZXZpc2lvbiAzMTY3MCkKKysr IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03 ODEsNiArNzgxLDE0IEBACiAgICAgICAgICAgICBXRUJLSVRfVFlQRV9XRUJfRlJBTUUsCiAgICAg ICAgICAgICBHX1RZUEVfU1RSSU5HKTsKIAorICAgIC8qKgorICAgICAqIFdlYktpdFdlYlZpZXc6 OmhvdmVyaW5nLW92ZXItbGluazoKKyAgICAgKiBAd2ViX3ZpZXc6IHRoZSBvYmplY3Qgb24gd2hp Y2ggdGhlIHNpZ25hbCBpcyBlbWl0dGVkCisgICAgICogQHRpdGxlOiB0aGUgbGluaydzIHRpdGxl CisgICAgICogQHVyaTogdGhlIFVSSSB0aGUgbGluayBwb2ludHMgdG8KKyAgICAgKgorICAgICAq IFdoZW4gdGhlIGN1cnNvciBpcyBvdmVyIGEgbGluaywgdGhpcyBzaWduYWwgaXMgZW1pdHRlZC4K KyAgICAgKi8KICAgICB3ZWJraXRfd2ViX3ZpZXdfc2lnbmFsc1tIT1ZFUklOR19PVkVSX0xJTktd ID0gZ19zaWduYWxfbmV3KCJob3ZlcmluZy1vdmVyLWxpbmsiLAogICAgICAgICAgICAgR19UWVBF X0ZST01fQ0xBU1Mod2ViVmlld0NsYXNzKSwKICAgICAgICAgICAgIChHU2lnbmFsRmxhZ3MpKEdf U0lHTkFMX1JVTl9MQVNUIHwgR19TSUdOQUxfQUNUSU9OKSwK