183811 2018-03-21 05:06:36 -0700 [WPE] Build failure with ENABLE_VIDEO=OFF when GStreamer is not available 2018-03-21 05:37:13 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez aperez bugs-noreply calvaris cgarcia pnormand oldest_to_newest 1407968 0 clopez 2018-03-21 05:06:36 -0700 Building WPE with video disabled currently fails if gstreamer is not avaialable (which its expected it won't be if the system doesn't need video). I think this started to happen with r228946 <https://trac.webkit.org/r228946> due to the unconditional inclusion of WebCore/GStreamerUtilities.h which is not guarded by USE(GSTREAMER) The build failure itself: In file included from /home/igalia/clopez/build-wpe-trunk/buildroot-2017.08.2/output/build/wpewebkit-custom/DerivedSources/ForwardingHeaders/WebCore/GStreamerUtilities.h:1:0, from /home/igalia/clopez/build-wpe-trunk/buildroot-2017.08.2/output/build/wpewebkit-custom/Source/WebKit/UIProcess/wpe/WebProcessPoolWPE.cpp:39, from /home/igalia/clopez/build-wpe-trunk/buildroot-2017.08.2/output/build/wpewebkit-custom/DerivedSources/WebKit/unified-sources/UnifiedSource36.cpp:6: /home/igalia/clopez/build-wpe-trunk/buildroot-2017.08.2/output/build/wpewebkit-custom/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.h:24:21: fatal error: gst/gst.h: No such file or directory compilation terminated. Source/WebKit/CMakeFiles/WebKit.dir/build.make:16176: recipe for target 'Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource36.cpp.o' failed 1407969 1 336185 clopez 2018-03-21 05:10:21 -0700 Created attachment 336185 Patch 1407971 2 336185 clopez 2018-03-21 05:37:09 -0700 Comment on attachment 336185 Patch Clearing flags on attachment: 336185 Committed r229803: <https://trac.webkit.org/changeset/229803> 1407972 3 clopez 2018-03-21 05:37:13 -0700 All reviewed patches have been landed. Closing bug. 336185 2018-03-21 05:10:21 -0700 2018-03-21 05:37:09 -0700 Patch bug-183811-20180321131019.patch text/plain 1589 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5ODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDY4NmFiZGUyY2FhMGIy YjE3NzhiYmJkNmU4NDI3YjgxNzBiNzk0MC4uNmM2YTM0MWFiNDA5NjQ0MjY2NTMxNGM0ZjEzZjI5 ZjIyZDk3NmMwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAzLTIxICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtX UEVdIEJ1aWxkIGZhaWx1cmUgd2l0aCBFTkFCTEVfVklERU89T0ZGIHdoZW4gR1N0cmVhbWVyIGlz IG5vdCBhdmFpbGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4MzgxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBidWlsZCBndWFyZHMgZm9yIFVTRV9HU1RSRUFNRVIuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCBpdCBpcyBhIGJ1aWxkIGZpeC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9HU3RyZWFtZXJVdGlsaXRpZXMuaDoKKwogMjAxOC0wMy0yMSAgWmFuIERv YmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NhaXJvXSBEcmF3IENh aXJvIHBhdHRlcm5zIHdpdGggY2Fpcm9fcGFpbnRfd2l0aF9hbHBoYSgpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVXRpbGl0 aWVzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVh bWVyVXRpbGl0aWVzLmgKaW5kZXggYTQ4YjRhYzllZTIyMWIxZTg2MDFlM2Q5MjFjYzc4YjNkNzdm ZWNlNS4uZDE0OTRmMGI0OGFkNTViZjc1Zjc5ODFkY2QwOTU3ZDgyMjM5OWZlYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclV0 aWxpdGllcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9HU3RyZWFtZXJVdGlsaXRpZXMuaApAQCAtMjAsNiArMjAsNyBAQAogI3ByYWdtYSBvbmNlCiAK IAorI2lmIFVTRShHU1RSRUFNRVIpCiAjaW5jbHVkZSAiRmxvYXRTaXplLmgiCiAjaW5jbHVkZSA8 Z3N0L2dzdC5oPgogI2luY2x1ZGUgPGdzdC92aWRlby92aWRlby1mb3JtYXQuaD4KQEAgLTg1LDMg Kzg2LDQgQEAgYm9vbCBnc3RSZWdpc3RyeUhhc0VsZW1lbnRGb3JNZWRpYVR5cGUoR0xpc3QqIGVs ZW1lbnRGYWN0b3JpZXMsIGNvbnN0IGNoYXIqIGNhcHMKICNpZm5kZWYgR1NUX0JVRkZFUl9EVFNf T1JfUFRTCiAjZGVmaW5lIEdTVF9CVUZGRVJfRFRTX09SX1BUUyhidWZmZXIpIChHU1RfQlVGRkVS X0RUU19JU19WQUxJRChidWZmZXIpID8gR1NUX0JVRkZFUl9EVFMoYnVmZmVyKSA6IEdTVF9CVUZG RVJfUFRTKGJ1ZmZlcikpCiAjZW5kaWYKKyNlbmRpZiAvLyBVU0UoR1NUUkVBTUVSKQo=