183810 2018-03-20 23:20:52 -0700 Windows 64-bit build fix after r229767 2018-03-21 00:26:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned achristensen chris.reid commit-queue don.olmstead ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1407924 0 chris.reid 2018-03-20 23:20:52 -0700 c:\git\webkit\source\javascriptcore\assembler\MacroAssemblerX86_64.h(180): error C2661: 'JSC::X86Assembler::call': no overloaded function takes 2 arguments c:\git\webkit\source\javascriptcore\assembler\MacroAssemblerX86_64.h(180): error C2440: '<function-style-cast>': cannot convert from 'JSC::AbstractMacroAssembler<JSC::Assembler>::Call::Flags' to 'JSC::AbstractMacroAssembler<JSC::Assembler>::Call' 1407929 1 336182 chris.reid 2018-03-20 23:31:45 -0700 Created attachment 336182 Patch 1407930 2 336182 mark.lam 2018-03-20 23:37:41 -0700 Comment on attachment 336182 Patch The tag argument comes from the incoming PtrTag, which I neglected to name. Can you please apply this fix? 1407934 3 chris.reid 2018-03-20 23:57:06 -0700 (In reply to Mark Lam from comment #2) > Comment on attachment 336182 [details] > Patch > > The tag argument comes from the incoming PtrTag, which I neglected to name. > Can you please apply this fix? I tried doing that initially but ran into that `'JSC::X86Assembler::call': no overloaded function takes 2 arguments` error. Do you know which function it's supposed to be using? 1407935 4 mark.lam 2018-03-20 23:59:31 -0700 (In reply to Christopher Reid from comment #3) > (In reply to Mark Lam from comment #2) > > Comment on attachment 336182 [details] > > Patch > > > > The tag argument comes from the incoming PtrTag, which I neglected to name. > > Can you please apply this fix? > > I tried doing that initially but ran into that `'JSC::X86Assembler::call': > no overloaded function takes 2 arguments` error. Do you know which function > it's supposed to be using? OK, nevermind then. Let's just go with your solution for now. 1407936 5 336182 mark.lam 2018-03-20 23:59:47 -0700 Comment on attachment 336182 Patch r=me 1407949 6 336182 commit-queue 2018-03-21 00:25:08 -0700 Comment on attachment 336182 Patch Clearing flags on attachment: 336182 Committed r229797: <https://trac.webkit.org/changeset/229797> 1407950 7 commit-queue 2018-03-21 00:25:10 -0700 All reviewed patches have been landed. Closing bug. 1407951 8 webkit-bug-importer 2018-03-21 00:26:24 -0700 <rdar://problem/38697546> 336182 2018-03-20 23:31:45 -0700 2018-03-21 00:25:08 -0700 Patch 183810.diff text/plain 1398 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVjY2MxMTE0ZTZkLi40ZDhmYzY1YjFkMSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDMtMjAgIENocmlz dG9waGVyIFJlaWQgIDxjaHJpcy5yZWlkQHNvbnkuY29tPgorCisgICAgICAgIFdpbmRvd3MgNjQt Yml0IGJ1aWxkIGZpeCBhZnRlciByMjI5NzY3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODM4MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmluZyBhbiBleHRyYSBwYXJhbWV0ZXIgaW4gdGhlIGNh bGwgdG8gbV9hc3NlbWJlcjo6Y2FsbC4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2Vt Ymxlclg4Nl82NC5oOgorCiAyMDE4LTAzLTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgogCiAgICAgICAgIFdlIG5lZWQgdG8gZG8gcHJvcGVyIGJvb2trZWVwaW5nIG9mIGV4aXRP SyB3aGVuIGluc2VydGluZyBjb25zdGFudHMgd2hlbiBzaW5raW5nIE5ld0FycmF5QnVmZmVyCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy WDg2XzY0LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy WDg2XzY0LmgKaW5kZXggZTk4N2FhODI5YTAuLmRhYWY2YzNlNDY0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2XzY0LmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4Nl82NC5oCkBA IC0xNzcsNyArMTc3LDcgQEAgcHVibGljOgogICAgICAgICBhZGQ2NChUcnVzdGVkSW1tMzIoNCAq IHNpemVvZihpbnQ2NF90KSksIFg4NlJlZ2lzdGVyczo6ZWN4KTsKIAogICAgICAgICBEYXRhTGFi ZWxQdHIgbGFiZWwgPSBtb3ZlV2l0aFBhdGNoKFRydXN0ZWRJbW1QdHIobnVsbHB0ciksIHNjcmF0 Y2hSZWdpc3RlcigpKTsKLSAgICAgICAgQ2FsbCByZXN1bHQgPSBDYWxsKG1fYXNzZW1ibGVyLmNh bGwoc2NyYXRjaFJlZ2lzdGVyKCksIHRhZyksIENhbGw6OkxpbmthYmxlKTsKKyAgICAgICAgQ2Fs bCByZXN1bHQgPSBDYWxsKG1fYXNzZW1ibGVyLmNhbGwoc2NyYXRjaFJlZ2lzdGVyKCkpLCBDYWxs OjpMaW5rYWJsZSk7CiAKICAgICAgICAgYWRkNjQoVHJ1c3RlZEltbTMyKDggKiBzaXplb2YoaW50 NjRfdCkpLCBYODZSZWdpc3RlcnM6OmVzcCk7CiAK