<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>183808</bug_id>
          
          <creation_ts>2018-03-20 22:45:22 -0700</creation_ts>
          <short_desc>Update the install name for JavaScriptCore when built with WK_ALTERNATE_FRAMEWORKS_DIR</short_desc>
          <delta_ts>2018-03-20 23:26:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Tim Horton">thorton</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mitz</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1407916</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2018-03-20 22:45:22 -0700</bug_when>
    <thetext>Update the DYLD install name for frameworks built with WK_ALTERNATE_FRAMEWORKS_DIR</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407917</commentid>
    <comment_count>1</comment_count>
      <attachid>336179</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2018-03-20 22:45:35 -0700</bug_when>
    <thetext>Created attachment 336179
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407918</commentid>
    <comment_count>2</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2018-03-20 22:45:51 -0700</bug_when>
    <thetext>&lt;rdar://problem/38692079&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407919</commentid>
    <comment_count>3</comment_count>
      <attachid>336179</attachid>
    <who name="">mitz</who>
    <bug_when>2018-03-20 22:48:45 -0700</bug_when>
    <thetext>Comment on attachment 336179
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336179&amp;action=review

&gt; Source/JavaScriptCore/ChangeLog:3
&gt; +        Update the DYLD install name for frameworks built with WK_ALTERNATE_FRAMEWORKS_DIR

s/DYLD //. Also, you say “frameworks” but only change one framework. Are you going to use this bug for more patches?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407920</commentid>
    <comment_count>4</comment_count>
      <attachid>336180</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2018-03-20 22:49:54 -0700</bug_when>
    <thetext>Created attachment 336180
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407925</commentid>
    <comment_count>5</comment_count>
      <attachid>336180</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-03-20 23:26:32 -0700</bug_when>
    <thetext>Comment on attachment 336180
Patch

Clearing flags on attachment: 336180

Committed r229789: &lt;https://trac.webkit.org/changeset/229789&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407926</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-03-20 23:26:33 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>336179</attachid>
            <date>2018-03-20 22:45:35 -0700</date>
            <delta_ts>2018-03-20 22:49:52 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-183808-20180320224534.patch</filename>
            <type>text/plain</type>
            <size>1779</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk
Y2QyZDExYTZiMTUxM2IwMDg2YjhiMWY2NGIxMmE3OGRjNzIwYjdjLi5iOTQwYjUwZTg0YjcyZWMw
Y2FmNjIwODcwMjU5OTg2Nzg2ODFmMWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxMyBAQAorMjAxOC0wMy0yMCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl
LmNvbT4KKworICAgICAgICBVcGRhdGUgdGhlIERZTEQgaW5zdGFsbCBuYW1lIGZvciBmcmFtZXdv
cmtzIGJ1aWx0IHdpdGggV0tfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM4MDgKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzM4NjkyMDc5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWc6CisK
IDIwMTgtMDMtMjAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAg
ICAgICAgRW5hYmxlIHRoZSBtaW5pbWFsIHNpbXVsYXRvciBmZWF0dXJlIGZsYWcgd2hlbiBhcHBy
b3ByaWF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25z
L0phdmFTY3JpcHRDb3JlLnhjY29uZmlnIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3Vy
YXRpb25zL0phdmFTY3JpcHRDb3JlLnhjY29uZmlnCmluZGV4IGIyN2UyMTEzZTAxODIxMzBjOWMy
NzllYWJjMDdkOGEzNDJkNDBhNjcuLjY0OTIxZTg4NmQ4MGU5ZTAzMjk2YTQ4NDMwMmRlMTdhM2Jk
N2M5NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9K
YXZhU2NyaXB0Q29yZS54Y2NvbmZpZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmln
dXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWcKQEAgLTUyLDcgKzUyLDkgQEAgT1RIRVJf
Q1BMVVNQTFVTRkxBR1MgPSAkKGluaGVyaXRlZCkgLS1zeXN0ZW0taGVhZGVyLXByZWZpeD11bmlj
b2RlLzsKIEhFQURFUl9TRUFSQ0hfUEFUSFMgPSAiJHtCVUlMVF9QUk9EVUNUU19ESVJ9L0Rlcml2
ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlIiAkKEhFQURFUl9TRUFSQ0hfUEFUSFMpOwogSU5GT1BM
SVNUX0ZJTEUgPSBJbmZvLnBsaXN0OwogSU5TVEFMTF9QQVRIID0gJChKQVZBU0NSSVBUQ09SRV9G
UkFNRVdPUktTX0RJUik7Ci1EWUxJQl9JTlNUQUxMX05BTUVfQkFTRSA9ICQoTk9STUFMX0pBVkFT
Q1JJUFRDT1JFX0ZSQU1FV09SS1NfRElSKTsKK0RZTElCX0lOU1RBTExfTkFNRV9CQVNFID0gJChE
WUxJQl9JTlNUQUxMX05BTUVfQkFTRV8kKFdLX1VTRV9BTFRFUk5BVEVfRlJBTUVXT1JLU19ESVIp
KTsKK0RZTElCX0lOU1RBTExfTkFNRV9CQVNFX05PID0gJChOT1JNQUxfSkFWQVNDUklQVENPUkVf
RlJBTUVXT1JLU19ESVIpCitEWUxJQl9JTlNUQUxMX05BTUVfQkFTRV9ZRVMgPSAkKERZTElCX0lO
U1RBTExfTkFNRV9CQVNFKTsKIFBST0RVQ1RfTkFNRSA9IEphdmFTY3JpcHRDb3JlOwogUFJPRFVD
VF9CVU5ETEVfSURFTlRJRklFUiA9IGNvbS5hcHBsZS4kKFBST0RVQ1RfTkFNRTpyZmMxMDM0aWRl
bnRpZmllcik7CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>336180</attachid>
            <date>2018-03-20 22:49:54 -0700</date>
            <delta_ts>2018-03-20 23:26:32 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-183808-20180320224953.patch</filename>
            <type>text/plain</type>
            <size>1782</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk
Y2QyZDExYTZiMTUxM2IwMDg2YjhiMWY2NGIxMmE3OGRjNzIwYjdjLi41ZWFhMjdiZjM1NDEyY2Y2
OGU4OWMwMGI3NDE5ZjJkMWRkN2RlNzAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxMyBAQAorMjAxOC0wMy0yMCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl
LmNvbT4KKworICAgICAgICBVcGRhdGUgdGhlIGluc3RhbGwgbmFtZSBmb3IgSmF2YVNjcmlwdENv
cmUgd2hlbiBidWlsdCB3aXRoIFdLX0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzODA4CisgICAgICAgIDxy
ZGFyOi8vcHJvYmxlbS8zODY5MjA3OT4KKworICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0
ZWluLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWc6
CisKIDIwMTgtMDMtMjAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK
ICAgICAgICAgRW5hYmxlIHRoZSBtaW5pbWFsIHNpbXVsYXRvciBmZWF0dXJlIGZsYWcgd2hlbiBh
cHByb3ByaWF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRp
b25zL0phdmFTY3JpcHRDb3JlLnhjY29uZmlnIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZp
Z3VyYXRpb25zL0phdmFTY3JpcHRDb3JlLnhjY29uZmlnCmluZGV4IGIyN2UyMTEzZTAxODIxMzBj
OWMyNzllYWJjMDdkOGEzNDJkNDBhNjcuLjY0OTIxZTg4NmQ4MGU5ZTAzMjk2YTQ4NDMwMmRlMTdh
M2JkN2M5NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9u
cy9KYXZhU2NyaXB0Q29yZS54Y2NvbmZpZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29u
ZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWcKQEAgLTUyLDcgKzUyLDkgQEAgT1RI
RVJfQ1BMVVNQTFVTRkxBR1MgPSAkKGluaGVyaXRlZCkgLS1zeXN0ZW0taGVhZGVyLXByZWZpeD11
bmljb2RlLzsKIEhFQURFUl9TRUFSQ0hfUEFUSFMgPSAiJHtCVUlMVF9QUk9EVUNUU19ESVJ9L0Rl
cml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlIiAkKEhFQURFUl9TRUFSQ0hfUEFUSFMpOwogSU5G
T1BMSVNUX0ZJTEUgPSBJbmZvLnBsaXN0OwogSU5TVEFMTF9QQVRIID0gJChKQVZBU0NSSVBUQ09S
RV9GUkFNRVdPUktTX0RJUik7Ci1EWUxJQl9JTlNUQUxMX05BTUVfQkFTRSA9ICQoTk9STUFMX0pB
VkFTQ1JJUFRDT1JFX0ZSQU1FV09SS1NfRElSKTsKK0RZTElCX0lOU1RBTExfTkFNRV9CQVNFID0g
JChEWUxJQl9JTlNUQUxMX05BTUVfQkFTRV8kKFdLX1VTRV9BTFRFUk5BVEVfRlJBTUVXT1JLU19E
SVIpKTsKK0RZTElCX0lOU1RBTExfTkFNRV9CQVNFX05PID0gJChOT1JNQUxfSkFWQVNDUklQVENP
UkVfRlJBTUVXT1JLU19ESVIpCitEWUxJQl9JTlNUQUxMX05BTUVfQkFTRV9ZRVMgPSAkKERZTElC
X0lOU1RBTExfTkFNRV9CQVNFKTsKIFBST0RVQ1RfTkFNRSA9IEphdmFTY3JpcHRDb3JlOwogUFJP
RFVDVF9CVU5ETEVfSURFTlRJRklFUiA9IGNvbS5hcHBsZS4kKFBST0RVQ1RfTkFNRTpyZmMxMDM0
aWRlbnRpZmllcik7CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>