183795 2018-03-20 13:17:21 -0700 We need to do proper bookkeeping of exitOK when inserting constants when sinking NewArrayBuffer 2018-03-20 14:59:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1407768 0 saam 2018-03-20 13:17:21 -0700 ... 1407770 1 saam 2018-03-20 13:18:07 -0700 <rdar://problem/38298694> 1407772 2 336145 saam 2018-03-20 13:24:30 -0700 Created attachment 336145 patch 1407776 3 336145 mark.lam 2018-03-20 13:27:44 -0700 Comment on attachment 336145 patch View in context: https://bugs.webkit.org/attachment.cgi?id=336145&action=review > Source/JavaScriptCore/ChangeLog:9 > + We were just assuming that the constans we were inserting were /constans/constants/ 1407780 4 336146 saam 2018-03-20 13:32:02 -0700 Created attachment 336146 patch for landing 1407819 5 336146 commit-queue 2018-03-20 14:59:38 -0700 Comment on attachment 336146 patch for landing Clearing flags on attachment: 336146 Committed r229775: <https://trac.webkit.org/changeset/229775> 1407820 6 commit-queue 2018-03-20 14:59:39 -0700 All reviewed patches have been landed. Closing bug. 336145 2018-03-20 13:24:30 -0700 2018-03-20 13:32:02 -0700 patch b-backup.diff text/plain 2907 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjk3NjkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE4LTAzLTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFdlIG5lZWQgdG8gZG8gcHJvcGVyIGJvb2trZWVwaW5nIG9mIGV4aXRP SyB3aGVuIGluc2VydGluZyBjb25zdGFudHMgd2hlbiBzaW5raW5nIE5ld0FycmF5QnVmZmVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM3OTUKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4Mjk4Njk0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL3NpbmstcGhhbnRvbS1uZXctYXJyYXkt YnVmZmVyLWV4aXQtb2suanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKyAgICAgICAgKGJhcik6 CisKIDIwMTgtMDMtMTYgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAK ICAgICAgICAgW0RGR11bRlRMXSBBZGQgdmVjdG9yTGVuZ3RoSGludCBmb3IgTmV3QXJyYXkKSW5k ZXg6IEpTVGVzdHMvc3RyZXNzL3NpbmstcGhhbnRvbS1uZXctYXJyYXktYnVmZmVyLWV4aXQtb2su anMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3Mvc2luay1waGFudG9tLW5ldy1hcnJheS1i dWZmZXItZXhpdC1vay5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9zaW5rLXBo YW50b20tbmV3LWFycmF5LWJ1ZmZlci1leGl0LW9rLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAg KzEsOCBAQAorZnVuY3Rpb24gZm9vKCkgeworfQorZnVuY3Rpb24gYmFyKCkgeworICAgIGZvbygu Li5bNDJdKTsKK30KK2ZvciAodmFyIGkgPSAwOyBpIDwgNDAwMDAwOyBpKyspIHsKKyAgICBiYXIo KTsKK30KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI5NzY5KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE5IEBACisyMDE4LTAzLTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisg ICAgICAgIFdlIG5lZWQgdG8gZG8gcHJvcGVyIGJvb2trZWVwaW5nIG9mIGV4aXRPSyB3aGVuIGlu c2VydGluZyBjb25zdGFudHMgd2hlbiBzaW5raW5nIE5ld0FycmF5QnVmZmVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM3OTUKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzM4Mjk4Njk0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlIHdlcmUganVzdCBhc3N1bWluZyB0aGF0IHRoZSBjb25zdGFucyB3 ZSB3ZXJlIGluc2VydGluZyB3ZXJlCisgICAgICAgIGFsd2F5cyBleGl0T0s9dHJ1ZS4gSG93ZXZl ciwgdGhpcyBicmVha3MgdmFsaWRhdGlvbi4gVGhlIGV4aXRPSworICAgICAgICB3ZSBlbWl0IGZv ciB0aGUgY29uc3RhbnRzIGluIHRoZSBOZXdBcnJheUJ1ZmZlciBzaG91bGQgcmVzcGVjdAorICAg ICAgICB0aGUgY3VycmVudCBleGl0IHN0YXRlIG9mIHRoZSBJUiB3ZSd2ZSBlbWl0dGVkLiBUaGlz IGlzIGp1c3QgSVIKKyAgICAgICAgYm9va2tlZXBpbmcgc2luY2UgSlNDb25zdGFudCBpcyBhIG5v bi1leGl0aW5nIG5vZGUuCisKKyAgICAgICAgKiBkZmcvREZHQXJndW1lbnRzRWxpbWluYXRpb25Q aGFzZS5jcHA6CisKIDIwMTgtMDMtMjAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIGFuZCBhZG9wdCBXS19QTEFURk9STV9OQU1FIGFuZCBhZGp1 c3QgZGVmYXVsdCBmZWF0dXJlIGRlZmluZXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQXJndW1lbnRzRWxpbWluYXRpb25QaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcmd1bWVudHNFbGltaW5hdGlvblBoYXNlLmNwcAkocmV2 aXNpb24gMjI5NzY5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcmd1bWVudHNF bGltaW5hdGlvblBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTE5LDcgKzkxOSw2IEBAIHBy aXZhdGU6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9CiAKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChjYW5kaWRhdGUtPm9wKCkgPT0gUGhhbnRv bU5ld0FycmF5QnVmZmVyKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYm9vbCBjYW5FeGl0ID0gdHJ1ZTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBhdXRvKiBhcnJheSA9IGNhbmRpZGF0ZS0+Y2FzdE9wZXJhbmQ8SlNGaXhlZEFycmF5 Kj4oKTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgKHVuc2ln bmVkIGluZGV4ID0gMDsgaW5kZXggPCBhcnJheS0+bGVuZ3RoKCk7ICsraW5kZXgpIHsKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSlNWYWx1ZSBjb25zdGFudDsK 336146 2018-03-20 13:32:02 -0700 2018-03-20 14:59:38 -0700 patch for landing b-backup.diff text/plain 2900 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjk3NjkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE4LTAzLTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFdlIG5lZWQgdG8gZG8gcHJvcGVyIGJvb2trZWVwaW5nIG9mIGV4aXRP SyB3aGVuIGluc2VydGluZyBjb25zdGFudHMgd2hlbiBzaW5raW5nIE5ld0FycmF5QnVmZmVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM3OTUKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4Mjk4Njk0PgorCisgICAgICAgIFJldmlld2VkIGJ5IEpG IEJhc3RpZW4uCisKKyAgICAgICAgKiBzdHJlc3Mvc2luay1waGFudG9tLW5ldy1hcnJheS1idWZm ZXItZXhpdC1vay5qczogQWRkZWQuCisgICAgICAgIChmb28pOgorICAgICAgICAoYmFyKToKKwog MjAxOC0wMy0xNiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAg ICAgICBbREZHXVtGVExdIEFkZCB2ZWN0b3JMZW5ndGhIaW50IGZvciBOZXdBcnJheQpJbmRleDog SlNUZXN0cy9zdHJlc3Mvc2luay1waGFudG9tLW5ldy1hcnJheS1idWZmZXItZXhpdC1vay5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9zaW5rLXBoYW50b20tbmV3LWFycmF5LWJ1ZmZl ci1leGl0LW9rLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL3NpbmstcGhhbnRv bS1uZXctYXJyYXktYnVmZmVyLWV4aXQtb2suanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw4 IEBACitmdW5jdGlvbiBmb28oKSB7Cit9CitmdW5jdGlvbiBiYXIoKSB7CisgICAgZm9vKC4uLls0 Ml0pOworfQorZm9yICh2YXIgaSA9IDA7IGkgPCA0MDAwMDA7IGkrKykgeworICAgIGJhcigpOwor fQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjk3NjkpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTgtMDMtMjAgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAg ICAgV2UgbmVlZCB0byBkbyBwcm9wZXIgYm9va2tlZXBpbmcgb2YgZXhpdE9LIHdoZW4gaW5zZXJ0 aW5nIGNvbnN0YW50cyB3aGVuIHNpbmtpbmcgTmV3QXJyYXlCdWZmZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mzc5NQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMzgyOTg2OTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSkYgQmFzdGllbi4KKwor ICAgICAgICBXZSB3ZXJlIGp1c3QgYXNzdW1pbmcgdGhhdCB0aGUgY29uc3RhbnRzIHdlIHdlcmUg aW5zZXJ0aW5nIHdlcmUKKyAgICAgICAgYWx3YXlzIGV4aXRPSz10cnVlLiBIb3dldmVyLCB0aGlz IGJyZWFrcyB2YWxpZGF0aW9uLiBUaGUgZXhpdE9LCisgICAgICAgIHdlIGVtaXQgZm9yIHRoZSBj b25zdGFudHMgaW4gdGhlIE5ld0FycmF5QnVmZmVyIHNob3VsZCByZXNwZWN0CisgICAgICAgIHRo ZSBjdXJyZW50IGV4aXQgc3RhdGUgb2YgdGhlIElSIHdlJ3ZlIGVtaXR0ZWQuIFRoaXMgaXMganVz dCBJUgorICAgICAgICBib29ra2VlcGluZyBzaW5jZSBKU0NvbnN0YW50IGlzIGEgbm9uLWV4aXRp bmcgbm9kZS4KKworICAgICAgICAqIGRmZy9ERkdBcmd1bWVudHNFbGltaW5hdGlvblBoYXNlLmNw cDoKKwogMjAxOC0wMy0yMCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4K IAogICAgICAgICBBZGQgYW5kIGFkb3B0IFdLX1BMQVRGT1JNX05BTUUgYW5kIGFkanVzdCBkZWZh dWx0IGZlYXR1cmUgZGVmaW5lcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdB cmd1bWVudHNFbGltaW5hdGlvblBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c0VsaW1pbmF0aW9uUGhhc2UuY3BwCShyZXZpc2lvbiAy Mjk3NjkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c0VsaW1pbmF0 aW9uUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MTksNyArOTE5LDYgQEAgcHJpdmF0ZToK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKGNhbmRpZGF0ZS0+b3AoKSA9PSBQaGFudG9tTmV3QXJy YXlCdWZmZXIpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29s IGNhbkV4aXQgPSB0cnVlOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGF1dG8qIGFycmF5ID0gY2FuZGlkYXRlLT5jYXN0T3BlcmFuZDxKU0ZpeGVkQXJyYXkqPigpOwog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvciAodW5zaWduZWQgaW5k ZXggPSAwOyBpbmRleCA8IGFycmF5LT5sZW5ndGgoKTsgKytpbmRleCkgewogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBKU1ZhbHVlIGNvbnN0YW50Owo=