183774 2018-03-20 05:26:22 -0700 [Cairo] Draw Cairo patterns with cairo_paint_with_alpha() 2018-03-29 09:25:55 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan cgarcia darin webkit-bug-importer oldest_to_newest 1407637 0 zan 2018-03-20 05:26:22 -0700 [Cairo] Draw Cairo patterns with cairo_paint_with_alpha() 1407639 1 336115 zan 2018-03-20 05:33:48 -0700 Created attachment 336115 Patch 1407945 2 336115 zan 2018-03-21 00:17:26 -0700 Comment on attachment 336115 Patch Clearing flags on attachment: 336115 Committed r229796: <https://trac.webkit.org/changeset/229796> 1407946 3 zan 2018-03-21 00:17:30 -0700 All reviewed patches have been landed. Closing bug. 1407948 4 webkit-bug-importer 2018-03-21 00:18:18 -0700 <rdar://problem/38697417> 1410282 5 336115 darin 2018-03-29 09:25:04 -0700 Comment on attachment 336115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336115&action=review > Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:155 > + cairo_paint_with_alpha(cr, std::max<float>(0, std::min<float>(1.0, alpha))); Another way to write this with MathExtras.h is clampTo<float>(alpha, 0, 1). 1410283 6 336115 darin 2018-03-29 09:25:55 -0700 Comment on attachment 336115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336115&action=review >> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:155 >> + cairo_paint_with_alpha(cr, std::max<float>(0, std::min<float>(1.0, alpha))); > > Another way to write this with MathExtras.h is clampTo<float>(alpha, 0, 1). But I just realized that MathExtras does not have enough overloads for float, so maybe it’s better to write it the way you did, or write std::max(0.0f, std::min(1.0f, alpha)). 336115 2018-03-20 05:33:48 -0700 2018-03-21 00:17:26 -0700 Patch bug-183774-20180320133347.patch text/plain 2090 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTZhMGJmY2YzMDQyZDhi MzU1MmU5OGMxOGNiODI5ZGU1ZmMyMzRiZC4uZWQ0ZTMxNmJjNjg3ZGQyMjQwMTA0YzM1NjRmNzZj OTJjYWFiOTQyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTAzLTIwICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIERyYXcg Q2Fpcm8gcGF0dGVybnMgd2l0aCBjYWlyb19wYWludF93aXRoX2FscGhhKCkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mzc3NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHRoZSBkcmF3UGF0dGVyblRv Q2Fpcm9Db250ZXh0KCkgaGVscGVyIGluIENhaXJvT3BlcmF0aW9ucy5jcHAgc291cmNlCisgICAg ICAgIGZpbGUsIGFsd2F5cyBjbGlwIHRoZSBwYWludGluZyByZWdpb24gdG8gdGhlIHNwZWNpZmll ZCByZWN0YW5nbGUgYW5kCisgICAgICAgIHRoZW4gdXNlIGNhaXJvX3BhaW50X3dpdGhfYWxwaGEo KSB0byBwYWludCB0aGUgcGFzc2VkLWluIHBhdHRlcm4gb2JqZWN0LAorICAgICAgICBub3QgcmVs YXlpbmcgcmFzdGVyaXphdGlvbiB0byBjYWlyb19maWxsKCkgd2hlbiB1c2luZyBvcGFxdWUgYWxw aGEuIFdlCisgICAgICAgIHN0aWxsIGNsYW1wIHRoZSBhbHBoYSB2YWx1ZSB0byB0aGUgMC4wIC0g MS4wIHJhbmdlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtLSBubyBjaGFuZ2UgaW4gYmVoYXZp b3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9DYWlyb09wZXJhdGlvbnMu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2Fpcm86OmRyYXdQYXR0ZXJuVG9DYWlyb0NvbnRleHQp OgorCiAyMDE4LTAzLTE5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgSGF2ZSBvbmUgc2VydmljZSB3b3JrZXIgcHJvY2VzcyBwZXIgc2VjdXJpdHkgb3JpZ2luCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9DYWlyb09w ZXJhdGlvbnMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQ2Fp cm9PcGVyYXRpb25zLmNwcAppbmRleCAxODYyZGVmYTFlYjNmYmQ0NjZmMWZiYTJkYWQ5ZjhkNDYw YWUyODI2Li5lY2M2ZmRmZGQ5MWQ4OTZlNjZiYmRmZTg4MTdlNTk4ZWVmNzMwMWZjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9DYWlyb09wZXJhdGlv bnMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJv T3BlcmF0aW9ucy5jcHAKQEAgLTE1MSwxMiArMTUxLDggQEAgc3RhdGljIHZvaWQgZHJhd1BhdHRl cm5Ub0NhaXJvQ29udGV4dChjYWlyb190KiBjciwgY2Fpcm9fcGF0dGVybl90KiBwYXR0ZXJuLCBj b24KICAgICBjYWlyb190cmFuc2xhdGUoY3IsIGRlc3RSZWN0LngoKSwgZGVzdFJlY3QueSgpKTsK ICAgICBjYWlyb19zZXRfc291cmNlKGNyLCBwYXR0ZXJuKTsKICAgICBjYWlyb19yZWN0YW5nbGUo Y3IsIDAsIDAsIGRlc3RSZWN0LndpZHRoKCksIGRlc3RSZWN0LmhlaWdodCgpKTsKLQotICAgIGlm IChhbHBoYSA8IDEpIHsKLSAgICAgICAgY2Fpcm9fY2xpcChjcik7Ci0gICAgICAgIGNhaXJvX3Bh aW50X3dpdGhfYWxwaGEoY3IsIGFscGhhKTsKLSAgICB9IGVsc2UKLSAgICAgICAgY2Fpcm9fZmls bChjcik7CisgICAgY2Fpcm9fY2xpcChjcik7CisgICAgY2Fpcm9fcGFpbnRfd2l0aF9hbHBoYShj ciwgc3RkOjptYXg8ZmxvYXQ+KDAsIHN0ZDo6bWluPGZsb2F0PigxLjAsIGFscGhhKSkpOwogfQog CiBzdGF0aWMgaW5saW5lIHZvaWQgZmlsbFJlY3RXaXRoQ29sb3IoY2Fpcm9fdCogY3IsIGNvbnN0 IEZsb2F0UmVjdCYgcmVjdCwgY29uc3QgQ29sb3ImIGNvbG9yKQo=