183773 2018-03-20 05:09:32 -0700 WebProcess memory monitor thresholds should be better tuned for embedded systems. 2018-03-25 17:53:45 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180861 https://bugs.webkit.org/show_bug.cgi?id=183997 P2 Normal --- 1 clopez clopez achristensen aperez benjamin bugs-noreply cdumez cmarcelo darin dbates eric.carlson ews-watchlist jer.noble ysuzuki oldest_to_newest 1407636 0 clopez 2018-03-20 05:09:32 -0700 The current thresholds for the WebProcess memory monitor are hard-coded and doesn't make sense on an embedded system where having 1GB or 512MB of RAM is usual. 1407642 1 336116 clopez 2018-03-20 05:50:01 -0700 Created attachment 336116 Patch 1407666 2 336125 clopez 2018-03-20 08:20:21 -0700 Created attachment 336125 Patch Patch v2, try to fix windows build 1407825 3 336125 aperez 2018-03-20 15:24:54 -0700 Comment on attachment 336125 Patch Informal r=me. Reading this patch makes me think that we might want to think whether it might make sense to provide some API which allows programs to set their own thresholds — each embedded application is a different beast. Dunno. At any rate, your proposed improvements look much better to me than the current hardcoded values, so I hope others agree and this can be landed. 1408662 4 clopez 2018-03-23 05:00:55 -0700 ping reviewers? all EWS are green. 1408663 5 336125 ysuzuki 2018-03-23 05:06:12 -0700 Comment on attachment 336125 Patch r=me too. 1408673 6 336125 clopez 2018-03-23 05:41:50 -0700 Comment on attachment 336125 Patch Clearing flags on attachment: 336125 Committed r229894: <https://trac.webkit.org/changeset/229894> 1408674 7 clopez 2018-03-23 05:41:57 -0700 All reviewed patches have been landed. Closing bug. 1409018 8 336125 darin 2018-03-23 20:41:57 -0700 Comment on attachment 336125 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336125&action=review > Source/WTF/wtf/MemoryPressureHandler.cpp:152 > + WTFLogAlways("Unable to shrink memory footprint of process (%lu MB) below the kill thresold (%lu MB). Killed\n", footprint.value() / MB, thresholdForMemoryKill() / MB); %lu is not the correct format for a size_t; %zu is correct. This might compile on platforms where size_t happens to be the same as unsigned long, but these %lu should be changed to %zu. 1409200 9 clopez 2018-03-25 12:34:09 -0700 (In reply to Darin Adler from comment #8) > Comment on attachment 336125 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336125&action=review > > > Source/WTF/wtf/MemoryPressureHandler.cpp:152 > > + WTFLogAlways("Unable to shrink memory footprint of process (%lu MB) below the kill thresold (%lu MB). Killed\n", footprint.value() / MB, thresholdForMemoryKill() / MB); > > %lu is not the correct format for a size_t; %zu is correct. This might > compile on platforms where size_t happens to be the same as unsigned long, > but these %lu should be changed to %zu. I picked %lu because that was used already on this file for other two messages involving size_t, but you're right: %zu should be used instead. I have opened bug 183997 to fix this one and the other two. 336116 2018-03-20 05:50:01 -0700 2018-03-20 08:19:58 -0700 Patch bug-183773-20180320134959.patch text/plain 3667 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU0YzQyMTUxM2U4NzJkYzgxZmM3NmM0 Y2Q3NjllN2MyNjk2NjZlMDkuLjMyNDA2NGY2MjBjZjM1OWExZDMxZmU0Mzg4NDM5OWYzZGU3N2Jl MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMDMtMjAgIENhcmxvcyBBbGJlcnRvIExvcGV6 IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgV2ViUHJvY2VzcyBtZW1vcnkg bW9uaXRvciB0aHJlc2hvbGRzIHNob3VsZCBiZSBiZXR0ZXIgdHVuZWQgZm9yIGVtYmVkZGVkIHN5 c3RlbXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODM3NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU YWtlIGludG8gYWNjb3VudCB0aGUgdG90YWwgc3lzdGVtIFJBTSBmb3IgdGhlIHRocmVzaG9sZHMg Y2FsY3VsYXRpb24uCisKKyAgICAgICAgRm9yIHN5c3RlbXMgd2l0aCBtb3JlIHRoYW4gM0dCIHRo ZSBjb25zZXJ2YXRpdmUgYW5kIHN0cmljdCB0aHJlc2hvbGRzIHJlbWFpbiBhcyB0aGV5IGFyZSwK KyAgICAgICAgYnV0IGZvciBzeXN0ZW1zIHdpdGggbGVzcyBSQU0gdGhlIHRocmVzaG9sZHMgYXJl IGR5bmFtaWNhbGx5IGNvbmZpZ3VyZWQgYXMgZm9sbG93czoKKworICAgICAgICAtIENvbnNlcnZh dGl2ZSB0aHJlc2hvbGQgKHJlbGVhc2Ugbm9uIGNyaXRpY2FsIG1lbW9yeSkgaWYgV2ViUHJvY2Vz cyB1c2luZyBtb3JlIHRoYW4gMzMlIG9mIHRoZSB0b3RhbCBSQU0uCisgICAgICAgIC0gU3RyaWN0 IHRocmVzaG9sZCAocmVsZWFzZSBhbGwgcG9zc2libGUgbWVtb3J5KSBpZiBXZWJQcm9jZXNzIHVz aW5nIG1vcmUgdGhhbiA1MCUgb2YgdGhlIHRvdGFsIFJBTS4KKworICAgICAgICBUaGUgS2lsbCB0 aHJlc2hvbGQgaXMgYWxzbyBtb2RpZmllZC4gTm93IGl0IGlzIGNhcHBlZCBhdCA5MCUgb2YgdGhl IHRvdGFsIFJBTS4KKworICAgICAgICAqIHd0Zi9NZW1vcnlQcmVzc3VyZUhhbmRsZXIuY3BwOgor ICAgICAgICAoV1RGOjp0aHJlc2hvbGRGb3JNZW1vcnlLaWxsV2l0aFByb2Nlc3NTdGF0ZSk6Cisg ICAgICAgIChXVEY6OnRocmVzaG9sZEZvclBvbGljeSk6CisgICAgICAgIChXVEY6Ok1lbW9yeVBy ZXNzdXJlSGFuZGxlcjo6c2hyaW5rT3JEaWUpOgorCiAyMDE4LTAzLTE5ICBFcmljIENhcmxzb24g IDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtFeHRyYSB6b29tIG1vZGVdIFJl cXVpcmUgZnVsbHNjcmVlbiBmb3IgdmlkZW8gcGxheWJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9NZW1vcnlQ cmVzc3VyZUhhbmRsZXIuY3BwCmluZGV4IGJiMzQyMTU2OGEwNjc3ZjBlNmVhYzA0MDAwMzgwNTVi MDhiNzgyM2MuLjM3NTYxMWI1Y2FmYmY0NjRmZGU3ZWM3NWE2MjgyNTEwOWE1MDgxNTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHAKKysrIGIvU291 cmNlL1dURi93dGYvTWVtb3J5UHJlc3N1cmVIYW5kbGVyLmNwcApAQCAtMjgsNiArMjgsNyBAQAog CiAjaW5jbHVkZSA8d3RmL01lbW9yeUZvb3RwcmludC5oPgogI2luY2x1ZGUgPHd0Zi9OZXZlckRl c3Ryb3llZC5oPgorI2luY2x1ZGUgPHd0Zi9SQU1TaXplLmg+CiAKICNkZWZpbmUgTE9HX0NIQU5O RUxfUFJFRklYIExvZwogCkBAIC04NCwyMCArODUsMTcgQEAgc3RhdGljIGNvbnN0IGNoYXIqIHRv U3RyaW5nKE1lbW9yeVVzYWdlUG9saWN5IHBvbGljeSkKIAogc3RhdGljIHNpemVfdCB0aHJlc2hv bGRGb3JNZW1vcnlLaWxsV2l0aFByb2Nlc3NTdGF0ZShXZWJzYW1Qcm9jZXNzU3RhdGUgcHJvY2Vz c1N0YXRlLCB1bnNpZ25lZCB0YWJDb3VudCkKIHsKLSNpZiBDUFUoWDg2XzY0KSB8fCBDUFUoQVJN NjQpCi0gICAgc2l6ZV90IGJhc2VUaHJlc2hvbGQ7CisgICAgc2l6ZV90IGJhc2VUaHJlc2hvbGQg PSAyICogR0I7CiAgICAgaWYgKHByb2Nlc3NTdGF0ZSA9PSBXZWJzYW1Qcm9jZXNzU3RhdGU6OkFj dGl2ZSkKICAgICAgICAgYmFzZVRocmVzaG9sZCA9IDQgKiBHQjsKLSAgICBlbHNlCi0gICAgICAg IGJhc2VUaHJlc2hvbGQgPSAyICogR0I7Ci0gICAgaWYgKHRhYkNvdW50IDw9IDEpCi0gICAgICAg IHJldHVybiBiYXNlVGhyZXNob2xkOwotICAgIHJldHVybiBiYXNlVGhyZXNob2xkICsgKHN0ZDo6 bWluKHRhYkNvdW50IC0gMSwgNHUpICogMSAqIEdCKTsKLSNlbHNlCi0gICAgVU5VU0VEX1BBUkFN KHByb2Nlc3NTdGF0ZSk7Ci0gICAgVU5VU0VEX1BBUkFNKHRhYkNvdW50KTsKLSAgICByZXR1cm4g MyAqIEdCOworICAgIGlmICh0YWJDb3VudCA+IDEpCisgICAgICAgIGJhc2VUaHJlc2hvbGQgKz0g c3RkOjptaW4odGFiQ291bnQgLSAxLCA0dSkgKiAxICogR0I7CisKKyNpZiAhKENQVShYODZfNjQp IHx8IENQVShBUk02NCkpCisgICAgYmFzZVRocmVzaG9sZCA9IHN0ZDo6bWluKGJhc2VUaHJlc2hv bGQsIDMgKiBHQik7CiAjZW5kaWYKKworICAgIHJldHVybiBzdGQ6Om1pbihiYXNlVGhyZXNob2xk LCBzdGF0aWNfY2FzdDxzaXplX3Q+KHJhbVNpemUoKSAqIDAuOSkpOwogfQogCiB2b2lkIE1lbW9y eVByZXNzdXJlSGFuZGxlcjo6c2V0UGFnZUNvdW50KHVuc2lnbmVkIHBhZ2VDb3VudCkKQEAgLTEx NCwxMSArMTEyLDEyIEBAIHNpemVfdCBNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnRocmVzaG9sZEZv ck1lbW9yeUtpbGwoKQogCiBzdGF0aWMgc2l6ZV90IHRocmVzaG9sZEZvclBvbGljeShNZW1vcnlV c2FnZVBvbGljeSBwb2xpY3kpCiB7CisgICAgY29uc3Qgc2l6ZV90IGJhc2VUaHJlc2hvbGRGb3JQ b2xpY3kgPSBzdGQ6Om1pbigzICogR0IsIHJhbVNpemUoKSk7CiAgICAgc3dpdGNoIChwb2xpY3kp IHsKICAgICBjYXNlIE1lbW9yeVVzYWdlUG9saWN5OjpDb25zZXJ2YXRpdmU6Ci0gICAgICAgIHJl dHVybiAxICogR0I7CisgICAgICAgIHJldHVybiBiYXNlVGhyZXNob2xkRm9yUG9saWN5IC8gMzsK ICAgICBjYXNlIE1lbW9yeVVzYWdlUG9saWN5OjpTdHJpY3Q6Ci0gICAgICAgIHJldHVybiAxLjUg KiBHQjsKKyAgICAgICAgcmV0dXJuIGJhc2VUaHJlc2hvbGRGb3JQb2xpY3kgLyAyOwogICAgIGNh c2UgTWVtb3J5VXNhZ2VQb2xpY3k6OlVucmVzdHJpY3RlZDoKICAgICBkZWZhdWx0OgogICAgICAg ICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKQEAgLTE1MCw2ICsxNDksNyBAQCB2b2lkIE1lbW9yeVBy ZXNzdXJlSGFuZGxlcjo6c2hyaW5rT3JEaWUoKQogICAgICAgICByZXR1cm47CiAgICAgfQogCisg ICAgV1RGTG9nQWx3YXlzKCJVbmFibGUgdG8gc2hyaW5rIG1lbW9yeSBmb290cHJpbnQgb2YgcHJv Y2VzcyAoJWx1IE1CKSBiZWxvdyB0aGUga2lsbCB0aHJlc29sZCAoJWx1IE1CKS4gS2lsbGVkXG4i LCBmb290cHJpbnQudmFsdWUoKSAvIE1CLCB0aHJlc2hvbGRGb3JNZW1vcnlLaWxsKCkgLyBNQik7 CiAgICAgUkVMRUFTRV9BU1NFUlQobV9tZW1vcnlLaWxsQ2FsbGJhY2spOwogICAgIG1fbWVtb3J5 S2lsbENhbGxiYWNrKCk7CiB9Cg== 336125 2018-03-20 08:20:21 -0700 2018-03-23 05:41:50 -0700 Patch bug-183773-20180320162019.patch text/plain 3681 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU0YzQyMTUxM2U4NzJkYzgxZmM3NmM0 Y2Q3NjllN2MyNjk2NjZlMDkuLjMyNDA2NGY2MjBjZjM1OWExZDMxZmU0Mzg4NDM5OWYzZGU3N2Jl MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMDMtMjAgIENhcmxvcyBBbGJlcnRvIExvcGV6 IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgV2ViUHJvY2VzcyBtZW1vcnkg bW9uaXRvciB0aHJlc2hvbGRzIHNob3VsZCBiZSBiZXR0ZXIgdHVuZWQgZm9yIGVtYmVkZGVkIHN5 c3RlbXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODM3NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU YWtlIGludG8gYWNjb3VudCB0aGUgdG90YWwgc3lzdGVtIFJBTSBmb3IgdGhlIHRocmVzaG9sZHMg Y2FsY3VsYXRpb24uCisKKyAgICAgICAgRm9yIHN5c3RlbXMgd2l0aCBtb3JlIHRoYW4gM0dCIHRo ZSBjb25zZXJ2YXRpdmUgYW5kIHN0cmljdCB0aHJlc2hvbGRzIHJlbWFpbiBhcyB0aGV5IGFyZSwK KyAgICAgICAgYnV0IGZvciBzeXN0ZW1zIHdpdGggbGVzcyBSQU0gdGhlIHRocmVzaG9sZHMgYXJl IGR5bmFtaWNhbGx5IGNvbmZpZ3VyZWQgYXMgZm9sbG93czoKKworICAgICAgICAtIENvbnNlcnZh dGl2ZSB0aHJlc2hvbGQgKHJlbGVhc2Ugbm9uIGNyaXRpY2FsIG1lbW9yeSkgaWYgV2ViUHJvY2Vz cyB1c2luZyBtb3JlIHRoYW4gMzMlIG9mIHRoZSB0b3RhbCBSQU0uCisgICAgICAgIC0gU3RyaWN0 IHRocmVzaG9sZCAocmVsZWFzZSBhbGwgcG9zc2libGUgbWVtb3J5KSBpZiBXZWJQcm9jZXNzIHVz aW5nIG1vcmUgdGhhbiA1MCUgb2YgdGhlIHRvdGFsIFJBTS4KKworICAgICAgICBUaGUgS2lsbCB0 aHJlc2hvbGQgaXMgYWxzbyBtb2RpZmllZC4gTm93IGl0IGlzIGNhcHBlZCBhdCA5MCUgb2YgdGhl IHRvdGFsIFJBTS4KKworICAgICAgICAqIHd0Zi9NZW1vcnlQcmVzc3VyZUhhbmRsZXIuY3BwOgor ICAgICAgICAoV1RGOjp0aHJlc2hvbGRGb3JNZW1vcnlLaWxsV2l0aFByb2Nlc3NTdGF0ZSk6Cisg ICAgICAgIChXVEY6OnRocmVzaG9sZEZvclBvbGljeSk6CisgICAgICAgIChXVEY6Ok1lbW9yeVBy ZXNzdXJlSGFuZGxlcjo6c2hyaW5rT3JEaWUpOgorCiAyMDE4LTAzLTE5ICBFcmljIENhcmxzb24g IDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtFeHRyYSB6b29tIG1vZGVdIFJl cXVpcmUgZnVsbHNjcmVlbiBmb3IgdmlkZW8gcGxheWJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9NZW1vcnlQ cmVzc3VyZUhhbmRsZXIuY3BwCmluZGV4IGJiMzQyMTU2OGEwNjc3ZjBlNmVhYzA0MDAwMzgwNTVi MDhiNzgyM2MuLjAzZWNiZDE2MmFkZWUzZDcxYWM0MDVlMWRkMzRkYmViYjY5YTQ2N2MgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHAKKysrIGIvU291 cmNlL1dURi93dGYvTWVtb3J5UHJlc3N1cmVIYW5kbGVyLmNwcApAQCAtMjgsNiArMjgsNyBAQAog CiAjaW5jbHVkZSA8d3RmL01lbW9yeUZvb3RwcmludC5oPgogI2luY2x1ZGUgPHd0Zi9OZXZlckRl c3Ryb3llZC5oPgorI2luY2x1ZGUgPHd0Zi9SQU1TaXplLmg+CiAKICNkZWZpbmUgTE9HX0NIQU5O RUxfUFJFRklYIExvZwogCkBAIC04NCwyMCArODUsMTcgQEAgc3RhdGljIGNvbnN0IGNoYXIqIHRv U3RyaW5nKE1lbW9yeVVzYWdlUG9saWN5IHBvbGljeSkKIAogc3RhdGljIHNpemVfdCB0aHJlc2hv bGRGb3JNZW1vcnlLaWxsV2l0aFByb2Nlc3NTdGF0ZShXZWJzYW1Qcm9jZXNzU3RhdGUgcHJvY2Vz c1N0YXRlLCB1bnNpZ25lZCB0YWJDb3VudCkKIHsKKyAgICBzaXplX3QgYmFzZVRocmVzaG9sZCA9 IDIgKiBHQjsKICNpZiBDUFUoWDg2XzY0KSB8fCBDUFUoQVJNNjQpCi0gICAgc2l6ZV90IGJhc2VU aHJlc2hvbGQ7CiAgICAgaWYgKHByb2Nlc3NTdGF0ZSA9PSBXZWJzYW1Qcm9jZXNzU3RhdGU6OkFj dGl2ZSkKICAgICAgICAgYmFzZVRocmVzaG9sZCA9IDQgKiBHQjsKLSAgICBlbHNlCi0gICAgICAg IGJhc2VUaHJlc2hvbGQgPSAyICogR0I7Ci0gICAgaWYgKHRhYkNvdW50IDw9IDEpCi0gICAgICAg IHJldHVybiBiYXNlVGhyZXNob2xkOwotICAgIHJldHVybiBiYXNlVGhyZXNob2xkICsgKHN0ZDo6 bWluKHRhYkNvdW50IC0gMSwgNHUpICogMSAqIEdCKTsKKyAgICBpZiAodGFiQ291bnQgPiAxKQor ICAgICAgICBiYXNlVGhyZXNob2xkICs9IHN0ZDo6bWluKHRhYkNvdW50IC0gMSwgNHUpICogMSAq IEdCOwogI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0ocHJvY2Vzc1N0YXRlKTsKLSAgICBVTlVTRURf UEFSQU0odGFiQ291bnQpOwotICAgIHJldHVybiAzICogR0I7CisgICAgaWYgKCh0YWJDb3VudCA+ IDEpIHx8IChwcm9jZXNzU3RhdGUgPT0gV2Vic2FtUHJvY2Vzc1N0YXRlOjpBY3RpdmUpKQorICAg ICAgICBiYXNlVGhyZXNob2xkID0gMyAqIEdCOwogI2VuZGlmCisgICAgcmV0dXJuIHN0ZDo6bWlu KGJhc2VUaHJlc2hvbGQsIHN0YXRpY19jYXN0PHNpemVfdD4ocmFtU2l6ZSgpICogMC45KSk7CiB9 CiAKIHZvaWQgTWVtb3J5UHJlc3N1cmVIYW5kbGVyOjpzZXRQYWdlQ291bnQodW5zaWduZWQgcGFn ZUNvdW50KQpAQCAtMTE0LDExICsxMTIsMTIgQEAgc2l6ZV90IE1lbW9yeVByZXNzdXJlSGFuZGxl cjo6dGhyZXNob2xkRm9yTWVtb3J5S2lsbCgpCiAKIHN0YXRpYyBzaXplX3QgdGhyZXNob2xkRm9y UG9saWN5KE1lbW9yeVVzYWdlUG9saWN5IHBvbGljeSkKIHsKKyAgICBjb25zdCBzaXplX3QgYmFz ZVRocmVzaG9sZEZvclBvbGljeSA9IHN0ZDo6bWluKDMgKiBHQiwgcmFtU2l6ZSgpKTsKICAgICBz d2l0Y2ggKHBvbGljeSkgewogICAgIGNhc2UgTWVtb3J5VXNhZ2VQb2xpY3k6OkNvbnNlcnZhdGl2 ZToKLSAgICAgICAgcmV0dXJuIDEgKiBHQjsKKyAgICAgICAgcmV0dXJuIGJhc2VUaHJlc2hvbGRG b3JQb2xpY3kgLyAzOwogICAgIGNhc2UgTWVtb3J5VXNhZ2VQb2xpY3k6OlN0cmljdDoKLSAgICAg ICAgcmV0dXJuIDEuNSAqIEdCOworICAgICAgICByZXR1cm4gYmFzZVRocmVzaG9sZEZvclBvbGlj eSAvIDI7CiAgICAgY2FzZSBNZW1vcnlVc2FnZVBvbGljeTo6VW5yZXN0cmljdGVkOgogICAgIGRl ZmF1bHQ6CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwpAQCAtMTUwLDYgKzE0OSw3IEBA IHZvaWQgTWVtb3J5UHJlc3N1cmVIYW5kbGVyOjpzaHJpbmtPckRpZSgpCiAgICAgICAgIHJldHVy bjsKICAgICB9CiAKKyAgICBXVEZMb2dBbHdheXMoIlVuYWJsZSB0byBzaHJpbmsgbWVtb3J5IGZv b3RwcmludCBvZiBwcm9jZXNzICglbHUgTUIpIGJlbG93IHRoZSBraWxsIHRocmVzb2xkICglbHUg TUIpLiBLaWxsZWRcbiIsIGZvb3RwcmludC52YWx1ZSgpIC8gTUIsIHRocmVzaG9sZEZvck1lbW9y eUtpbGwoKSAvIE1CKTsKICAgICBSRUxFQVNFX0FTU0VSVChtX21lbW9yeUtpbGxDYWxsYmFjayk7 CiAgICAgbV9tZW1vcnlLaWxsQ2FsbGJhY2soKTsKIH0K