183760 2018-03-19 19:04:11 -0700 NetworkStateNotifier::updateStateWithoutNotifying() is inefficient 2018-03-23 16:47:24 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez aestes ap beidson commit-queue rniwa webkit-bug-importer oldest_to_newest 1407541 0 cdumez 2018-03-19 19:04:11 -0700 NetworkStateNotifier::updateStateWithoutNotifying() is inefficient. In particular, the call to SCDynamicStoreCopyKeyList() is very expensive and can be avoided. 1407542 1 cdumez 2018-03-19 19:04:26 -0700 <rdar://problem/37093299> 1407543 2 336095 cdumez 2018-03-19 19:12:43 -0700 Created attachment 336095 Patch 1408824 3 336404 cdumez 2018-03-23 12:26:19 -0700 Created attachment 336404 Patch 1408962 4 336404 cdumez 2018-03-23 16:46:54 -0700 Comment on attachment 336404 Patch Clearing flags on attachment: 336404 Committed r229935: <https://trac.webkit.org/changeset/229935> 1408963 5 cdumez 2018-03-23 16:46:56 -0700 All reviewed patches have been landed. Closing bug. 1408964 6 webkit-bug-importer 2018-03-23 16:47:24 -0700 <rdar://problem/38812960> 336095 2018-03-19 19:12:43 -0700 2018-03-23 12:26:18 -0700 Patch bug-183760-20180319191242.patch text/plain 3744 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhiMjU0NTk2YTU5YTI0 NzkyMzJiMjhmMzk4MzEyODFlMDJlY2YwMy4uZTMxMGRjNWZkNjc3YzQ1MWY0OWM1MGZlNzY4ZmQ1 ZmJiN2Q2NzI4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE4LTAzLTE5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTmV0d29ya1N0YXRlTm90aWZp ZXI6OnVwZGF0ZVN0YXRlV2l0aG91dE5vdGlmeWluZygpIGlzIGluZWZmaWNpZW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM3NjAKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzM3MDkzMjk5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBOZXR3b3JrU3RhdGVOb3RpZmllcjo6dXBkYXRlU3Rh dGVXaXRob3V0Tm90aWZ5aW5nKCkgdG8gc3RvcCBjYWxsaW5nCisgICAgICAgIFNDRHluYW1pY1N0 b3JlQ29weUtleUxpc3QoKS4gU0NEeW5hbWljU3RvcmVDb3B5S2V5TGlzdCgpIGlzIGV4cGVuc2l2 ZSBhcyBpdAorICAgICAgICBleHBlY3RzIGl0cyBrZXkgcGFyYW1ldGVyIHRvIGJlIGEgcmVndWxh ciBleHByZXNzaW9uLiBJdCBpcyBhbHNvIHVubmVjZXNzYXJ5CisgICAgICAgIGluIG91ciBjYXNl IHNpbmNlIHdlIGFscmVhZHkgaGF2ZSBhbiBleGFjdCBrZXkuIFdlIG5vdyBjYWxsIHRoZSBtb3Jl IGVmZmljaWVudAorICAgICAgICBTQ0R5bmFtaWNTdG9yZUNvcHlWYWx1ZSgpIGluc3RlYWQgYW5k IGxvb2t1cCB0aGUga1NDUHJvcE5ldExpbmtBY3RpdmUga2V5CisgICAgICAgIGluIHRoZSByZXR1 cm5lZCBkaWN0aW9uYXJ5IHRvIGNoZWNrIGlmIHRoZSBuZXR3b3JrIGludGVyZmFjZSBpcyBhY3Rp dmUgb3Igbm90LgorCisgICAgICAgIFRoaXMgd2FzIHRlc3RlZCBtYW51YWxseSBhcyB0aGVyZSBp cyBubyBlYXN5IHdheSB0byB3cml0ZSBhbiBhdXRvbWF0ZWQgdGVzdAorICAgICAgICBmb3IgdGhp cy4KKworICAgICAgICBJbiBhIGZvbGxvdy11cCwgSSBhbHNvIHBsYW4gdG8gY2FsbCBleGVjdXRl IHRoaXMgY29kZSBpbiB0aGUgVUlQcm9jZXNzIHRvCisgICAgICAgIGF2b2lkIGNhbGxpbmcgaXQg b25jZSBwZXIgV2ViUHJvY2Vzcy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL05l dHdvcmtTdGF0ZU5vdGlmaWVyTWFjLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzSW50ZXJmYWNl QWN0aXZlKToKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtTdGF0ZU5vdGlmaWVyOjp1cGRhdGVT dGF0ZVdpdGhvdXROb3RpZnlpbmcpOgorCiAyMDE4LTAzLTE5ICBKaWV3ZW4gVGFuICA8amlld2Vu X3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYW5vdGhlciBxdWljayBmaXgg Zm9yIHIyMjk2OTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv bWFjL05ldHdvcmtTdGF0ZU5vdGlmaWVyTWFjLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvbWFjL05ldHdvcmtTdGF0ZU5vdGlmaWVyTWFjLmNwcAppbmRleCA2MWRmNzgzYmIx ZDkwYTk4MzU5ZDU5ZDcyOTcwZDg2OTkxNWFkNmQwLi5jNDdjOWM3NWQyNjU0MzM4NmRjZGE0ZDdj NTk2YmIyZmZlNDVkNGEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL21hYy9OZXR3b3JrU3RhdGVOb3RpZmllck1hYy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9tYWMvTmV0d29ya1N0YXRlTm90aWZpZXJNYWMuY3BwCkBAIC0zMiw2 ICszMiwzMSBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK3N0YXRpYyBib29sIGlzSW50ZXJm YWNlQWN0aXZlKFNDRHluYW1pY1N0b3JlUmVmIHN0b3JlLCBDRlN0cmluZ1JlZiBpbnRlcmZhY2VO YW1lKQoreworICAgIGF1dG8ga2V5ID0gYWRvcHRDRihTQ0R5bmFtaWNTdG9yZUtleUNyZWF0ZU5l dHdvcmtJbnRlcmZhY2VFbnRpdHkoMCwga1NDRHluYW1pY1N0b3JlRG9tYWluU3RhdGUsIGludGVy ZmFjZU5hbWUsIGtTQ0VudE5ldElQdjQpKTsKKyAgICBhdXRvIGRpY3QgPSBhZG9wdENGKChDRkRp Y3Rpb25hcnlSZWYpU0NEeW5hbWljU3RvcmVDb3B5VmFsdWUoc3RvcmUsIGtleS5nZXQoKSkpOwor ICAgIGlmICghZGljdCB8fCBDRkdldFR5cGVJRChkaWN0LmdldCgpKSAhPSBDRkRpY3Rpb25hcnlH ZXRUeXBlSUQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgQ0ZUeXBlUmVmIGxpbmtB Y3RpdmUgPSBDRkRpY3Rpb25hcnlHZXRWYWx1ZShkaWN0LmdldCgpLCBrU0NQcm9wTmV0TGlua0Fj dGl2ZSk7CisgICAgaWYgKCFsaW5rQWN0aXZlKSB7CisgICAgICAgIC8vIGlmIG5vIHN0YXR1cywg dGhlbiBhc3N1bWUgaXQncyB1cCBiZWNhdXNlIHRoYXQncyB0aGUgd2F5IFNDIGRvZXMgaXQuCisg ICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKworICAgIGJvb2wgaXNBY3RpdmUgPSBmYWxzZTsK KyAgICBpZiAoQ0ZHZXRUeXBlSUQobGlua0FjdGl2ZSkgPT0gQ0ZCb29sZWFuR2V0VHlwZUlEKCkp IHsKKyAgICAgICAgaWYgKENGQm9vbGVhbkdldFZhbHVlKChDRkJvb2xlYW5SZWYpbGlua0FjdGl2 ZSkpCisgICAgICAgICAgICBpc0FjdGl2ZSA9IHRydWU7CisgICAgfSBlbHNlIGlmIChDRkdldFR5 cGVJRChsaW5rQWN0aXZlKSA9PSBDRk51bWJlckdldFR5cGVJRCgpKSB7CisgICAgICAgIGludCBp bnRWYWx1ZTsKKyAgICAgICAgaWYgKENGTnVtYmVyR2V0VmFsdWUoKENGTnVtYmVyUmVmKWxpbmtB Y3RpdmUsIGtDRk51bWJlckludFR5cGUsICZpbnRWYWx1ZSkpCisgICAgICAgICAgICBpc0FjdGl2 ZSA9ICEhaW50VmFsdWU7CisgICAgfQorICAgIHJldHVybiBpc0FjdGl2ZTsKK30KKwogdm9pZCBO ZXR3b3JrU3RhdGVOb3RpZmllcjo6dXBkYXRlU3RhdGVXaXRob3V0Tm90aWZ5aW5nKCkKIHsKICAg ICBhdXRvIGtleSA9IGFkb3B0Q0YoU0NEeW5hbWljU3RvcmVLZXlDcmVhdGVOZXR3b3JrSW50ZXJm YWNlKDAsIGtTQ0R5bmFtaWNTdG9yZURvbWFpblN0YXRlKSk7CkBAIC02MCw5ICs4NSw3IEBAIHZv aWQgTmV0d29ya1N0YXRlTm90aWZpZXI6OnVwZGF0ZVN0YXRlV2l0aG91dE5vdGlmeWluZygpCiAg ICAgICAgIGlmIChDRlN0cmluZ0hhc1ByZWZpeChpbnRlcmZhY2VOYW1lLCBDRlNUUigidm1uZXQi KSkpCiAgICAgICAgICAgICBjb250aW51ZTsKIAotICAgICAgICBhdXRvIGtleSA9IGFkb3B0Q0Yo U0NEeW5hbWljU3RvcmVLZXlDcmVhdGVOZXR3b3JrSW50ZXJmYWNlRW50aXR5KDAsIGtTQ0R5bmFt aWNTdG9yZURvbWFpblN0YXRlLCBpbnRlcmZhY2VOYW1lLCBrU0NFbnROZXRJUHY0KSk7Ci0gICAg ICAgIGF1dG8ga2V5TGlzdCA9IGFkb3B0Q0YoU0NEeW5hbWljU3RvcmVDb3B5S2V5TGlzdChtX3N0 b3JlLmdldCgpLCBrZXkuZ2V0KCkpKTsKLSAgICAgICAgaWYgKGtleUxpc3QgJiYgQ0ZBcnJheUdl dENvdW50KGtleUxpc3QuZ2V0KCkpKSB7CisgICAgICAgIGlmIChpc0ludGVyZmFjZUFjdGl2ZSht X3N0b3JlLmdldCgpLCBpbnRlcmZhY2VOYW1lKSkgewogICAgICAgICAgICAgbV9pc09uTGluZSA9 IHRydWU7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0K 336404 2018-03-23 12:26:19 -0700 2018-03-23 16:46:54 -0700 Patch bug-183760-20180323122618.patch text/plain 2481 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5OTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM5NTM4NDhhYTdkZWFj MTljOTQyNTVkMDliODRkYjkzMmM0ODM5My4uYTliZTRlYmM1YTZjYWQ4NDA1OTYyNWQ5OTNkNTU0 OGI3YjVmNTgwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE4LTAzLTIzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTmV0d29ya1N0YXRlTm90aWZp ZXI6OnVwZGF0ZVN0YXRlV2l0aG91dE5vdGlmeWluZygpIGlzIGluZWZmaWNpZW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM3NjAKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzM3MDkzMjk5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBOZXR3b3JrU3RhdGVOb3RpZmllcjo6dXBkYXRlU3Rh dGVXaXRob3V0Tm90aWZ5aW5nKCkgdG8gc3RvcCBjYWxsaW5nCisgICAgICAgIFNDRHluYW1pY1N0 b3JlQ29weUtleUxpc3QoKS4gU0NEeW5hbWljU3RvcmVDb3B5S2V5TGlzdCgpIGlzIGV4cGVuc2l2 ZSBhcyBpdAorICAgICAgICBleHBlY3RzIGl0cyBrZXkgcGFyYW1ldGVyIHRvIGJlIGEgcmVndWxh ciBleHByZXNzaW9uIGFuZCBpdCBjYW4gbWF0Y2ggc2V2ZXJhbAorICAgICAgICBrZXlzLiBJdCBp cyBhbHNvIHVubmVjZXNzYXJ5IGluIG91ciBjYXNlIHNpbmNlIHdlIGFscmVhZHkgaGF2ZSBhbiBl eGFjdCBrZXkuCisgICAgICAgIFdlIG5vdyBjYWxsIHRoZSBtb3JlIGVmZmljaWVudCBTQ0R5bmFt aWNTdG9yZUNvcHlWYWx1ZSgpIGluc3RlYWQsIHdoaWNoIGlzCisgICAgICAgIHRoZSByaWdodCB0 aGluZyB0byBjYWxsIHdoZW4gd2UgaGF2ZSBhbiBleGFjdCBrZXkuCisKKyAgICAgICAgVGhpcyBj aGFuZ2Ugd2FzIHN1Z2dlc3RlZCBieSB0aGUgU0MgdGVhbS4KKworICAgICAgICBUaGlzIHdhcyB0 ZXN0ZWQgbWFudWFsbHkgYXMgdGhlcmUgaXMgbm8gZWFzeSB3YXkgdG8gd3JpdGUgYW4gYXV0b21h dGVkIHRlc3QKKyAgICAgICAgZm9yIHRoaXMuCisKKyAgICAgICAgSW4gYSBmb2xsb3ctdXAsIEkg YWxzbyBwbGFuIHRvIGNhbGwgdGhpcyBjb2RlIGluIHRoZSBVSVByb2Nlc3MgKG9yIE5ldHdvcmtQ cm9jZXNzKQorICAgICAgICB0byBhdm9pZCBjYWxsaW5nIGl0IG9uY2UgcGVyIFdlYlByb2Nlc3Mu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9OZXR3b3JrU3RhdGVOb3RpZmllck1h Yy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrU3RhdGVOb3RpZmllcjo6dXBkYXRlU3Rh dGVXaXRob3V0Tm90aWZ5aW5nKToKKwogMjAxOC0wMy0yMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgQWN0aXZlRE9NT2JqZWN0IHNob3VsZCBhc3NlcnQgdGhh dCB0aGV5IGFyZSBkZXN0cm95ZWQgaW4gdGhlIHRocmVhZCB0aGV5IGFyZSBjcmVhdGVkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9OZXR3b3JrU3RhdGVO b3RpZmllck1hYy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9OZXR3 b3JrU3RhdGVOb3RpZmllck1hYy5jcHAKaW5kZXggNjFkZjc4M2JiMWQ5MGE5ODM1OWQ1OWQ3Mjk3 MGQ4Njk5MTVhZDZkMC4uYjFiNzYwMDNmMWVlMDlhNDM4N2E1NTM4ODQ3YzFmYTA2YWEzMzU1YyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvTmV0d29ya1N0 YXRlTm90aWZpZXJNYWMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv bWFjL05ldHdvcmtTdGF0ZU5vdGlmaWVyTWFjLmNwcApAQCAtNjEsOCArNjEsNyBAQCB2b2lkIE5l dHdvcmtTdGF0ZU5vdGlmaWVyOjp1cGRhdGVTdGF0ZVdpdGhvdXROb3RpZnlpbmcoKQogICAgICAg ICAgICAgY29udGludWU7CiAKICAgICAgICAgYXV0byBrZXkgPSBhZG9wdENGKFNDRHluYW1pY1N0 b3JlS2V5Q3JlYXRlTmV0d29ya0ludGVyZmFjZUVudGl0eSgwLCBrU0NEeW5hbWljU3RvcmVEb21h aW5TdGF0ZSwgaW50ZXJmYWNlTmFtZSwga1NDRW50TmV0SVB2NCkpOwotICAgICAgICBhdXRvIGtl eUxpc3QgPSBhZG9wdENGKFNDRHluYW1pY1N0b3JlQ29weUtleUxpc3QobV9zdG9yZS5nZXQoKSwg a2V5LmdldCgpKSk7Ci0gICAgICAgIGlmIChrZXlMaXN0ICYmIENGQXJyYXlHZXRDb3VudChrZXlM aXN0LmdldCgpKSkgeworICAgICAgICBpZiAoU0NEeW5hbWljU3RvcmVDb3B5VmFsdWUobV9zdG9y ZS5nZXQoKSwga2V5LmdldCgpKSkgewogICAgICAgICAgICAgbV9pc09uTGluZSA9IHRydWU7CiAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0K