183759 2018-03-19 18:32:53 -0700 Clear style colors when setting default appearance 2018-03-19 19:49:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1407536 0 megan_gardner 2018-03-19 18:32:53 -0700 Clear style colors when setting default appearance 1407537 1 336093 megan_gardner 2018-03-19 18:35:08 -0700 Created attachment 336093 Patch 1407539 2 webkit-bug-importer 2018-03-19 18:37:54 -0700 <rdar://problem/38645722> 1407540 3 336093 thorton 2018-03-19 19:03:24 -0700 Comment on attachment 336093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336093&action=review > Source/WebKitLegacy/mac/WebView/WebView.mm:5202 > +- (void)_setDefaultAppearanceAndClearStyle I think this is “update”, not “set”, because it takes no arguments. And you can leave the clearStyle bit off 1407557 4 megan_gardner 2018-03-19 19:49:38 -0700 https://trac.webkit.org/changeset/229737/webkit 336093 2018-03-19 18:35:08 -0700 2018-03-19 19:03:24 -0700 Patch bug-183759-20180319183508.patch text/plain 3970 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjk3MzApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAzLTE5ICBNZWdhbiBHYXJk bmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYXIgc3R5bGUgY29s b3JzIHdoZW4gc2V0dGluZyBkZWZhdWx0IGFwcGVhcmFuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mzc1OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbG9ycyBhcmUgY2FjaGVkIGFuZCBuZWVkIHRv IGJlIGNsZWFyZWQgYW5kIHJlY2FsY3VsYXRlZC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2V0RGVmYXVsdEFw cGVhcmFuY2UpOgorCiAyMDE4LTAzLTE5ICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYW5vdGhlciBxdWljayBmaXggZm9yIHIyMjk2OTkK SW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCShy ZXZpc2lvbiAyMjk2NzkpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgzLDYgKzE4Myw3IEBACiAjaW5jbHVkZSA8V2Vi Q29yZS9Qcm9taXNlZEJsb2JJbmZvLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SYW5nZS5oPgogI2lu Y2x1ZGUgPFdlYkNvcmUvUmVuZGVyTGF5ZXIuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL1JlbmRlclRo ZW1lLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZW5kZXJUcmVlQXNUZXh0Lmg+CiAjaW5jbHVkZSA8 V2ViQ29yZS9SZW5kZXJWaWV3Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZVJlcXVlc3Qu aD4KQEAgLTQxMzAsNiArNDEzMSw3IEBAIHZvaWQgV2ViUGFnZTo6c2V0VXNlU3lzdGVtQXBwZWFy YW5jZShib28KIHZvaWQgV2ViUGFnZTo6c2V0RGVmYXVsdEFwcGVhcmFuY2UoYm9vbCBkZWZhdWx0 QXBwZWFyYW5jZSkKIHsKICAgICBjb3JlUGFnZSgpLT5zZXREZWZhdWx0QXBwZWFyYW5jZShkZWZh dWx0QXBwZWFyYW5jZSk7CisgICAgUmVuZGVyVGhlbWU6OnNpbmdsZXRvbigpLnBsYXRmb3JtQ29s b3JzRGlkQ2hhbmdlKCk7CiAgICAgY29yZVBhZ2UoKS0+c2V0TmVlZHNSZWNhbGNTdHlsZUluQWxs RnJhbWVzKCk7CiB9CiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyOTY3OSkKKysrIFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAzLTE5ICBNZWdhbiBHYXJkbmVyICA8 bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYXIgc3R5bGUgY29sb3JzIHdo ZW4gc2V0dGluZyBkZWZhdWx0IGFwcGVhcmFuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mzc1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENvbG9ycyBhcmUgY2FjaGVkIGFuZCBuZWVkIHRvIGJlIGNs ZWFyZWQgYW5kIHJlY2FsY3VsYXRlZC4KKyAgICAgICAgUmVmYWN0b3IgdG8gZG8gYWxsIHN0eWxl IHJlY2FsY3MgdG9nZXRoZXIuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAg ICAgICgtW1dlYlZpZXcgX3NldERlZmF1bHRBcHBlYXJhbmNlQW5kQ2xlYXJTdHlsZV0pOgorICAg ICAgICAoLVtXZWJWaWV3IF9zZXRVc2VTeXN0ZW1BcHBlYXJhbmNlOl0pOgorICAgICAgICAoLVtX ZWJWaWV3IGVmZmVjdGl2ZUFwcGVhcmFuY2VEaWRDaGFuZ2VdKToKKwogMjAxOC0wMy0xNiAgTWVn YW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEVuc3VyZSB0 aGF0IHN0eWxlIGlzIHVwZGF0ZWQgd2hlbiB0aGUgZWZmZWN0aXZlIGFwcGVhcmFuY2UgY2hhbmdl cwpJbmRleDogU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkocmV2 aXNpb24gMjI5Njc5KQorKysgU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3 Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xODUsNiArMTg1LDcgQEAKICNpbXBvcnQgPFdlYkNvcmUv UGF0aFV0aWxpdGllcy5oPgogI2ltcG9ydCA8V2ViQ29yZS9QbGF0Zm9ybUV2ZW50RmFjdG9yeU1h Yy5oPgogI2ltcG9ydCA8V2ViQ29yZS9Qcm9ncmVzc1RyYWNrZXIuaD4KKyNpbXBvcnQgPFdlYkNv cmUvUmVuZGVyVGhlbWUuaD4KICNpbXBvcnQgPFdlYkNvcmUvUmVuZGVyVmlldy5oPgogI2ltcG9y dCA8V2ViQ29yZS9SZW5kZXJXaWRnZXQuaD4KICNpbXBvcnQgPFdlYkNvcmUvUmVzb3VyY2VIYW5k bGUuaD4KQEAgLTUxOTcsMTIgKzUxOTgsMTkgQEAgLSAoV2ViRWRnZUluc2V0cylfdW5vYnNjdXJl ZFNhZmVBcmVhSW5zZQogLSAoYm9vbClfZGVmYXVsdEFwcGVhcmFuY2UgeyByZXR1cm4gdHJ1ZTsg fQogI2VuZGlmCiAKKworLSAodm9pZClfc2V0RGVmYXVsdEFwcGVhcmFuY2VBbmRDbGVhclN0eWxl Cit7CisgICAgX3ByaXZhdGUtPnBhZ2UtPnNldERlZmF1bHRBcHBlYXJhbmNlKFtzZWxmIF9kZWZh dWx0QXBwZWFyYW5jZV0pOworICAgIFJlbmRlclRoZW1lOjpzaW5nbGV0b24oKS5wbGF0Zm9ybUNv bG9yc0RpZENoYW5nZSgpOworICAgIF9wcml2YXRlLT5wYWdlLT5zZXROZWVkc1JlY2FsY1N0eWxl SW5BbGxGcmFtZXMoKTsKK30KKwogLSAodm9pZClfc2V0VXNlU3lzdGVtQXBwZWFyYW5jZTooQk9P TCl1c2VTeXN0ZW1BcHBlYXJhbmNlCiB7CiAgICAgaWYgKGF1dG8gcGFnZSA9IF9wcml2YXRlLT5w YWdlKSB7CiAgICAgICAgIHBhZ2UtPnNldFVzZVN5c3RlbUFwcGVhcmFuY2UodXNlU3lzdGVtQXBw ZWFyYW5jZSk7Ci0gICAgICAgIHBhZ2UtPnNldERlZmF1bHRBcHBlYXJhbmNlKFtzZWxmIF9kZWZh dWx0QXBwZWFyYW5jZV0pOwotICAgICAgICBwYWdlLT5zZXROZWVkc1JlY2FsY1N0eWxlSW5BbGxG cmFtZXMoKTsKKyAgICAgICAgW3NlbGYgX3NldERlZmF1bHRBcHBlYXJhbmNlQW5kQ2xlYXJTdHls ZV07CiAgICAgfQogfQogCkBAIC01MjE5LDggKzUyMjcsNyBAQCAtICh2b2lkKWVmZmVjdGl2ZUFw cGVhcmFuY2VEaWRDaGFuZ2UKICAgICBpZiAoIV9wcml2YXRlLT5wYWdlKQogICAgICAgICByZXR1 cm47CiAgICAgCi0gICAgX3ByaXZhdGUtPnBhZ2UtPnNldERlZmF1bHRBcHBlYXJhbmNlKFtzZWxm IF9kZWZhdWx0QXBwZWFyYW5jZV0pOwotICAgIF9wcml2YXRlLT5wYWdlLT5zZXROZWVkc1JlY2Fs Y1N0eWxlSW5BbGxGcmFtZXMoKTsKKyAgICBbc2VsZiBfc2V0RGVmYXVsdEFwcGVhcmFuY2VBbmRD bGVhclN0eWxlXTsKIH0KIAogLSAodm9pZClfc2V0U291cmNlQXBwbGljYXRpb25BdWRpdERhdGE6 KE5TRGF0YSAqKXNvdXJjZUFwcGxpY2F0aW9uQXVkaXREYXRhCg==