183757 2018-03-19 16:51:11 -0700 Add a layout test verifying AppCache resource fetches have the document's cookie in place 2018-03-19 19:29:20 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson achristensen aestes cdumez commit-queue lforschler webkit-bug-importer oldest_to_newest 1407511 0 beidson 2018-03-19 16:51:11 -0700 Add a layout test verifying AppCache resource fetches have the document's cookie in place For a brief period we broke this. We refixed it on trunk. I'm adding a test to verify it remains fixed on trunk. 1407513 1 beidson 2018-03-19 17:12:14 -0700 Note: a test verifying the manifest file itself has these cookies set was landed in https://trac.webkit.org/changeset/229691/webkit This test is a further elaboration on that. 1407515 2 336086 beidson 2018-03-19 17:22:06 -0700 Created attachment 336086 patch I'm attaching this patch knowingly without a ChangeLog to get EWS to run on it. I will make a ChangeLog before I land. 1407538 3 336094 beidson 2018-03-19 18:37:05 -0700 Created attachment 336094 Patch 1407545 4 336094 commit-queue 2018-03-19 19:28:01 -0700 Comment on attachment 336094 Patch Clearing flags on attachment: 336094 Committed r229733: <https://trac.webkit.org/changeset/229733> 1407546 5 commit-queue 2018-03-19 19:28:03 -0700 All reviewed patches have been landed. Closing bug. 1407548 6 webkit-bug-importer 2018-03-19 19:29:20 -0700 <rdar://problem/38647111> 336086 2018-03-19 17:22:06 -0700 2018-03-19 18:37:04 -0700 patch patch text/plain 2707 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvZG9jdW1lbnQtY29v a2llLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvZG9jdW1l bnQtY29va2llLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMC4uMDIyMzVlNjVhNTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2FwcGNhY2hlL2RvY3VtZW50LWNvb2tpZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBA CitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTogQXBwbGljYXRpb25DYWNoZSBpcyBkZXByZWNhdGVk LiBQbGVhc2UgdXNlIFNlcnZpY2VXb3JrZXJzIGluc3RlYWQuCitUaGlzIHRlc3RzIHRoYXQgY29v a2llcyBzZXQgb24gdGhlIG1haW4gZG9jdW1lbnQgYXJlIHVzZWQgd2hlbiBhY2Nlc3NpbmcgcmVz b3VyY2VzIGluIHRoZSBtYW5pZmVzdC4KK1BBU1NFRDogQ29va2llIGlzIHNldCB0byAnYmFyJwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9kb2N1bWVudC1jb29r aWUucGhwIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9kb2N1bWVudC1jb29raWUu cGhwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi4xN2UxNWUzODJhYwot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvZG9jdW1l bnQtY29va2llLnBocApAQCAtMCwwICsxLDI4IEBACis8P3BocAorc2V0Y29va2llKCJmb28iLCAi YmFyIiwgMCwgIi8iKTsKKz8+Cis8aHRtbCBtYW5pZmVzdD0icmVzb3VyY2VzL2RvY3VtZW50LWNv b2tpZS5tYW5pZmVzdCI+CisKKzxkaXY+VGhpcyB0ZXN0cyB0aGF0IGNvb2tpZXMgc2V0IG9uIHRo ZSBtYWluIGRvY3VtZW50IGFyZSB1c2VkIHdoZW4gYWNjZXNzaW5nIHJlc291cmNlcyBpbiB0aGUg bWFuaWZlc3QuPC9kaXY+Cis8ZGl2IGlkPSJyZXN1bHQiPk5vdCBydW4geWV0PC9kaXY+Cis8c2Ny aXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0 KCkKKyAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK30KKworZnVuY3Rpb24gZHluYW1p Y1NjcmlwdExvYWQoKSB7CisJdmFyIHNjcmlwdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNj cmlwdCIpOworCXNjcmlwdC50eXBlID0gInRleHQvamF2YXNjcmlwdCI7CisJc2NyaXB0LnNyYyA9 ICIuL3Jlc291cmNlcy9jb29raWUtcHJvdGVjdGVkLXNjcmlwdC5waHAiOyAKKwlkb2N1bWVudC5n ZXRFbGVtZW50c0J5VGFnTmFtZSgiaGVhZCIpWzBdLmFwcGVuZENoaWxkKHNjcmlwdCk7Cit9CisK K2Z1bmN0aW9uIGNhY2hlZCgpCit7CisJc2V0VGltZW91dCgiZHluYW1pY1NjcmlwdExvYWQoKTsi LCAwKTsKK30KKworYXBwbGljYXRpb25DYWNoZS5hZGRFdmVudExpc3RlbmVyKCdjYWNoZWQnLCBj YWNoZWQsIGZhbHNlKTsKKzwvc2NyaXB0PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9yZXNvdXJjZXMvY29va2llLXByb3RlY3RlZC1zY3JpcHQu cGhwIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9yZXNvdXJjZXMvY29va2llLXBy b3RlY3RlZC1zY3JpcHQucGhwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw Li4zNzYzMTI0NTFjMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv YXBwY2FjaGUvcmVzb3VyY2VzL2Nvb2tpZS1wcm90ZWN0ZWQtc2NyaXB0LnBocApAQCAtMCwwICsx LDE4IEBACis8P3BocAoraGVhZGVyKCJDb250ZW50LXR5cGU6YXBwbGljYXRpb24vamF2YXNjcmlw dCIpOworCitpZiAoaXNzZXQoJF9DT09LSUVbImZvbyJdKSkgeworICAgIGVjaG8gInZhciBjb29r aWVWYWwgPSAnIiAuICRfQ09PS0lFWyJmb28iXSAuICInOyI7Cit9IGVsc2UgeworICAgIGVjaG8g InZhciBjb29raWVWYWwgPSAnPG51bGw+JzsiOworfQorCis/PgorCitpZiAoY29va2llVmFsID09 ICJiYXIiKQorCWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwgPSAi UEFTU0VEOiBDb29raWUgaXMgc2V0IHRvICdiYXInIjsKK2Vsc2UKKwlkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MID0gIkZBSUxFRDogQ29va2llIHNob3VsZCBiZSAn YmFyJywgaXMgc2V0IHRvICciICsgY29va2llVmFsICsgIiciOworCitpZiAod2luZG93LnRlc3RS dW5uZXIpCisJdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy9kb2N1bWVudC1jb29raWUubWFuaWZlc3Qg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy9kb2N1bWVudC1jb29r aWUubWFuaWZlc3QKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjAxMzU2 NmM4OTA3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNo ZS9yZXNvdXJjZXMvZG9jdW1lbnQtY29va2llLm1hbmlmZXN0CkBAIC0wLDAgKzEsNCBAQAorQ0FD SEUgTUFOSUZFU1QKKy9hcHBjYWNoZS9yZXNvdXJjZXMvY29va2llLXByb3RlY3RlZC1zY3JpcHQu cGhwCitORVRXT1JLOgorL2Zhdmljb24uaWNvCg== 336094 2018-03-19 18:37:05 -0700 2018-03-19 19:28:01 -0700 Patch bug-183757-20180319183710.patch text/plain 3814 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NzMwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTliN2ZkYWI0ZjFhZjQ1YWRmNTgz MTAwNzkzYmU3MDE5NWUzZTY5ZC4uZGY2ZDJmZjczMDRjYWE1ZWE5NmMxMTE3OWVjMzAyY2ZmZjlk ZjUzNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAzLTE5ICBCcmFkeSBFaWRzb24gIDxi ZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBsYXlvdXQgdGVzdCB2ZXJpZnlpbmcg QXBwQ2FjaGUgcmVzb3VyY2UgZmV0Y2hlcyBoYXZlIHRoZSBkb2N1bWVudCdzIGNvb2tpZSBpbiBw bGFjZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 Mzc1NworCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXggQ2hyaXN0ZW5zZW4uCisKKyAgICAgICAg KiBodHRwL3Rlc3RzL2FwcGNhY2hlL2RvY3VtZW50LWNvb2tpZS1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGh0dHAvdGVzdHMvYXBwY2FjaGUvZG9jdW1lbnQtY29va2llLnBocDogQWRk ZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9hcHBjYWNoZS9yZXNvdXJjZXMvY29va2llLXByb3Rl Y3RlZC1zY3JpcHQucGhwOiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL2FwcGNhY2hlL3Jl c291cmNlcy9kb2N1bWVudC1jb29raWUubWFuaWZlc3Q6IEFkZGVkLgorCiAyMDE4LTAzLTE5ICBD aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBwb2xpY3kgZGVj aXNpb25zIGFzeW5jaHJvbm91cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9h cHBjYWNoZS9kb2N1bWVudC1jb29raWUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9hcHBjYWNoZS9kb2N1bWVudC1jb29raWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjAy MjM1ZTY1YTUzMDBlOTJhYzlmMDg5NjAzYTA0NzQyNWI5YWYwYmEKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL2RvY3VtZW50LWNvb2tpZS1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSwzIEBACitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTogQXBwbGljYXRp b25DYWNoZSBpcyBkZXByZWNhdGVkLiBQbGVhc2UgdXNlIFNlcnZpY2VXb3JrZXJzIGluc3RlYWQu CitUaGlzIHRlc3RzIHRoYXQgY29va2llcyBzZXQgb24gdGhlIG1haW4gZG9jdW1lbnQgYXJlIHVz ZWQgd2hlbiBhY2Nlc3NpbmcgcmVzb3VyY2VzIGluIHRoZSBtYW5pZmVzdC4KK1BBU1NFRDogQ29v a2llIGlzIHNldCB0byAnYmFyJwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9h cHBjYWNoZS9kb2N1bWVudC1jb29raWUucGhwIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBj YWNoZS9kb2N1bWVudC1jb29raWUucGhwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE3ZTE1ZTM4MmFjMzgwZDVkZmQ4 MmQ3YTQ0MTA5NTVhYWRkZTI4ZjMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2FwcGNhY2hlL2RvY3VtZW50LWNvb2tpZS5waHAKQEAgLTAsMCArMSwyOCBAQAorPD9w aHAKK3NldGNvb2tpZSgiZm9vIiwgImJhciIsIDAsICIvIik7Cis/PgorPGh0bWwgbWFuaWZlc3Q9 InJlc291cmNlcy9kb2N1bWVudC1jb29raWUubWFuaWZlc3QiPgorCis8ZGl2PlRoaXMgdGVzdHMg dGhhdCBjb29raWVzIHNldCBvbiB0aGUgbWFpbiBkb2N1bWVudCBhcmUgdXNlZCB3aGVuIGFjY2Vz c2luZyByZXNvdXJjZXMgaW4gdGhlIG1hbmlmZXN0LjwvZGl2PgorPGRpdiBpZD0icmVzdWx0Ij5O b3QgcnVuIHlldDwvZGl2PgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAg IHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpCisgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7 Cit9CisKK2Z1bmN0aW9uIGR5bmFtaWNTY3JpcHRMb2FkKCkgeworCXZhciBzY3JpcHQgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCJzY3JpcHQiKTsKKwlzY3JpcHQudHlwZSA9ICJ0ZXh0L2phdmFz Y3JpcHQiOworCXNjcmlwdC5zcmMgPSAiLi9yZXNvdXJjZXMvY29va2llLXByb3RlY3RlZC1zY3Jp cHQucGhwIjsgCisJZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoImhlYWQiKVswXS5hcHBl bmRDaGlsZChzY3JpcHQpOworfQorCitmdW5jdGlvbiBjYWNoZWQoKQoreworCXNldFRpbWVvdXQo ImR5bmFtaWNTY3JpcHRMb2FkKCk7IiwgMCk7Cit9CisKK2FwcGxpY2F0aW9uQ2FjaGUuYWRkRXZl bnRMaXN0ZW5lcignY2FjaGVkJywgY2FjaGVkLCBmYWxzZSk7Cis8L3NjcmlwdD4KKzwvaHRtbD4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2VzL2Nv b2tpZS1wcm90ZWN0ZWQtc2NyaXB0LnBocCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2Fj aGUvcmVzb3VyY2VzL2Nvb2tpZS1wcm90ZWN0ZWQtc2NyaXB0LnBocApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zNzYz MTI0NTFjMTI2MGQ2ZDgxZTk0MGU2MTBiNWMxMjVkNTViZDA4Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9yZXNvdXJjZXMvY29va2llLXByb3RlY3Rl ZC1zY3JpcHQucGhwCkBAIC0wLDAgKzEsMTggQEAKKzw/cGhwCitoZWFkZXIoIkNvbnRlbnQtdHlw ZTphcHBsaWNhdGlvbi9qYXZhc2NyaXB0Iik7CisKK2lmIChpc3NldCgkX0NPT0tJRVsiZm9vIl0p KSB7CisgICAgZWNobyAidmFyIGNvb2tpZVZhbCA9ICciIC4gJF9DT09LSUVbImZvbyJdIC4gIic7 IjsKK30gZWxzZSB7CisgICAgZWNobyAidmFyIGNvb2tpZVZhbCA9ICc8bnVsbD4nOyI7Cit9CisK Kz8+CisKK2lmIChjb29raWVWYWwgPT0gImJhciIpCisJZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InJlc3VsdCIpLmlubmVySFRNTCA9ICJQQVNTRUQ6IENvb2tpZSBpcyBzZXQgdG8gJ2JhciciOwor ZWxzZQorCWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwgPSAiRkFJ TEVEOiBDb29raWUgc2hvdWxkIGJlICdiYXInLCBpcyBzZXQgdG8gJyIgKyBjb29raWVWYWwgKyAi JyI7CisKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKwl0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2VzL2Rv Y3VtZW50LWNvb2tpZS5tYW5pZmVzdCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUv cmVzb3VyY2VzL2RvY3VtZW50LWNvb2tpZS5tYW5pZmVzdApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wMTM1NjZjODkw N2EwODhmMjc3NzNlNDc0ZWU3YjczY2ZmZjVmYTBhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9yZXNvdXJjZXMvZG9jdW1lbnQtY29va2llLm1hbmlm ZXN0CkBAIC0wLDAgKzEsNCBAQAorQ0FDSEUgTUFOSUZFU1QKKy9hcHBjYWNoZS9yZXNvdXJjZXMv Y29va2llLXByb3RlY3RlZC1zY3JpcHQucGhwCitORVRXT1JLOgorL2Zhdmljb24uaWNvCg==