183753 2018-03-19 15:00:28 -0700 Have select element respect current appearance 2018-03-20 09:26:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner commit-queue ryanhaddad thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1407469 0 megan_gardner 2018-03-19 15:00:28 -0700 Have select element respect current appearance 1407519 1 336087 megan_gardner 2018-03-19 17:59:49 -0700 Created attachment 336087 Patch 1407520 2 webkit-bug-importer 2018-03-19 18:01:02 -0700 <rdar://problem/38644433> 1407521 3 336087 thorton 2018-03-19 18:04:06 -0700 Comment on attachment 336087 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336087&action=review > Source/WebCore/rendering/RenderThemeMac.mm:1348 > + style.setColor(e ? !e->isDisabledFormControl() ? systemColor(CSSValueButtontext, e->document().page()->useSystemAppearance()) : systemColor(CSSValueGraytext, e->document().page()->useSystemAppearance()) : Color::darkGray); The logic here (nested ternary operators) is incredibly hard to follow. Can we pop it out into a few lines instead? 1407522 4 thorton 2018-03-19 18:04:37 -0700 Also I can't actually follow if you don't dereference e in the !e case 1407526 5 336088 megan_gardner 2018-03-19 18:12:05 -0700 Created attachment 336088 Patch 1407528 6 336088 thorton 2018-03-19 18:15:16 -0700 Comment on attachment 336088 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336088&action=review > Source/WebCore/rendering/RenderThemeMac.mm:1350 > + c = !e->isDisabledFormControl() ? systemColor(CSSValueButtontext, e->document().page()->useSystemAppearance()) : systemColor(CSSValueGraytext, e->document().page()->useSystemAppearance()); Pop useSystemAppearance into a local 1407531 7 336090 megan_gardner 2018-03-19 18:17:17 -0700 Created attachment 336090 Patch 1407534 8 megan_gardner 2018-03-19 18:22:52 -0700 https://trac.webkit.org/changeset/229730/webkit 1407687 9 ryanhaddad 2018-03-20 09:26:35 -0700 Rebaselined failing tests in https://trac.webkit.org/changeset/229762/webkit 336087 2018-03-19 17:59:49 -0700 2018-03-19 18:12:04 -0700 Patch bug-183753-20180319175948.patch text/plain 1696 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyOTcwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAzLTE5ICBNZWdhbiBH YXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgSGF2ZSBzZWxlY3Qg ZWxlbWVudCByZXNwZWN0IGN1cnJlbnQgYXBwZWFyYW5jZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNzUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm90IGN1cnJlbnRseSB0ZXN0YWJsZSwgd2lsbCBh ZGQgdGVzdHMgaW4gYSBsYXRlciBwYXRjaC4KKworICAgICAgICBIYXZlIHRoZSBtZW51IGxpc3Rz L3NlbGVjdCBlbGVtZW50cyBmb2xsb3cgdGhlIHN5c3RlbSBjb2xvcnMuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVt ZU1hYzo6YWRqdXN0TWVudUxpc3RTdHlsZSBjb25zdCk6CisKIDIwMTgtMDMtMTkgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBFbnN1cmUgbG9jYWwg YXBwZWFyYW5jZSBhY3R1YWxseSBtaXJyb3JzIHRoZSBhcHAncyBhcHBlYXJhbmNlCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCShyZXZpc2lvbiAyMjk2 NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0JKHdvcmtp bmcgY29weSkKQEAgLTEzNDUsOCArMTM0NSw3IEBAIHZvaWQgUmVuZGVyVGhlbWVNYWM6OmFkanVz dE1lbnVMaXN0U3R5bGUKICAgICBzdHlsZS5zZXRXaGl0ZVNwYWNlKFBSRSk7CiAKICAgICAvLyBT ZXQgdGhlIGZvcmVncm91bmQgY29sb3IgdG8gYmxhY2sgb3IgZ3JheSB3aGVuIHdlIGhhdmUgdGhl IGFxdWEgbG9vay4KLSAgICAvLyBDYXN0IHRvIFJHQjMyIGlzIHRvIHdvcmsgYXJvdW5kIGEgY29t cGlsZXIgYnVnLgotICAgIHN0eWxlLnNldENvbG9yKGUgJiYgIWUtPmlzRGlzYWJsZWRGb3JtQ29u dHJvbCgpID8gc3RhdGljX2Nhc3Q8UkdCQTMyPihDb2xvcjo6YmxhY2spIDogQ29sb3I6OmRhcmtH cmF5KTsKKyAgICBzdHlsZS5zZXRDb2xvcihlID8gIWUtPmlzRGlzYWJsZWRGb3JtQ29udHJvbCgp ID8gc3lzdGVtQ29sb3IoQ1NTVmFsdWVCdXR0b250ZXh0LCBlLT5kb2N1bWVudCgpLnBhZ2UoKS0+ dXNlU3lzdGVtQXBwZWFyYW5jZSgpKSA6IHN5c3RlbUNvbG9yKENTU1ZhbHVlR3JheXRleHQsIGUt PmRvY3VtZW50KCkucGFnZSgpLT51c2VTeXN0ZW1BcHBlYXJhbmNlKCkpIDogQ29sb3I6OmRhcmtH cmF5KTsKIAogICAgIC8vIFNldCB0aGUgYnV0dG9uJ3MgdmVydGljYWwgc2l6ZS4KICAgICBzZXRT aXplRnJvbUZvbnQoc3R5bGUsIG1lbnVMaXN0QnV0dG9uU2l6ZXMoKSk7Cg== 336088 2018-03-19 18:12:05 -0700 2018-03-19 18:17:16 -0700 Patch bug-183753-20180319181204.patch text/plain 1735 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyOTcwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAzLTE5ICBNZWdhbiBH YXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgSGF2ZSBzZWxlY3Qg ZWxlbWVudCByZXNwZWN0IGN1cnJlbnQgYXBwZWFyYW5jZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNzUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm90IGN1cnJlbnRseSB0ZXN0YWJsZSwgd2lsbCBh ZGQgdGVzdHMgaW4gYSBsYXRlciBwYXRjaC4KKworICAgICAgICBIYXZlIHRoZSBtZW51IGxpc3Rz L3NlbGVjdCBlbGVtZW50cyBmb2xsb3cgdGhlIHN5c3RlbSBjb2xvcnMuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVt ZU1hYzo6YWRqdXN0TWVudUxpc3RTdHlsZSBjb25zdCk6CisKIDIwMTgtMDMtMTkgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBFbnN1cmUgbG9jYWwg YXBwZWFyYW5jZSBhY3R1YWxseSBtaXJyb3JzIHRoZSBhcHAncyBhcHBlYXJhbmNlCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCShyZXZpc2lvbiAyMjk2 NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0JKHdvcmtp bmcgY29weSkKQEAgLTEzNDUsOCArMTM0NSwxMCBAQCB2b2lkIFJlbmRlclRoZW1lTWFjOjphZGp1 c3RNZW51TGlzdFN0eWxlCiAgICAgc3R5bGUuc2V0V2hpdGVTcGFjZShQUkUpOwogCiAgICAgLy8g U2V0IHRoZSBmb3JlZ3JvdW5kIGNvbG9yIHRvIGJsYWNrIG9yIGdyYXkgd2hlbiB3ZSBoYXZlIHRo ZSBhcXVhIGxvb2suCi0gICAgLy8gQ2FzdCB0byBSR0IzMiBpcyB0byB3b3JrIGFyb3VuZCBhIGNv bXBpbGVyIGJ1Zy4KLSAgICBzdHlsZS5zZXRDb2xvcihlICYmICFlLT5pc0Rpc2FibGVkRm9ybUNv bnRyb2woKSA/IHN0YXRpY19jYXN0PFJHQkEzMj4oQ29sb3I6OmJsYWNrKSA6IENvbG9yOjpkYXJr R3JheSk7CisgICAgQ29sb3IgYyA9IENvbG9yOjpkYXJrR3JheTsKKyAgICBpZiAoZSkKKyAgICAg ICAgYyA9ICFlLT5pc0Rpc2FibGVkRm9ybUNvbnRyb2woKSA/IHN5c3RlbUNvbG9yKENTU1ZhbHVl QnV0dG9udGV4dCwgZS0+ZG9jdW1lbnQoKS5wYWdlKCktPnVzZVN5c3RlbUFwcGVhcmFuY2UoKSkg OiBzeXN0ZW1Db2xvcihDU1NWYWx1ZUdyYXl0ZXh0LCBlLT5kb2N1bWVudCgpLnBhZ2UoKS0+dXNl U3lzdGVtQXBwZWFyYW5jZSgpKTsKKyAgICBzdHlsZS5zZXRDb2xvcihjKTsKIAogICAgIC8vIFNl dCB0aGUgYnV0dG9uJ3MgdmVydGljYWwgc2l6ZS4KICAgICBzZXRTaXplRnJvbUZvbnQoc3R5bGUs IG1lbnVMaXN0QnV0dG9uU2l6ZXMoKSk7Cg== 336090 2018-03-19 18:17:17 -0700 2018-03-19 18:18:14 -0700 Patch bug-183753-20180319181717.patch text/plain 1777 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyOTcwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAzLTE5ICBNZWdhbiBH YXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgSGF2ZSBzZWxlY3Qg ZWxlbWVudCByZXNwZWN0IGN1cnJlbnQgYXBwZWFyYW5jZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNzUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm90IGN1cnJlbnRseSB0ZXN0YWJsZSwgd2lsbCBh ZGQgdGVzdHMgaW4gYSBsYXRlciBwYXRjaC4KKworICAgICAgICBIYXZlIHRoZSBtZW51IGxpc3Rz L3NlbGVjdCBlbGVtZW50cyBmb2xsb3cgdGhlIHN5c3RlbSBjb2xvcnMuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVt ZU1hYzo6YWRqdXN0TWVudUxpc3RTdHlsZSBjb25zdCk6CisKIDIwMTgtMDMtMTkgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBFbnN1cmUgbG9jYWwg YXBwZWFyYW5jZSBhY3R1YWxseSBtaXJyb3JzIHRoZSBhcHAncyBhcHBlYXJhbmNlCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCShyZXZpc2lvbiAyMjk2 NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0JKHdvcmtp bmcgY29weSkKQEAgLTEzNDUsOCArMTM0NSwxMiBAQCB2b2lkIFJlbmRlclRoZW1lTWFjOjphZGp1 c3RNZW51TGlzdFN0eWxlCiAgICAgc3R5bGUuc2V0V2hpdGVTcGFjZShQUkUpOwogCiAgICAgLy8g U2V0IHRoZSBmb3JlZ3JvdW5kIGNvbG9yIHRvIGJsYWNrIG9yIGdyYXkgd2hlbiB3ZSBoYXZlIHRo ZSBhcXVhIGxvb2suCi0gICAgLy8gQ2FzdCB0byBSR0IzMiBpcyB0byB3b3JrIGFyb3VuZCBhIGNv bXBpbGVyIGJ1Zy4KLSAgICBzdHlsZS5zZXRDb2xvcihlICYmICFlLT5pc0Rpc2FibGVkRm9ybUNv bnRyb2woKSA/IHN0YXRpY19jYXN0PFJHQkEzMj4oQ29sb3I6OmJsYWNrKSA6IENvbG9yOjpkYXJr R3JheSk7CisgICAgQ29sb3IgYyA9IENvbG9yOjpkYXJrR3JheTsKKyAgICBpZiAoZSkgeworICAg ICAgICBib29sIHVzZVN5c3RlbUFwcGVhcmFuY2UgPSBlLT5kb2N1bWVudCgpLnBhZ2UoKS0+dXNl U3lzdGVtQXBwZWFyYW5jZSgpOworICAgICAgICBjID0gIWUtPmlzRGlzYWJsZWRGb3JtQ29udHJv bCgpID8gc3lzdGVtQ29sb3IoQ1NTVmFsdWVCdXR0b250ZXh0LCB1c2VTeXN0ZW1BcHBlYXJhbmNl KSA6IHN5c3RlbUNvbG9yKENTU1ZhbHVlR3JheXRleHQsIHVzZVN5c3RlbUFwcGVhcmFuY2UpOwor ICAgIH0KKyAgICBzdHlsZS5zZXRDb2xvcihjKTsKIAogICAgIC8vIFNldCB0aGUgYnV0dG9uJ3Mg dmVydGljYWwgc2l6ZS4KICAgICBzZXRTaXplRnJvbUZvbnQoc3R5bGUsIG1lbnVMaXN0QnV0dG9u U2l6ZXMoKSk7Cg==