183751 2018-03-19 14:32:27 -0700 AX: embedded attachments do not work correctly with text marker APIs on macOS 2018-03-19 18:08:58 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 n_wang webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni ews-watchlist jcraig jdiggs n_wang samuel_white webkit-bug-importer oldest_to_newest 1407463 0 n_wang 2018-03-19 14:32:27 -0700 AXUnknown is returned in AXAttributedStringForTextMarkerRange and AXUIElementForTextMarker when there's an embedded attachment. <rdar://problem/37709113> 1407467 1 336076 n_wang 2018-03-19 14:56:23 -0700 Created attachment 336076 patch 1407475 2 336076 cfleizach 2018-03-19 15:14:25 -0700 Comment on attachment 336076 patch View in context: https://bugs.webkit.org/attachment.cgi?id=336076&action=review > Source/WebCore/ChangeLog:8 > + In WebKit1, embeddd attachments are not working well with text marker APIs. embedded > Source/WebCore/ChangeLog:10 > + 1. Hittesting on an attachment object. hit testing 1407476 3 336077 n_wang 2018-03-19 15:21:31 -0700 Created attachment 336077 patch update 1407524 4 336077 commit-queue 2018-03-19 18:08:57 -0700 Comment on attachment 336077 patch Clearing flags on attachment: 336077 Committed r229729: <https://trac.webkit.org/changeset/229729> 1407525 5 commit-queue 2018-03-19 18:08:58 -0700 All reviewed patches have been landed. Closing bug. 336076 2018-03-19 14:56:23 -0700 2018-03-19 15:21:38 -0700 patch patch.txt text/plain 3216 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyOTcxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE4LTAzLTE5ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGVtYmVkZGVkIGF0dGFjaG1lbnRz IGRvIG5vdCB3b3JrIGNvcnJlY3RseSB3aXRoIHRleHQgbWFya2VyIEFQSXMgb24gbWFjT1MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mzc1MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIFdlYktpdDEs IGVtYmVkZGQgYXR0YWNobWVudHMgYXJlIG5vdCB3b3JraW5nIHdlbGwgd2l0aCB0ZXh0IG1hcmtl ciBBUElzLgorICAgICAgICBXZSBzaG91bGQgdXNlIHRoZSBjb3JyZXNwb25kaW5nIGF0dGFjaG1l bnQgdmlldyBpbiB0aGUgZm9sbG93aW5nIGNhc2VzOgorICAgICAgICAxLiBIaXR0ZXN0aW5nIG9u IGFuIGF0dGFjaG1lbnQgb2JqZWN0LgorICAgICAgICAyLiBHZXR0aW5nIHRoZSBhdHRhY2htZW50 IG9iamVjdCBhdCBhIHRleHQgbWFya2VyIHBvc2l0aW9uLgorICAgICAgICAzLiBBc2tpbmcgZm9y IHRoZSBhc3NvY2lhdGVkIGVsZW1lbnQgd2l0aCBOU0FjY2Vzc2liaWxpdHlBdHRhY2htZW50VGV4 dEF0dHJpYnV0ZS4gCisKKyAgICAgICAgTm90IGFibGUgdG8gY29uc3RydWN0IGEgbGF5b3V0IHRl c3QgYmVjYXVzZSBpdCByZWxpZXMgb24gZW1iZWRkZWQgYXR0YWNobWVudHMuCisKKyAgICAgICAg KiBhY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbToK KyAgICAgICAgKEFYQXR0cmlidXRlU3RyaW5nU2V0RWxlbWVudCk6CisgICAgICAgICgtW1dlYkFj Y2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlIaXRUZXN0Ol0pOgorICAgICAg ICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBhY2Nlc3NpYmlsaXR5QXR0cmlidXRl VmFsdWU6Zm9yUGFyYW1ldGVyOl0pOgorCiAyMDE4LTAzLTE5ICBFcmljIENhcmxzb24gIDxlcmlj LmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtFeHRyYSB6b29tIG1vZGVdIFJlcXVpcmUg ZnVsbHNjcmVlbiBmb3IgdmlkZW8gcGxheWJhY2sKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlP YmplY3RXcmFwcGVyTWFjLm1tCShyZXZpc2lvbiAyMjk2MTIpCisrKyBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQkod29y a2luZyBjb3B5KQpAQCAtMTAxNSw3ICsxMDE1LDExIEBAIHN0YXRpYyB2b2lkIEFYQXR0cmlidXRl U3RyaW5nU2V0RWxlbWVudCgKICAgICAgICAgaWYgKCFjYWNoZSkKICAgICAgICAgICAgIHJldHVy bjsKICAgICAgICAgCi0gICAgICAgIEFYVUlFbGVtZW50UmVmIGF4RWxlbWVudCA9IE5TQWNjZXNz aWJpbGl0eUNyZWF0ZUFYVUlFbGVtZW50UmVmKG9iamVjdC0+d3JhcHBlcigpKTsKKyAgICAgICAg aWQgb2JqZWN0V3JhcHBlciA9IG9iamVjdC0+d3JhcHBlcigpOworICAgICAgICBpZiAoW2F0dHJp YnV0ZSBpc0VxdWFsVG9TdHJpbmc6TlNBY2Nlc3NpYmlsaXR5QXR0YWNobWVudFRleHRBdHRyaWJ1 dGVdICYmIG9iamVjdC0+aXNBdHRhY2htZW50KCkgJiYgW29iamVjdFdyYXBwZXIgYXR0YWNobWVu dFZpZXddKQorICAgICAgICAgICAgb2JqZWN0V3JhcHBlciA9IFtvYmplY3RXcmFwcGVyIGF0dGFj aG1lbnRWaWV3XTsKKyAgICAgICAgCisgICAgICAgIEFYVUlFbGVtZW50UmVmIGF4RWxlbWVudCA9 IE5TQWNjZXNzaWJpbGl0eUNyZWF0ZUFYVUlFbGVtZW50UmVmKG9iamVjdFdyYXBwZXIpOwogICAg ICAgICBpZiAoYXhFbGVtZW50KSB7CiAgICAgICAgICAgICBbYXR0clN0cmluZyBhZGRBdHRyaWJ1 dGU6YXR0cmlidXRlIHZhbHVlOihpZClheEVsZW1lbnQgcmFuZ2U6cmFuZ2VdOwogICAgICAgICAg ICAgQ0ZSZWxlYXNlKGF4RWxlbWVudCk7CkBAIC0zMzA3LDggKzMzMTEsMTEgQEAgLSAoaWQpYWNj ZXNzaWJpbGl0eUhpdFRlc3Q6KE5TUG9pbnQpcG9pbgogICAgIAogICAgIG1fb2JqZWN0LT51cGRh dGVDaGlsZHJlbklmTmVjZXNzYXJ5KCk7CiAgICAgUmVmUHRyPEFjY2Vzc2liaWxpdHlPYmplY3Q+ IGF4T2JqZWN0ID0gbV9vYmplY3QtPmFjY2Vzc2liaWxpdHlIaXRUZXN0KEludFBvaW50KHBvaW50 KSk7Ci0gICAgaWYgKGF4T2JqZWN0KQorICAgIGlmIChheE9iamVjdCkgeworICAgICAgICBpZiAo YXhPYmplY3QtPmlzQXR0YWNobWVudCgpICYmIFtheE9iamVjdC0+d3JhcHBlcigpIGF0dGFjaG1l bnRWaWV3XSkKKyAgICAgICAgICAgIHJldHVybiBbYXhPYmplY3QtPndyYXBwZXIoKSBhdHRhY2ht ZW50Vmlld107CiAgICAgICAgIHJldHVybiBOU0FjY2Vzc2liaWxpdHlVbmlnbm9yZWRBbmNlc3Rv cihheE9iamVjdC0+d3JhcHBlcigpKTsKKyAgICB9CiAgICAgcmV0dXJuIE5TQWNjZXNzaWJpbGl0 eVVuaWdub3JlZEFuY2VzdG9yKHNlbGYpOwogfQogCkBAIC0zOTkxLDYgKzM5OTgsOCBAQCAtIChp ZClhY2Nlc3NpYmlsaXR5QXR0cmlidXRlVmFsdWU6KE5TU3RyCiAgICAgICAgIEFjY2Vzc2liaWxp dHlPYmplY3QqIGF4T2JqZWN0ID0gW3NlbGYgYWNjZXNzaWJpbGl0eU9iamVjdEZvclRleHRNYXJr ZXI6dGV4dE1hcmtlcl07CiAgICAgICAgIGlmICghYXhPYmplY3QpCiAgICAgICAgICAgICByZXR1 cm4gbmlsOworICAgICAgICBpZiAoYXhPYmplY3QtPmlzQXR0YWNobWVudCgpICYmIFtheE9iamVj dC0+d3JhcHBlcigpIGF0dGFjaG1lbnRWaWV3XSkKKyAgICAgICAgICAgIHJldHVybiBbYXhPYmpl Y3QtPndyYXBwZXIoKSBhdHRhY2htZW50Vmlld107CiAgICAgICAgIHJldHVybiBheE9iamVjdC0+ d3JhcHBlcigpOwogICAgIH0KICAgICAK 336077 2018-03-19 15:21:31 -0700 2018-03-19 18:08:57 -0700 patch patch.txt text/plain 3218 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyOTcxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE4LTAzLTE5ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGVtYmVkZGVkIGF0dGFjaG1lbnRz IGRvIG5vdCB3b3JrIGNvcnJlY3RseSB3aXRoIHRleHQgbWFya2VyIEFQSXMgb24gbWFjT1MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mzc1MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIFdlYktpdDEs IGVtYmVkZGVkIGF0dGFjaG1lbnRzIGFyZSBub3Qgd29ya2luZyB3ZWxsIHdpdGggdGV4dCBtYXJr ZXIgQVBJcy4KKyAgICAgICAgV2Ugc2hvdWxkIHVzZSB0aGUgY29ycmVzcG9uZGluZyBhdHRhY2ht ZW50IHZpZXcgaW4gdGhlIGZvbGxvd2luZyBjYXNlczoKKyAgICAgICAgMS4gSGl0IHRlc3Rpbmcg b24gYW4gYXR0YWNobWVudCBvYmplY3QuCisgICAgICAgIDIuIEdldHRpbmcgdGhlIGF0dGFjaG1l bnQgb2JqZWN0IGF0IGEgdGV4dCBtYXJrZXIgcG9zaXRpb24uCisgICAgICAgIDMuIEFza2luZyBm b3IgdGhlIGFzc29jaWF0ZWQgZWxlbWVudCB3aXRoIE5TQWNjZXNzaWJpbGl0eUF0dGFjaG1lbnRU ZXh0QXR0cmlidXRlLiAKKworICAgICAgICBOb3QgYWJsZSB0byBjb25zdHJ1Y3QgYSBsYXlvdXQg dGVzdCBiZWNhdXNlIGl0IHJlbGllcyBvbiBlbWJlZGRlZCBhdHRhY2htZW50cy4KKworICAgICAg ICAqIGFjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1t OgorICAgICAgICAoQVhBdHRyaWJ1dGVTdHJpbmdTZXRFbGVtZW50KToKKyAgICAgICAgKC1bV2Vi QWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJpbGl0eUhpdFRlc3Q6XSk6CisgICAg ICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlBdHRyaWJ1 dGVWYWx1ZTpmb3JQYXJhbWV0ZXI6XSk6CisKIDIwMTgtMDMtMTkgIEVyaWMgQ2FybHNvbiAgPGVy aWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0V4dHJhIHpvb20gbW9kZV0gUmVxdWly ZSBmdWxsc2NyZWVuIGZvciB2aWRlbyBwbGF5YmFjawpJbmRleDogU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJNYWMubW0JKHJldmlzaW9uIDIyOTYxMikKKysrIFNvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0xMDE1LDcgKzEwMTUsMTEgQEAgc3RhdGljIHZvaWQgQVhBdHRyaWJ1 dGVTdHJpbmdTZXRFbGVtZW50KAogICAgICAgICBpZiAoIWNhY2hlKQogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICAKLSAgICAgICAgQVhVSUVsZW1lbnRSZWYgYXhFbGVtZW50ID0gTlNBY2Nl c3NpYmlsaXR5Q3JlYXRlQVhVSUVsZW1lbnRSZWYob2JqZWN0LT53cmFwcGVyKCkpOworICAgICAg ICBpZCBvYmplY3RXcmFwcGVyID0gb2JqZWN0LT53cmFwcGVyKCk7CisgICAgICAgIGlmIChbYXR0 cmlidXRlIGlzRXF1YWxUb1N0cmluZzpOU0FjY2Vzc2liaWxpdHlBdHRhY2htZW50VGV4dEF0dHJp YnV0ZV0gJiYgb2JqZWN0LT5pc0F0dGFjaG1lbnQoKSAmJiBbb2JqZWN0V3JhcHBlciBhdHRhY2ht ZW50Vmlld10pCisgICAgICAgICAgICBvYmplY3RXcmFwcGVyID0gW29iamVjdFdyYXBwZXIgYXR0 YWNobWVudFZpZXddOworICAgICAgICAKKyAgICAgICAgQVhVSUVsZW1lbnRSZWYgYXhFbGVtZW50 ID0gTlNBY2Nlc3NpYmlsaXR5Q3JlYXRlQVhVSUVsZW1lbnRSZWYob2JqZWN0V3JhcHBlcik7CiAg ICAgICAgIGlmIChheEVsZW1lbnQpIHsKICAgICAgICAgICAgIFthdHRyU3RyaW5nIGFkZEF0dHJp YnV0ZTphdHRyaWJ1dGUgdmFsdWU6KGlkKWF4RWxlbWVudCByYW5nZTpyYW5nZV07CiAgICAgICAg ICAgICBDRlJlbGVhc2UoYXhFbGVtZW50KTsKQEAgLTMzMDcsOCArMzMxMSwxMSBAQCAtIChpZClh Y2Nlc3NpYmlsaXR5SGl0VGVzdDooTlNQb2ludClwb2luCiAgICAgCiAgICAgbV9vYmplY3QtPnVw ZGF0ZUNoaWxkcmVuSWZOZWNlc3NhcnkoKTsKICAgICBSZWZQdHI8QWNjZXNzaWJpbGl0eU9iamVj dD4gYXhPYmplY3QgPSBtX29iamVjdC0+YWNjZXNzaWJpbGl0eUhpdFRlc3QoSW50UG9pbnQocG9p bnQpKTsKLSAgICBpZiAoYXhPYmplY3QpCisgICAgaWYgKGF4T2JqZWN0KSB7CisgICAgICAgIGlm IChheE9iamVjdC0+aXNBdHRhY2htZW50KCkgJiYgW2F4T2JqZWN0LT53cmFwcGVyKCkgYXR0YWNo bWVudFZpZXddKQorICAgICAgICAgICAgcmV0dXJuIFtheE9iamVjdC0+d3JhcHBlcigpIGF0dGFj aG1lbnRWaWV3XTsKICAgICAgICAgcmV0dXJuIE5TQWNjZXNzaWJpbGl0eVVuaWdub3JlZEFuY2Vz dG9yKGF4T2JqZWN0LT53cmFwcGVyKCkpOworICAgIH0KICAgICByZXR1cm4gTlNBY2Nlc3NpYmls aXR5VW5pZ25vcmVkQW5jZXN0b3Ioc2VsZik7CiB9CiAKQEAgLTM5OTEsNiArMzk5OCw4IEBAIC0g KGlkKWFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTooTlNTdHIKICAgICAgICAgQWNjZXNzaWJp bGl0eU9iamVjdCogYXhPYmplY3QgPSBbc2VsZiBhY2Nlc3NpYmlsaXR5T2JqZWN0Rm9yVGV4dE1h cmtlcjp0ZXh0TWFya2VyXTsKICAgICAgICAgaWYgKCFheE9iamVjdCkKICAgICAgICAgICAgIHJl dHVybiBuaWw7CisgICAgICAgIGlmIChheE9iamVjdC0+aXNBdHRhY2htZW50KCkgJiYgW2F4T2Jq ZWN0LT53cmFwcGVyKCkgYXR0YWNobWVudFZpZXddKQorICAgICAgICAgICAgcmV0dXJuIFtheE9i amVjdC0+d3JhcHBlcigpIGF0dGFjaG1lbnRWaWV3XTsKICAgICAgICAgcmV0dXJuIGF4T2JqZWN0 LT53cmFwcGVyKCk7CiAgICAgfQogICAgIAo=