183749 2018-03-19 13:27:32 -0700 REGRESSION(r225340): WPE port should not be getting EGL X11 types on ANGLE 2018-03-19 15:05:27 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez achristensen aperez bugs-noreply darin dino ews-watchlist graouts graouts kondapallykalyan mcatanzaro zan oldest_to_newest 1407438 0 clopez 2018-03-19 13:27:32 -0700 On revision r225340 <https://trac.webkit.org/r225340> ANGLE was updated, but this update didn't took into account the previous changes that r216497 <https://trac.webkit.org/r216497> did over the eglplatform.h file. Without this change, the WPE port is building the ANGLE target using the X11 types, which seems quite wrong. Also this causes the build to fail on systems not having libx11 (like embedded ones). 1407442 1 336073 clopez 2018-03-19 13:34:28 -0700 Created attachment 336073 Patch 1407443 2 ews-watchlist 2018-03-19 13:37:11 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1407470 3 336073 clopez 2018-03-19 15:05:23 -0700 Comment on attachment 336073 Patch Clearing flags on attachment: 336073 Committed r229721: <https://trac.webkit.org/changeset/229721> 1407471 4 clopez 2018-03-19 15:05:27 -0700 All reviewed patches have been landed. Closing bug. 336073 2018-03-19 13:34:28 -0700 2018-03-19 15:05:23 -0700 Patch bug-183749-20180319213427.patch text/plain 2468 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMGYyZDgxMDIxYzkyNDE1Yjg1ZTg5NTUwOWMwM2U3ZTkyYjZhM2IwNy4uMTRkMmNmMWEwNjRh MzY1OTcyNDQzNjQ2M2M2NzVjM2JlNWVkYzEyYyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAzLTE5ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJl eiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIyNTM0MCk6IFdQ RSBwb3J0IHNob3VsZCBub3QgYmUgZ2V0dGluZyBFR0wgWDExIHR5cGVzIG9uIEFOR0xFCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM3NDkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYmFjayB0aGUg VVNFX1dQRSBpZmRlZi4KKworICAgICAgICAqIGNoYW5nZXMuZGlmZjoKKyAgICAgICAgKiBpbmNs dWRlL0VHTC9lZ2xwbGF0Zm9ybS5oOgorCiAyMDE4LTAzLTE1ICBUaW0gSG9ydG9uICA8dGltb3Ro eV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbmQgYWRvcHQgV0tfQUxURVJOQVRF X0ZSQU1FV09SS1NfRElSIGluIEFOR0xFCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9jaGFuZ2VzLmRpZmYgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9jaGFuZ2VzLmRpZmYK aW5kZXggYTU4MjBkNzgxYmY5OGMzNzQ4YTAxM2ZiNTVhZDA0MTMzZjhhYWRiYi4uZWFjZmVlOWRm NTYzMWNlMWIwMjQ5ZTgzMzVjOWIyMzUzMWUwNDBiNSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvY2hhbmdlcy5kaWZmCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2No YW5nZXMuZGlmZgpAQCAtODA2NiwzICs4MDY2LDE2IEBAIGluZGV4IDZkYWE3ODMzMC4uOTg5MzFm ZTMxIDEwMDY0NAogICAgICBib29sIEVuZE9iamVjdChTaXplVHlwZSBtZW1iZXJDb3VudCA9IDAp IHsKICAgICAgICAgICh2b2lkKW1lbWJlckNvdW50OwogICAgICAgICAgUkFQSURKU09OX0FTU0VS VChsZXZlbF9zdGFja18uR2V0U2l6ZSgpID49IHNpemVvZihMZXZlbCkpOworZGlmZiAtLWdpdCBh L2luY2x1ZGUvRUdML2VnbHBsYXRmb3JtLmggYi9pbmNsdWRlL0VHTC9lZ2xwbGF0Zm9ybS5oCitp bmRleCAzMzM0NDhiZTM0OC4uNDdkMTgwOTNjOTYgMTAwNjQ0CistLS0gYS9pbmNsdWRlL0VHTC9l Z2xwbGF0Zm9ybS5oCisrKysgYi9pbmNsdWRlL0VHTC9lZ2xwbGF0Zm9ybS5oCitAQCAtMTAwLDcg KzEwMCw3IEBAIHR5cGVkZWYgc3RydWN0IEFOYXRpdmVXaW5kb3cqICAgICAgICAgICBFR0xOYXRp dmVXaW5kb3dUeXBlOworIHR5cGVkZWYgc3RydWN0IGVnbF9uYXRpdmVfcGl4bWFwX3QqICAgICBF R0xOYXRpdmVQaXhtYXBUeXBlOworIHR5cGVkZWYgdm9pZCogICAgICAgICAgICAgICAgICAgICAg ICAgICBFR0xOYXRpdmVEaXNwbGF5VHlwZTsKKyAKKy0jZWxpZiBkZWZpbmVkKFVTRV9PWk9ORSkK KysjZWxpZiBkZWZpbmVkKFVTRV9PWk9ORSkgfHwgZGVmaW5lZChVU0VfV1BFKQorIAorIHR5cGVk ZWYgaW50cHRyX3QgRUdMTmF0aXZlRGlzcGxheVR5cGU7CisgdHlwZWRlZiBpbnRwdHJfdCBFR0xO YXRpdmVXaW5kb3dUeXBlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5j bHVkZS9FR0wvZWdscGxhdGZvcm0uaCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1ZGUv RUdML2VnbHBsYXRmb3JtLmgKaW5kZXggMzMzNDQ4YmUzNDhhZDQ2YzRiZWMwZjM3OWMzOGY0ZDg1 M2Q3NjcyMi4uNDdkMTgwOTNjOTY2ZTM1MjcxYTMxYWNmMWExZTlhNGUyZGEwZjk3ZCAxMDA2NDQK LS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9FR0wvZWdscGxhdGZvcm0uaAor KysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL0VHTC9lZ2xwbGF0Zm9ybS5oCkBA IC0xMDAsNyArMTAwLDcgQEAgdHlwZWRlZiBzdHJ1Y3QgQU5hdGl2ZVdpbmRvdyogICAgICAgICAg IEVHTE5hdGl2ZVdpbmRvd1R5cGU7CiB0eXBlZGVmIHN0cnVjdCBlZ2xfbmF0aXZlX3BpeG1hcF90 KiAgICAgRUdMTmF0aXZlUGl4bWFwVHlwZTsKIHR5cGVkZWYgdm9pZCogICAgICAgICAgICAgICAg ICAgICAgICAgICBFR0xOYXRpdmVEaXNwbGF5VHlwZTsKIAotI2VsaWYgZGVmaW5lZChVU0VfT1pP TkUpCisjZWxpZiBkZWZpbmVkKFVTRV9PWk9ORSkgfHwgZGVmaW5lZChVU0VfV1BFKQogCiB0eXBl ZGVmIGludHB0cl90IEVHTE5hdGl2ZURpc3BsYXlUeXBlOwogdHlwZWRlZiBpbnRwdHJfdCBFR0xO YXRpdmVXaW5kb3dUeXBlOwo=