183725 2018-03-17 14:57:15 -0700 REGRESSION (r222113): Tests fail in messages_unittest.py 2018-03-17 15:35:45 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All All ASSIGNED Regression P2 Normal --- 176984 1 dbates dbates ap ddkilzer jfbastien lforschler thorton oldest_to_newest 1407264 0 dbates 2018-03-17 14:57:15 -0700 Steps to reproduce: 1. Open a terminal and change directories to the top-level WebKit checkout. 2. Run `python Source/WebKit/Scripts/webkit/messages_unittest.py` Then the unit tests fail: $ python Source/WebKit/Scripts/webkit/messages_unittest.py F.... ====================================================================== FAIL: test_receiver_headers (__main__.HeaderTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 328, in test_receiver_headers _expected_receiver_header_file_name) File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 318, in assertHeaderEqual self.assertGeneratedFileContentsEqual(actual_file_contents, expected_file_name) File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 312, in assertGeneratedFileContentsEqual self.assertEquals(actual_line, expected_line_list[index]) AssertionError: '#include <wtf/HashMap.h>' != '#include <wtf/Forward.h>' ---------------------------------------------------------------------- Ran 5 tests in 0.012s FAILED (failures=1) 1407265 1 336014 dbates 2018-03-17 15:03:51 -0700 Created attachment 336014 Patch 1407267 2 dbates 2018-03-17 15:33:42 -0700 The test failures were caused by the patch for bug #176984. We need to make the messages generator smarter in order for the expected results to use the wtf/Forward.h header instead of wtf/Vector.h. 1407270 3 dbates 2018-03-17 15:35:45 -0700 Committed in <https://trac.webkit.org/changeset/229697>. 336014 2018-03-17 15:03:51 -0700 2018-03-17 15:13:07 -0700 Patch bug-183725-20180317150350.patch text/plain 1941 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQyZGQ5MjAzMGIzYTI5MzQx ODU1Zjk0Mjc5OTliNzc0ODQ2ZmRlMDguLjI5NWU1YWIxYzlhNjQ3OGU0YzNjYTczMDI4ZDNlZGI3 ZWFiOGMwZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDMtMTcgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFRlc3QgZmFpbHVyZXMgaW4gbWVz c2FnZXNfdW5pdHRlc3QucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4MzcyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVwZGF0ZWQgZXhwZWN0ZWQgcmVzdWx0cy4KKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0L0xlZ2FjeU1lc3NhZ2VzLWV4cGVjdGVkLmg6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXQvTWVzc2FnZXMtZXhwZWN0ZWQuaDoKKwogMjAxOC0wMy0xNSAgV2Vuc29uIEhzaWVoICA8d2Vu c29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TIFdLMl0gSGl0LXRlc3RpbmcgZmFp bHMgd2hlbiBzcGVjaWZ5aW5nIGEgbGFyZ2UgdG9wIGNvbnRlbnQgaW5zZXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQvTGVnYWN5TWVzc2FnZXMtZXhwZWN0ZWQuaCBi L1NvdXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQvTGVnYWN5TWVzc2FnZXMtZXhwZWN0ZWQuaApp bmRleCA5YzdlMzFiNTA0MzUwOWIwNTBhNWQ3NDhjNjQyZjUwYmRmNzAyOGUzLi4yYTA5OTRjMGQ4 YzdiOTQ2NDZkNGZlZjVmMzYyMjEyOWJjYjFhNDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1NjcmlwdHMvd2Via2l0L0xlZ2FjeU1lc3NhZ2VzLWV4cGVjdGVkLmgKKysrIGIvU291cmNlL1dl YktpdC9TY3JpcHRzL3dlYmtpdC9MZWdhY3lNZXNzYWdlcy1leHBlY3RlZC5oCkBAIC0zMyw5ICsz Myw5IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9LZXlib2FyZEV2ZW50Lmg+CiAjaW5jbHVkZSA8V2Vi Q29yZS9QbHVnaW5EYXRhLmg+CiAjaW5jbHVkZSA8dXRpbGl0eT4KLSNpbmNsdWRlIDx3dGYvRm9y d2FyZC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CiAjaW5jbHVkZSA8d3RmL1RocmVhZFNh ZmVSZWZDb3VudGVkLmg+CisjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogI2luY2x1ZGUgPHd0Zi90 ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgSVBDIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvU2NyaXB0cy93ZWJraXQvTWVzc2FnZXMtZXhwZWN0ZWQuaCBiL1NvdXJjZS9XZWJLaXQv U2NyaXB0cy93ZWJraXQvTWVzc2FnZXMtZXhwZWN0ZWQuaAppbmRleCA5YzdlMzFiNTA0MzUwOWIw NTBhNWQ3NDhjNjQyZjUwYmRmNzAyOGUzLi4yYTA5OTRjMGQ4YzdiOTQ2NDZkNGZlZjVmMzYyMjEy OWJjYjFhNDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvd2Via2l0L01lc3Nh Z2VzLWV4cGVjdGVkLmgKKysrIGIvU291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdC9NZXNzYWdl cy1leHBlY3RlZC5oCkBAIC0zMyw5ICszMyw5IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9LZXlib2Fy ZEV2ZW50Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9QbHVnaW5EYXRhLmg+CiAjaW5jbHVkZSA8dXRp bGl0eT4KLSNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+ CiAjaW5jbHVkZSA8d3RmL1RocmVhZFNhZmVSZWZDb3VudGVkLmg+CisjaW5jbHVkZSA8d3RmL1Zl Y3Rvci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgSVBD IHsK