183714 2018-03-16 17:23:03 -0700 [iOS debug] Layout Test http/tests/storageAccess/grant-storage-access-under-opener.html is a flaky timeout 2018-07-10 09:15:44 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183620 https://bugs.webkit.org/show_bug.cgi?id=186777 https://bugs.webkit.org/show_bug.cgi?id=186903 InRadar P2 Normal --- 1 ryanhaddad wilander commit-queue jlewis3 webkit-bug-importer wilander oldest_to_newest 1407178 0 ryanhaddad 2018-03-16 17:23:03 -0700 The following layout test is a flaky timeout on iOS Debug bots http/tests/storageAccess/grant-storage-access-under-opener.html Probable cause: This test was added with https://trac.webkit.org/changeset/229597/webkit Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FstorageAccess%2Fgrant-storage-access-under-opener.html 1407685 1 ryanhaddad 2018-03-20 09:25:54 -0700 Skipped test on iOS debug in https://trac.webkit.org/changeset/229760/webkit 1407686 2 webkit-bug-importer 2018-03-20 09:26:20 -0700 <rdar://problem/38666060> 1428636 3 341612 wilander 2018-05-30 15:55:15 -0700 Created attachment 341612 Patch for landing 1428637 4 wilander 2018-05-30 15:56:18 -0700 The patch just adds additional logging and turns the test back on for iOS Debug. With the new console log entries we might be able to figure out why the test is timing out. 1428663 5 341612 commit-queue 2018-05-30 16:34:18 -0700 Comment on attachment 341612 Patch for landing Clearing flags on attachment: 341612 Committed r232317: <https://trac.webkit.org/changeset/232317> 1428664 6 commit-queue 2018-05-30 16:34:20 -0700 All reviewed patches have been landed. Closing bug. 1432798 7 ryanhaddad 2018-06-13 13:57:52 -0700 https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r232798%20(4808)/results.html --- /Volumes/Data/slave/ios-simulator-11-debug-tests-wk2/build/layout-test-results/http/tests/storageAccess/grant-storage-access-under-opener-expected.txt +++ /Volumes/Data/slave/ios-simulator-11-debug-tests-wk2/build/layout-test-results/http/tests/storageAccess/grant-storage-access-under-opener-actual.txt @@ -1,22 +1,5 @@ CONSOLE MESSAGE: line 54: Running test. CONSOLE MESSAGE: line 67: About to call testRunner.statisticsUpdateCookiePartitioning(). -CONSOLE MESSAGE: line 69: About to open the new window. -CONSOLE MESSAGE: line 43: About to open the third party iframe. -Tests that a cross-origin window from a prevalent domain with non-recent user interaction gets immediate storage access under its opener. +#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 63652) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS Cookie created. -PASS successfullyParsed is true - -TEST COMPLETE - - --------- -Frame: '<!--frame1-->' --------- -Should receive first-party cookie. -Received cookie named 'firstPartyCookie'. -Did not receive cookie named ''. -Client-side document.cookie: firstPartyCookie=value 1432800 8 wilander 2018-06-13 13:59:17 -0700 Thanks! It's testRunner.statisticsUpdateCookiePartitioning() that gets tripped up somehow. Will investigate. 1434054 9 wilander 2018-06-18 10:40:14 -0700 I'll make a related change in https://bugs.webkit.org/show_bug.cgi?id=186777. 1435151 10 ryanhaddad 2018-06-21 10:42:11 -0700 It looks like this is still a flaky timeout (with no output) on iOS debug bots. 1435161 11 wilander 2018-06-21 11:07:43 -0700 No output is seriously messed up. :( 1435326 12 wilander 2018-06-21 17:25:09 -0700 Further work to address this is tracked in https://bugs.webkit.org/show_bug.cgi?id=186903. 1440860 13 ryanhaddad 2018-07-10 09:15:44 -0700 This test has been consistently passing on iOS bots since 6/25, so this appears to be resolved. 341612 2018-05-30 15:55:15 -0700 2018-05-30 16:34:18 -0700 Patch for landing bug-183714-20180530155515.patch text/plain 6213 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzAxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2FhY2U0N2EwMzk3YTVmMDAwNmY2 YjFhMzc5YTM4ZDMwYTc1MzUzYS4uYzJjZTQ5ZTljMjVlMDk5MTEwMmE5MzUwNmY3NjgxNjlmMzRk NmFiOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA1LTMwICBKb2huIFdpbGFuZGVyICA8 d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBjb25zb2xlIGxvZ2dpbmcgdG8gZ3Jh bnQtc3RvcmFnZS1hY2Nlc3MtdW5kZXItb3BlbmVyLmh0bWwgdG8gYXNzZXNzIGl0cyBmbGFraW5l c3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Mzcx NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzg2NjYwNjA+CisKKyAgICAgICAgVW5yZXZpZXdl ZCB0ZXN0IGdhcmRlbmluZy4KKworICAgICAgICAqIGh0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9n cmFudC1zdG9yYWdlLWFjY2Vzcy11bmRlci1vcGVuZXItZXhwZWN0ZWQudHh0OgorICAgICAgICAq IGh0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9ncmFudC1zdG9yYWdlLWFjY2Vzcy11bmRlci1vcGVu ZXIuaHRtbDoKKyAgICAgICAgICAgIE5vdyBvdXRwdXRzIGNvbnNvbGUgbG9nIGVudHJpZXMsIHN0 ZXAgYnkgc3RlcCwgdG8gc2VlIHdoZXJlIHRoZSB0aW1lb3V0cyBoYXBwZW4uCisgICAgICAgICog cGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAgICAgU3dpdGNoZWQg dG8gWyBQYXNzIF0gb24gaU9TIERlYnVnIHRvIG1heGltaXplIGNoYW5jZSBvZiBzZWVpbmcgdGhl IGZsYWtpbmVzcy4KKwogMjAxOC0wNS0zMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNv bT4KIAogICAgICAgICBNZWRpYSBlbGVtZW50cyBvdXRzaWRlIGZ1bGxzY3JlZW4gc2hvdWxkIG5v dCBiZSBjb25zaWRlcmVkIG1haW4gY29udGVudC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9ncmFudC1zdG9yYWdlLWFjY2Vzcy11bmRlci1vcGVuZXIt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL2dyYW50 LXN0b3JhZ2UtYWNjZXNzLXVuZGVyLW9wZW5lci1leHBlY3RlZC50eHQKaW5kZXggNWZlNDNjNzcx MzBmMjUxZjQwMjRmN2NkNWJiZDJhN2IzNzgzZjhiZi4uNTMwODgwNDE0MjExYmZiODdlMzE2ZGY1 YjE1ZTQyMWVhMjE4ZDc1ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9y YWdlQWNjZXNzL2dyYW50LXN0b3JhZ2UtYWNjZXNzLXVuZGVyLW9wZW5lci1leHBlY3RlZC50eHQK KysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL2dyYW50LXN0b3JhZ2Ut YWNjZXNzLXVuZGVyLW9wZW5lci1leHBlY3RlZC50eHQKQEAgLTEsMyArMSw3IEBACitDT05TT0xF IE1FU1NBR0U6IGxpbmUgNTQ6IFJ1bm5pbmcgdGVzdC4KK0NPTlNPTEUgTUVTU0FHRTogbGluZSA2 NzogQWJvdXQgdG8gY2FsbCB0ZXN0UnVubmVyLnN0YXRpc3RpY3NVcGRhdGVDb29raWVQYXJ0aXRp b25pbmcoKS4KK0NPTlNPTEUgTUVTU0FHRTogbGluZSA2OTogQWJvdXQgdG8gb3BlbiB0aGUgbmV3 IHdpbmRvdy4KK0NPTlNPTEUgTUVTU0FHRTogbGluZSA0MzogQWJvdXQgdG8gb3BlbiB0aGUgdGhp cmQgcGFydHkgaWZyYW1lLgogVGVzdHMgdGhhdCBhIGNyb3NzLW9yaWdpbiB3aW5kb3cgZnJvbSBh IHByZXZhbGVudCBkb21haW4gd2l0aCBub24tcmVjZW50IHVzZXIgaW50ZXJhY3Rpb24gZ2V0cyBp bW1lZGlhdGUgc3RvcmFnZSBhY2Nlc3MgdW5kZXIgaXRzIG9wZW5lci4KIAogT24gc3VjY2Vzcywg eW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRF U1QgQ09NUExFVEUiLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdl QWNjZXNzL2dyYW50LXN0b3JhZ2UtYWNjZXNzLXVuZGVyLW9wZW5lci5odG1sIGIvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL2dyYW50LXN0b3JhZ2UtYWNjZXNzLXVuZGVyLW9w ZW5lci5odG1sCmluZGV4IGFhNTE0ZTMzOTM4OTYyZjA5NzA1MWY2NDA3NDk1NzlhMWVhMjE1OGYu LjFjYmQxYzc3YjliMzFhMmY5Y2Y0Nzk4NDM5NmFjNmM3NzJjMDA1MTMgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9ncmFudC1zdG9yYWdlLWFjY2Vzcy11 bmRlci1vcGVuZXIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2VBY2Nl c3MvZ3JhbnQtc3RvcmFnZS1hY2Nlc3MtdW5kZXItb3BlbmVyLmh0bWwKQEAgLTQwLDMzICs0MCwz OCBAQAogICAgICAgICAgICAgICAgIHRlc3RGYWlsZWQoIlJlY2VpdmVkIGEgbWVzc2FnZSBmcm9t IGFuIHVuZXhwZWN0ZWQgb3JpZ2luOiAiICsgZXZlbnQub3JpZ2luKTsKIAogICAgICAgICAgICAg bmV3V2luLmNsb3NlKCk7CisgICAgICAgICAgICBjb25zb2xlLmxvZygiQWJvdXQgdG8gb3BlbiB0 aGUgdGhpcmQgcGFydHkgaWZyYW1lLiIpOwogICAgICAgICAgICAgb3BlbklmcmFtZSh0aGlyZFBh cnR5QmFzZVVybCArIHN1YlBhdGhUb0dldENvb2tpZXMgKyAiJm1lc3NhZ2U9U2hvdWxkIHJlY2Vp dmUgZmlyc3QtcGFydHkgY29va2llLiIsIGZpbmlzaFRlc3QpOwogICAgICAgICB9CiAKLSAgICAg ICAgc2V0RW5hYmxlRmVhdHVyZSh0cnVlKTsKLSAgICAgICAgdGVzdFJ1bm5lci5zZXRDYW5PcGVu V2luZG93cygpOwotCiAgICAgICAgIGNvbnN0IHRoaXJkUGFydHlPcmlnaW4gPSAiaHR0cDovL2xv Y2FsaG9zdDo4MDAwIjsKICAgICAgICAgY29uc3QgcmVzb3VyY2VQYXRoID0gIi9zdG9yYWdlQWNj ZXNzL3Jlc291cmNlcyI7CiAgICAgICAgIGNvbnN0IHRoaXJkUGFydHlCYXNlVXJsID0gdGhpcmRQ YXJ0eU9yaWdpbiArIHJlc291cmNlUGF0aDsKICAgICAgICAgY29uc3QgZmlyc3RQYXJ0eUNvb2tp ZU5hbWUgPSAiZmlyc3RQYXJ0eUNvb2tpZSI7CiAgICAgICAgIGNvbnN0IHN1YlBhdGhUb0dldENv b2tpZXMgPSAiL2dldC1jb29raWVzLnBocD9uYW1lMT0iICsgZmlyc3RQYXJ0eUNvb2tpZU5hbWU7 CisgICAgICAgIHZhciBuZXdXaW47CisgICAgICAgIGZ1bmN0aW9uIHJ1bigpIHsKKyAgICAgICAg ICAgIGNvbnNvbGUubG9nKCJSdW5uaW5nIHRlc3QuIik7CisgICAgICAgICAgICBzZXRFbmFibGVG ZWF0dXJlKHRydWUpOworICAgICAgICAgICAgdGVzdFJ1bm5lci5zZXRDYW5PcGVuV2luZG93cygp OwogCi0gICAgICAgIHRlc3RSdW5uZXIuc2V0U3RhdGlzdGljc1ByZXZhbGVudFJlc291cmNlKHRo aXJkUGFydHlPcmlnaW4sIHRydWUpOwotICAgICAgICBpZiAoIXRlc3RSdW5uZXIuaXNTdGF0aXN0 aWNzUHJldmFsZW50UmVzb3VyY2UodGhpcmRQYXJ0eU9yaWdpbikpCi0gICAgICAgICAgICB0ZXN0 RmFpbGVkKCJIb3N0IGRpZCBub3QgZ2V0IHNldCBhcyBwcmV2YWxlbnQgcmVzb3VyY2UuIik7Ci0g ICAgICAgIHRlc3RSdW5uZXIuc2V0U3RhdGlzdGljc0hhc0hhZE5vblJlY2VudFVzZXJJbnRlcmFj dGlvbih0aGlyZFBhcnR5T3JpZ2luLCB0cnVlKTsKLSAgICAgICAgaWYgKCF0ZXN0UnVubmVyLmlz U3RhdGlzdGljc0hhc0hhZFVzZXJJbnRlcmFjdGlvbih0aGlyZFBhcnR5T3JpZ2luKSkKLSAgICAg ICAgICAgIHRlc3RGYWlsZWQoIkhvc3QgZGlkIG5vdCBnZXQgbG9nZ2VkIGZvciB1c2VyIGludGVy YWN0aW9uLiIpOwotICAgICAgICB0ZXN0UnVubmVyLmR1bXBDaGlsZEZyYW1lc0FzVGV4dCgpOwot ICAgICAgICB0ZXN0UnVubmVyLnNldENsb3NlUmVtYWluaW5nV2luZG93c1doZW5Db21wbGV0ZSh0 cnVlKTsKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuc2V0U3RhdGlzdGljc1ByZXZhbGVudFJlc291 cmNlKHRoaXJkUGFydHlPcmlnaW4sIHRydWUpOworICAgICAgICAgICAgaWYgKCF0ZXN0UnVubmVy LmlzU3RhdGlzdGljc1ByZXZhbGVudFJlc291cmNlKHRoaXJkUGFydHlPcmlnaW4pKQorICAgICAg ICAgICAgICAgIHRlc3RGYWlsZWQoIkhvc3QgZGlkIG5vdCBnZXQgc2V0IGFzIHByZXZhbGVudCBy ZXNvdXJjZS4iKTsKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuc2V0U3RhdGlzdGljc0hhc0hhZE5v blJlY2VudFVzZXJJbnRlcmFjdGlvbih0aGlyZFBhcnR5T3JpZ2luLCB0cnVlKTsKKyAgICAgICAg ICAgIGlmICghdGVzdFJ1bm5lci5pc1N0YXRpc3RpY3NIYXNIYWRVc2VySW50ZXJhY3Rpb24odGhp cmRQYXJ0eU9yaWdpbikpCisgICAgICAgICAgICAgICAgdGVzdEZhaWxlZCgiSG9zdCBkaWQgbm90 IGdldCBsb2dnZWQgZm9yIHVzZXIgaW50ZXJhY3Rpb24uIik7CisgICAgICAgICAgICB0ZXN0UnVu bmVyLmR1bXBDaGlsZEZyYW1lc0FzVGV4dCgpOworICAgICAgICAgICAgdGVzdFJ1bm5lci5zZXRD bG9zZVJlbWFpbmluZ1dpbmRvd3NXaGVuQ29tcGxldGUodHJ1ZSk7CiAKLSAgICAgICAgdmFyIG5l d1dpbjsKLSAgICAgICAgdGVzdFJ1bm5lci5zdGF0aXN0aWNzVXBkYXRlQ29va2llUGFydGl0aW9u aW5nKGZ1bmN0aW9uICgpIHsKLSAgICAgICAgICAgIG5ld1dpbiA9IHdpbmRvdy5vcGVuKHRoaXJk UGFydHlPcmlnaW4gKyAiL3N0b3JhZ2VBY2Nlc3MvcmVzb3VyY2VzL3NldC1jb29raWUtYW5kLXJl cG9ydC1iYWNrLmh0bWwiLCAidGVzdFdpbmRvdyIpOwotICAgICAgICB9KTsKKyAgICAgICAgICAg IGNvbnNvbGUubG9nKCJBYm91dCB0byBjYWxsIHRlc3RSdW5uZXIuc3RhdGlzdGljc1VwZGF0ZUNv b2tpZVBhcnRpdGlvbmluZygpLiIpOworICAgICAgICAgICAgdGVzdFJ1bm5lci5zdGF0aXN0aWNz VXBkYXRlQ29va2llUGFydGl0aW9uaW5nKGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgICAgICBj b25zb2xlLmxvZygiQWJvdXQgdG8gb3BlbiB0aGUgbmV3IHdpbmRvdy4iKTsKKyAgICAgICAgICAg ICAgICBuZXdXaW4gPSB3aW5kb3cub3Blbih0aGlyZFBhcnR5T3JpZ2luICsgIi9zdG9yYWdlQWNj ZXNzL3Jlc291cmNlcy9zZXQtY29va2llLWFuZC1yZXBvcnQtYmFjay5odG1sIiwgInRlc3RXaW5k b3ciKTsKKyAgICAgICAgICAgIH0pOworICAgICAgICB9CiAgICAgPC9zY3JpcHQ+CiA8L2hlYWQ+ Ci08Ym9keT4KKzxib2R5IG9ubG9hZD0icnVuKCkiPgogPC9ib2R5PgogPC9odG1sPgpcIE5vIG5l d2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lv cy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVz dEV4cGVjdGF0aW9ucwppbmRleCAwMGZjYzdlOWIyZDRmY2RkOWVmNDk0NDE4N2Y5NjQ5Zjg1ZDUy MDk3Li45YzJlOTczZGEzYzczMjU2ZjZiNGMyZjJkOWY5YTcwZWIwNjM5OTA2IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMzQ2LDcgKzEz NDYsOCBAQCB3ZWJraXQub3JnL2IvMTgyMTQ0IFsgRGVidWcgXSB3ZWJnbC8xLjAuMy9jb25mb3Jt YW5jZS9yZW5kZXJpbmcvbWFueS1kcmF3LWNhbGxzLgogCiB3ZWJraXQub3JnL2IvMTgyODQ5IGlt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvWE1MSHR0cFJlcXVlc3QvZXZlbnQtdXBsb2Fk LXByb2dyZXNzLWNyb3Nzb3JpZ2luLmh0bSBbIFBhc3MgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcv Yi8xODM3MTQgWyBEZWJ1ZyBdIGh0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9ncmFudC1zdG9yYWdl LWFjY2Vzcy11bmRlci1vcGVuZXIuaHRtbCBbIFNraXAgXQorIyBUaGlzIGlzIG1hcmtlZCBhcyBQ YXNzIHRvIHNlZSBpZiBhZGRpdGlvbmFsIGxvZ2dpbmcgY2FuIHJldmVhbCB0aGUgY2F1c2Ugb2Yg dGhlIGZsYWtpbmVzcy4KK3dlYmtpdC5vcmcvYi8xODM3MTQgWyBEZWJ1ZyBdIGh0dHAvdGVzdHMv c3RvcmFnZUFjY2Vzcy9ncmFudC1zdG9yYWdlLWFjY2Vzcy11bmRlci1vcGVuZXIuaHRtbCBbIFBh c3MgXQogCiB3ZWJraXQub3JnL2IvMTgzODYwIFsgUmVsZWFzZSBdIGh0dHAvd3B0L3NlcnZpY2Ut d29ya2Vycy90aGlyZC1wYXJ0eS1yZWdpc3RyYXRpb24uaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAK