183710 2018-03-16 15:30:50 -0700 Correct debug assertion in Range::borderAndTextRects 2018-03-19 09:14:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham cdumez commit-queue darin dbates esprehn+autocc ews-watchlist kangil.han rniwa oldest_to_newest 1407140 0 bfulgham 2018-03-16 15:30:50 -0700 A debug assertion will fire if Range::borderAndTextRects is asked to evaluate a set of selected elements, where one of the elements does not have a parent. We should consider a nullptr parent as satisfying the condition of a parent not being present in the selection set. 1407141 1 bfulgham 2018-03-16 15:31:17 -0700 <rdar://problem/38466976> 1407170 2 335983 bfulgham 2018-03-16 17:01:08 -0700 Created attachment 335983 Patch 1407223 3 335983 commit-queue 2018-03-16 23:44:45 -0700 Comment on attachment 335983 Patch Clearing flags on attachment: 335983 Committed r229695: <https://trac.webkit.org/changeset/229695> 1407224 4 commit-queue 2018-03-16 23:44:46 -0700 All reviewed patches have been landed. Closing bug. 1407370 5 darin 2018-03-19 09:14:29 -0700 The problem isn’t the assertion. The problem is that in production builds if we pass in null, contains might return true! That’s what the assertion is communicating. 335983 2018-03-16 17:01:08 -0700 2018-03-16 23:44:45 -0700 Patch bug-183710-20180316170107.patch text/plain 3710 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyOTY4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE4LTAzLTE2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIENvcnJlY3QgZGVidWcgYXNz ZXJ0aW9uIGluIFJhbmdlOjpib3JkZXJBbmRUZXh0UmVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzcxMAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzg0NjY5NzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQSBkZWJ1ZyBhc3NlcnRpb24gd2lsbCBmaXJlIGlmIFJhbmdlOjpib3JkZXJBbmRUZXh0 UmVjdHMgaXMgYXNrZWQgdG8gZXZhbHVhdGUgYSBzZXQgb2Ygc2VsZWN0ZWQgZWxlbWVudHMsIHdo ZXJlIG9uZSBvZiB0aGUgZWxlbWVudHMgZG9lcyBub3QgaGF2ZSBhIHBhcmVudC4KKworICAgICAg ICBXZSBzaG91bGQgY29uc2lkZXIgYSBudWxscHRyIHBhcmVudCBhcyBzYXRpc2Z5aW5nIHRoZSBj b25kaXRpb24gb2YgYSBwYXJlbnQgbm90IGJlaW5nIHByZXNlbnQgaW4gdGhlIHNlbGVjdGlvbiBz ZXQuCisKKyAgICAgICAgVGVzdHM6IGZhc3QvZG9tL3JhbmdlL3JhbmdlLXNlbGVjdGlvbi1lbXB0 eS1ib2R5Lmh0bWwKKworICAgICAgICAqIGRvbS9SYW5nZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSYW5nZTo6Ym9yZGVyQW5kVGV4dFJlY3RzIGNvbnN0KToKKwogMjAxOC0wMy0xNiAgQnJlbnQg RnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBTZXQgYSB0cmFwIHRvIGNh dGNoIGFuIGluZnJlcXVlbnQgZm9ybS1yZWxhdGVkIG51bGxwdHIgY3Jhc2gKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2RvbS9SYW5nZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9t L1JhbmdlLmNwcAkocmV2aXNpb24gMjI5NjgyKQorKysgU291cmNlL1dlYkNvcmUvZG9tL1Jhbmdl LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgyMyw3ICsxODIzLDcgQEAgVmVjdG9yPEZsb2F0UmVj dD4gUmFuZ2U6OmJvcmRlckFuZFRleHRSZQogICAgICAgICBzZWxlY3RlZEVsZW1lbnRzU2V0LnJl bW92ZShwYXJlbnQpOwogCiAgICAgZm9yIChOb2RlKiBub2RlID0gZmlyc3ROb2RlKCk7IG5vZGUg IT0gc3RvcE5vZGU7IG5vZGUgPSBOb2RlVHJhdmVyc2FsOjpuZXh0KCpub2RlKSkgewotICAgICAg ICBpZiAoaXM8RWxlbWVudD4oKm5vZGUpICYmIHNlbGVjdGVkRWxlbWVudHNTZXQuY29udGFpbnMo bm9kZSkgJiYgIXNlbGVjdGVkRWxlbWVudHNTZXQuY29udGFpbnMobm9kZS0+cGFyZW50Tm9kZSgp KSkgeworICAgICAgICBpZiAoaXM8RWxlbWVudD4oKm5vZGUpICYmIHNlbGVjdGVkRWxlbWVudHNT ZXQuY29udGFpbnMobm9kZSkgJiYgKCFub2RlLT5wYXJlbnROb2RlKCkgfHwgIXNlbGVjdGVkRWxl bWVudHNTZXQuY29udGFpbnMobm9kZS0+cGFyZW50Tm9kZSgpKSkpIHsKICAgICAgICAgICAgIGlm IChhdXRvKiByZW5kZXJlciA9IGRvd25jYXN0PEVsZW1lbnQ+KCpub2RlKS5yZW5kZXJCb3hNb2Rl bE9iamVjdCgpKSB7CiAgICAgICAgICAgICAgICAgVmVjdG9yPEZsb2F0UXVhZD4gZWxlbWVudFF1 YWRzOwogICAgICAgICAgICAgICAgIHJlbmRlcmVyLT5hYnNvbHV0ZVF1YWRzKGVsZW1lbnRRdWFk cyk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjk2ODcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0wMy0xNiAgQnJlbnQgRnVsZ2hh bSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KKworICAgICAgICBDb3JyZWN0IGRlYnVnIGFzc2VydGlv biBpbiBSYW5nZTo6Ym9yZGVyQW5kVGV4dFJlY3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM3MTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4 NDY2OTc2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZmFzdC9kb20vUmFuZ2UvcmFuZ2Utc2VsZWN0aW9uLWVtcHR5LWJvZHktZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9SYW5nZS9yYW5nZS1zZWxlY3Rpb24tZW1wdHkt Ym9keS5odG1sOiBBZGRlZC4KKwogMjAxOC0wMy0xNSAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFk QGFwcGxlLmNvbT4KIAogICAgICAgICBTa2lwIGVkaXRpbmcvcGFzdGVib2FyZC9kYXRhLXRyYW5z ZmVyLWdldC1kYXRhLW9uLXBhc3RpbmctaHRtbC11c2VzLWJsb2ItdXJsLmh0bWwgb24gaU9TLgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vUmFuZ2UvcmFuZ2Utc2VsZWN0aW9uLWVtcHR5LWJv ZHktZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1Jhbmdl L3JhbmdlLXNlbGVjdGlvbi1lbXB0eS1ib2R5LWV4cGVjdGVkLnR4dAkobm9uZXhpc3RlbnQpCisr KyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9SYW5nZS9yYW5nZS1zZWxlY3Rpb24tZW1wdHktYm9keS1l eHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSBAQAorVGVzdCBwYXNzZXMgaWYg aXQgZG9lcyBub3QgQVNTRVJULgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vUmFuZ2UvcmFu Z2Utc2VsZWN0aW9uLWVtcHR5LWJvZHkuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2RvbS9SYW5nZS9yYW5nZS1zZWxlY3Rpb24tZW1wdHktYm9keS5odG1sCShub25leGlzdGVu dCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL3JhbmdlLXNlbGVjdGlvbi1lbXB0eS1i b2R5Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyMCBAQAorPCFET0NUWVBFIGh0bWw+ Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0 ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworZnVuY3Rpb24gcnVuVGVzdCgpCit7CisgICAgdmFy IG5ld0JvZHkgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJib2R5Iik7CisgICAgdmFyIGRvY1Jh bmdlID0gZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKTsKKyAgICBkb2NSYW5nZS5zZWxlY3ROb2RlQ29u dGVudHMobmV3Qm9keSk7CisgICAgdmFyIGJvdW5kaW5nUmVjdCA9IGRvY1JhbmdlLmdldEJvdW5k aW5nQ2xpZW50UmVjdCgpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9cnVu VGVzdCgpPgorVGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgQVNTRVJULgorPC9ib2R5PgorPC9o dG1sPgo=