183709 2018-03-16 15:01:02 -0700 Ensure Document::responseReceived and clearResource are called on the main thread 2018-03-19 12:48:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen aestes ap beidson cdumez commit-queue dbates ews-watchlist japhet thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1407128 0 youennf 2018-03-16 15:01:02 -0700 Ensure Document::responseReceived and clearResource are called on the main thread This might help debugging rdar://problem/36256931 1407129 1 335974 youennf 2018-03-16 15:02:12 -0700 Created attachment 335974 Patch 1407183 2 335974 commit-queue 2018-03-16 17:39:50 -0700 Comment on attachment 335974 Patch Clearing flags on attachment: 335974 Committed r229690: <https://trac.webkit.org/changeset/229690> 1407184 3 commit-queue 2018-03-16 17:39:51 -0700 All reviewed patches have been landed. Closing bug. 1407187 4 webkit-bug-importer 2018-03-16 17:41:24 -0700 <rdar://problem/38566063> 1407372 5 335974 ap 2018-03-19 09:32:17 -0700 Comment on attachment 335974 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335974&action=review > Source/WebCore/loader/DocumentLoader.cpp:704 > + ASSERT(isMainThread()); I don't think that this qualifies as "ensure". "Try to find cases when not", maybe. 1407373 6 cdumez 2018-03-19 09:34:12 -0700 (In reply to Alexey Proskuryakov from comment #5) > Comment on attachment 335974 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=335974&action=review > > > Source/WebCore/loader/DocumentLoader.cpp:704 > > + ASSERT(isMainThread()); > > I don't think that this qualifies as "ensure". "Try to find cases when not", > maybe. ... or are we ensuring by crashing otherwise? 1407431 7 ap 2018-03-19 12:48:05 -0700 That's only in debug mode. 335974 2018-03-16 15:02:12 -0700 2018-03-16 17:39:50 -0700 Patch bug-183709-20180316150211.patch text/plain 1740 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzJlMWI0NGEwZjU1ZTJk ZGRmZWY5MmFjODhhMGU2ODA3YjJhMzg2My4uYWMyOTQ3ZThjMWQ3ZWIyODgwMmU2N2NjMDljZjhj NzE1NzQyZmY4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAzLTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBFbnN1cmUgRG9jdW1lbnQ6 OnJlc3BvbnNlUmVjZWl2ZWQgYW5kIGNsZWFyUmVzb3VyY2UgYXJlIGNhbGxlZCBvbiB0aGUgbWFp biB0aHJlYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4MzcwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIGNoYW5nZSBvZiBiZWhhdmlvci4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6cmVzcG9uc2VSZWNlaXZl ZCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6Y2xlYXJNYWluUmVzb3VyY2Up OgorCiAyMDE4LTAzLTExICBKYXNvbiBNYXJjZWxsICA8am1hcmNlbGxAYXBwbGUuY29tPgogCiAg ICAgICAgIENoZXJyeS1waWNrIHIyMjkwODYuIHJkYXI6Ly9wcm9ibGVtLzM3OTkyMzAxCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAppbmRleCAxYWI2OTc2YmQ3OTVjYmY2 MmQ4NDAyNDQ5ZTFlZjBhMjFlYmNiY2QwLi5mOTA1YzA5MWE5MTk2NTAyMTQ3MjE4MDcxMDMxNTVm MGJiNzVhYTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2Fk ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKQEAg LTcwMSw2ICs3MDEsNyBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpyZXNwb25zZVJlY2VpdmVkKENh Y2hlZFJlc291cmNlJiByZXNvdXJjZSwgY29uc3QgUmVzb3VyY2VSZQogCiB2b2lkIERvY3VtZW50 TG9hZGVyOjpyZXNwb25zZVJlY2VpdmVkKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNl KQogeworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAjaWYgRU5BQkxFKENPTlRFTlRfRklM VEVSSU5HKQogICAgIGlmIChtX2NvbnRlbnRGaWx0ZXIgJiYgIW1fY29udGVudEZpbHRlci0+Y29u dGludWVBZnRlclJlc3BvbnNlUmVjZWl2ZWQocmVzcG9uc2UpKQogICAgICAgICByZXR1cm47CkBA IC0xNzYxLDYgKzE3NjIsNyBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjp3aWxsQ29udGludWVNYWlu UmVzb3VyY2VMb2FkQWZ0ZXJSZWRpcmVjdChjb25zdCBSZXNvdXJjZVJlcQogCiB2b2lkIERvY3Vt ZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJjZSgpCiB7CisgICAgQVNTRVJUKGlzTWFpblRocmVh ZCgpKTsKICAgICBpZiAobV9tYWluUmVzb3VyY2UgJiYgbV9tYWluUmVzb3VyY2UtPmhhc0NsaWVu dCgqdGhpcykpCiAgICAgICAgIG1fbWFpblJlc291cmNlLT5yZW1vdmVDbGllbnQoKnRoaXMpOwog I2lmIEVOQUJMRShDT05URU5UX0ZJTFRFUklORykK