183706 2018-03-16 14:18:37 -0700 Add _useSystemAppearance to WKView 2018-03-16 15:23:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton wenson_hsieh oldest_to_newest 1407107 0 megan_gardner 2018-03-16 14:18:37 -0700 Add _useSystemAppearance to WKView 1407108 1 335968 megan_gardner 2018-03-16 14:24:56 -0700 Created attachment 335968 Patch 1407109 2 megan_gardner 2018-03-16 14:25:30 -0700 <rdar://problem/38516584> 1407131 3 335968 thorton 2018-03-16 15:12:15 -0700 Comment on attachment 335968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335968&action=review LGTM. Technically we could probably share the implementation of the defaultAppearance getter in WebViewImpl as well, but that’s just cleanup > Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h:142 > +@property (nonatomic, readwrite, setter=_setUseSystemAppearance:) BOOL _useSystemAppearance WK_API_AVAILABLE(macosx(WK_MAC_TBA)); Maybe a newline before this. 1407137 4 megan_gardner 2018-03-16 15:23:30 -0700 https://trac.webkit.org/changeset/229684/webkit 335968 2018-03-16 14:24:56 -0700 2018-03-16 15:12:15 -0700 Patch bug-183706-20180316142456.patch text/plain 5753 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjk2ODMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE4LTAzLTE2ICBNZWdhbiBHYXJk bmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIF91c2VTeXN0ZW1B cHBlYXJhbmNlIHRvIFdLVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgzNzA2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zODUxNjU4ND4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQbHVtYiB1c2VT eXN0ZW1BcHBlYXJhbmNlIGFuZCBvdGhlciBzdXBwb3J0aW5nIGZ1bmN0aW9ucyB0byBXS1ZpZXcK KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tWaWV3UHJpdmF0ZS5oOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZp ZXcgX2luaXRpYWxpemVXaXRoQ29uZmlndXJhdGlvbjpdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3 IF91c2VTeXN0ZW1BcHBlYXJhbmNlXSk6CisgICAgICAgICgtW1dLV2ViVmlldyBfc2V0VXNlU3lz dGVtQXBwZWFyYW5jZTpdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IGVmZmVjdGl2ZUFwcGVhcmFu Y2VEaWRDaGFuZ2VdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06Cisg ICAgICAgICgtW1dLVmlldyBlZmZlY3RpdmVBcHBlYXJhbmNlRGlkQ2hhbmdlXSk6CisgICAgICAg ICgtW1dLVmlldyBfc2V0VXNlU3lzdGVtQXBwZWFyYW5jZTpdKToKKyAgICAgICAgKC1bV0tWaWV3 IF91c2VTeXN0ZW1BcHBlYXJhbmNlXSk6CisgICAgICAgICgtW1dLVmlldyBfc2V0RGVmYXVsdEFw cGVhcmFuY2U6XSk6CisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLmg6Cisg ICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tOgorICAgICAgICAoV2ViS2l0 OjpXZWJWaWV3SW1wbDo6c2V0VXNlU3lzdGVtQXBwZWFyYW5jZSk6CisgICAgICAgIChXZWJLaXQ6 OldlYlZpZXdJbXBsOjp1c2VTeXN0ZW1BcHBlYXJhbmNlKToKKyAgICAgICAgKFdlYktpdDo6V2Vi Vmlld0ltcGw6OnNldERlZmF1bHRBcHBlYXJhbmNlKToKKwogMjAxOC0wMy0xNiAgQnJlbnQgRnVs Z2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBTZXQgYSB0cmFwIHRvIGNhdGNo IGFuIGluZnJlcXVlbnQgZm9ybS1yZWxhdGVkIG51bGxwdHIgY3Jhc2gKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ZpZXdQcml2YXRlLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVmlld1ByaXZhdGUuaAkocmV2aXNp b24gMjI5Njc4KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVmlld1By aXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTM5LDYgKzEzOSw3IEBACiAtICh2b2lkKV9yZW1v dmVNZWRpYVBsYXliYWNrQ29udHJvbHNWaWV3OwogCiAtICh2b2lkKV9kb0FmdGVyTmV4dFByZXNl bnRhdGlvblVwZGF0ZToodm9pZCAoXikodm9pZCkpdXBkYXRlQmxvY2sgV0tfQVBJX0FWQUlMQUJM RShtYWNvc3goV0tfTUFDX1RCQSkpOworQHByb3BlcnR5IChub25hdG9taWMsIHJlYWR3cml0ZSwg c2V0dGVyPV9zZXRVc2VTeXN0ZW1BcHBlYXJhbmNlOikgQk9PTCBfdXNlU3lzdGVtQXBwZWFyYW5j ZSBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSk7CiAKIEBlbmQKIApJbmRleDog U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCShyZXZp c2lvbiAyMjk2NzkpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC02ODQsOCArNjg0LDYgQEAgICAgIC8vIFdlIGFyZSBp biB0aGUgVmlldydzIGluaXRpYWxpemF0aQogCiAgICAgX2ltcGwtPnNldEF1dG9tYXRpY2FsbHlB ZGp1c3RzQ29udGVudEluc2V0cyh0cnVlKTsKICAgICBfaW1wbC0+c2V0UmVxdWlyZXNVc2VyQWN0 aW9uRm9yRWRpdGluZ0NvbnRyb2xzTWFuYWdlcihbY29uZmlndXJhdGlvbiBfcmVxdWlyZXNVc2Vy QWN0aW9uRm9yRWRpdGluZ0NvbnRyb2xzTWFuYWdlcl0pOwotICAgIAotICAgIF9wYWdlLT5zZXRE ZWZhdWx0QXBwZWFyYW5jZShbc2VsZiBfZGVmYXVsdEFwcGVhcmFuY2VdKTsKICNlbmRpZgogCiAg ICAgX3BhZ2UtPnNldEJhY2tncm91bmRFeHRlbmRzQmV5b25kUGFnZSh0cnVlKTsKQEAgLTYxNzIs MTggKzYxNzAsMTggQEAgLSAoTlNSZWN0KV9jYW5kaWRhdGVSZWN0CiAKIC0gKEJPT0wpX3VzZVN5 c3RlbUFwcGVhcmFuY2UKIHsKLSAgICByZXR1cm4gX3BhZ2UtPnVzZVN5c3RlbUFwcGVhcmFuY2Uo KTsKKyAgICByZXR1cm4gX2ltcGwtPnVzZVN5c3RlbUFwcGVhcmFuY2UoKTsKIH0KIAogLSAodm9p ZClfc2V0VXNlU3lzdGVtQXBwZWFyYW5jZTooQk9PTCl1c2VTeXN0ZW1BcHBlYXJhbmNlCiB7Ci0g ICAgX3BhZ2UtPnNldFVzZVN5c3RlbUFwcGVhcmFuY2UodXNlU3lzdGVtQXBwZWFyYW5jZSk7Ci0g ICAgX3BhZ2UtPnNldERlZmF1bHRBcHBlYXJhbmNlKFtzZWxmIF9kZWZhdWx0QXBwZWFyYW5jZV0p OworICAgIF9pbXBsLT5zZXRVc2VTeXN0ZW1BcHBlYXJhbmNlKHVzZVN5c3RlbUFwcGVhcmFuY2Up OworICAgIF9pbXBsLT5zZXREZWZhdWx0QXBwZWFyYW5jZShbc2VsZiBfZGVmYXVsdEFwcGVhcmFu Y2VdKTsKIH0KIAogLSAodm9pZCllZmZlY3RpdmVBcHBlYXJhbmNlRGlkQ2hhbmdlCiB7Ci0gICAg X3BhZ2UtPnNldERlZmF1bHRBcHBlYXJhbmNlKFtzZWxmIF9kZWZhdWx0QXBwZWFyYW5jZV0pOwor ICAgIF9pbXBsLT5zZXREZWZhdWx0QXBwZWFyYW5jZShbc2VsZiBfZGVmYXVsdEFwcGVhcmFuY2Vd KTsKIH0KIAogLSAodm9pZClfc2V0SGVhZGVyQmFubmVySGVpZ2h0OihpbnQpaGVpZ2h0CkluZGV4 OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gMjI5 Njc4KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtp bmcgY29weSkKQEAgLTE2MDksNiArMTYwOSwzNSBAQCAtICh2b2lkKV9zZXRTaG91bGRTdXBwcmVz c0ZpcnN0UmVzcG9uZGVyCiB7CiAgICAgX2RhdGEtPl9pbXBsLT5zZXRTaG91bGRTdXBwcmVzc0Zp cnN0UmVzcG9uZGVyQ2hhbmdlcyhzaG91bGRTdXBwcmVzcyk7CiB9CisKKyNpZiBVU0UoQVBQTEVf SU5URVJOQUxfU0RLKQorI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zL1dlYlZpZXdBbmRXS1dlYlZp ZXdBZGRpdGlvbnMubW0+CisjZWxzZQorLSAoYm9vbClfZGVmYXVsdEFwcGVhcmFuY2UgeyByZXR1 cm4gdHJ1ZTsgfQorI2VuZGlmCisKKy0gKHZvaWQpZWZmZWN0aXZlQXBwZWFyYW5jZURpZENoYW5n ZQoreworICAgIF9kYXRhLT5faW1wbC0+c2V0RGVmYXVsdEFwcGVhcmFuY2UoW3NlbGYgX2RlZmF1 bHRBcHBlYXJhbmNlXSk7Cit9CisKKy0gKHZvaWQpX3NldFVzZVN5c3RlbUFwcGVhcmFuY2U6KEJP T0wpdXNlU3lzdGVtQXBwZWFyYW5jZQoreworICAgIF9kYXRhLT5faW1wbC0+c2V0VXNlU3lzdGVt QXBwZWFyYW5jZSh1c2VTeXN0ZW1BcHBlYXJhbmNlKTsKKyAgICBfZGF0YS0+X2ltcGwtPnNldERl ZmF1bHRBcHBlYXJhbmNlKFtzZWxmIF9kZWZhdWx0QXBwZWFyYW5jZV0pOworfQorCistIChCT09M KV91c2VTeXN0ZW1BcHBlYXJhbmNlCit7CisgICAgcmV0dXJuIF9kYXRhLT5faW1wbC0+dXNlU3lz dGVtQXBwZWFyYW5jZSgpOworfQorCistICh2b2lkKV9zZXREZWZhdWx0QXBwZWFyYW5jZTooQk9P TClkZWZhdWx0QXBwZWFyYW5jZQoreworICAgIF9kYXRhLT5faW1wbC0+c2V0RGVmYXVsdEFwcGVh cmFuY2UoZGVmYXVsdEFwcGVhcmFuY2UpOworfQorCisKIEBlbmQKIAogI2VuZGlmIC8vIFBMQVRG T1JNKE1BQykKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBs LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0lt cGwuaAkocmV2aXNpb24gMjI5Njc4KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev V2ViVmlld0ltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtNTMzLDYgKzUzMywxMCBAQCBwdWJsaWM6 CiAKICAgICBib29sIGJlZ2luQmFja1N3aXBlRm9yVGVzdGluZygpOwogICAgIGJvb2wgY29tcGxl dGVCYWNrU3dpcGVGb3JUZXN0aW5nKCk7CisgICAgCisgICAgdm9pZCBzZXRVc2VTeXN0ZW1BcHBl YXJhbmNlKGJvb2wpOworICAgIGJvb2wgdXNlU3lzdGVtQXBwZWFyYW5jZSgpOworICAgIHZvaWQg c2V0RGVmYXVsdEFwcGVhcmFuY2UoYm9vbCk7CiAKIHByaXZhdGU6CiAjaWYgSEFWRShUT1VDSF9C QVIpCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5t bQkocmV2aXNpb24gMjI5Njc4KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2Vi Vmlld0ltcGwubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ5NzMsNiArNDk3MywyMSBAQCBib29sIFdl YlZpZXdJbXBsOjpjb21wbGV0ZUJhY2tTd2lwZUZvclRlCiAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICByZXR1cm4gbV9nZXN0dXJlQ29udHJvbGxlci0+Y29tcGxldGVTaW11bGF0ZWRTd2lwZUlu RGlyZWN0aW9uRm9yVGVzdGluZyhWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OlN3aXBlRGlyZWN0aW9u OjpCYWNrKTsKIH0KKyAgICAKK3ZvaWQgV2ViVmlld0ltcGw6OnNldFVzZVN5c3RlbUFwcGVhcmFu Y2UoYm9vbCB1c2VTeXN0ZW1BcHBlYXJhbmNlKQoreworICAgIG1fcGFnZS0+c2V0VXNlU3lzdGVt QXBwZWFyYW5jZSh1c2VTeXN0ZW1BcHBlYXJhbmNlKTsKK30KKworYm9vbCBXZWJWaWV3SW1wbDo6 dXNlU3lzdGVtQXBwZWFyYW5jZSgpCit7CisgICAgcmV0dXJuIG1fcGFnZS0+dXNlU3lzdGVtQXBw ZWFyYW5jZSgpOworfQorCit2b2lkIFdlYlZpZXdJbXBsOjpzZXREZWZhdWx0QXBwZWFyYW5jZShi b29sIGRlZmF1bHRBcHBlYXJhbmNlKQoreworICAgIG1fcGFnZS0+c2V0RGVmYXVsdEFwcGVhcmFu Y2UoZGVmYXVsdEFwcGVhcmFuY2UpOworfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAo=