183701 2018-03-16 10:25:05 -0700 Make run-webkit-app work for non-GUI apps 2018-03-19 13:50:36 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Mac All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates ap ddkilzer lforschler mitz webkit-bug-importer oldest_to_newest 1407038 0 dbates 2018-03-16 10:25:05 -0700 The run-webkit-app is convenient for running a GUI app with a built WebKit. I do not see a need to restrict this functionality to GUI apps. We should also make run-webkit-app work for non-GUI apps. 1407048 1 335951 dbates 2018-03-16 10:50:26 -0700 Created attachment 335951 Patch 1407054 2 335954 dbates 2018-03-16 11:24:06 -0700 Created attachment 335954 Patch 1407412 3 335954 dbates 2018-03-19 11:39:45 -0700 Comment on attachment 335954 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335954&action=review > Tools/Scripts/webkitdirs.pm:97 > USE_OPEN_COMMAND > + DO_NOT_USE_OPEN_COMMAND I'll sort these before landing. 1407447 4 dbates 2018-03-19 13:49:17 -0700 Committed r229711: <https://trac.webkit.org/changeset/229711> 1407448 5 webkit-bug-importer 2018-03-19 13:50:36 -0700 <rdar://problem/38633433> 335951 2018-03-16 10:50:26 -0700 2018-03-16 11:24:05 -0700 Patch bug-183701-20180316105026.patch text/plain 2401 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NjMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTU0MWUyZjg1M2UyYTA4MjA3NWZlZDVlZWJmMzFhNDU4 MzNiOTI0My4uNDEyZDYzNGYyMTRlNDg0YTg1ZTUyNjQ0NDZiZmZhMDFkYzRhZjJlZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE4LTAzLTE2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBNYWtlIHJ1bi13ZWJraXQtYXBwIHdvcmsgZm9yIG5vbi1HVUkgYXBwcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNzAxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGF1bmNoIHRoZSBhcHAgZGly ZWN0bHkgaWYgaXQgaXMgYW4gZXhlY3V0YWJsZSBmaWxlLiBPdGhlcndpc2UsIGFzc3VtZSBpdCBp cyBhbiBhcHAgYnVuZGxlCisgICAgICAgIGFuZCBsYXVuY2ggaXQgdXNpbmcgb3BlbigxKSBhcyB3 ZSBjdXJyZW50bHkgZG8uCisKKyAgICAgICAgTm90ZSB0aGF0IG9wZW4oMSkgaXMgbWVhbnQgZm9y IGxhdW5jaGluZyBHVUkgYXBwcy4gU3RhbmRhcmQgb3V0cHV0IGFuZCBzdGFuZGFyZCBlcnJvciBh cmUKKyAgICAgICAgbm90IHNlbnQgdG8gdGhlIHR0eSB3aGVuIHVzaW5nIG9wZW4oMSkgdG8gbGF1 bmNoIGEgbm9uLUdVSSBhcHAuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtYXBwOiBX ZSBtYWtlIHRoZSBhc3N1bXB0aW9uIHRoYXQgCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJz LnBtOgorICAgICAgICAgICAgLSBEZWZpbmUgYW5kIGV4cG9ydCBjb25zdGFudCBET19OT1RfVVNF X09QRU5fQ09NTUFORC4KKwogMjAxOC0wMy0xNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBs ZS5jb20+CiAKICAgICAgICAgcnVuLXdlYmtpdC1hcHAgLWcgZG9lcyBub3Qgd29yawpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LWFwcCBiL1Rvb2xzL1NjcmlwdHMvcnVuLXdl YmtpdC1hcHAKaW5kZXggYWE2ODMyZmZlZGU2MTA3ODk2MzViYjBjNTg5ZmU2Nzc1MzQ0NWYyNy4u MTM1NGYyNzc2MGZkMTU2NDIzN2JhNWUzY2I1ZGMyYTY3OTY2MmMxMSAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy9ydW4td2Via2l0LWFwcAorKysgYi9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQt YXBwCkBAIC00OCw0ICs0OCw1IEBAIG15ICRhcHBQYXRoID0gc2hpZnQoQEFSR1YpOwogaWYgKGlz SU9TV2ViS2l0KCkpIHsKICAgICBleGl0IGV4aXRTdGF0dXMocnVuSU9TV2ViS2l0QXBwKCRhcHBQ YXRoKSk7CiB9Ci1leGl0IGV4aXRTdGF0dXMocnVuTWFjV2ViS2l0QXBwKCRhcHBQYXRoLCBVU0Vf T1BFTl9DT01NQU5EKSk7CitteSAkaXNFeGVjdXRhYmxlID0gLWYgJGFwcFBhdGggJiYgLXggJGFw cFBhdGg7CitleGl0IGV4aXRTdGF0dXMocnVuTWFjV2ViS2l0QXBwKCRhcHBQYXRoLCAkaXNFeGVj dXRhYmxlID8gVVNFX09QRU5fQ09NTUFORCA6IERPX05PVF9VU0VfT1BFTl9DT01NQU5EKSk7CmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0KaW5kZXggOTY3NzQ4MjMxNTAxYWY5ZTg5NmIxNTY5MDNjNzk1MjI2ZGVjMjFi Mi4uZmVmNjAwMTJkNWE3OTdhOWVjYmFjZDIwNDAwMzNhNzAyZDA3YjA0NiAxMDA3NTUKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQpAQCAtOTQsNiArOTQsNyBAQCBCRUdJTiB7CiAgICAgICAgJndpbGxVc2VJT1NTaW11bGF0 b3JTREsKICAgICAgICBTSU1VTEFUT1JfREVWSUNFX1NVRkZJWF9GT1JfV0VCS0lUX0RFVkVMT1BN RU5UCiAgICAgICAgVVNFX09QRU5fQ09NTUFORAorICAgICAgIERPX05PVF9VU0VfT1BFTl9DT01N QU5ECiAgICApOwogICAgJUVYUE9SVF9UQUdTID0gKCApOwogICAgQEVYUE9SVF9PSyAgID0gKCk7 CkBAIC0xMTQsNiArMTE1LDcgQEAgdXNlIGNvbnN0YW50IHsKIH07CiAKIHVzZSBjb25zdGFudCBV U0VfT1BFTl9DT01NQU5EID0+IDE7ICMgVXNlZCBpbiBydW5NYWNXZWJLaXRBcHAoKS4KK3VzZSBj b25zdGFudCBET19OT1RfVVNFX09QRU5fQ09NTUFORCA9PiAyOwogdXNlIGNvbnN0YW50IFNJTVVM QVRPUl9ERVZJQ0VfU1RBVEVfU0hVVERPV04gPT4gIjEiOwogdXNlIGNvbnN0YW50IFNJTVVMQVRP Ul9ERVZJQ0VfU1RBVEVfQk9PVEVEID0+ICIzIjsKIHVzZSBjb25zdGFudCBTSU1VTEFUT1JfREVW SUNFX1NVRkZJWF9GT1JfV0VCS0lUX0RFVkVMT1BNRU5UICA9PiAiRm9yIFdlYktpdCBEZXZlbG9w bWVudCI7Cg== 335954 2018-03-16 11:24:06 -0700 2018-03-19 11:42:06 -0700 Patch bug-183701-20180316112406.patch text/plain 2401 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NjMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTU0MWUyZjg1M2UyYTA4MjA3NWZlZDVlZWJmMzFhNDU4 MzNiOTI0My4uNDEyZDYzNGYyMTRlNDg0YTg1ZTUyNjQ0NDZiZmZhMDFkYzRhZjJlZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE4LTAzLTE2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBNYWtlIHJ1bi13ZWJraXQtYXBwIHdvcmsgZm9yIG5vbi1HVUkgYXBwcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNzAxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGF1bmNoIHRoZSBhcHAgZGly ZWN0bHkgaWYgaXQgaXMgYW4gZXhlY3V0YWJsZSBmaWxlLiBPdGhlcndpc2UsIGFzc3VtZSBpdCBp cyBhbiBhcHAgYnVuZGxlCisgICAgICAgIGFuZCBsYXVuY2ggaXQgdXNpbmcgb3BlbigxKSBhcyB3 ZSBjdXJyZW50bHkgZG8uCisKKyAgICAgICAgTm90ZSB0aGF0IG9wZW4oMSkgaXMgbWVhbnQgZm9y IGxhdW5jaGluZyBHVUkgYXBwcy4gU3RhbmRhcmQgb3V0cHV0IGFuZCBzdGFuZGFyZCBlcnJvciBh cmUKKyAgICAgICAgbm90IHNlbnQgdG8gdGhlIHR0eSB3aGVuIHVzaW5nIG9wZW4oMSkgdG8gbGF1 bmNoIGEgbm9uLUdVSSBhcHAuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtYXBwOiBX ZSBtYWtlIHRoZSBhc3N1bXB0aW9uIHRoYXQgCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJz LnBtOgorICAgICAgICAgICAgLSBEZWZpbmUgYW5kIGV4cG9ydCBjb25zdGFudCBET19OT1RfVVNF X09QRU5fQ09NTUFORC4KKwogMjAxOC0wMy0xNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBs ZS5jb20+CiAKICAgICAgICAgcnVuLXdlYmtpdC1hcHAgLWcgZG9lcyBub3Qgd29yawpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LWFwcCBiL1Rvb2xzL1NjcmlwdHMvcnVuLXdl YmtpdC1hcHAKaW5kZXggYWE2ODMyZmZlZGU2MTA3ODk2MzViYjBjNTg5ZmU2Nzc1MzQ0NWYyNy4u MWQ1OTA0ODNmNzJlOTQwZGI0NWQ5MTZhMjIwZWNiNTkwOTM0MWQ0NyAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy9ydW4td2Via2l0LWFwcAorKysgYi9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQt YXBwCkBAIC00OCw0ICs0OCw1IEBAIG15ICRhcHBQYXRoID0gc2hpZnQoQEFSR1YpOwogaWYgKGlz SU9TV2ViS2l0KCkpIHsKICAgICBleGl0IGV4aXRTdGF0dXMocnVuSU9TV2ViS2l0QXBwKCRhcHBQ YXRoKSk7CiB9Ci1leGl0IGV4aXRTdGF0dXMocnVuTWFjV2ViS2l0QXBwKCRhcHBQYXRoLCBVU0Vf T1BFTl9DT01NQU5EKSk7CitteSAkaXNFeGVjdXRhYmxlID0gLWYgJGFwcFBhdGggJiYgLXggJGFw cFBhdGg7CitleGl0IGV4aXRTdGF0dXMocnVuTWFjV2ViS2l0QXBwKCRhcHBQYXRoLCAkaXNFeGVj dXRhYmxlID8gRE9fTk9UX1VTRV9PUEVOX0NPTU1BTkQgOiBVU0VfT1BFTl9DT01NQU5EKSk7CmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0KaW5kZXggOTY3NzQ4MjMxNTAxYWY5ZTg5NmIxNTY5MDNjNzk1MjI2ZGVjMjFi Mi4uZmVmNjAwMTJkNWE3OTdhOWVjYmFjZDIwNDAwMzNhNzAyZDA3YjA0NiAxMDA3NTUKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQpAQCAtOTQsNiArOTQsNyBAQCBCRUdJTiB7CiAgICAgICAgJndpbGxVc2VJT1NTaW11bGF0 b3JTREsKICAgICAgICBTSU1VTEFUT1JfREVWSUNFX1NVRkZJWF9GT1JfV0VCS0lUX0RFVkVMT1BN RU5UCiAgICAgICAgVVNFX09QRU5fQ09NTUFORAorICAgICAgIERPX05PVF9VU0VfT1BFTl9DT01N QU5ECiAgICApOwogICAgJUVYUE9SVF9UQUdTID0gKCApOwogICAgQEVYUE9SVF9PSyAgID0gKCk7 CkBAIC0xMTQsNiArMTE1LDcgQEAgdXNlIGNvbnN0YW50IHsKIH07CiAKIHVzZSBjb25zdGFudCBV U0VfT1BFTl9DT01NQU5EID0+IDE7ICMgVXNlZCBpbiBydW5NYWNXZWJLaXRBcHAoKS4KK3VzZSBj b25zdGFudCBET19OT1RfVVNFX09QRU5fQ09NTUFORCA9PiAyOwogdXNlIGNvbnN0YW50IFNJTVVM QVRPUl9ERVZJQ0VfU1RBVEVfU0hVVERPV04gPT4gIjEiOwogdXNlIGNvbnN0YW50IFNJTVVMQVRP Ul9ERVZJQ0VfU1RBVEVfQk9PVEVEID0+ICIzIjsKIHVzZSBjb25zdGFudCBTSU1VTEFUT1JfREVW SUNFX1NVRkZJWF9GT1JfV0VCS0lUX0RFVkVMT1BNRU5UICA9PiAiRm9yIFdlYktpdCBEZXZlbG9w bWVudCI7Cg==