<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>183694</bug_id>
          
          <creation_ts>2018-03-16 03:43:23 -0700</creation_ts>
          <short_desc>[DFG][FTL] Add vectorLengthHint for NewArray</short_desc>
          <delta_ts>2018-03-20 00:59:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>fpizlo</cc>
    
    <cc>jfbastien</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>ticaiolima</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1406959</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-03-16 03:43:23 -0700</bug_when>
    <thetext>[DFG][FTL] Add vectorLengthHint for NewArray</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1406960</commentid>
    <comment_count>1</comment_count>
      <attachid>335928</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-03-16 03:46:52 -0700</bug_when>
    <thetext>Created attachment 335928
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1406961</commentid>
    <comment_count>2</comment_count>
      <attachid>335928</attachid>
    <who name="Caio Lima">ticaiolima</who>
    <bug_when>2018-03-16 04:07:20 -0700</bug_when>
    <thetext>Comment on attachment 335928
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335928&amp;action=review

LGTM. I have some suggestions in the tests. Also, why not create a microbenchmark for that?

&gt; JSTests/stress/vector-length-hint-new-array.js:3
&gt; +        throw new Error(&apos;bad value: &apos; + actual);

I think you should print the expected value as well. I helps a lot when it crashes on EWS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407587</commentid>
    <comment_count>3</comment_count>
      <attachid>335928</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2018-03-19 22:06:37 -0700</bug_when>
    <thetext>Comment on attachment 335928
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335928&amp;action=review

r=me

&gt; Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:3734
&gt; +            ASSERT(vectorLengthHint &gt;= numElements);

I’d make this a validation rule</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407618</commentid>
    <comment_count>4</comment_count>
      <attachid>335928</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-03-20 00:43:48 -0700</bug_when>
    <thetext>Comment on attachment 335928
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335928&amp;action=review

Thank you

&gt;&gt; Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:3734
&gt;&gt; +            ASSERT(vectorLengthHint &gt;= numElements);
&gt; 
&gt; I’d make this a validation rule

Added that rules.

&gt;&gt; JSTests/stress/vector-length-hint-new-array.js:3
&gt;&gt; +        throw new Error(&apos;bad value: &apos; + actual);
&gt; 
&gt; I think you should print the expected value as well. I helps a lot when it crashes on EWS.

Added</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407619</commentid>
    <comment_count>5</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-03-20 00:58:27 -0700</bug_when>
    <thetext>Committed r229743: &lt;https://trac.webkit.org/changeset/229743&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407620</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-03-20 00:59:20 -0700</bug_when>
    <thetext>&lt;rdar://problem/38655034&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>335928</attachid>
            <date>2018-03-16 03:46:52 -0700</date>
            <delta_ts>2018-03-19 22:06:37 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-183694-20180316194651.patch</filename>
            <type>text/plain</type>
            <size>8899</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk
MGM5NzgzYTkwMGQwZjIzMmY3ZDVkMGY4NWE5ODA2ODRmOTI1MTRmLi44NzlmMDQ4MTllZjNlMzg0
MTdjZDczZDdlYzA5YWFkMjU2MzA0ZDU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSw0MSBAQAorMjAxOC0wMy0xNiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls
LmNvbT4KKworICAgICAgICBbREZHXVtGVExdIEFkZCB2ZWN0b3JMZW5ndGhIaW50IGZvciBOZXdB
cnJheQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgz
Njk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hp
bGUgdGhlIGZvbGxvd2luZyBjb2RlIGlzIGEgY29tbW9uLCBpdCBpcyBub3Qgc28gZWZmaWNpZW50
LgorCisgICAgICAgIHZhciBhcnJheSA9IFtdOworICAgICAgICBmb3IgKC4uLikgeworICAgICAg
ICAgICAgLi4uCisgICAgICAgICAgICBhcnJheS5wdXNoKC4uLik7CisgICAgICAgIH0KKworICAg
ICAgICBUaGUgYXJyYXkgaXMgYWx3YXlzIGFsbG9jYXRlZCB3aXRoIDAgdmVjdG9yIGxlbmd0aC4g
QW5kIGl0IGlzIGV2ZW50dWFsbHkgZ3Jvd24uCisKKyAgICAgICAgV2UgaGF2ZSBBcnJheUFsbG9j
YXRpb25Qcm9maWxlLCBhbmQgaXQgdGVsbHMgdXMgdGhhdCB0aGUgdmVjdG9yIGxlbmd0aCBoaW50
IGZvcgorICAgICAgICB0aGUgYWxsb2NhdGVkIGFycmF5cy4gVGhpcyBoaW50IGlzIGFscmVhZHkg
dXNlZCBmb3IgTmV3QXJyYXlCdWZmZXIuIFRoaXMgcGF0Y2gKKyAgICAgICAgZXh0ZW5kcyB0aGlz
IHN1cHBvcnQgZm9yIE5ld0FycmF5IERGRyBub2RlLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaW1w
cm92ZXMgS3Jha2VuL3N0YW5mb3JkLWNyeXB0by1hZXMgNCUuCisKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgYmFzZWxpbmUgICAgICAgICAgICAgICAgICBwYXRjaGVkCisK
KyAgICAgICAgc3RhbmZvcmQtY3J5cHRvLWFlcyAgICAgICAgNjQuMDY5Ky0xLjM1MiAgICAgICAg
ICAgICA2MS41ODkrLTEuMjc0ICAgICAgICAgICBtaWdodCBiZSAxLjA0MDN4IGZhc3RlcgorCisg
ICAgICAgICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpC
eXRlQ29kZVBhcnNlcjo6aGFuZGxlQ29uc3RhbnRJbnRlcm5hbEZ1bmN0aW9uKToKKyAgICAgICAg
KEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayk6CisgICAgICAgICogZGZnL0RG
R05vZGUuaDoKKyAgICAgICAgKEpTQzo6REZHOjpOb2RlOjpoYXNWZWN0b3JMZW5ndGhIaW50KToK
KyAgICAgICAgKEpTQzo6REZHOjpOb2RlOjp2ZWN0b3JMZW5ndGhIaW50KToKKyAgICAgICAgKiBk
ZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRp
dmVKSVQ6OmNvbXBpbGUpOgorICAgICAgICAqIGZ0bC9GVExMb3dlckRGR1RvQjMuY3BwOgorICAg
ICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0IzOjpjb21waWxlTmV3QXJyYXkpOgorCiAy
MDE4LTAzLTE1ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAg
ICAgICBGaXggTVNWQyBydW4tdGltZSBjaGVjayBhZnRlciByMjI5MzkxLiAKZGlmZiAtLWdpdCBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwIGIvU291cmNl
L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKaW5kZXggYTU2M2Q3ODA0
M2NkZjhkMTIyNTVhNGQwYjJmMjBiNGNlZDkzMTg3OC4uZTBhZDJkMTkxOGMyMThkOGJlNTk0NjEz
ZDZjMWFjMDJhOGY5Zjk4NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E
RkdCeXRlQ29kZVBhcnNlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdC
eXRlQ29kZVBhcnNlci5jcHAKQEAgLTM0NTQsNyArMzQ1NCw3IEBAIGJvb2wgQnl0ZUNvZGVQYXJz
ZXI6OmhhbmRsZUNvbnN0YW50SW50ZXJuYWxGdW5jdGlvbigKICAgICAgICAgZm9yIChpbnQgaSA9
IDE7IGkgPCBhcmd1bWVudENvdW50SW5jbHVkaW5nVGhpczsgKytpKQogICAgICAgICAgICAgYWRk
VmFyQXJnQ2hpbGQoZ2V0KHZpcnR1YWxSZWdpc3RlckZvckFyZ3VtZW50KGksIHJlZ2lzdGVyT2Zm
c2V0KSkpOwogICAgICAgICBzZXQoVmlydHVhbFJlZ2lzdGVyKHJlc3VsdE9wZXJhbmQpLAotICAg
ICAgICAgICAgYWRkVG9HcmFwaChOb2RlOjpWYXJBcmcsIE5ld0FycmF5LCBPcEluZm8oQXJyYXlX
aXRoVW5kZWNpZGVkKSwgT3BJbmZvKDApKSk7CisgICAgICAgICAgICBhZGRUb0dyYXBoKE5vZGU6
OlZhckFyZywgTmV3QXJyYXksIE9wSW5mbyhBcnJheVdpdGhVbmRlY2lkZWQpLCBPcEluZm8oYXJn
dW1lbnRDb3VudEluY2x1ZGluZ1RoaXMgLSAxKSkpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAg
ICB9CiAKQEAgLTQ1MDksNyArNDUwOSw4IEBAIHZvaWQgQnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxv
Y2sodW5zaWduZWQgbGltaXQpCiAgICAgICAgICAgICBBcnJheUFsbG9jYXRpb25Qcm9maWxlKiBw
cm9maWxlID0gY3VycmVudEluc3RydWN0aW9uWzRdLnUuYXJyYXlBbGxvY2F0aW9uUHJvZmlsZTsK
ICAgICAgICAgICAgIGZvciAoaW50IG9wZXJhbmRJZHggPSBzdGFydE9wZXJhbmQ7IG9wZXJhbmRJ
ZHggPiBzdGFydE9wZXJhbmQgLSBudW1PcGVyYW5kczsgLS1vcGVyYW5kSWR4KQogICAgICAgICAg
ICAgICAgIGFkZFZhckFyZ0NoaWxkKGdldChWaXJ0dWFsUmVnaXN0ZXIob3BlcmFuZElkeCkpKTsK
LSAgICAgICAgICAgIHNldChWaXJ0dWFsUmVnaXN0ZXIoY3VycmVudEluc3RydWN0aW9uWzFdLnUu
b3BlcmFuZCksIGFkZFRvR3JhcGgoTm9kZTo6VmFyQXJnLCBOZXdBcnJheSwgT3BJbmZvKHByb2Zp
bGUtPnNlbGVjdEluZGV4aW5nVHlwZSgpKSwgT3BJbmZvKDApKSk7CisgICAgICAgICAgICB1bnNp
Z25lZCB2ZWN0b3JMZW5ndGhIaW50ID0gc3RkOjptYXg8dW5zaWduZWQ+KHByb2ZpbGUtPnZlY3Rv
ckxlbmd0aEhpbnQoKSwgbnVtT3BlcmFuZHMpOworICAgICAgICAgICAgc2V0KFZpcnR1YWxSZWdp
c3RlcihjdXJyZW50SW5zdHJ1Y3Rpb25bMV0udS5vcGVyYW5kKSwgYWRkVG9HcmFwaChOb2RlOjpW
YXJBcmcsIE5ld0FycmF5LCBPcEluZm8ocHJvZmlsZS0+c2VsZWN0SW5kZXhpbmdUeXBlKCkpLCBP
cEluZm8odmVjdG9yTGVuZ3RoSGludCkpKTsKICAgICAgICAgICAgIE5FWFRfT1BDT0RFKG9wX25l
d19hcnJheSk7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl
L2RmZy9ERkdOb2RlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGUuaAppbmRl
eCBhMDZhNTRiZmU5MDNhMWVhZTdjNTNmYTQ4N2M0NDk5N2M0YTg3Mjg1Li45MjFjNTA2NTAwY2I1
MTU3MjJmYTJlYTg5MDc4NWRmNDM3ZGUwOGEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvZGZnL0RGR05vZGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05v
ZGUuaApAQCAtMTEyMSwxMiArMTEyMSwyMSBAQCBzdHJ1Y3QgTm9kZSB7CiAKICAgICB1bnNpZ25l
ZCBoYXNWZWN0b3JMZW5ndGhIaW50KCkKICAgICB7Ci0gICAgICAgIHJldHVybiBvcCgpID09IE5l
d0FycmF5QnVmZmVyIHx8IG9wKCkgPT0gUGhhbnRvbU5ld0FycmF5QnVmZmVyOworICAgICAgICBz
d2l0Y2ggKG9wKCkpIHsKKyAgICAgICAgY2FzZSBOZXdBcnJheToKKyAgICAgICAgY2FzZSBOZXdB
cnJheUJ1ZmZlcjoKKyAgICAgICAgY2FzZSBQaGFudG9tTmV3QXJyYXlCdWZmZXI6CisgICAgICAg
ICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgIHJldHVybiBm
YWxzZTsKKyAgICAgICAgfQogICAgIH0KICAgICAKICAgICB1bnNpZ25lZCB2ZWN0b3JMZW5ndGhI
aW50KCkKICAgICB7CiAgICAgICAgIEFTU0VSVChoYXNWZWN0b3JMZW5ndGhIaW50KCkpOworICAg
ICAgICBpZiAob3AoKSA9PSBOZXdBcnJheSkKKyAgICAgICAgICAgIHJldHVybiBtX29wSW5mbzIu
YXM8dW5zaWduZWQ+KCk7CiAgICAgICAgIHJldHVybiBuZXdBcnJheUJ1ZmZlckRhdGEoKS52ZWN0
b3JMZW5ndGhIaW50OwogICAgIH0KICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
ZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCmluZGV4IGM5NmQ0MWY3M2Q0MGE3OWVkOGU3NDYw
ODNjMDg1Y2MwYzUyZWUwYTcuLmU5NmJmNzM5MjcwMTlkY2JjY2I1ZjVhNDZlYmM4N2ViYTM3NGYw
ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVK
SVQ2NC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ
VDY0LmNwcApAQCAtMzczMCw2ICszNzMwLDggQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGls
ZShOb2RlKiBub2RlKQogICAgICAgICAgICAgICAgIHx8IGhhc0NvbnRpZ3VvdXMoc3RydWN0dXJl
LT5pbmRleGluZ1R5cGUoKSkpOwogICAgICAgICAgICAgCiAgICAgICAgICAgICB1bnNpZ25lZCBu
dW1FbGVtZW50cyA9IG5vZGUtPm51bUNoaWxkcmVuKCk7CisgICAgICAgICAgICB1bnNpZ25lZCB2
ZWN0b3JMZW5ndGhIaW50ID0gbm9kZS0+dmVjdG9yTGVuZ3RoSGludCgpOworICAgICAgICAgICAg
QVNTRVJUKHZlY3Rvckxlbmd0aEhpbnQgPj0gbnVtRWxlbWVudHMpOwogICAgICAgICAgICAgCiAg
ICAgICAgICAgICBHUFJUZW1wb3JhcnkgcmVzdWx0KHRoaXMpOwogICAgICAgICAgICAgR1BSVGVt
cG9yYXJ5IHN0b3JhZ2UodGhpcyk7CkBAIC0zNzM3LDcgKzM3MzksNyBAQCB2b2lkIFNwZWN1bGF0
aXZlSklUOjpjb21waWxlKE5vZGUqIG5vZGUpCiAgICAgICAgICAgICBHUFJSZWcgcmVzdWx0R1BS
ID0gcmVzdWx0LmdwcigpOwogICAgICAgICAgICAgR1BSUmVnIHN0b3JhZ2VHUFIgPSBzdG9yYWdl
LmdwcigpOwogCi0gICAgICAgICAgICBlbWl0QWxsb2NhdGVSYXdPYmplY3QocmVzdWx0R1BSLCBz
dHJ1Y3R1cmUsIHN0b3JhZ2VHUFIsIG51bUVsZW1lbnRzLCBudW1FbGVtZW50cyk7CisgICAgICAg
ICAgICBlbWl0QWxsb2NhdGVSYXdPYmplY3QocmVzdWx0R1BSLCBzdHJ1Y3R1cmUsIHN0b3JhZ2VH
UFIsIG51bUVsZW1lbnRzLCB2ZWN0b3JMZW5ndGhIaW50KTsKICAgICAgICAgICAgIAogICAgICAg
ICAgICAgLy8gQXQgdGhpcyBwb2ludCwgb25lIHdheSBvciBhbm90aGVyLCByZXN1bHRHUFIgYW5k
IHN0b3JhZ2VHUFIgaGF2ZSBwb2ludGVycyB0bwogICAgICAgICAgICAgLy8gdGhlIEpTQXJyYXkg
YW5kIHRoZSBCdXR0ZXJmbHksIHJlc3BlY3RpdmVseS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAppbmRleCA0YTk0ZTY3Y2JmNTFhMTQ0YTY1NTM2NTE5
MTAwYzgyYzRiOWUzMjhlLi44ODJjNGQwYzRlMGI2YWI4Zjk1OGNkMDY5NjNkMDQyMTQ1NTE0N2Zl
IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5j
cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCkBA
IC01NDAzLDkgKzU0MDMsMTEgQEAgY2xhc3MgTG93ZXJERkdUb0IzIHsKIAogICAgICAgICBpZiAo
IWdsb2JhbE9iamVjdC0+aXNIYXZpbmdBQmFkVGltZSgpICYmICFoYXNBbnlBcnJheVN0b3JhZ2Uo
bV9ub2RlLT5pbmRleGluZ1R5cGUoKSkpIHsKICAgICAgICAgICAgIHVuc2lnbmVkIG51bUVsZW1l
bnRzID0gbV9ub2RlLT5udW1DaGlsZHJlbigpOworICAgICAgICAgICAgdW5zaWduZWQgdmVjdG9y
TGVuZ3RoSGludCA9IG1fbm9kZS0+dmVjdG9yTGVuZ3RoSGludCgpOworICAgICAgICAgICAgQVNT
RVJUKHZlY3Rvckxlbmd0aEhpbnQgPj0gbnVtRWxlbWVudHMpOwogICAgICAgICAgICAgCiAgICAg
ICAgICAgICBBcnJheVZhbHVlcyBhcnJheVZhbHVlcyA9Ci0gICAgICAgICAgICAgICAgYWxsb2Nh
dGVVbmluaXRpYWxpemVkQ29udGlndW91c0pTQXJyYXkobV9vdXQuY29uc3RJbnQzMihudW1FbGVt
ZW50cyksIHN0cnVjdHVyZSk7CisgICAgICAgICAgICAgICAgYWxsb2NhdGVVbmluaXRpYWxpemVk
Q29udGlndW91c0pTQXJyYXkobnVtRWxlbWVudHMsIHZlY3Rvckxlbmd0aEhpbnQsIHN0cnVjdHVy
ZSk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGZvciAodW5zaWduZWQgb3BlcmFuZEluZGV4
ID0gMDsgb3BlcmFuZEluZGV4IDwgbV9ub2RlLT5udW1DaGlsZHJlbigpOyArK29wZXJhbmRJbmRl
eCkgewogICAgICAgICAgICAgICAgIEVkZ2UgZWRnZSA9IG1fZ3JhcGgudmFyQXJnQ2hpbGQobV9u
b2RlLCBvcGVyYW5kSW5kZXgpOwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rl
c3RzL0NoYW5nZUxvZwppbmRleCAwNWY1ZDk4MWY5NTk1ZDRhMTIxZGQzNzJmN2VlN2VhNDdmYWZl
ZDE3Li43NzIxOWFkNTcwMjMxYzdmNWY3Nzc2OTgwYWRiODY2ZDMxMzcxMGViIDEwMDY0NAotLS0g
YS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3
IEBACisyMDE4LTAzLTE2ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgor
CisgICAgICAgIFtERkddW0ZUTF0gQWRkIHZlY3Rvckxlbmd0aEhpbnQgZm9yIE5ld0FycmF5Cisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM2OTQKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy92
ZWN0b3ItbGVuZ3RoLWhpbnQtYXJyYXktY29uc3RydWN0b3IuanM6IEFkZGVkLgorICAgICAgICAo
c2hvdWxkQmUpOgorICAgICAgICAodGVzdCk6CisgICAgICAgICogc3RyZXNzL3ZlY3Rvci1sZW5n
dGgtaGludC1uZXctYXJyYXkuanM6IEFkZGVkLgorICAgICAgICAoc2hvdWxkQmUpOgorICAgICAg
ICAodGVzdCk6CisKIDIwMTgtMDMtMTQgIENhaXRsaW4gUG90dGVyICA8Y2FpdHBAaWdhbGlhLmNv
bT4KIAogICAgICAgICBbSlNDXSBmaXggb3JkZXIgb2YgZXZhbHVhdGlvbiBmb3IgQ2xhc3NEZWZp
bml0aW9uRXZhbHVhdGlvbgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvdmVjdG9yLWxlbmd0
aC1oaW50LWFycmF5LWNvbnN0cnVjdG9yLmpzIGIvSlNUZXN0cy9zdHJlc3MvdmVjdG9yLWxlbmd0
aC1oaW50LWFycmF5LWNvbnN0cnVjdG9yLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmNkNWRhZTUxYzQ2MmZiMDZm
MGY2Yjc3ZjMyOGY2MWUxODBjZDQ0YTgKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVz
cy92ZWN0b3ItbGVuZ3RoLWhpbnQtYXJyYXktY29uc3RydWN0b3IuanMKQEAgLTAsMCArMSwxOCBA
QAorZnVuY3Rpb24gc2hvdWxkQmUoYWN0dWFsLCBleHBlY3RlZCkgeworICAgIGlmIChhY3R1YWwg
IT09IGV4cGVjdGVkKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoJ2JhZCB2YWx1ZTogJyArIGFj
dHVhbCk7Cit9CisKK2Z1bmN0aW9uIHRlc3QoY29uc3RydWN0b3IpCit7CisgICAgdmFyIGFycmF5
ID0gbmV3IGNvbnN0cnVjdG9yKDEsIDIpOworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMjA7ICsr
aSkKKyAgICAgICAgYXJyYXkucHVzaChpKTsKKyAgICByZXR1cm4gYXJyYXk7Cit9Citub0lubGlu
ZSh0ZXN0KTsKKworZm9yICh2YXIgaSA9IDA7IGkgPCAxZTU7ICsraSkgeworICAgIHZhciByZXN1
bHQgPSB0ZXN0KEFycmF5KTsKKyAgICBzaG91bGRCZShKU09OLnN0cmluZ2lmeShyZXN1bHQpLCBg
WzEsMiwwLDEsMiwzLDQsNSw2LDcsOCw5LDEwLDExLDEyLDEzLDE0LDE1LDE2LDE3LDE4LDE5XWAp
OworfQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvdmVjdG9yLWxlbmd0aC1oaW50LW5ldy1h
cnJheS5qcyBiL0pTVGVzdHMvc3RyZXNzL3ZlY3Rvci1sZW5ndGgtaGludC1uZXctYXJyYXkuanMK
bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMC4uZWQ5NmE4ZGUzNjM5MDVhNTM3ODhkNzQ5Y2VhYTg2ZWE4NzY3OWQzNgotLS0g
L2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL3ZlY3Rvci1sZW5ndGgtaGludC1uZXctYXJy
YXkuanMKQEAgLTAsMCArMSwxOCBAQAorZnVuY3Rpb24gc2hvdWxkQmUoYWN0dWFsLCBleHBlY3Rl
ZCkgeworICAgIGlmIChhY3R1YWwgIT09IGV4cGVjdGVkKQorICAgICAgICB0aHJvdyBuZXcgRXJy
b3IoJ2JhZCB2YWx1ZTogJyArIGFjdHVhbCk7Cit9CisKK2Z1bmN0aW9uIHRlc3QodjAsIHYxKQor
eworICAgIHZhciBhcnJheSA9IFt2MCwgdjFdOworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMjA7
ICsraSkKKyAgICAgICAgYXJyYXkucHVzaChpKTsKKyAgICByZXR1cm4gYXJyYXk7Cit9Citub0lu
bGluZSh0ZXN0KTsKKworZm9yICh2YXIgaSA9IDA7IGkgPCAxZTU7ICsraSkgeworICAgIHZhciBy
ZXN1bHQgPSB0ZXN0KDEsIDIpOworICAgIHNob3VsZEJlKEpTT04uc3RyaW5naWZ5KHJlc3VsdCks
IGBbMSwyLDAsMSwyLDMsNCw1LDYsNyw4LDksMTAsMTEsMTIsMTMsMTQsMTUsMTYsMTcsMTgsMTld
YCk7Cit9Cg==
</data>
<flag name="review"
          id="354503"
          type_id="1"
          status="+"
          setter="saam"
    />
          </attachment>
      

    </bug>

</bugzilla>