183691 2018-03-15 21:03:14 -0700 [LayoutReloaded] Should never need to go beyond the root container when asking for the containing block. 2018-03-15 21:14:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan webkit-bug-importer oldest_to_newest 1406933 0 zalan 2018-03-15 21:03:14 -0700 While laying out the boxes in a block formatting context, when we happen to need to get to the containing block, it should always be a descendant of the root container (or the root container itself). Nothing outside of the formatting context should be able to impact the boxes inside. 1406934 1 335923 zalan 2018-03-15 21:06:00 -0700 Created attachment 335923 Patch 1406935 2 zalan 2018-03-15 21:13:31 -0700 Committed r229658: <https://trac.webkit.org/changeset/229658> 1406936 3 webkit-bug-importer 2018-03-15 21:14:26 -0700 <rdar://problem/38531372> 335923 2018-03-15 21:06:00 -0700 2018-03-15 21:06:00 -0700 Patch bug-183691-20180315210600.patch text/plain 7168 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NjI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjRlYjhkMzhkYWQ4NDRiYjQ4ZGFlOGRjODg1NzFiNWNj ZmViN2JlOS4uZWI2MmIyYWZmYzhhNWI4MjhmMTVmNjljZGFjMTg1OWU3MWViNTY5NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMw IEBACisyMDE4LTAzLTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAg ICAgW0xheW91dFJlbG9hZGVkXSBTaG91bGQgbmV2ZXIgbmVlZCB0byBnbyBiZXlvbmQgdGhlIHJv b3QgY29udGFpbmVyIHdoZW4gYXNraW5nIGZvciB0aGUgY29udGFpbmluZyBibG9jay4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzY5MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIGxheWluZyBv dXQgdGhlIGJveGVzIGluIGEgYmxvY2sgZm9ybWF0dGluZyBjb250ZXh0LCBpZiB3ZSBoYXBwZW4g dG8gbmVlZAorICAgICAgICB0byBnZXQgdG8gdGhlIGNvbnRhaW5pbmcgYmxvY2sgb2YgYSBib3gg dG8gY29tcHV0ZSBnZW9tZXRyeSwgaXQgc2hvdWxkIGFsd2F5cyBiZSBhCisgICAgICAgIGRlc2Nl bmRhbnQgb2YgdGhlIHJvb3QgY29udGFpbmVyIChvciB0aGUgcm9vdCBjb250YWluZXIgaXRzZWxm KS4KKyAgICAgICAgTm90aGluZyBvdXRzaWRlIG9mIHRoZSBmb3JtYXR0aW5nIGNvbnRleHQgc2hv dWxkIGJlIGFibGUgdG8gaW1wYWN0IHRoZSBib3hlcyBpbnNpZGUuCisKKyAgICAgICAgKiBMYXlv dXRSZWxvYWRlZC9Gb3JtYXR0aW5nQ29udGV4dC9CbG9ja0Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0 aW5nQ29udGV4dC5qczoKKyAgICAgICAgKEJsb2NrRm9ybWF0dGluZ0NvbnRleHQucHJvdG90eXBl Ll9jb21wdXRlT3V0T2ZGbG93UG9zaXRpb24pOgorICAgICAgICAoQmxvY2tGb3JtYXR0aW5nQ29u dGV4dC5wcm90b3R5cGUuX3RvQWJzb2x1dGVQb3NpdGlvbik6CisgICAgICAgIChCbG9ja0Zvcm1h dHRpbmdDb250ZXh0KToKKyAgICAgICAgKiBMYXlvdXRSZWxvYWRlZC9Gb3JtYXR0aW5nQ29udGV4 dC9CbG9ja0Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5Db2xsYXBzZS5qczoKKyAgICAgICAgKEJsb2Nr TWFyZ2luQ29sbGFwc2UuX2lzTWFyZ2luVG9wQ29sbGFwc2VkV2l0aFBhcmVudCk6CisgICAgICAg IChCbG9ja01hcmdpbkNvbGxhcHNlLl9pc01hcmdpbkJvdHRvbUNvbGxhcHNlZFdpdGhQYXJlbnQp OgorICAgICAgICAqIExheW91dFJlbG9hZGVkL0xheW91dFRyZWUvQm94LmpzOgorICAgICAgICAo TGF5b3V0LkJveC5wcm90b3R5cGUuaXNSb290Qm94KToKKyAgICAgICAgKExheW91dC5Cb3gucHJv dG90eXBlLmlzUm9vdEVsZW1lbnQpOiBEZWxldGVkLgorICAgICAgICAqIExheW91dFJlbG9hZGVk L1V0aWxzLmpzOgorICAgICAgICAoVXRpbHMuaXNEZXNjZW5kYW50T2YpOgorICAgICAgICAoVXRp bHMubWFwU3RhdGljVG9BYnNvbHV0ZSk6IERlbGV0ZWQuCisgICAgICAgICogTGF5b3V0UmVsb2Fk ZWQvbWlzYy9oZWFkZXJzL0JveC5oOgorCiAyMDE4LTAzLTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xheW91dFJlbG9hZGVkXSBJbnRyb2R1Y2UgTGF5b3V0 IG5hbWVzcGFjZQpkaWZmIC0tZ2l0IGEvVG9vbHMvTGF5b3V0UmVsb2FkZWQvRm9ybWF0dGluZ0Nv bnRleHQvQmxvY2tGb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuanMgYi9Ub29scy9M YXlvdXRSZWxvYWRlZC9Gb3JtYXR0aW5nQ29udGV4dC9CbG9ja0Zvcm1hdHRpbmcvQmxvY2tGb3Jt YXR0aW5nQ29udGV4dC5qcwppbmRleCA5YjkwNTczYTdkOWE5ODdkMTZhMWY4Nzg2NzhjMWRlMjVi ZmY0ZmQ5Li4yYmM3YmVkZTU5Nzk2MmMwZTlhM2QzZjdhZjgyMDVjYWFlOGJmNDY3IDEwMDY0NAot LS0gYS9Ub29scy9MYXlvdXRSZWxvYWRlZC9Gb3JtYXR0aW5nQ29udGV4dC9CbG9ja0Zvcm1hdHRp bmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5qcworKysgYi9Ub29scy9MYXlvdXRSZWxvYWRlZC9G b3JtYXR0aW5nQ29udGV4dC9CbG9ja0Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5q cwpAQCAtMjk0LDcgKzI5NCw3IEBAIGNsYXNzIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQgZXh0ZW5k cyBGb3JtYXR0aW5nQ29udGV4dCB7CiAgICAgICAgIGxldCB0b3AgPSBOdW1iZXIuTmFOOwogICAg ICAgICBpZiAoVXRpbHMuaXNUb3BBdXRvKGxheW91dEJveCkgJiYgVXRpbHMuaXNCb3R0b21BdXRv KGxheW91dEJveCkpIHsKICAgICAgICAgICAgIC8vIENvbnZlcnQgc3RhdGljIHBvc2l0aW9uIHRv IGFic29sdXRlLgotICAgICAgICAgICAgdG9wID0gVXRpbHMubWFwU3RhdGljVG9BYnNvbHV0ZShs YXlvdXRCb3gpLnRvcCgpOworICAgICAgICAgICAgdG9wID0gdGhpcy5fdG9BYnNvbHV0ZVBvc2l0 aW9uKGxheW91dEJveCkudG9wKCk7CiAgICAgICAgIH0gZWxzZSBpZiAoIVV0aWxzLmlzVG9wQXV0 byhsYXlvdXRCb3gpKQogICAgICAgICAgICAgdG9wID0gVXRpbHMudG9wKGxheW91dEJveCkgKyB0 aGlzLm1hcmdpblRvcChsYXlvdXRCb3gpOwogICAgICAgICBlbHNlIGlmICghVXRpbHMuaXNCb3R0 b21BdXRvKGxheW91dEJveCkpCkBAIC0zMDUsNyArMzA1LDcgQEAgY2xhc3MgQmxvY2tGb3JtYXR0 aW5nQ29udGV4dCBleHRlbmRzIEZvcm1hdHRpbmdDb250ZXh0IHsKICAgICAgICAgbGV0IGxlZnQg PSBOdW1iZXIuTmFOOwogICAgICAgICBpZiAoVXRpbHMuaXNMZWZ0QXV0byhsYXlvdXRCb3gpICYm IFV0aWxzLmlzUmlnaHRBdXRvKGxheW91dEJveCkpIHsKICAgICAgICAgICAgIC8vIENvbnZlcnQg c3RhdGljIHBvc2l0aW9uIHRvIGFic29sdXRlLgotICAgICAgICAgICAgbGVmdCA9IFV0aWxzLm1h cFN0YXRpY1RvQWJzb2x1dGUobGF5b3V0Qm94KS5sZWZ0KCk7CisgICAgICAgICAgICBsZWZ0ID0g dGhpcy5fdG9BYnNvbHV0ZVBvc2l0aW9uKGxheW91dEJveCkubGVmdCgpOwogICAgICAgICB9IGVs c2UgaWYgKCFVdGlscy5pc0xlZnRBdXRvKGxheW91dEJveCkpCiAgICAgICAgICAgICBsZWZ0ID0g VXRpbHMubGVmdChsYXlvdXRCb3gpICsgdGhpcy5tYXJnaW5MZWZ0KGxheW91dEJveCk7CiAgICAg ICAgIGVsc2UgaWYgKCFVdGlscy5pc1JpZ2h0QXV0byhsYXlvdXRCb3gpKQpAQCAtMzI3LDUgKzMy NywxOCBAQCBjbGFzcyBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0IGV4dGVuZHMgRm9ybWF0dGluZ0Nv bnRleHQgewogICAgICAgICB9CiAgICAgICAgIHJldHVybiB3aWR0aDsKICAgICB9CisKKyAgICBf dG9BYnNvbHV0ZVBvc2l0aW9uKGxheW91dEJveCkgeworICAgICAgICAvLyBXZSBzaG91bGQgbmV2 ZXIgbmVlZCB0byBnbyBiZXlvbmQgdGhlIHJvb3QgY29udGFpbmVyLgorICAgICAgICBsZXQgY29u dGFpbmluZ0Jsb2NrID0gbGF5b3V0Qm94LmNvbnRhaW5pbmdCbG9jaygpOworICAgICAgICBBU1NF UlQoY29udGFpbmluZ0Jsb2NrID09IHRoaXMucm9vdENvbnRhaW5lcigpIHx8IFV0aWxzLmlzRGVz Y2VuZGFudE9mKGNvbnRhaW5pbmdCbG9jaywgdGhpcy5yb290Q29udGFpbmVyKCkpKTsKKyAgICAg ICAgbGV0IHRvcExlZnQgPSBsYXlvdXRCb3gucmVjdCgpLnRvcExlZnQoKTsKKyAgICAgICAgbGV0 IGFzY2VuZGFudCA9IGxheW91dEJveC5wYXJlbnQoKTsKKyAgICAgICAgd2hpbGUgKGFzY2VuZGFu dCAmJiBhc2NlbmRhbnQgIT0gY29udGFpbmluZ0Jsb2NrKSB7CisgICAgICAgICAgICB0b3BMZWZ0 Lm1vdmVCeShhc2NlbmRhbnQucmVjdCgpLnRvcExlZnQoKSk7CisgICAgICAgICAgICBhc2NlbmRh bnQgPSBhc2NlbmRhbnQucGFyZW50KCk7CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuIG5ldyBM YXlvdXRSZWN0KHRvcExlZnQsIGxheW91dEJveC5yZWN0KCkuc2l6ZSgpKTsKKyAgICB9CiB9CiAK ZGlmZiAtLWdpdCBhL1Rvb2xzL0xheW91dFJlbG9hZGVkL0Zvcm1hdHRpbmdDb250ZXh0L0Jsb2Nr Rm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNlLmpzIGIvVG9vbHMvTGF5b3V0UmVsb2FkZWQv Rm9ybWF0dGluZ0NvbnRleHQvQmxvY2tGb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuanMK aW5kZXggZGIyZDRkM2IyZDBmZWExZTlkMjQ5ODE2Nzc4ZDg0YTQ4YjYwMjNkMi4uNzg0NWEwOTA3 N2IyNDJiZWE0YzNjYTNhNWE1ODFlMGU3YTNhYTExMyAxMDA2NDQKLS0tIGEvVG9vbHMvTGF5b3V0 UmVsb2FkZWQvRm9ybWF0dGluZ0NvbnRleHQvQmxvY2tGb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29s bGFwc2UuanMKKysrIGIvVG9vbHMvTGF5b3V0UmVsb2FkZWQvRm9ybWF0dGluZ0NvbnRleHQvQmxv Y2tGb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuanMKQEAgLTk0LDcgKzk0LDcgQEAgY2xh c3MgQmxvY2tNYXJnaW5Db2xsYXBzZSB7CiAgICAgICAgIGlmIChwYXJlbnQuZXN0YWJsaXNoZXNC bG9ja0Zvcm1hdHRpbmdDb250ZXh0KCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAg ICAgIC8vIE1hcmdpbnMgb2YgdGhlIHJvb3QgZWxlbWVudCdzIGJveCBkbyBub3QgY29sbGFwc2Uu Ci0gICAgICAgIGlmIChwYXJlbnQuaXNSb290RWxlbWVudCgpKQorICAgICAgICBpZiAocGFyZW50 LmlzUm9vdEJveCgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBpZiAoVXRp bHMuaGFzQm9yZGVyVG9wKHBhcmVudCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC0x MTcsNyArMTE3LDcgQEAgY2xhc3MgQmxvY2tNYXJnaW5Db2xsYXBzZSB7CiAgICAgICAgIGlmIChw YXJlbnQuZXN0YWJsaXNoZXNCbG9ja0Zvcm1hdHRpbmdDb250ZXh0KCkpCiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgICAgIC8vIE1hcmdpbnMgb2YgdGhlIHJvb3QgZWxlbWVudCdzIGJv eCBkbyBub3QgY29sbGFwc2UuCi0gICAgICAgIGlmIChwYXJlbnQuaXNSb290RWxlbWVudCgpKQor ICAgICAgICBpZiAocGFyZW50LmlzUm9vdEJveCgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNl OwogICAgICAgICBpZiAoVXRpbHMuaGFzQm9yZGVyVG9wKHBhcmVudCkpCiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CmRpZmYgLS1naXQgYS9Ub29scy9MYXlvdXRSZWxvYWRlZC9MYXlvdXRUcmVl L0JveC5qcyBiL1Rvb2xzL0xheW91dFJlbG9hZGVkL0xheW91dFRyZWUvQm94LmpzCmluZGV4IGI1 Mzk3NjVhMjMyOGEyZmQyOWFhYzY0NzBmNDc2ZTI2ZmM0YTBlZGIuLjg1MWE5M2EzZmMxYWIzMTA2 YTI5NGQ5OTNiNTVkNmQ2MWRlMjA1MmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0xheW91dFJlbG9hZGVk L0xheW91dFRyZWUvQm94LmpzCisrKyBiL1Rvb2xzL0xheW91dFJlbG9hZGVkL0xheW91dFRyZWUv Qm94LmpzCkBAIC0yMTMsNyArMjEzLDcgQEAgTGF5b3V0LkJveCA9IGNsYXNzIEJveCB7CiAgICAg ICAgIHJldHVybiB0aGlzLmlzRmxvYXRpbmdQb3NpdGlvbmVkKCkgfHwgdGhpcy5pc091dE9mRmxv d1Bvc2l0aW9uZWQoKTsKICAgICB9CiAKLSAgICBpc1Jvb3RFbGVtZW50KCkgeworICAgIGlzUm9v dEJveCgpIHsKICAgICAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGp1c3QgYmUgYSBzaW1wbGUg aW5zdGFuY2VvZiBjaGVjaywgYnV0IHdlIGFyZSBpbiB0aGUgbWFpbmZyYW1lIHdoaWxlIHRoZSB0 ZXN0IGRvY3VtZW50IGlzIGluIGFuIGlmcmFtZQogICAgICAgICAvLyBMZXQncyBqdXN0IHJldHVy biByb290IGZvciBib3RoIHRoZSBSZW5kZXJWaWV3IGFuZCB0aGUgPGh0bWw+IGVsZW1lbnQuCiAg ICAgICAgIHJldHVybiAhdGhpcy5wYXJlbnQoKSB8fCAhdGhpcy5wYXJlbnQoKS5wYXJlbnQoKTsK ZGlmZiAtLWdpdCBhL1Rvb2xzL0xheW91dFJlbG9hZGVkL1V0aWxzLmpzIGIvVG9vbHMvTGF5b3V0 UmVsb2FkZWQvVXRpbHMuanMKaW5kZXggZmFkMzY0YjQ3ZTIwNjE0NDFiODZhN2Q1MTQzNTRkMWFk ZjI5ZmI4My4uMjRjOGMyNjkzZjdhMDk1ZjE1ZTVmMzcxM2NmYTYwYWYyYmYzMTcyNSAxMDA2NDQK LS0tIGEvVG9vbHMvTGF5b3V0UmVsb2FkZWQvVXRpbHMuanMKKysrIGIvVG9vbHMvTGF5b3V0UmVs b2FkZWQvVXRpbHMuanMKQEAgLTQ4Niw4ICs0ODYsMTIgQEAgY2xhc3MgVXRpbHMgewogICAgICAg ICByZXR1cm4gbmV3IExheW91dFJlY3QodG9wTGVmdCwgYm94LnJlY3QoKS5zaXplKCkpOwogICAg IH0KIAotICAgIHN0YXRpYyBtYXBTdGF0aWNUb0Fic29sdXRlKGJveCkgewotICAgICAgICByZXR1 cm4gVXRpbHMubWFwVG9Db250YWluZXIoYm94LCBib3guY29udGFpbmluZ0Jsb2NrKCkpOworICAg IHN0YXRpYyBpc0Rlc2NlbmRhbnRPZihsYXlvdXRCb3gsIGNvbnRhaW5lcikgeworICAgICAgICBB U1NFUlQoY29udGFpbmVyKTsKKyAgICAgICAgbGV0IGFzY2VuZGFudCA9IGxheW91dEJveC5wYXJl bnQoKTsKKyAgICAgICAgd2hpbGUgKGFzY2VuZGFudCAmJiBhc2NlbmRhbnQgIT0gY29udGFpbmVy KQorICAgICAgICAgICAgYXNjZW5kYW50ID0gYXNjZW5kYW50LnBhcmVudCgpOworICAgICAgICBy ZXR1cm4gISFhc2NlbmRhbnQ7CiAgICAgfQogCiAgICAgc3RhdGljIGNvbGxlY3RPdXRPZkZsb3dE ZXNjZW5kYW50cyhjb250YWludEJsb2NrKSB7CmRpZmYgLS1naXQgYS9Ub29scy9MYXlvdXRSZWxv YWRlZC9taXNjL2hlYWRlcnMvQm94LmggYi9Ub29scy9MYXlvdXRSZWxvYWRlZC9taXNjL2hlYWRl cnMvQm94LmgKaW5kZXggMTEwODc1NDA0NWM4MjM5YzE0OTRkYzQ3MTllODQzNjE1NGFkYjM5Ny4u YWE1Y2QyNDA1NGFiYWY0NGMzMmQ5NzQ4NzQ2YzQyZDkzNDc4ZmM4MiAxMDA2NDQKLS0tIGEvVG9v bHMvTGF5b3V0UmVsb2FkZWQvbWlzYy9oZWFkZXJzL0JveC5oCisrKyBiL1Rvb2xzL0xheW91dFJl bG9hZGVkL21pc2MvaGVhZGVycy9Cb3guaApAQCAtNTQsNyArNTQsNyBAQCBjbGFzcyBCb3ggewog ICAgIAogICAgIHZvaWQgc2V0SXNBbm9ueW1vdXMoYm9vbCk7CiAgICAgYm9vbCBpc0Fub255bW91 cygpIGNvbnN0OwotICAgIHZpcnR1YWwgYm9vbCBpc1Jvb3RFbGVtZW50KCkgY29uc3Q7CisgICAg Ym9vbCBpc1Jvb3RCb3goKSBjb25zdDsKICAgICB2aXJ0dWFsIGJvb2wgaXNDb250YWluZXIoKSBj b25zdDsKIAogICAgIGJvb2wgaXNCbG9ja0xldmVsQm94KCkgY29uc3Q7Cg==