183664 2018-03-15 10:50:20 -0700 Add unit-test for NetworkTransaction URLError handling 2018-03-15 11:40:27 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1406712 0 aakash_jain 2018-03-15 10:50:20 -0700 Add unit-test for NetworkTransaction URLError handling. 1406713 1 335861 aakash_jain 2018-03-15 10:53:17 -0700 Created attachment 335861 Proposed patch 1406739 2 335861 commit-queue 2018-03-15 11:39:48 -0700 Comment on attachment 335861 Proposed patch Clearing flags on attachment: 335861 Committed r229630: <https://trac.webkit.org/changeset/229630> 1406740 3 commit-queue 2018-03-15 11:39:49 -0700 All reviewed patches have been landed. Closing bug. 1406742 4 webkit-bug-importer 2018-03-15 11:40:27 -0700 <rdar://problem/38509284> 335861 2018-03-15 10:53:17 -0700 2018-03-15 11:39:48 -0700 Proposed patch webkitpy_URLError_unittest.patch text/plain 3077 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyOTYyNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTAzLTE1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgdW5pdC10ZXN0IGZvciBOZXR3b3JrVHJhbnNhY3Rpb24gVVJMRXJy b3IgaGFuZGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4MzY2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L25ldHdvcmt0cmFuc2FjdGlvbl91bml0 dGVzdC5weToKKyAgICAgICAgKE5ldHdvcmtUcmFuc2FjdGlvblRlc3QuX3JhaXNlX1VSTEVycm9y KTogTWV0aG9kIHRvIHJhaXNlIFVSTEVycm9yLgorICAgICAgICAoTmV0d29ya1RyYW5zYWN0aW9u VGVzdC50ZXN0X3JldHJ5X29uX0hUVFBFcnJvcik6IFJlbmFtZWQgZnJvbSB0ZXN0X3JldHJ5Lgor ICAgICAgICAoTmV0d29ya1RyYW5zYWN0aW9uVGVzdC50ZXN0X3JldHJ5X29uX1VSTEVycm9yKTog dW5pdC10ZXN0IGZvciB0ZXN0aW5nIFVSTEVycm9yIGhhbmRsaW5nLgorCiAyMDE4LTAzLTE1ICBB YWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBFV1Mgc2hvdWxk IHByaW50IHRoZSBVUkwgaW4gbG9ncyBvbiBVUkxFcnJvcgpJbmRleDogVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vbmV0L25ldHdvcmt0cmFuc2FjdGlvbl91bml0dGVzdC5weQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvbmV0d29ya3RyYW5zYWN0 aW9uX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyMjk2MjcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9uZXQvbmV0d29ya3RyYW5zYWN0aW9uX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNv cHkpCkBAIC02MiwxMSArNjIsMTggQEAgY2xhc3MgTmV0d29ya1RyYW5zYWN0aW9uVGVzdChMb2dn aW5nVGVzdAogICAgICAgICAgICAgcmFpc2UgSFRUUEVycm9yKCJodHRwOi8vZXhhbXBsZS5jb20v IiwgNTAwLCAiaW50ZXJuYWwgc2VydmVyIGVycm9yIiwgTm9uZSwgTm9uZSkKICAgICAgICAgcmV0 dXJuIDQyCiAKKyAgICBkZWYgX3JhaXNlX1VSTEVycm9yKHNlbGYpOgorICAgICAgICBzZWxmLl9y dW5fY291bnQgKz0gMQorICAgICAgICBpZiBzZWxmLl9ydW5fY291bnQgPCAzOgorICAgICAgICAg ICAgZnJvbSB3ZWJraXRweS50aGlyZHBhcnR5LmF1dG9pbnN0YWxsZWQubWVjaGFuaXplIGltcG9y dCBVUkxFcnJvcgorICAgICAgICAgICAgcmFpc2UgVVJMRXJyb3IoIltFcnJubyA2MF0gT3BlcmF0 aW9uIHRpbWVkIG91dCIpCisgICAgICAgIHJldHVybiA0MworCiAgICAgZGVmIF9yYWlzZV80MDRf ZXJyb3Ioc2VsZik6CiAgICAgICAgIGZyb20gd2Via2l0cHkudGhpcmRwYXJ0eS5hdXRvaW5zdGFs bGVkLm1lY2hhbml6ZSBpbXBvcnQgSFRUUEVycm9yCiAgICAgICAgIHJhaXNlIEhUVFBFcnJvcigi aHR0cDovL2Zvby5jb20vIiwgNDA0LCAibm90IGZvdW5kIiwgTm9uZSwgTm9uZSkKIAotICAgIGRl ZiB0ZXN0X3JldHJ5KHNlbGYpOgorICAgIGRlZiB0ZXN0X3JldHJ5X29uX0hUVFBFcnJvcihzZWxm KToKICAgICAgICAgc2VsZi5fcnVuX2NvdW50ID0gMAogICAgICAgICB0cmFuc2FjdGlvbiA9IE5l dHdvcmtUcmFuc2FjdGlvbihpbml0aWFsX2JhY2tvZmZfc2Vjb25kcz0wKQogICAgICAgICBzZWxm LmFzc2VydEVxdWFsKHRyYW5zYWN0aW9uLnJ1bihsYW1iZGE6IHNlbGYuX3JhaXNlXzUwMF9lcnJv cigpKSwgNDIpCkBAIC03Niw2ICs4MywxNyBAQCBjbGFzcyBOZXR3b3JrVHJhbnNhY3Rpb25UZXN0 KExvZ2dpbmdUZXN0CiAgICAgICAgICAgICAgICAgICAgICAgICAnV0FSTklORzogUmVjZWl2ZWQg SFRUUCBzdGF0dXMgNTAwIGxvYWRpbmcgImh0dHA6Ly9leGFtcGxlLmNvbS8iLiAgJwogICAgICAg ICAgICAgICAgICAgICAgICAgJ1JldHJ5aW5nIGluIDAuMCBzZWNvbmRzLi4uXG4nXSkKIAorICAg IGRlZiB0ZXN0X3JldHJ5X29uX1VSTEVycm9yKHNlbGYpOgorICAgICAgICBzZWxmLl9ydW5fY291 bnQgPSAwCisgICAgICAgIHVybCA9ICJodHRwOi8vZXhhbXBsZS5jb20vIgorICAgICAgICB0cmFu c2FjdGlvbiA9IE5ldHdvcmtUcmFuc2FjdGlvbihpbml0aWFsX2JhY2tvZmZfc2Vjb25kcz0wKQor ICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHRyYW5zYWN0aW9uLnJ1bihsYW1iZGE6IHNlbGYuX3Jh aXNlX1VSTEVycm9yKCksIHVybCksIDQzKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYu X3J1bl9jb3VudCwgMykKKyAgICAgICAgc2VsZi5hc3NlcnRMb2coWydXQVJOSU5HOiBSZWNlaXZl ZCBVUkxFcnJvcjogIltFcnJubyA2MF0gT3BlcmF0aW9uIHRpbWVkIG91dCIgd2hpbGUgbG9hZGlu ZyBodHRwOi8vZXhhbXBsZS5jb20vLiAnCisgICAgICAgICAgICAgICAgICAgICAgICAnUmV0cnlp bmcgaW4gMCBzZWNvbmRzLi4uXG4nLAorICAgICAgICAgICAgICAgICAgICAgICAgJ1dBUk5JTkc6 IFJlY2VpdmVkIFVSTEVycm9yOiAiW0Vycm5vIDYwXSBPcGVyYXRpb24gdGltZWQgb3V0IiB3aGls ZSBsb2FkaW5nIGh0dHA6Ly9leGFtcGxlLmNvbS8uICcKKyAgICAgICAgICAgICAgICAgICAgICAg ICdSZXRyeWluZyBpbiAwLjAgc2Vjb25kcy4uLlxuJ10pCisKICAgICBkZWYgdGVzdF9jb252ZXJ0 XzQwNF90b19Ob25lKHNlbGYpOgogICAgICAgICB0cmFuc2FjdGlvbiA9IE5ldHdvcmtUcmFuc2Fj dGlvbihjb252ZXJ0XzQwNF90b19Ob25lPVRydWUpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo dHJhbnNhY3Rpb24ucnVuKGxhbWJkYTogc2VsZi5fcmFpc2VfNDA0X2Vycm9yKCkpLCBOb25lKQo=