183663 2018-03-15 09:57:54 -0700 REGRESSION(r229484): Plugins often require CGS Connections to draw 2018-03-15 12:40:27 -0700 1 1 1 Unclassified WebKit Plug-ins WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 182747 183672 1 bfulgham bfulgham bfulgham commit-queue pvollan oldest_to_newest 1406692 0 bfulgham 2018-03-15 09:57:54 -0700 Flash content broke after r229484 because it needs an active CGSConnection to perform certain drawing operations. To maintain compatibility, we need to continue to allow the Plugin Process to communicate with the Window Server, which is unfortunate. 1406695 1 bfulgham 2018-03-15 09:58:24 -0700 <rdar://problem/38439218> 1406698 2 335857 bfulgham 2018-03-15 10:04:50 -0700 Created attachment 335857 Patch 1406700 3 335857 pvollan 2018-03-15 10:11:51 -0700 Comment on attachment 335857 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335857&action=review > Source/WebKit/Platform/mac/LayerHostingContext.mm:81 > + layerHostingContext->m_context = [CAContext contextWithCGSConnection:CGSMainConnectionID() options:@{ kCAContextCIFilterBehavior : @"ignore" }]; Will creating the context with 'layerHostingContext->m_context = [CAContext remoteContextWithOptions:@{kCAContextCIFilterBehavior : @"ignore"}];' work? 1406701 4 bfulgham 2018-03-15 10:12:51 -0700 (In reply to Per Arne Vollan from comment #3) > Comment on attachment 335857 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=335857&action=review > > > Source/WebKit/Platform/mac/LayerHostingContext.mm:81 > > + layerHostingContext->m_context = [CAContext contextWithCGSConnection:CGSMainConnectionID() options:@{ kCAContextCIFilterBehavior : @"ignore" }]; > > Will creating the context with 'layerHostingContext->m_context = [CAContext > remoteContextWithOptions:@{kCAContextCIFilterBehavior : @"ignore"}];' work? No -- I tried that first and it failed. 1406702 5 335857 pvollan 2018-03-15 10:20:07 -0700 Comment on attachment 335857 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335857&action=review R=me. >>> Source/WebKit/Platform/mac/LayerHostingContext.mm:81 >>> + layerHostingContext->m_context = [CAContext contextWithCGSConnection:CGSMainConnectionID() options:@{ kCAContextCIFilterBehavior : @"ignore" }]; >> >> Will creating the context with 'layerHostingContext->m_context = [CAContext remoteContextWithOptions:@{kCAContextCIFilterBehavior : @"ignore"}];' work? > > No -- I tried that first and it failed. Ah, right. I first thought it was the call '[CAContext setAllowsCGSConnections:NO];' that made this fail for the Plugin process. 1406732 6 335857 commit-queue 2018-03-15 11:30:24 -0700 Comment on attachment 335857 Patch Clearing flags on attachment: 335857 Committed r229629: <https://trac.webkit.org/changeset/229629> 1406733 7 commit-queue 2018-03-15 11:30:25 -0700 All reviewed patches have been landed. Closing bug. 335857 2018-03-15 10:04:50 -0700 2018-03-15 11:30:24 -0700 Patch bug-183663-20180315100449.patch text/plain 3444 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjk2MjYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTAzLTE1ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIyOTQ4NCk6 IFBsdWdpbnMgb2Z0ZW4gcmVxdWlyZSBDR1MgQ29ubmVjdGlvbnMgdG8gZHJhdworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNjYzCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zODQzOTIxOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGbGFzaCByZXF1aXJlcyBhbiBhY3RpdmUgQ0dTQ29ubmVjdGlvbiB0 byB3b3JrIHByb3Blcmx5LiBTaW5jZSB3ZSBkb24ndCB3YW50IHRoZSBXZWJDb250ZW50CisgICAg ICAgIHByb2Nlc3MgdG8gaGF2ZSBvbiwgY3JlYXRlIGEgbmV3IHBsdWdpbiBwcm9jZXNzLXNwZWNp ZmljIGxheWVyIGhvc3QgY3JlYXRpb24gbWV0aG9kIHRoYXQKKyAgICAgICAgZ2l2ZXMgdGhpcyBh Y2Nlc3MuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9tYWMvTGF5ZXJIb3N0aW5nQ29udGV4dC5oOgor ICAgICAgICAqIFBsYXRmb3JtL21hYy9MYXllckhvc3RpbmdDb250ZXh0Lm1tOgorICAgICAgICAo V2ViS2l0OjpMYXllckhvc3RpbmdDb250ZXh0OjpjcmVhdGVGb3JFeHRlcm5hbFBsdWdpbkhvc3Rp bmdQcm9jZXNzKTogQWRkZWQuCisgICAgICAgICogUGx1Z2luUHJvY2Vzcy9tYWMvUGx1Z2luQ29u dHJvbGxlclByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5Db250cm9sbGVyUHJv eHk6OnVwZGF0ZUxheWVySG9zdGluZ0NvbnRleHQpOiBVc2UgdGhlIG5ldyBjcmVhdGlvbgorICAg ICAgICBtZXRob2QuCisKIDIwMTgtMDMtMTUgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtUZXhNYXBdIFJlbW92ZSBUZXh0dXJlTWFwcGVyTGF5ZXI6OnRl eHR1cmUoKQpJbmRleDogU291cmNlL1dlYktpdC9QbGF0Zm9ybS9tYWMvTGF5ZXJIb3N0aW5nQ29u dGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvUGxhdGZvcm0vbWFjL0xheWVySG9z dGluZ0NvbnRleHQuaAkocmV2aXNpb24gMjI5NjI2KQorKysgU291cmNlL1dlYktpdC9QbGF0Zm9y bS9tYWMvTGF5ZXJIb3N0aW5nQ29udGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC00Niw2ICs0Niw5 IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPExheWVySG9zdGluZ0NvbnRl eHQ+IGNyZWF0ZUZvclBvcnQoY29uc3QgV2ViQ29yZTo6TWFjaFNlbmRSaWdodCYgc2VydmVyUG9y dCk7CiAjaWYgSEFWRShPVVRfT0ZfUFJPQ0VTU19MQVlFUl9IT1NUSU5HKQogICAgIHN0YXRpYyBz dGQ6OnVuaXF1ZV9wdHI8TGF5ZXJIb3N0aW5nQ29udGV4dD4gY3JlYXRlRm9yRXh0ZXJuYWxIb3N0 aW5nUHJvY2VzcygpOworI2lmIFBMQVRGT1JNKE1BQykKKyAgICBzdGF0aWMgc3RkOjp1bmlxdWVf cHRyPExheWVySG9zdGluZ0NvbnRleHQ+IGNyZWF0ZUZvckV4dGVybmFsUGx1Z2luSG9zdGluZ1By b2Nlc3MoKTsKKyNlbmRpZgogI2VuZGlmCiAKICAgICBMYXllckhvc3RpbmdDb250ZXh0KCk7Cklu ZGV4OiBTb3VyY2UvV2ViS2l0L1BsYXRmb3JtL21hYy9MYXllckhvc3RpbmdDb250ZXh0Lm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvUGxhdGZvcm0vbWFjL0xheWVySG9zdGluZ0NvbnRl eHQubW0JKHJldmlzaW9uIDIyOTYyNikKKysrIFNvdXJjZS9XZWJLaXQvUGxhdGZvcm0vbWFjL0xh eWVySG9zdGluZ0NvbnRleHQubW0JKHdvcmtpbmcgY29weSkKQEAgLTcyLDcgKzcyLDE3IEBAIHN0 ZDo6dW5pcXVlX3B0cjxMYXllckhvc3RpbmdDb250ZXh0PiBMYXkKICAgICAKICAgICByZXR1cm4g bGF5ZXJIb3N0aW5nQ29udGV4dDsKIH0KKworI2lmIFBMQVRGT1JNKE1BQykKK3N0ZDo6dW5pcXVl X3B0cjxMYXllckhvc3RpbmdDb250ZXh0PiBMYXllckhvc3RpbmdDb250ZXh0OjpjcmVhdGVGb3JF eHRlcm5hbFBsdWdpbkhvc3RpbmdQcm9jZXNzKCkKK3sKKyAgICBhdXRvIGxheWVySG9zdGluZ0Nv bnRleHQgPSBzdGQ6Om1ha2VfdW5pcXVlPExheWVySG9zdGluZ0NvbnRleHQ+KCk7CisgICAgbGF5 ZXJIb3N0aW5nQ29udGV4dC0+bV9sYXllckhvc3RpbmdNb2RlID0gTGF5ZXJIb3N0aW5nTW9kZTo6 T3V0T2ZQcm9jZXNzOworICAgIGxheWVySG9zdGluZ0NvbnRleHQtPm1fY29udGV4dCA9IFtDQUNv bnRleHQgY29udGV4dFdpdGhDR1NDb25uZWN0aW9uOkNHU01haW5Db25uZWN0aW9uSUQoKSBvcHRp b25zOkB7IGtDQUNvbnRleHRDSUZpbHRlckJlaGF2aW9yIDogQCJpZ25vcmUiIH1dOworICAgIHJl dHVybiBsYXllckhvc3RpbmdDb250ZXh0OworfQogI2VuZGlmCisjZW5kaWYgLy8gSEFWRShPVVRf T0ZfUFJPQ0VTU19MQVlFUl9IT1NUSU5HKQogCiBMYXllckhvc3RpbmdDb250ZXh0OjpMYXllckhv c3RpbmdDb250ZXh0KCkKIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvUGx1Z2luUHJvY2Vzcy9tYWMv UGx1Z2luQ29udHJvbGxlclByb3h5TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv UGx1Z2luUHJvY2Vzcy9tYWMvUGx1Z2luQ29udHJvbGxlclByb3h5TWFjLm1tCShyZXZpc2lvbiAy Mjk2MjYpCisrKyBTb3VyY2UvV2ViS2l0L1BsdWdpblByb2Nlc3MvbWFjL1BsdWdpbkNvbnRyb2xs ZXJQcm94eU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTMwLDcgKzEzMCw3IEBAIHZvaWQgUGx1 Z2luQ29udHJvbGxlclByb3h5Ojp1cGRhdGVMYXllckgKICAgICAgICAgICAgIGJyZWFrOwogI2lm IEhBVkUoT1VUX09GX1BST0NFU1NfTEFZRVJfSE9TVElORykKICAgICAgICAgY2FzZSBMYXllckhv c3RpbmdNb2RlOjpPdXRPZlByb2Nlc3M6Ci0gICAgICAgICAgICBtX2xheWVySG9zdGluZ0NvbnRl eHQgPSBMYXllckhvc3RpbmdDb250ZXh0OjpjcmVhdGVGb3JFeHRlcm5hbEhvc3RpbmdQcm9jZXNz KCk7CisgICAgICAgICAgICBtX2xheWVySG9zdGluZ0NvbnRleHQgPSBMYXllckhvc3RpbmdDb250 ZXh0OjpjcmVhdGVGb3JFeHRlcm5hbFBsdWdpbkhvc3RpbmdQcm9jZXNzKCk7CiAgICAgICAgICAg ICBicmVhazsKICNlbmRpZgogICAgIH0K