183647 2018-03-14 16:33:37 -0700 Web Inspector: Canvas: a recording initiated by the user should be shown immediately on completion 2018-03-14 23:48:52 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 173807 1 mattbaker hi commit-queue inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1406544 0 mattbaker 2018-03-14 16:33:37 -0700 Summary: A recording initiated by the user should be shown immediately on completion. This does not include recordings started using console.record. Steps to Reproduce: 1. Open https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Basic_animations 2. Open Canvas tab 3. Click record on the "A looping panorama" canvas 4. Wait for a couple frames, then hit stop Actual: => Recording is added to "View Recordings" Expected: => Recording view is shown Note: This only affects multi-frame recordings. 1406545 1 webkit-bug-importer 2018-03-14 16:33:51 -0700 <rdar://problem/38479187> 1406561 2 335813 hi 2018-03-14 17:26:27 -0700 Created attachment 335813 Patch 1406567 3 335813 mattbaker 2018-03-14 17:44:16 -0700 Comment on attachment 335813 Patch r=me. A top-level comment about *why* this fixes the issue would be nice. I had to do some debugging to learn that CanvasManager was dispatching RecordingStopped with `fromConsole` set to true, because this._recordingCanvas was being nulled out too early. 1406603 4 335832 hi 2018-03-14 21:45:57 -0700 Created attachment 335832 Patch 1406613 5 335832 commit-queue 2018-03-14 22:54:57 -0700 Comment on attachment 335832 Patch Clearing flags on attachment: 335832 Committed r229620: <https://trac.webkit.org/changeset/229620> 1406614 6 commit-queue 2018-03-14 22:54:59 -0700 All reviewed patches have been landed. Closing bug. 1406620 7 335832 mattbaker 2018-03-14 23:48:52 -0700 Comment on attachment 335832 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335832&action=review > Source/WebInspectorUI/ChangeLog:20 > + in `stopRecording`, so this patch just prevents it from being nulled too early. You really took that review comment and ran with it! 335813 2018-03-14 17:26:27 -0700 2018-03-14 21:45:55 -0700 Patch bug-183647-20180314182626.patch text/plain 4094 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY5Yjc1NTBmZGZjNTI3ZWFiMTBkOWEzZGM4ZjYx MTVhMjY1YjVjY2MuLmVjODk2ZWNhNjE0Y2NmNWU2NWIyODc2MGQ4M2VjOGUyYTVhYjQ1MTQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAzLTE0ICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IENhbnZhczogYSByZWNvcmRpbmcgaW5pdGlhdGVkIGJ5IHRoZSB1c2VyIHNob3VsZCBiZSBz aG93biBpbW1lZGlhdGVseSBvbiBjb21wbGV0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM2NDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4 NDc5MTg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9DYW52YXNNYW5hZ2VyLmpzOgorICAgICAgICAo V0kuQ2FudmFzTWFuYWdlci5wcm90b3R5cGUuc3RvcFJlY29yZGluZyk6CisgICAgICAgIFdlIHNo b3VsZCBvbmx5IGJlIG51bGxpbmcgYF9yZWNvcmRpbmdDYW52YXNgIHdoZW4gYSBmaW5pc2hlZCBy ZWNvcmRpbmcncyBwYXlsb2FkIGlzCisgICAgICAgIHJlY2lldmVkIChvciBhbiBlcnJvciBvY2N1 cnMpIGluc3RlYWQgb2YgYmVmb3JlIHdlIHJ1biB0aGUgYWdlbnQgY2FsbC4KKwogMjAxOC0wMy0x MiAgSm9uIERhdmlzICA8am9uZEBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog UmVtb3ZlIHJlZHVuZGFudCB0b29sdGlwcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ2FudmFzTWFuYWdlci5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NhbnZhc01hbmFnZXIuanMK aW5kZXggZDIyNGI0ZWYwMTY0ZTk5ZGNmNjYyMTEwYTU0Nzk3Njc1MjI3NWZhYS4uNmY0MTI0NWUx NjMwNzAzNWEyY2Y5Y2QyMjU5MDY4YmY2ODEzZTA4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ2FudmFzTWFuYWdlci5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9DYW52YXNN YW5hZ2VyLmpzCkBAIC0xMTAsMTMgKzExMCwxMyBAQCBXSS5DYW52YXNNYW5hZ2VyID0gY2xhc3Mg Q2FudmFzTWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICAgICAgcmV0dXJuOwogCiAg ICAgICAgIGxldCBjYW52YXMgPSB0aGlzLl9yZWNvcmRpbmdDYW52YXM7Ci0gICAgICAgIHRoaXMu X3JlY29yZGluZ0NhbnZhcyA9IG51bGw7CiAKICAgICAgICAgQ2FudmFzQWdlbnQuc3RvcFJlY29y ZGluZyhjYW52YXMuaWRlbnRpZmllciwgKGVycm9yKSA9PiB7CiAgICAgICAgICAgICBpZiAoIWVy cm9yKQogICAgICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICAgICAgY29uc29sZS5lcnJv cihlcnJvcik7CisgICAgICAgICAgICB0aGlzLl9yZWNvcmRpbmdDYW52YXMgPSBudWxsOwogICAg ICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV0kuQ2FudmFzTWFuYWdlci5F dmVudC5SZWNvcmRpbmdTdG9wcGVkLCB7Y2FudmFzLCByZWNvcmRpbmc6IG51bGx9KTsKICAgICAg ICAgfSk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGMzMDE4MTA5YmVlMjJhMWE3YzJkNGU2NTc1ZDY1YWJkN2Q5 NzE4NWMuLjgyYjE1OWYxYWRkODdlMWYzYzhiMmVlYzE0MDM2ZGVlZmVmNGQyNmMgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxOC0wMy0xNCAgRGV2aW4gUm91c3NvICA8d2Via2l0QGRldmlucm91 c3NvLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDYW52YXM6IGEgcmVjb3JkaW5nIGlu aXRpYXRlZCBieSB0aGUgdXNlciBzaG91bGQgYmUgc2hvd24gaW1tZWRpYXRlbHkgb24gY29tcGxl dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgz NjQ3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zODQ3OTE4Nz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9jYW52YXMvcmVjb3Jk aW5nLTJkLmh0bWw6CisgICAgICAgIFJlb3JkZXIgdGhlIGFnZW50IGNhbGxzIHNvIHRoYXQgdGhl IENhbnZhc01hbmFnZXIgYF9yZWNvcmRpbmdDYW52YXNgIHN0YXRlIHZhcmlhYmxlIGhhcyBhCisg ICAgICAgIGNoYW5jZSB0byBwcm9wZXJseSB1cGRhdGUgYWZ0ZXIgYSByZWNvcmRpbmcgaXMgc3Rv cHBlZC4KKwogMjAxOC0wMy0xMyAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXNvdXJjZSBMb2FkIFN0YXRpc3RpY3M6IEltbWVkaWF0ZWx5IGZvcndhcmQg Y29va2llIGFjY2VzcyBmb3IgZG9tYWlucyB3aXRoIHByZXZpb3VzIHVzZXIgaW50ZXJhY3Rpb24g d2hlbiB0aGVyZSdzIGFuIG9wZW5lciBkb2N1bWVudApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2NhbnZhcy9yZWNvcmRpbmctMmQuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9jYW52YXMvcmVjb3JkaW5nLTJkLmh0bWwKaW5kZXggMjcyYmVjNjhkZTA2YmRmNDEwMDIzOTIy OGQ4Nzc1NGYyNGFkNzU5OS4uN2QzNzI1YTgwYTU5NTQyNjUwYzc3YjNlM2Q0YjhlYjMwOGM5MWMx ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NhbnZhcy9yZWNvcmRpbmctMmQu aHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL3JlY29yZGluZy0yZC5odG1s CkBAIC01MDgsOSArNTA4LDEyIEBAIGZ1bmN0aW9uIHRlc3QoKSB7CiAgICAgICAgICAgICAgICAg SW5zcGVjdG9yVGVzdC5hc3NlcnQoIWV2ZW50LmRhdGEucmVjb3JkaW5nLCAiVGhlIHJlY29yZGlu ZyBwYXlsb2FkIHNob3VsZCBiZSBudWxsLiIpOwogCiAgICAgICAgICAgICAgICAgKytldmVudENv dW50OwotICAgICAgICAgICAgICAgIGlmIChldmVudENvdW50ID09IDEpCisgICAgICAgICAgICAg ICAgaWYgKGV2ZW50Q291bnQgPT0gMSkgewogICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JU ZXN0LnBhc3MoIkEgcmVjb3JkaW5nIHNob3VsZCBoYXZlIGJlZW4gc3RhcnRlZCBhbmQgc3RvcHBl ZCBvbmNlLiIpOwotICAgICAgICAgICAgICAgIGVsc2UgaWYgKGV2ZW50Q291bnQgPj0gMikgewor CisgICAgICAgICAgICAgICAgICAgIFdJLmNhbnZhc01hbmFnZXIuc3RhcnRSZWNvcmRpbmcoY2Fu dmFzKTsKKyAgICAgICAgICAgICAgICAgICAgV0kuY2FudmFzTWFuYWdlci5zdG9wUmVjb3JkaW5n KCk7CisgICAgICAgICAgICAgICAgfSBlbHNlIGlmIChldmVudENvdW50ID49IDIpIHsKICAgICAg ICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5wYXNzKCJBIHJlY29yZGluZyBzaG91bGQgaGF2 ZSBiZWVuIHN0YXJ0ZWQgYW5kIHN0b3BwZWQgdHdpY2UuIik7CiAKICAgICAgICAgICAgICAgICAg ICAgV0kuY2FudmFzTWFuYWdlci5yZW1vdmVFdmVudExpc3RlbmVyKGhhbmRsZVJlY29yZGluZ1N0 b3BwZWQpOwpAQCAtNTIxLDkgKzUyNCw2IEBAIGZ1bmN0aW9uIHRlc3QoKSB7CiAKICAgICAgICAg ICAgIFdJLmNhbnZhc01hbmFnZXIuc3RhcnRSZWNvcmRpbmcoY2FudmFzKTsKICAgICAgICAgICAg IFdJLmNhbnZhc01hbmFnZXIuc3RvcFJlY29yZGluZygpOwotCi0gICAgICAgICAgICBXSS5jYW52 YXNNYW5hZ2VyLnN0YXJ0UmVjb3JkaW5nKGNhbnZhcyk7Ci0gICAgICAgICAgICBXSS5jYW52YXNN YW5hZ2VyLnN0b3BSZWNvcmRpbmcoKTsKICAgICAgICAgfSwKICAgICB9KTsKIAo= 335832 2018-03-14 21:45:57 -0700 2018-03-14 22:54:57 -0700 Patch bug-183647-20180314224556.patch text/plain 4939 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY5Yjc1NTBmZGZjNTI3ZWFiMTBkOWEzZGM4ZjYx MTVhMjY1YjVjY2MuLjVhYWY5YjExZDM0YjAxZjNhM2QzZmE5N2EzNzFkNjUxYzMwNDJjYTkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE4LTAzLTE0ICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IENhbnZhczogYSByZWNvcmRpbmcgaW5pdGlhdGVkIGJ5IHRoZSB1c2VyIHNob3VsZCBiZSBz aG93biBpbW1lZGlhdGVseSBvbiBjb21wbGV0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM2NDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4 NDc5MTg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE1hdHQgQmFrZXIuCisKKyAgICAgICAgV2hl biByZWNvcmRpbmdzIGFyZSBpbml0aWF0ZWQgdmlhIGBjb25zb2xlLnJlY29yZGAsIHdlIGRvbid0 IHdhbnQgdG8gYXV0b21hdGljYWxseSBzaG93IHRoZQorICAgICAgICByZWNvcmRpbmcgYWZ0ZXIg aXQncyBwYXlsb2FkIGlzIHNlbnQgdG8gdGhlIGZyb250ZW5kLiBXZSBkZXRlcm1pbmUgd2hldGhl ciBhIHJlY29yZGluZyBjYW1lCisgICAgICAgIGZyb20gdGhlIGNvbnNvbGUgYnkgY29tcGFyaW5n IHRoZSByZWNvcmRpbmcncyBhc3NvY2lhdGVkIGNhbnZhcyB3aXRoIHRoZSBjdXJyZW50IHZhbHVl IG9mCisgICAgICAgIGBfcmVjb3JkaW5nQ2FudmFzYC4gUHJldmlvdXNseSwgd2hlbiBzdG9wcGlu ZyBhIHJlY29yZGluZywgd2Ugd291bGQgYWx3YXlzIG51bGwgdGhlIHZhbHVlLAorICAgICAgICB3 aGljaCBtZWFudCB0aGF0IGFsbCBub24tc2luZ2xlLWZyYW1lIHJlY29yZGluZ3MgKHNpbmdsZS1m cmFtZSByZWNvcmRpbmdzIGFyZSBzdG9wcGVkIGJ5CisgICAgICAgIHRoZSBhZ2VudCBhZnRlciB0 aGUgZmlyc3QgcGFpbnQgb3IgdGljayBhZnRlciBhbiBhY3Rpb24gaXMgcGVyZm9ybWVkKSB3b3Vs ZCBiZSBjYXRlZ29yaXplZAorICAgICAgICBhcyBjb21pbmcgZnJvbSB0aGUgY29uc29sZSwgc2lu Y2UgYF9yZWNvcmRpbmdDYW52YXNgIHdvdWxkIGJlIG51bGwgYnkgdGhlIHRpbWUgdGhlIGZyb250 ZW5kCisgICAgICAgIHJlY2lldmVkIHRoZSBwYXlsb2FkLgorCisgICAgICAgIFRoaXMgcGF0Y2gg Y2hhbmdlcyBpdCBzbyB0aGF0IHRoZSBudWxsaW5nIG9mIGBfcmVjb3JkaW5nQ2FudmFzYCBpbiBg c3RvcFJlY29yZGluZ2AgaXMgb25seQorICAgICAgICBkb25lIGlmIHRoZSBhZ2VudCBjb21tYW5k IGVycm9ycy4gSXQgd2FzIGFscmVhZHkgdGhlIGNhc2UgdGhhdCBgX3JlY29yZGluZ0NhbnZhc2Ag d2FzIG51bGxlZAorICAgICAgICBpbiBgc3RvcFJlY29yZGluZ2AsIHNvIHRoaXMgcGF0Y2gganVz dCBwcmV2ZW50cyBpdCBmcm9tIGJlaW5nIG51bGxlZCB0b28gZWFybHkuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NhbnZhc01hbmFnZXIuanM6CisgICAgICAgIChXSS5D YW52YXNNYW5hZ2VyLnByb3RvdHlwZS5zdG9wUmVjb3JkaW5nKToKKwogMjAxOC0wMy0xMiAgSm9u IERhdmlzICA8am9uZEBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IHJlZHVuZGFudCB0b29sdGlwcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ2FudmFzTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NhbnZhc01hbmFnZXIuanMKaW5kZXgg ZDIyNGI0ZWYwMTY0ZTk5ZGNmNjYyMTEwYTU0Nzk3Njc1MjI3NWZhYS4uNmY0MTI0NWUxNjMwNzAz NWEyY2Y5Y2QyMjU5MDY4YmY2ODEzZTA4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ2FudmFzTWFuYWdlci5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9DYW52YXNNYW5hZ2Vy LmpzCkBAIC0xMTAsMTMgKzExMCwxMyBAQCBXSS5DYW52YXNNYW5hZ2VyID0gY2xhc3MgQ2FudmFz TWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAg IGxldCBjYW52YXMgPSB0aGlzLl9yZWNvcmRpbmdDYW52YXM7Ci0gICAgICAgIHRoaXMuX3JlY29y ZGluZ0NhbnZhcyA9IG51bGw7CiAKICAgICAgICAgQ2FudmFzQWdlbnQuc3RvcFJlY29yZGluZyhj YW52YXMuaWRlbnRpZmllciwgKGVycm9yKSA9PiB7CiAgICAgICAgICAgICBpZiAoIWVycm9yKQog ICAgICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICAgICAgY29uc29sZS5lcnJvcihlcnJv cik7CisgICAgICAgICAgICB0aGlzLl9yZWNvcmRpbmdDYW52YXMgPSBudWxsOwogICAgICAgICAg ICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV0kuQ2FudmFzTWFuYWdlci5FdmVudC5S ZWNvcmRpbmdTdG9wcGVkLCB7Y2FudmFzLCByZWNvcmRpbmc6IG51bGx9KTsKICAgICAgICAgfSk7 CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IGMzMDE4MTA5YmVlMjJhMWE3YzJkNGU2NTc1ZDY1YWJkN2Q5NzE4NWMu LjdmYmQwNzk2YmVkNDQ0YzIyYTFlODI1ZmFkMDJlMWZlOTAwNzliNDcgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNSBAQAorMjAxOC0wMy0xNCAgRGV2aW4gUm91c3NvICA8d2Via2l0QGRldmlucm91c3NvLmNv bT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDYW52YXM6IGEgcmVjb3JkaW5nIGluaXRpYXRl ZCBieSB0aGUgdXNlciBzaG91bGQgYmUgc2hvd24gaW1tZWRpYXRlbHkgb24gY29tcGxldGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNjQ3Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zODQ3OTE4Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBN YXR0IEJha2VyLgorCisgICAgICAgICogaW5zcGVjdG9yL2NhbnZhcy9yZWNvcmRpbmctMmQuaHRt bDoKKyAgICAgICAgUmVvcmRlciB0aGUgYWdlbnQgY2FsbHMgc28gdGhhdCB0aGUgQ2FudmFzTWFu YWdlciBgX3JlY29yZGluZ0NhbnZhc2Agc3RhdGUgdmFyaWFibGUgaGFzIGEKKyAgICAgICAgY2hh bmNlIHRvIHByb3Blcmx5IHVwZGF0ZSBhZnRlciBhIHJlY29yZGluZyBpcyBzdG9wcGVkLgorCiAy MDE4LTAzLTEzICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFJlc291cmNlIExvYWQgU3RhdGlzdGljczogSW1tZWRpYXRlbHkgZm9yd2FyZCBjb29raWUgYWNj ZXNzIGZvciBkb21haW5zIHdpdGggcHJldmlvdXMgdXNlciBpbnRlcmFjdGlvbiB3aGVuIHRoZXJl J3MgYW4gb3BlbmVyIGRvY3VtZW50CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv Y2FudmFzL3JlY29yZGluZy0yZC5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NhbnZhcy9y ZWNvcmRpbmctMmQuaHRtbAppbmRleCAyNzJiZWM2OGRlMDZiZGY0MTAwMjM5MjI4ZDg3NzU0ZjI0 YWQ3NTk5Li43ZDM3MjVhODBhNTk1NDI2NTBjNzdiM2UzZDRiOGViMzA4YzkxYzFkIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL3JlY29yZGluZy0yZC5odG1sCisrKyBi L0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvcmVjb3JkaW5nLTJkLmh0bWwKQEAgLTUwOCw5 ICs1MDgsMTIgQEAgZnVuY3Rpb24gdGVzdCgpIHsKICAgICAgICAgICAgICAgICBJbnNwZWN0b3JU ZXN0LmFzc2VydCghZXZlbnQuZGF0YS5yZWNvcmRpbmcsICJUaGUgcmVjb3JkaW5nIHBheWxvYWQg c2hvdWxkIGJlIG51bGwuIik7CiAKICAgICAgICAgICAgICAgICArK2V2ZW50Q291bnQ7Ci0gICAg ICAgICAgICAgICAgaWYgKGV2ZW50Q291bnQgPT0gMSkKKyAgICAgICAgICAgICAgICBpZiAoZXZl bnRDb3VudCA9PSAxKSB7CiAgICAgICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QucGFzcygi QSByZWNvcmRpbmcgc2hvdWxkIGhhdmUgYmVlbiBzdGFydGVkIGFuZCBzdG9wcGVkIG9uY2UuIik7 Ci0gICAgICAgICAgICAgICAgZWxzZSBpZiAoZXZlbnRDb3VudCA+PSAyKSB7CisKKyAgICAgICAg ICAgICAgICAgICAgV0kuY2FudmFzTWFuYWdlci5zdGFydFJlY29yZGluZyhjYW52YXMpOworICAg ICAgICAgICAgICAgICAgICBXSS5jYW52YXNNYW5hZ2VyLnN0b3BSZWNvcmRpbmcoKTsKKyAgICAg ICAgICAgICAgICB9IGVsc2UgaWYgKGV2ZW50Q291bnQgPj0gMikgewogICAgICAgICAgICAgICAg ICAgICBJbnNwZWN0b3JUZXN0LnBhc3MoIkEgcmVjb3JkaW5nIHNob3VsZCBoYXZlIGJlZW4gc3Rh cnRlZCBhbmQgc3RvcHBlZCB0d2ljZS4iKTsKIAogICAgICAgICAgICAgICAgICAgICBXSS5jYW52 YXNNYW5hZ2VyLnJlbW92ZUV2ZW50TGlzdGVuZXIoaGFuZGxlUmVjb3JkaW5nU3RvcHBlZCk7CkBA IC01MjEsOSArNTI0LDYgQEAgZnVuY3Rpb24gdGVzdCgpIHsKIAogICAgICAgICAgICAgV0kuY2Fu dmFzTWFuYWdlci5zdGFydFJlY29yZGluZyhjYW52YXMpOwogICAgICAgICAgICAgV0kuY2FudmFz TWFuYWdlci5zdG9wUmVjb3JkaW5nKCk7Ci0KLSAgICAgICAgICAgIFdJLmNhbnZhc01hbmFnZXIu c3RhcnRSZWNvcmRpbmcoY2FudmFzKTsKLSAgICAgICAgICAgIFdJLmNhbnZhc01hbmFnZXIuc3Rv cFJlY29yZGluZygpOwogICAgICAgICB9LAogICAgIH0pOwogCg==