183643 2018-03-14 13:36:36 -0700 webkitdirectory-open-panel stumbles over unordered results 2018-03-15 15:13:23 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin cdumez achristensen commit-queue rniwa webkit-bug-importer wenson_hsieh youennf oldest_to_newest 1406491 0 krollin 2018-03-14 13:36:36 -0700 After running fast/forms/file/entries-api/webkitdirectory-open-panel.html, .../OpenSource/WebKitBuild/Release/layout-test-results/fast/forms/file/entries-api/webkitdirectory-open-panel-actual.txt contains the results below. It looks like all of the expected results are there, but just not in the expected order. ========== Actual Results ========== OPEN FILE PANEL -> DIRECTORIES ARE ALLOWED Tests choosing a folder via the file picker when using webkitdirectory. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS inputElement.webkitdirectory is true PASS fileList.length is 5 FAIL fileList[0].name should be file1.txt. Was file2.txt. FAIL fileList[0].webkitRelativePath should be testFiles/file1.txt. Was testFiles/file2.txt. FAIL fileList[1].name should be file2.txt. Was file1.txt. FAIL fileList[1].webkitRelativePath should be testFiles/file2.txt. Was testFiles/file1.txt. FAIL fileList[2].name should be file3.txt. Was file4.txt. FAIL fileList[2].webkitRelativePath should be testFiles/subfolder1/file3.txt. Was testFiles/subfolder2/file4.txt. FAIL fileList[3].name should be file4.txt. Was file5.txt. FAIL fileList[3].webkitRelativePath should be testFiles/subfolder2/file4.txt. Was testFiles/subfolder2/subfolder2a/file5.txt. FAIL fileList[4].name should be file5.txt. Was file3.txt. FAIL fileList[4].webkitRelativePath should be testFiles/subfolder2/subfolder2a/file5.txt. Was testFiles/subfolder1/file3.txt. PASS successfullyParsed is true Some tests failed. TEST COMPLETE ========== Expected Results ========== OPEN FILE PANEL -> DIRECTORIES ARE ALLOWED Tests choosing a folder via the file picker when using webkitdirectory. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS inputElement.webkitdirectory is true PASS fileList.length is 5 PASS fileList[0].name is "file1.txt" PASS fileList[0].webkitRelativePath is "testFiles/file1.txt" PASS fileList[1].name is "file2.txt" PASS fileList[1].webkitRelativePath is "testFiles/file2.txt" PASS fileList[2].name is "file3.txt" PASS fileList[2].webkitRelativePath is "testFiles/subfolder1/file3.txt" PASS fileList[3].name is "file4.txt" PASS fileList[3].webkitRelativePath is "testFiles/subfolder2/file4.txt" PASS fileList[4].name is "file5.txt" PASS fileList[4].webkitRelativePath is "testFiles/subfolder2/subfolder2a/file5.txt" PASS successfullyParsed is true TEST COMPLETE 1406801 1 335883 cdumez 2018-03-15 14:21:37 -0700 Created attachment 335883 Patch 1406827 2 335883 commit-queue 2018-03-15 15:12:14 -0700 Comment on attachment 335883 Patch Clearing flags on attachment: 335883 Committed r229642: <https://trac.webkit.org/changeset/229642> 1406828 3 commit-queue 2018-03-15 15:12:16 -0700 All reviewed patches have been landed. Closing bug. 1406829 4 webkit-bug-importer 2018-03-15 15:13:23 -0700 <rdar://problem/38518705> 335883 2018-03-15 14:21:37 -0700 2018-03-15 15:12:14 -0700 Patch bug-183643-20180315142136.patch text/plain 4873 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NjM5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGZjODZmMTlmYmY2ZTk1ZGNmMjYz NmY0OTY3N2E5OGZjZDAzNWQ3MC4uOWFjMDg2OGEyZWFlOGZjZTc2YWM4YjY2NjI0NDQ0NjhiNmEw Y2ZiNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAzLTE1ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgd2Via2l0ZGlyZWN0b3J5LW9wZW4tcGFuZWwgc3R1 bWJsZXMgb3ZlciB1bm9yZGVyZWQgcmVzdWx0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIGZhc3QvZm9ybXMvZmlsZS9lbnRyaWVzLWFwaS93 ZWJraXRkaXJlY3Rvcnktb3Blbi1wYW5lbC5odG1sIHRvIG5vdCByZWx5IG9uIGEKKyAgICAgICAg c3BlY2lmaWMgZmlsZSBvcmRlcmluZyB3aGVuIGNoZWNraW5nIGlucHV0LmZpbGVzLgorCisgICAg ICAgICogZmFzdC9mb3Jtcy9maWxlL2VudHJpZXMtYXBpL3dlYmtpdGRpcmVjdG9yeS1vcGVuLXBh bmVsLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2ZpbGUvZW50cmllcy1hcGkv d2Via2l0ZGlyZWN0b3J5LW9wZW4tcGFuZWwuaHRtbDoKKwogMjAxOC0wMy0xNSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0IFRlc3QgaHR0cC93cHQv c2VydmljZS13b3JrZXJzL3VwZGF0ZS1zZXJ2aWNlLXdvcmtlci5odHRwcy5odG1sIGlzIGZsYWt5 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ZpbGUvZW50cmllcy1hcGkvd2Vi a2l0ZGlyZWN0b3J5LW9wZW4tcGFuZWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9maWxlL2VudHJpZXMtYXBpL3dlYmtpdGRpcmVjdG9yeS1vcGVuLXBhbmVsLWV4cGVjdGVk LnR4dAppbmRleCA4NDlkYjVlZmFiNTQyNmFmZGNhZmRmM2JlMWU3OTFlNWIyNWJmOGM1Li40ZWZl MWY0NTg2Y2NhMjMwMmM5OGM3NWY0MzFjNGI3M2FmYTk1ZWNlIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL2ZpbGUvZW50cmllcy1hcGkvd2Via2l0ZGlyZWN0b3J5LW9wZW4tcGFu ZWwtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZmlsZS9lbnRyaWVz LWFwaS93ZWJraXRkaXJlY3Rvcnktb3Blbi1wYW5lbC1leHBlY3RlZC50eHQKQEAgLTcsMTYgKzcs MTYgQEAgT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUKIAogUEFTUyBpbnB1dEVsZW1lbnQud2Via2l0 ZGlyZWN0b3J5IGlzIHRydWUKIFBBU1MgZmlsZUxpc3QubGVuZ3RoIGlzIDUKLVBBU1MgZmlsZUxp c3RbMF0ubmFtZSBpcyAiZmlsZTEudHh0IgotUEFTUyBmaWxlTGlzdFswXS53ZWJraXRSZWxhdGl2 ZVBhdGggaXMgInRlc3RGaWxlcy9maWxlMS50eHQiCi1QQVNTIGZpbGVMaXN0WzFdLm5hbWUgaXMg ImZpbGUyLnR4dCIKLVBBU1MgZmlsZUxpc3RbMV0ud2Via2l0UmVsYXRpdmVQYXRoIGlzICJ0ZXN0 RmlsZXMvZmlsZTIudHh0IgotUEFTUyBmaWxlTGlzdFsyXS5uYW1lIGlzICJmaWxlMy50eHQiCi1Q QVNTIGZpbGVMaXN0WzJdLndlYmtpdFJlbGF0aXZlUGF0aCBpcyAidGVzdEZpbGVzL3N1YmZvbGRl cjEvZmlsZTMudHh0IgotUEFTUyBmaWxlTGlzdFszXS5uYW1lIGlzICJmaWxlNC50eHQiCi1QQVNT IGZpbGVMaXN0WzNdLndlYmtpdFJlbGF0aXZlUGF0aCBpcyAidGVzdEZpbGVzL3N1YmZvbGRlcjIv ZmlsZTQudHh0IgotUEFTUyBmaWxlTGlzdFs0XS5uYW1lIGlzICJmaWxlNS50eHQiCi1QQVNTIGZp bGVMaXN0WzRdLndlYmtpdFJlbGF0aXZlUGF0aCBpcyAidGVzdEZpbGVzL3N1YmZvbGRlcjIvc3Vi Zm9sZGVyMmEvZmlsZTUudHh0IgorUEFTUyBmaWxlTGlzdCBjb250YWlucyBmaWxlIGZpbGUxLnR4 dAorUEFTUyBmaWxlLndlYmtpdFJlbGF0aXZlUGF0aCBpcyAidGVzdEZpbGVzL2ZpbGUxLnR4dCIK K1BBU1MgZmlsZUxpc3QgY29udGFpbnMgZmlsZSBmaWxlMi50eHQKK1BBU1MgZmlsZS53ZWJraXRS ZWxhdGl2ZVBhdGggaXMgInRlc3RGaWxlcy9maWxlMi50eHQiCitQQVNTIGZpbGVMaXN0IGNvbnRh aW5zIGZpbGUgZmlsZTMudHh0CitQQVNTIGZpbGUud2Via2l0UmVsYXRpdmVQYXRoIGlzICJ0ZXN0 RmlsZXMvc3ViZm9sZGVyMS9maWxlMy50eHQiCitQQVNTIGZpbGVMaXN0IGNvbnRhaW5zIGZpbGUg ZmlsZTQudHh0CitQQVNTIGZpbGUud2Via2l0UmVsYXRpdmVQYXRoIGlzICJ0ZXN0RmlsZXMvc3Vi Zm9sZGVyMi9maWxlNC50eHQiCitQQVNTIGZpbGVMaXN0IGNvbnRhaW5zIGZpbGUgZmlsZTUudHh0 CitQQVNTIGZpbGUud2Via2l0UmVsYXRpdmVQYXRoIGlzICJ0ZXN0RmlsZXMvc3ViZm9sZGVyMi9z dWJmb2xkZXIyYS9maWxlNS50eHQiCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAK IFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZmlsZS9l bnRyaWVzLWFwaS93ZWJraXRkaXJlY3Rvcnktb3Blbi1wYW5lbC5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9maWxlL2VudHJpZXMtYXBpL3dlYmtpdGRpcmVjdG9yeS1vcGVuLXBhbmVsLmh0 bWwKaW5kZXggZDM5NGIyNzllMjlkODhjODAzNTNlODhkZjI2NjUyMTgwZTAzNDljNy4uMjU5NGQ5 ZGRhM2M3ZjFlZWE4N2YxYTc1Mjc1ZGQwMGFjNjY3OTgzOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy9maWxlL2VudHJpZXMtYXBpL3dlYmtpdGRpcmVjdG9yeS1vcGVuLXBhbmVs Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWxlL2VudHJpZXMtYXBpL3dlYmtp dGRpcmVjdG9yeS1vcGVuLXBhbmVsLmh0bWwKQEAgLTIwLDIwICsyMCwyOCBAQCBmdW5jdGlvbiBy dW5UZXN0KCkKICAgICAgICAgaW5wdXRFbGVtZW50Lm9mZnNldFRvcCArIGlucHV0RWxlbWVudC5v ZmZzZXRIZWlnaHQgLyAyKTsKIH0KIAorZnVuY3Rpb24gY2hlY2tGaWxlTGlzdEluY2x1ZGVzKGZp bGVzLCBuYW1lLCByZWxhdGl2ZVBhdGgpCit7CisgICAgZm9yIChsZXQgX2ZpbGUgb2YgZmlsZXMp IHsKKyAgICAgICAgZmlsZSA9IF9maWxlOworICAgICAgICBpZiAoZmlsZS5uYW1lID09PSBuYW1l KSB7CisgICAgICAgICAgICB0ZXN0UGFzc2VkKCJmaWxlTGlzdCBjb250YWlucyBmaWxlICIgKyBu YW1lKTsKKyAgICAgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiZmlsZS53ZWJraXRSZWxh dGl2ZVBhdGgiLCAiIiArIHJlbGF0aXZlUGF0aCk7CisgICAgICAgICAgICByZXR1cm47CisgICAg ICAgIH0KKyAgICB9CisgICAgdGVzdEZhaWxlZCgiZmlsZUxpc3QgZG9lcyBub3QgY29udGFpbiBm aWxlICIgKyBuYW1lKTsKK30KKwogZnVuY3Rpb24gY2hhbmdlZChldmVudCkKIHsKICAgICBmaWxl TGlzdCA9IGV2ZW50LnRhcmdldC5maWxlczsKICAgICBzaG91bGRCZSgiZmlsZUxpc3QubGVuZ3Ro IiwgIjUiKTsKLSAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImZpbGVMaXN0WzBdLm5hbWUiLCAi ZmlsZTEudHh0Iik7Ci0gICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJmaWxlTGlzdFswXS53ZWJr aXRSZWxhdGl2ZVBhdGgiLCAidGVzdEZpbGVzL2ZpbGUxLnR4dCIpOwotICAgIHNob3VsZEJlRXF1 YWxUb1N0cmluZygiZmlsZUxpc3RbMV0ubmFtZSIsICJmaWxlMi50eHQiKTsKLSAgICBzaG91bGRC ZUVxdWFsVG9TdHJpbmcoImZpbGVMaXN0WzFdLndlYmtpdFJlbGF0aXZlUGF0aCIsICJ0ZXN0Rmls ZXMvZmlsZTIudHh0Iik7Ci0gICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJmaWxlTGlzdFsyXS5u YW1lIiwgImZpbGUzLnR4dCIpOwotICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiZmlsZUxpc3Rb Ml0ud2Via2l0UmVsYXRpdmVQYXRoIiwgInRlc3RGaWxlcy9zdWJmb2xkZXIxL2ZpbGUzLnR4dCIp OwotICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiZmlsZUxpc3RbM10ubmFtZSIsICJmaWxlNC50 eHQiKTsKLSAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImZpbGVMaXN0WzNdLndlYmtpdFJlbGF0 aXZlUGF0aCIsICJ0ZXN0RmlsZXMvc3ViZm9sZGVyMi9maWxlNC50eHQiKTsKLSAgICBzaG91bGRC ZUVxdWFsVG9TdHJpbmcoImZpbGVMaXN0WzRdLm5hbWUiLCAiZmlsZTUudHh0Iik7Ci0gICAgc2hv dWxkQmVFcXVhbFRvU3RyaW5nKCJmaWxlTGlzdFs0XS53ZWJraXRSZWxhdGl2ZVBhdGgiLCAidGVz dEZpbGVzL3N1YmZvbGRlcjIvc3ViZm9sZGVyMmEvZmlsZTUudHh0Iik7CisgICAgY2hlY2tGaWxl TGlzdEluY2x1ZGVzKGZpbGVMaXN0LCAiZmlsZTEudHh0IiwgInRlc3RGaWxlcy9maWxlMS50eHQi KTsKKyAgICBjaGVja0ZpbGVMaXN0SW5jbHVkZXMoZmlsZUxpc3QsICJmaWxlMi50eHQiLCAidGVz dEZpbGVzL2ZpbGUyLnR4dCIpOworICAgIGNoZWNrRmlsZUxpc3RJbmNsdWRlcyhmaWxlTGlzdCwg ImZpbGUzLnR4dCIsICJ0ZXN0RmlsZXMvc3ViZm9sZGVyMS9maWxlMy50eHQiKTsKKyAgICBjaGVj a0ZpbGVMaXN0SW5jbHVkZXMoZmlsZUxpc3QsICJmaWxlNC50eHQiLCAidGVzdEZpbGVzL3N1YmZv bGRlcjIvZmlsZTQudHh0Iik7CisgICAgY2hlY2tGaWxlTGlzdEluY2x1ZGVzKGZpbGVMaXN0LCAi ZmlsZTUudHh0IiwgInRlc3RGaWxlcy9zdWJmb2xkZXIyL3N1YmZvbGRlcjJhL2ZpbGU1LnR4dCIp OwogCiAgICAgZmluaXNoSlNUZXN0KCk7CiB9Cg==