18364 2008-04-08 07:19:11 -0700 [GTK] Buttons activated with the keyboard should be painted as clicked 2010-10-11 15:44:59 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 marco.barisione webkit-unassigned abarth eric jmalonzo mrobinson webkit.review.bot oldest_to_newest 76606 0 marco.barisione 2008-04-08 07:19:11 -0700 When activating a button with the keyboard it should be painted as pressed. 95868 1 jmalonzo 2008-10-18 04:19:39 -0700 marco, pressed or focused? can you please confirm if this doesn't occur in ToT yet? cheersm 292007 2 mrobinson 2010-10-08 18:31:20 -0700 I can confirm that tabbing to a button and pressing space does not cause the button to be shown as pressed. Compare the behavior that happens in Chromium or Firefox. 292155 3 70360 mrobinson 2010-10-09 12:24:57 -0700 Created attachment 70360 Patch for this issue 292645 4 70360 gustavo 2010-10-11 14:14:00 -0700 Comment on attachment 70360 Patch for this issue Cunning. 292650 5 70360 mrobinson 2010-10-11 14:21:00 -0700 Comment on attachment 70360 Patch for this issue Clearing flags on attachment: 70360 Committed r69526: <http://trac.webkit.org/changeset/69526> 292651 6 mrobinson 2010-10-11 14:21:04 -0700 All reviewed patches have been landed. Closing bug. 292721 7 webkit.review.bot 2010-10-11 15:44:59 -0700 http://trac.webkit.org/changeset/69526 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/move-past-trailing-space.html fast/css/shadow-multiple.html fast/text/shadow-no-blur.html 70360 2010-10-09 12:24:57 -0700 2010-10-11 14:21:00 -0700 Patch for this issue bug-18364-20101009122456.patch text/plain 2474 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWQzMTA2NDhiYThiMGY0OGQyN2FjNDcyZjExNWRmZjU2NmExODRlMS4uYjFjOTdkMGQxZjllY2U0 MWNlZmNhYmZmMWViMWFlNThjMGUzNDc3NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNCBAQAogMjAxMC0xMC0wOSAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQnV0dG9ucyBhY3RpdmF0ZWQgd2l0 aCB0aGUga2V5Ym9hcmQgc2hvdWxkIGJlIHBhaW50ZWQgYXMgY2xpY2tlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNjQKKworICAgICAgICBXaGVu IGEgYnV0dG9uIGlzIHByZXNzZWQsIGZvcmNlIGl0IGludG8gdGhlIGhvdmVyZWQgc3RhdGUgYXMg ZmFyIGFzIHRoZQorICAgICAgICBNb3ppbGxhIHRoZW1lIGRyYXdpbmcgY29kZSBpcyBjb25jZXJu ZWQuIFRoaXMgYnVnIGFsc28gc2VlbXMgdG8gYmUgYW4KKyAgICAgICAgaXNzdWUgZm9yIEZpcmVm b3guIFdoZW4gd2Ugc3dpdGNoIGF3YXkgZnJvbSB0aGUgTW96aWxsYSB0aGVtZSBkcmF3aW5nCisg ICAgICAgIGNvZGUgdGhpcyB3b3JrLWFyb3VuZCBzaG91bGQgbm8gbG9uZ2VyIGJlIG5lY2Vzc2Fy eS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIEkgd2FzIG5vdCBhYmxlIHRvIGdlbmVyYXRlIGEg cGl4ZWwgdGVzdCBmb3IgdGhpcyBpc3N1ZS4gSXQKKyAgICAgICAgc2VlbXMgdGhhdCBvdXIgRFJU IGRvZXMgbm90IGhhdmUgdGhlIG5lY2Vzc2FyeSBpbmZyYXN0cnVjdHVyZSB0byBnZW5lcmF0ZSBh CisgICAgICAgIHBpeGVsIGR1bXAgd2hpbGUgYSBidXR0b24gaXMgaW4gdGhlIHByZXNzZWQgc3Rh dGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVHdGs6OnBhaW50UmVuZGVyT2JqZWN0KToKKworMjAxMC0x MC0wOSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKICAgICAgICAg UmV2aWV3ZWQgYnkgWGFuIExvcGV6LgogCiAgICAgICAgIFtHdGtdIE5vbi1yZWN0YW5ndWxhciBi dXR0b25zIGhhdmUgYSBzcXVhcmUgYmFja2dyb3VuZCBiZWhpbmQgdGhlbQpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwCmluZGV4IGU2NDdlZWU5Y2YxY2I0Mjg0ZjdiMmIyYWJi ODk0YWNjOTA2YTNhZTAuLmFmOTNlYjZkMGM3NTZjYjhiYTRjN2UyZDU1NjRjNTY0MmUzNmNmY2Yg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKQEAgLTM2MSw3ICszNjEs MTMgQEAgYm9vbCBSZW5kZXJUaGVtZUd0azo6cGFpbnRSZW5kZXJPYmplY3QoR3RrVGhlbWVXaWRn ZXRUeXBlIHR5cGUsIFJlbmRlck9iamVjdCogcmUKICAgICBHdGtXaWRnZXRTdGF0ZSB3aWRnZXRT dGF0ZTsKICAgICB3aWRnZXRTdGF0ZS5hY3RpdmUgPSBpc1ByZXNzZWQocmVuZGVyT2JqZWN0KTsK ICAgICB3aWRnZXRTdGF0ZS5mb2N1c2VkID0gaXNGb2N1c2VkKHJlbmRlck9iamVjdCk7Ci0gICAg d2lkZ2V0U3RhdGUuaW5Ib3ZlciA9IGlzSG92ZXJlZChyZW5kZXJPYmplY3QpOworCisgICAgLy8g aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzY0CisgICAgLy8gVGhl IE1vemlsbGEgdGhlbWUgZHJhd2luZyBjb2RlLCBvbmx5IHBhaW50cyBhIGJ1dHRvbiBhcyBwcmVz c2VkIHdoZW4gaXQncyBwcmVzc2VkIAorICAgIC8vIHdoaWxlIGhvdmVyZWQuIFVudGlsIHdlIG1v dmUgYXdheSBmcm9tIHRoZSBNb3ppbGEgY29kZSwgd29yay1hcm91bmQgdGhlIGlzc3VlIGJ5Cisg ICAgLy8gZm9yY2luZyBhIHByZXNzZWQgYnV0dG9uIGludG8gdGhlIGhvdmVyZWQgc3RhdGUuIFRo aXMgZW5zdXJlcyB0aGF0IGJ1dHRvbnMgYWN0aXZhdGVkCisgICAgLy8gdmlhIHRoZSBrZXlib2Fy ZCBoYXZlIHRoZSBwcm9wZXIgcmVuZGVyaW5nLgorICAgIHdpZGdldFN0YXRlLmluSG92ZXIgPSBp c0hvdmVyZWQocmVuZGVyT2JqZWN0KSB8fCAodHlwZSA9PSBNT1pfR1RLX0JVVFRPTiAmJiBpc1By ZXNzZWQocmVuZGVyT2JqZWN0KSk7CiAKICAgICAvLyBGSVhNRTogRGlzYWJsZWQgZG9lcyBub3Qg YWx3YXlzIGdpdmUgdGhlIGNvcnJlY3QgYXBwZWFyYW5jZSBmb3IgUmVhZE9ubHkKICAgICB3aWRn ZXRTdGF0ZS5kaXNhYmxlZCA9ICFpc0VuYWJsZWQocmVuZGVyT2JqZWN0KSB8fCBpc1JlYWRPbmx5 Q29udHJvbChyZW5kZXJPYmplY3QpOwo=