183612 2018-03-13 13:35:10 -0700 [WK2] Web Inspector: NavigationAction for opening a link in a new tab should have a UserGestureIndicator 2018-03-13 14:42:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1406221 0 bburg 2018-03-13 13:35:10 -0700 This is only possible via user interaction so we need to synthesize a user gesture indicator. This is done properly in the WK1/DRT case, but not in the WK2 case. 1406222 1 bburg 2018-03-13 13:35:29 -0700 <rdar://problem/38388641> 1406224 2 335722 bburg 2018-03-13 13:38:18 -0700 Created attachment 335722 Patch 1406250 3 335722 commit-queue 2018-03-13 14:42:13 -0700 Comment on attachment 335722 Patch Clearing flags on attachment: 335722 Committed r229588: <https://trac.webkit.org/changeset/229588> 1406251 4 commit-queue 2018-03-13 14:42:14 -0700 All reviewed patches have been landed. Closing bug. 335722 2018-03-13 13:38:18 -0700 2018-03-13 14:42:13 -0700 Patch bug-183612-20180313133818.patch text/plain 1525 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ0NmY2MmQ2YzRkMzA0Y2Iy OTZiNjhhMmMyOTEyYjAwY2Q0YmFjZmEuLjM5NmY1Y2JlZGY4YzE1YWFkMjlmMTJlODNjNGNkM2Iy OGNlMDQwZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDMtMTMgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gV2ViIEluc3BlY3RvcjogTmF2 aWdhdGlvbkFjdGlvbiBmb3Igb3BlbmluZyBhIGxpbmsgaW4gYSBuZXcgdGFiIHNob3VsZCBoYXZl IGEgVXNlckdlc3R1cmVJbmRpY2F0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4MzYxMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzgzODg2NDE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGN1 cnJlbnQgZ2VzdHVyZSB0b2tlbiB3aWxsIGJlIGF0dGFjaGVkIHRvIHRoZSBOYXZpZ2F0aW9uQWN0 aW9uIGF0IGNvbnN0cnVjdGlvbiB0aW1lLAorICAgICAgICBzbyBzZXQgdXAgYSBVc2VyR2VzdHVy ZUluZGljYXRvciB3aGVuIGNyZWF0aW5nIHRoZSBhY3Rpb24gYW5kIHNlbmRpbmcgaXQgb3V0Lgor CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvci5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYkluc3BlY3Rvcjo6b3BlbkluTmV3VGFiKToKKwogMjAxOC0wMy0xMyAgSmll d2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFNvZnQtbGluayBMb2Nh bEF1dGhlbnRpY2F0aW9uLkZyYW1ld29yawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYkluc3BlY3Rvci5jcHAKaW5kZXggY2NkNTQ3ZTAwZTI0YzEzN2I5NjhmMzYw YjE4YzNlMzBhY2Y1MzYyNi4uMjBiZDMwOGNiY2IzYzQyZTVjYmVmYzIzMmU2Y2JkMWQxMjUxYWE5 NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVj dG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0 b3IuY3BwCkBAIC0xNDUsNiArMTQ1LDggQEAgdm9pZCBXZWJJbnNwZWN0b3I6OmNsb3NlKCkKIAog dm9pZCBXZWJJbnNwZWN0b3I6Om9wZW5Jbk5ld1RhYihjb25zdCBTdHJpbmcmIHVybFN0cmluZykK IHsKKyAgICBVc2VyR2VzdHVyZUluZGljYXRvciBpbmRpY2F0b3IgeyBQcm9jZXNzaW5nVXNlckdl c3R1cmUgfTsKKwogICAgIFBhZ2UqIGluc3BlY3RlZFBhZ2UgPSBtX3BhZ2UtPmNvcmVQYWdlKCk7 CiAgICAgaWYgKCFpbnNwZWN0ZWRQYWdlKQogICAgICAgICByZXR1cm47Cg==